GNU logs - #59438, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#59438: 29.0.50; [PATCH] Make defvar's into defcustom's in tab-line
Resent-From: Gabriel <gabriel376@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 21 Nov 2022 09:30:01 +0000
Resent-Message-ID: <handler.59438.B.166902295316960 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 59438 <at> debbugs.gnu.org
From: Gabriel <gabriel376@HIDDEN>
Date: Mon, 21 Nov 2022 06:25:17 -0300
Message-ID: <SJ0PR06MB860970919EE7F0B0A8E645708B0A9@HIDDEN>
Content-Type: multipart/mixed; boundary="=-=-="
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR06MB8609:EE_|SJ0PR06MB7471:EE_
X-MS-Office365-Filtering-Correlation-Id: c3f0aa96-7cca-4a55-f0bf-08dacba251b3
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: YVX6KGD+00N1TNNkrKu+YWvg3PDWe4zQFpPEdQG2Zx0tjEkiP6+dk/m6Qbxu/jlQPQXjDHQSbYx74caOSgfs19XT/1hlkIxUcQYaMKNELPI3WkAIJc0aTntkifH/h6Hyc646m86mAFxuM3BqVpre5Ueelj9w45XaKekHIM3r3Ur2wSWev6Vxp9O/a67ZT01CJbuZJweqhhG7cpqJjNB0o/QglBmBgw4hsX/PktN/m2rDfNa2HsZyaWWrzShkZ1bcF828qDvxx9RkrpbiIWqIPf2KrY/3MAqh0GfNIJQnjcQQlyNjW1DdHMFxJH8nNofLDTLTfpdCmav9vyv6CkPzfovqRs8IXdKD09oBT4XmLdNYV+TkeuY/8TLG1bPSBSso+mZa0ZnwOOFpA6BkgcrE6sGNmerEt6Fa9nCZ/TW82RkbSgAbd2mKdI3b7+//7CfrfiPxv02Q/f7Gj5n/gRDlfd0/hRZJ4J1Ns8fNkeUwEVlyrc63Cl/hTcunn/jWfC6Z9Nn4Gc29BMhPWvvpx6m4V73wmTLccNzwv+O/8aeb47M2DHD7fcN81myp1L4ogWVJ4YWRsK7U5BUYhZvjy/PKNt/bttR8K5MoI8ExeTeBUcM=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: MyGU9lQ75wRzrD4e3Xb16MG31x+gruxNhZ0HTy5wysh+kKhUpvkoA5wh8y/S5YBnwP4JYLSo4RqbPlWcTiRkOhjMGMFj0/5hRPdQiE4PgE/VMA8tKWnR9eUVmKXxzmNZSaQlNKprbsr0lLnTZWWXWO798Q1jUmMuGEgRcJLTx88r8i3GrTbYTfPTCR4VF58TEfqPnEOCxGCSDnZMqILuNgSEeGO8s1o/7KmhUCO0MtTyrpDwK24w1aInQoiJXp7smja6ukOy2Ia4kd6o+tK9JDlZnETT0Fhz6G5qNNa71eE4U2QMZ8f8i+X7JoK12zeJ7qVk7ELVjH8YQhASvvxQEFhqeHRYfWC+vMBN0kE6b56GbeG9mlF7qc4BHht0l4VBRVPgueY/VYhTWtNXMbSqquei6/ZJn0sJ2cqWoF+ihL+KntWe0hPB+g1fB8NesbSKhWc+A3pZz/QdmpqT8PcpjzbvkifGjtJuAlINdREkYuzZYE7j6PXbFm0a3dEmJnJJrCRIBzHkhZqtmTVmSVxXjM0evP7+CBFu2fV/Yu+jVmljMEI2m9JIW56bAOUu/1FgsAqXZ2V7ljKRC3fdIvvkJ2TNQ1nE2uZh5aEV10YbOgNsbdM45rglUW7Q3qATPHX62lj4odjjEszR3El/UqP8ccr4oWu1b0n+SWmKGihDYTZndRLxEuCr/6NwxArCw2W7/k3pAtKyM3jyzoA2mlspQZejGZrj5LoLSTa20aW+sx8tXw/IHkkvZJ6OWLSN1y7sQ1OIiqHKinPo4JSzN8QBdkiRprWzVQn+HyWr23FPNST6wv8hxNp4O/kNcPSWfEeN1AUHt58VX0FDdT9AAFsm6nxbaKEHBxFzsMlgG+KfdUosSEMK5gIXYMLiGVTfk7R2lZg34j8hMrNTYqJoUJkWBurY6e0sZQF0rcGZsS/wEbgu2vmavgyyHip1ZZmSD9cyW8FkAuNLBQD2d9ub6s/dgXklc185HnH2BII5YvE3Rg6YNKHl0rM+rVapmPXKZSQSwfvKASenNaSftfygBicyj63RbsaLHNAsAE825/C7uSxAyfPtv4owg6rDtjRfRE5RButETLNDLPM7/nm9qcyoVmfh38T9C6njv6H9YmH8yZABZfa4IO7exdQb065h6acs9PByisoxk0UXDEj2fU0ty19+Wp3wbJ9vzTaPBlOl1shPyzxfT15MtfZ6+Y5J6EtoJKnavR/Wm5QlgisNUIxmjUKs5S1e7igELToboYXIFz7aSNT5iPMTe9BMwSBjT+W2Fl2iV4tuQo2kF4ni7oTpGlFH25rYPvJUM+TBuuzZ2lDeYWjlBOGfUheO0gpPLOJBiZYRL8X090+BBHCb+wtnlA==
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-89723.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: c3f0aa96-7cca-4a55-f0bf-08dacba251b3
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR06MB8609.namprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 09:25:24.8326 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR06MB7471
Received-SPF: pass client-ip=40.92.47.108; envelope-from=gabriel376@HIDDEN;
 helo=NAM04-BN8-obe.outbound.protection.outlook.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.1 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.1 (--)

--=-=-=
Content-Type: text/plain

Description:

Please find attached a patch that proposes the following minor changes
to tab-line.  I can refactor the patch if we decide that some change are
not worth or if it's better to split it into smaller patches.

1) Turn the following defvar's into defcustom's:

- `tab-line-tabs-buffer-group-function'
- `tab-line-tabs-buffer-group-sort-function'
- `tab-line-tabs-buffer-groups-sort-function'

2) Add conditional around function call of
`tab-line-tabs-buffer-groups-sort-function', in
`tab-line-tabs-buffer-groups'.  This guards against nil values, similar
to how `tab-line-tabs-buffer-group-sort-function is handled, making the
behavior more consistent across these two (similar) variables.

Should we announce these "new" defcustom's in NEWS?


--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
 filename=0001-Make-defvar-s-into-defcustom-s-in-tab-line.patch

From da1053e7211d8bb17769fe43650a9bcdd359aeab Mon Sep 17 00:00:00 2001
From: Gabriel do Nascimento Ribeiro <gabriel376@HIDDEN>
Date: Mon, 21 Nov 2022 06:17:49 -0300
Subject: [PATCH 1/1] Make defvar's into defcustom's in tab-line

* lisp/tab-line.el (tab-line-tabs-buffer-group-function)
  (tab-line-tabs-buffer-group-sort-function)
  (tab-line-tabs-buffer-groups-sort-function): Make into defcustom's.
  (Make defvar's into defcustom's in tab-line): Handle case when
  variable tab-line-tabs-buffer-groups-sort-function is nil.
---
 lisp/tab-line.el | 51 ++++++++++++++++++++++++++++--------------------
 1 file changed, 30 insertions(+), 21 deletions(-)

diff --git a/lisp/tab-line.el b/lisp/tab-line.el
index 99a785ee3e..9b1c101718 100644
--- a/lisp/tab-line.el
+++ b/lisp/tab-line.el
@@ -341,16 +341,26 @@ tab-line-tabs-mode-buffers
                                            (derived-mode-p mode)))
                              (funcall tab-line-tabs-buffer-list-function)))))
 
-(defvar tab-line-tabs-buffer-group-function nil
+(defcustom tab-line-tabs-buffer-group-function nil
   "Function to add a buffer to the appropriate group of tabs.
-Takes a buffer as arg and should return a group name as a string.
-If the return value is nil, the buffer should be filtered out.")
+Takes a buffer as argument and should return a group name as a
+string.  If the return value is nil, the buffer should be
+ filtered out."
+  :type 'function
+  :group 'tab-line
+  :version "29.1")
 
-(defvar tab-line-tabs-buffer-group-sort-function nil
-  "Function to sort buffers in a group.")
+(defcustom tab-line-tabs-buffer-group-sort-function nil
+  "Function to sort buffers in a group."
+  :type 'function
+  :group 'tab-line
+  :version "29.1")
 
-(defvar tab-line-tabs-buffer-groups-sort-function #'string<
-  "Function to sort group names.")
+(defcustom tab-line-tabs-buffer-groups-sort-function #'string<
+  "Function to sort group names."
+  :type 'function
+  :group 'tab-line
+  :version "29.1")
 
 (defvar tab-line-tabs-buffer-groups mouse-buffer-menu-mode-groups
   "How to group various major modes together in the tab line.
@@ -378,13 +388,14 @@ tab-line-tabs-buffer-groups
 generate the group name."
   (if (window-parameter nil 'tab-line-groups)
       (let* ((buffers (funcall tab-line-tabs-buffer-list-function))
-             (groups
-              (seq-sort tab-line-tabs-buffer-groups-sort-function
-                        (delq nil (mapcar #'car (seq-group-by
-                                                 (lambda (buffer)
-                                                   (tab-line-tabs-buffer-group-name
-                                                    buffer))
-                                                 buffers)))))
+             (groups (delq nil
+                           (mapcar #'car
+                                   (seq-group-by #'tab-line-tabs-buffer-group-name
+                                                 buffers))))
+             (sorted-groups (if (functionp tab-line-tabs-buffer-groups-sort-function)
+                                (seq-sort tab-line-tabs-buffer-groups-sort-function
+                                          groups)
+                              groups))
              (selected-group (window-parameter nil 'tab-line-group))
              (tabs
               (mapcar (lambda (group)
@@ -395,9 +406,8 @@ tab-line-tabs-buffer-groups
                                        (set-window-parameter nil 'tab-line-groups nil)
                                        (set-window-parameter nil 'tab-line-group group)
                                        (set-window-parameter nil 'tab-line-hscroll nil)))))
-                      groups)))
-        tabs)
-
+                      sorted-groups)))
+             tabs)
     (let* ((window-parameter (window-parameter nil 'tab-line-group))
            (group-name (tab-line-tabs-buffer-group-name (current-buffer)))
            (group (prog1 (or window-parameter group-name "All")
@@ -410,10 +420,9 @@ tab-line-tabs-buffer-groups
                                      (set-window-parameter nil 'tab-line-groups t)
                                      (set-window-parameter nil 'tab-line-group group)
                                      (set-window-parameter nil 'tab-line-hscroll nil)))))
-           (buffers
-            (seq-filter (lambda (b)
-                          (equal (tab-line-tabs-buffer-group-name b) group))
-                        (funcall tab-line-tabs-buffer-list-function)))
+           (buffers (seq-filter (lambda (b)
+                                  (equal (tab-line-tabs-buffer-group-name b) group))
+                                (funcall tab-line-tabs-buffer-list-function)))
            (sorted-buffers (if (functionp tab-line-tabs-buffer-group-sort-function)
                                (seq-sort tab-line-tabs-buffer-group-sort-function
                                          buffers)
-- 
2.34.1


--=-=-=
Content-Type: text/plain


---
Gabriel

--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Gabriel <gabriel376@HIDDEN>
Subject: bug#59438: Acknowledgement (29.0.50; [PATCH] Make defvar's into
 defcustom's in tab-line)
Message-ID: <handler.59438.B.166902295316960.ack <at> debbugs.gnu.org>
References: <SJ0PR06MB860970919EE7F0B0A8E645708B0A9@HIDDEN>
X-Gnu-PR-Message: ack 59438
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 59438 <at> debbugs.gnu.org
Date: Mon, 21 Nov 2022 09:30:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 59438 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
59438: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D59438
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 24 Nov 2022 18:26:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 24 13:26:59 2022
Received: from localhost ([127.0.0.1]:60014 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oyGw7-0006oJ-2X
	for submit <at> debbugs.gnu.org; Thu, 24 Nov 2022 13:26:59 -0500
Received: from mail-oo1-f45.google.com ([209.85.161.45]:34498)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1oyGw2-0006nZ-Ok
 for control <at> debbugs.gnu.org; Thu, 24 Nov 2022 13:26:55 -0500
Received: by mail-oo1-f45.google.com with SMTP id
 j1-20020a4ad181000000b0049e6e8c13b4so367441oor.1
 for <control <at> debbugs.gnu.org>; Thu, 24 Nov 2022 10:26:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=rBMFgXXkSWEYBADuuIvEdEg8eU1UPxbNwnXHHyttsWg=;
 b=NH999DZKDCDYo9nY+4Tp0mAzZpiDgkrFKMuGIYR9gqeqtJbJve9CQT/4U1KC7NhYSo
 4VBAb52SScubyOLB2OCFo+4p/RfvWkgZhJvEaJkSyKPgvswC1swUC5unsGPm9NXTzMZS
 UmnZZrXgUgSrG7Ua/uou5oyKRbYgrXhbQhhxpM4wwlgyT58uqbQdC6Ae7pT75wTQx+QX
 gPBKw2xi4LlLZ+qWgT4BWSgvrjnu688rFB2JlcSYVa8hnJFZU6d0JR/weLyT9VLKg1Rw
 QmYmWLBwe5cM4/fCnq/eum8StSzvKhlSBBSx/AYZon7UbfcSHeHupk/r4oewSGZtO+Z+
 mHAQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=rBMFgXXkSWEYBADuuIvEdEg8eU1UPxbNwnXHHyttsWg=;
 b=kt6ANCeS4zLBflrWSB/nsSfgVPyBDFIAcay3F/i8csofs6ZweLyavnxrBwZvvjL/5f
 iHEzQUjkOUX3iVjK4QSuJki1ZAuIjBxnxZe+v/1MW538VuANk6bxogOR5C5Dk5nKeQcY
 1WMkhP2f3nOKOfSbqZizQKZ/JtT1Fv6GD1g285cBiOFV+qXS7SWUO6vT0EXVk/uyIug+
 YBH0yTyKbgNQiteQUBD+rWoYsqSnl1eBX0QPeygqqhI4/O6AJxEf86rAuM2W5LEYU1U2
 t1vLjTOlIdn6KK4e8mIOBP+rvfO0Hk8d1ztVHazrRVL2pOsftKlWP+rc253HIU/NwOm7
 RWrg==
X-Gm-Message-State: ANoB5plXLtjPZka9XBgXW4sBLrz88wxkLwQLtNaru9DUvIDDTSbGw8K0
 GIEXxqUNMSQfdbDJdfoAYYaKkpLK4fnl5PVkWEpf0Bm8
X-Google-Smtp-Source: AA0mqf4o9sqgE7Gv4RtYHE1QWYnDw5sVTgiMVEzPvYSzOjPralfxgY/OsC+14EK2uoUW4bGfNJgqZl7NdYWrJ6P3D2U=
X-Received: by 2002:a4a:2a57:0:b0:49a:6eb0:735a with SMTP id
 x23-20020a4a2a57000000b0049a6eb0735amr6106207oox.34.1669314409214; Thu, 24
 Nov 2022 10:26:49 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Thu, 24 Nov 2022 10:26:48 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
X-Hashcash: 1:20:221124:control <at> debbugs.gnu.org::gXfZ6SiWwXjgyVHg:1J3m
MIME-Version: 1.0
Date: Thu, 24 Nov 2022 10:26:48 -0800
Message-ID: <CADwFkmnKtwJGgdd0PcC_R2ATHL=mwBFXKVk6jVfFHzL+JYF-OA@HIDDEN>
Subject: control message for bug #59438
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

severity 59438 wishlist
quit

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#59438: 29.0.50; [PATCH] Make defvar's into defcustom's in tab-line
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 25 Nov 2022 01:17:04 +0000
Resent-Message-ID: <handler.59438.B59438.166933896432629 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Gabriel <gabriel376@HIDDEN>
Cc: 59438 <at> debbugs.gnu.org, Juri Linkov <juri@HIDDEN>
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <SJ0PR06MB860970919EE7F0B0A8E645708B0A9@HIDDEN>
 (Gabriel's message of "Mon, 21 Nov 2022 06:25:17 -0300")
References: <SJ0PR06MB860970919EE7F0B0A8E645708B0A9@HIDDEN>
MIME-Version: 1.0
Date: Thu, 24 Nov 2022 17:15:56 -0800
Message-ID: <CADwFkm=74_r2ddOw_ebexBG1PG2J_SGgDeZNfMMjyYTF5Rvxug@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Gabriel <gabriel376@HIDDEN> writes:

> Please find attached a patch that proposes the following minor changes
> to tab-line.  I can refactor the patch if we decide that some change are
> not worth or if it's better to split it into smaller patches.
>
> 1) Turn the following defvar's into defcustom's:
>
> - `tab-line-tabs-buffer-group-function'
> - `tab-line-tabs-buffer-group-sort-function'
> - `tab-line-tabs-buffer-groups-sort-function'
>
> 2) Add conditional around function call of
> `tab-line-tabs-buffer-groups-sort-function', in
> `tab-line-tabs-buffer-groups'.  This guards against nil values, similar
> to how `tab-line-tabs-buffer-group-sort-function is handled, making the
> behavior more consistent across these two (similar) variables.
>
> Should we announce these "new" defcustom's in NEWS?

Juri, thoughts?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#59438: 29.0.50; [PATCH] Make defvar's into defcustom's in tab-line
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 07 Sep 2023 21:08:02 +0000
Resent-Message-ID: <handler.59438.B59438.169412083929509 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 59438
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Gabriel <gabriel376@HIDDEN>
Cc: 59438 <at> debbugs.gnu.org, Juri Linkov <juri@HIDDEN>
Received: via spool by 59438-submit <at> debbugs.gnu.org id=B59438.169412083929509
          (code B ref 59438); Thu, 07 Sep 2023 21:08:02 +0000
Received: (at 59438) by debbugs.gnu.org; 7 Sep 2023 21:07:19 +0000
Received: from localhost ([127.0.0.1]:41519 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qeMDf-0007ft-Ck
	for submit <at> debbugs.gnu.org; Thu, 07 Sep 2023 17:07:19 -0400
Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]:58721)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1qeMDc-0007fd-R2
 for 59438 <at> debbugs.gnu.org; Thu, 07 Sep 2023 17:07:17 -0400
Received: by mail-lf1-x12c.google.com with SMTP id
 2adb3069b0e04-501bd7711e8so2433722e87.1
 for <59438 <at> debbugs.gnu.org>; Thu, 07 Sep 2023 14:07:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20221208; t=1694120829; x=1694725629; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=vM0x687fy5RaKTKbRavxxrdTLuwCutn8czrcft0iu+0=;
 b=jJgXXF2/gyrpiy0ZCAXKT56f5eUZOdbWjUi2aad2P0abom9MnE9+sH54Hnu6XxLHll
 nlEYJX+ge72b4qOe/ElfeB8WvSPdIoXovY/peLMNwVknSyYq3zei0jZFCvKRJ9dGIsoB
 c2pNnM8TidSY8A9qt+8iikhhOe/Fkxdn21WCkyEMa1qlOrdRgFSBqf4K32wIQqpib0+h
 ziT2Pet0TVJ/iIbbvAvoPGTe3K84PPv8klWBDvwJrpr5m5Eu45Ruwrltydmiz18WOL9S
 v0qBCr8nMZqE1XzgcmdRgQfzoUBYu2ns9RPOZv+ji/phszWMxsxo9Mx3mIOi0OMcG+eG
 wzYw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1694120829; x=1694725629;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=vM0x687fy5RaKTKbRavxxrdTLuwCutn8czrcft0iu+0=;
 b=a5pndOR58MZVcnsn4mjiXuzfr0RweiDkHAldANkjMt9uQgqFxjxz32pegR0DvG97Hv
 OfoufUZuwTz41O0TdDl2t+XuKib6KS4mE+HBBYgBfFeoAi9cZS/ApYOL/B7wp6psh6/H
 x4eM6dfW98YgcMt+VbTN2LZ5jty3BrnO0aGHAXwUZbRMUcL9kBRWnOvjzGeM6egENs+W
 ANRw0R7/xVj7tuWXe3B27/WSBm/8eWV5E/qG8S2FFe3OtqQ4xD1YpGV2sXLRtRpbhVSe
 Cvn25wS+Pm+cBGtNyJgKYoPZLOVu9MnihQK/Ch+Z1xc9sSi1JR+MoIgwB0GcmB82+07o
 /TCA==
X-Gm-Message-State: AOJu0YwBXG/GTmA3Nf8H6IjxBQOyxRnKdYb2hCKP0f25Kd+MhHrA93sz
 JmzOuWKZMvnsxmIhoDTHHDuCoyonD0UAdXwJap8=
X-Google-Smtp-Source: AGHT+IEHaVCtWwJ7g+f6q+OrYxpwFnBuWLbsAvr2QijYBW1JnvVvoI3Ib87huKNe/ACh6wESK3C0ANln0HYpSuYXQ70=
X-Received: by 2002:a05:6512:3d8e:b0:500:8d17:1992 with SMTP id
 k14-20020a0565123d8e00b005008d171992mr493504lfv.22.1694120828791; Thu, 07 Sep
 2023 14:07:08 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Thu, 7 Sep 2023 14:07:08 -0700
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <CADwFkm=74_r2ddOw_ebexBG1PG2J_SGgDeZNfMMjyYTF5Rvxug@HIDDEN>
 (Stefan Kangas's message of "Thu, 24 Nov 2022 17:15:56 -0800")
References: <SJ0PR06MB860970919EE7F0B0A8E645708B0A9@HIDDEN>
 <CADwFkm=74_r2ddOw_ebexBG1PG2J_SGgDeZNfMMjyYTF5Rvxug@HIDDEN>
MIME-Version: 1.0
Date: Thu, 7 Sep 2023 14:07:08 -0700
Message-ID: <CADwFkmm=kpLwEdQkM2SOKdjwUe0REEm83+Uet2X6ZY_FYjadWA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Stefan Kangas <stefankangas@HIDDEN> writes:

> Gabriel <gabriel376@HIDDEN> writes:
>
>> Please find attached a patch that proposes the following minor changes
>> to tab-line.  I can refactor the patch if we decide that some change are
>> not worth or if it's better to split it into smaller patches.
>>
>> 1) Turn the following defvar's into defcustom's:
>>
>> - `tab-line-tabs-buffer-group-function'
>> - `tab-line-tabs-buffer-group-sort-function'
>> - `tab-line-tabs-buffer-groups-sort-function'
>>
>> 2) Add conditional around function call of
>> `tab-line-tabs-buffer-groups-sort-function', in
>> `tab-line-tabs-buffer-groups'.  This guards against nil values, similar
>> to how `tab-line-tabs-buffer-group-sort-function is handled, making the
>> behavior more consistent across these two (similar) variables.
>>
>> Should we announce these "new" defcustom's in NEWS?
>
> Juri, thoughts?

Ping.  Does anyone have any comments?

Last modified: Thu, 7 Sep 2023 21:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.