GNU logs - #60880, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#60880: 30.0.50; tree-sitter `treesit-explore-mode' is buggy and does not behave properly
Resent-From: Mickey Petersen <mickey@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 17 Jan 2023 13:50:02 +0000
Resent-Message-ID: <handler.60880.B.167396338732383 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 60880 <at> debbugs.gnu.org
Received-SPF: Pass (protection.outlook.com: domain of masteringemacs.org
 designates 178.79.136.144 as permitted sender)
 receiver=protection.outlook.com; client-ip=178.79.136.144;
 helo=semantical.co.uk; pr=C
From: Mickey Petersen <mickey@HIDDEN>
Date: Tue, 17 Jan 2023 13:44:21 +0000
Message-ID: <87wn5ls2bu.fsf@HIDDEN>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2023 13:44:28.4806 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 31d2fef5-da98-48e5-a84a-08daf890f462
X-MS-Exchange-CrossTenant-Id: a4e27e3d-bab0-45e8-8942-e64cf9fbd34f
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a4e27e3d-bab0-45e8-8942-e64cf9fbd34f; Ip=[178.79.136.144];
 Helo=[semantical.co.uk]
X-MS-Exchange-CrossTenant-AuthSource: LO2GBR01FT024.eop-gbr01.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LOYP265MB1791
Received-SPF: pass client-ip=2a01:111:f400:fe15::706;
 envelope-from=mickey@HIDDEN;
 helo=GBR01-LO2-obe.outbound.protection.outlook.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)


A medley of issues here:

1. Executing `treesit-explore-mode' on a buffer with no valid grammar
support causes the minor mode (and playground buffer) to stick around and "load" anyway.

2. Bailing out of the grammar prompt does not, in actual fact, stop explore mode from proceeding. Instead it creates an empty buffer and it still engages the minor mode.

3. Killing the playground buffer does not remove the explore mode buffer.

4. treesit-explore-mode is stored against a buffer during `desktop-save' (and subsequently read with) `desktop-read'. Thus broken buffers or files inherit the explore mode. This is especially pernicious due to #1, #2, and #3.




In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.20, cairo version 1.16.0) of 2023-01-17 built on mickey-work
Repository revision: bb383a54910c3094e5d228e0af62bf70e36203ca
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12013000
System Description: Ubuntu 20.04.3 LTS

Configured using:
 'configure --with-native-compilation --with-json --with-mailutils
 --without-compress-install --with-imagemagick CC=gcc-10'

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Mickey Petersen <mickey@HIDDEN>
Subject: bug#60880: Acknowledgement (30.0.50; tree-sitter `treesit-explore-mode'
 is buggy and does not behave properly)
Message-ID: <handler.60880.B.167396338732383.ack <at> debbugs.gnu.org>
References: <87wn5ls2bu.fsf@HIDDEN>
X-Gnu-PR-Message: ack 60880
X-Gnu-PR-Package: emacs
Reply-To: 60880 <at> debbugs.gnu.org
Date: Tue, 17 Jan 2023 13:50:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 60880 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
60880: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D60880
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#60880: 30.0.50; tree-sitter `treesit-explore-mode' is buggy  and does not behave properly
References: <87wn5ls2bu.fsf@HIDDEN>
In-Reply-To: <87wn5ls2bu.fsf@HIDDEN>
Resent-From: Yuan Fu <casouri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 19 Jan 2023 22:32:02 +0000
Resent-Message-ID: <handler.60880.B60880.167416746810778 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Mickey Petersen <mickey@HIDDEN>
Cc: 60880 <at> debbugs.gnu.org
From: Yuan Fu <casouri@HIDDEN>
Content-Type: text/plain;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\))
Message-Id: <616F5C5A-1D12-4E14-90D4-8ABE7FD869BD@HIDDEN>
Date: Thu, 19 Jan 2023 14:30:46 -0800
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>


Mickey Petersen <mickey@HIDDEN> writes:

> A medley of issues here:
>
> 1. Executing `treesit-explore-mode' on a buffer with no valid grammar
> support causes the minor mode (and playground buffer) to stick around =
and "load" anyway.
>
> 2. Bailing out of the grammar prompt does not, in actual fact, stop
> explore mode from proceeding. Instead it creates an empty buffer and
> it still engages the minor mode.
>
> 3. Killing the playground buffer does not remove the explore mode =
buffer.
>
> 4. treesit-explore-mode is stored against a buffer during
> `desktop-save' (and subsequently read with) `desktop-read'. Thus
> broken buffers or files inherit the explore mode. This is especially
> pernicious due to #1, #2, and #3.

Ok, I fixed those problems. Now if the language is not available,
treesit-explore-mode raises an error instead of continuing, desktop-save
will not save the explorer buffer, and killing the source buffer also
kills the explorer buffer.

Invalid language doesn=E2=80=99t stop treesit-explore-mode from turning =
on, even
if it doesn=E2=80=99t create buffers, etc, since I think this is how =
minor modes
usually behave.

Yuan

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#60880: 30.0.50; tree-sitter `treesit-explore-mode' is buggy and does not behave properly
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 20 Jan 2023 07:03:01 +0000
Resent-Message-ID: <handler.60880.B60880.167419813530208 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Yuan Fu <casouri@HIDDEN>
Cc: 60880 <at> debbugs.gnu.org, mickey@HIDDEN
Date: Fri, 20 Jan 2023 09:02:01 +0200
Message-Id: <83ilh1ofiu.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <616F5C5A-1D12-4E14-90D4-8ABE7FD869BD@HIDDEN> (message from
 Yuan Fu on Thu, 19 Jan 2023 14:30:46 -0800)
References: <87wn5ls2bu.fsf@HIDDEN>
 <616F5C5A-1D12-4E14-90D4-8ABE7FD869BD@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> Cc: 60880 <at> debbugs.gnu.org
> From: Yuan Fu <casouri@HIDDEN>
> Date: Thu, 19 Jan 2023 14:30:46 -0800
> 
> 
> Mickey Petersen <mickey@HIDDEN> writes:
> 
> > A medley of issues here:
> >
> > 1. Executing `treesit-explore-mode' on a buffer with no valid grammar
> > support causes the minor mode (and playground buffer) to stick around and "load" anyway.
> >
> > 2. Bailing out of the grammar prompt does not, in actual fact, stop
> > explore mode from proceeding. Instead it creates an empty buffer and
> > it still engages the minor mode.
> >
> > 3. Killing the playground buffer does not remove the explore mode buffer.
> >
> > 4. treesit-explore-mode is stored against a buffer during
> > `desktop-save' (and subsequently read with) `desktop-read'. Thus
> > broken buffers or files inherit the explore mode. This is especially
> > pernicious due to #1, #2, and #3.
> 
> Ok, I fixed those problems. Now if the language is not available,
> treesit-explore-mode raises an error instead of continuing, desktop-save
> will not save the explorer buffer, and killing the source buffer also
> kills the explorer buffer.

I don't think the desktop-save part is correct: the test should be at
desktop-read time, not at desktop-save time.  Because the fact we had
the language available when we saved the desktop doesn't guarantee we
will have it available when restoring that desktop: it could be in a
different build of Emacs or even on a different machine.

I'm not sure I understand the problem which desktop-read has when
restoring desktop with buffers in treesit-explore-mode, but if the
problems are more than just warning messages, then desktop-read should
detect these problems, emit an echo-area message, and refrain from
restoring the mode.  Like it does with buffers that visited files
which are no longer there, for example.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#60880: 30.0.50; tree-sitter `treesit-explore-mode' is buggy and does not behave properly
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 20 Jan 2023 08:21:01 +0000
Resent-Message-ID: <handler.60880.B60880.16742028025473 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 60880
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 60880 <at> debbugs.gnu.org, Yuan Fu <casouri@HIDDEN>, mickey@HIDDEN
Received: via spool by 60880-submit <at> debbugs.gnu.org id=B60880.16742028025473
          (code B ref 60880); Fri, 20 Jan 2023 08:21:01 +0000
Received: (at 60880) by debbugs.gnu.org; 20 Jan 2023 08:20:02 +0000
Received: from localhost ([127.0.0.1]:45361 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pImcz-0001Pj-4s
	for submit <at> debbugs.gnu.org; Fri, 20 Jan 2023 03:20:02 -0500
Received: from relay9-d.mail.gandi.net ([217.70.183.199]:53879)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1pImcu-0001PS-PR
 for 60880 <at> debbugs.gnu.org; Fri, 20 Jan 2023 03:20:00 -0500
Received: (Authenticated sender: juri@HIDDEN)
 by mail.gandi.net (Postfix) with ESMTPSA id E1580FF802;
 Fri, 20 Jan 2023 08:19:48 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
In-Reply-To: <83ilh1ofiu.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 20 Jan
 2023 09:02:01 +0200")
Organization: LINKOV.NET
References: <87wn5ls2bu.fsf@HIDDEN>
 <616F5C5A-1D12-4E14-90D4-8ABE7FD869BD@HIDDEN>
 <83ilh1ofiu.fsf@HIDDEN>
Date: Fri, 20 Jan 2023 09:59:09 +0200
Message-ID: <8635856316.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

> I don't think the desktop-save part is correct: the test should be at
> desktop-read time, not at desktop-save time.  Because the fact we had
> the language available when we saved the desktop doesn't guarantee we
> will have it available when restoring that desktop: it could be in a
> different build of Emacs or even on a different machine.

When the buffer is not saved, then it will cause no problems when restoring.

Last modified: Fri, 20 Jan 2023 08:30:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.