Received: (at 60880) by debbugs.gnu.org; 20 Jan 2023 08:20:02 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 20 03:20:02 2023 Received: from localhost ([127.0.0.1]:45361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pImcz-0001Pj-4s for submit <at> debbugs.gnu.org; Fri, 20 Jan 2023 03:20:02 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:53879) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1pImcu-0001PS-PR for 60880 <at> debbugs.gnu.org; Fri, 20 Jan 2023 03:20:00 -0500 Received: (Authenticated sender: juri@HIDDEN) by mail.gandi.net (Postfix) with ESMTPSA id E1580FF802; Fri, 20 Jan 2023 08:19:48 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#60880: 30.0.50; tree-sitter `treesit-explore-mode' is buggy and does not behave properly In-Reply-To: <83ilh1ofiu.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 20 Jan 2023 09:02:01 +0200") Organization: LINKOV.NET References: <87wn5ls2bu.fsf@HIDDEN> <616F5C5A-1D12-4E14-90D4-8ABE7FD869BD@HIDDEN> <83ilh1ofiu.fsf@HIDDEN> Date: Fri, 20 Jan 2023 09:59:09 +0200 Message-ID: <8635856316.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60880 Cc: 60880 <at> debbugs.gnu.org, Yuan Fu <casouri@HIDDEN>, mickey@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > I don't think the desktop-save part is correct: the test should be at > desktop-read time, not at desktop-save time. Because the fact we had > the language available when we saved the desktop doesn't guarantee we > will have it available when restoring that desktop: it could be in a > different build of Emacs or even on a different machine. When the buffer is not saved, then it will cause no problems when restoring.
bug-gnu-emacs@HIDDEN:bug#60880; Package emacs.
Full text available.Received: (at 60880) by debbugs.gnu.org; 20 Jan 2023 07:02:15 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 20 02:02:15 2023 Received: from localhost ([127.0.0.1]:45301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pIlPi-0007r8-MQ for submit <at> debbugs.gnu.org; Fri, 20 Jan 2023 02:02:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1pIlPe-0007qq-On for 60880 <at> debbugs.gnu.org; Fri, 20 Jan 2023 02:02:13 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pIlPY-0005NW-Hc; Fri, 20 Jan 2023 02:02:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=gQFzYdXFtbQJ1GL4oEdtw1JrSsAVyrItw2v9BZCIJLM=; b=jv3Ljsq44Jrd atMWP8QgN7/ylijAdtDMrDZCiFXlPp3S7Y0uaMDpsbGGIPeSG4yYNh4dyqxgaWnn6fNJTmp0x/4U1 Fus5TDxgN9lGsxrEdkzF7VtCIvczZRkSZA605KLKO4x4cHmTUqV6rq2Y6v7kyhxaE5xsHIqKf0hWV gNFQZmlFJ1sMXWdSUp52uLS++FpX0LvdIf9duYTujJtRsb7qs6hKi9n6TIyahKNdGuS4oxVYaWwZn YpDvVxJ+wNB5d/vpFEAjt7JXZZrPEChfe9ayd2EWov4LJH+A5rj1HrirV1RAu2fSiPH+gNpjgFApg P7smerGtxW2KFY6qOpMQEg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pIlPX-0007Py-Ko; Fri, 20 Jan 2023 02:02:04 -0500 Date: Fri, 20 Jan 2023 09:02:01 +0200 Message-Id: <83ilh1ofiu.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Yuan Fu <casouri@HIDDEN> In-Reply-To: <616F5C5A-1D12-4E14-90D4-8ABE7FD869BD@HIDDEN> (message from Yuan Fu on Thu, 19 Jan 2023 14:30:46 -0800) Subject: Re: bug#60880: 30.0.50; tree-sitter `treesit-explore-mode' is buggy and does not behave properly References: <87wn5ls2bu.fsf@HIDDEN> <616F5C5A-1D12-4E14-90D4-8ABE7FD869BD@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60880 Cc: 60880 <at> debbugs.gnu.org, mickey@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: 60880 <at> debbugs.gnu.org > From: Yuan Fu <casouri@HIDDEN> > Date: Thu, 19 Jan 2023 14:30:46 -0800 > > > Mickey Petersen <mickey@HIDDEN> writes: > > > A medley of issues here: > > > > 1. Executing `treesit-explore-mode' on a buffer with no valid grammar > > support causes the minor mode (and playground buffer) to stick around and "load" anyway. > > > > 2. Bailing out of the grammar prompt does not, in actual fact, stop > > explore mode from proceeding. Instead it creates an empty buffer and > > it still engages the minor mode. > > > > 3. Killing the playground buffer does not remove the explore mode buffer. > > > > 4. treesit-explore-mode is stored against a buffer during > > `desktop-save' (and subsequently read with) `desktop-read'. Thus > > broken buffers or files inherit the explore mode. This is especially > > pernicious due to #1, #2, and #3. > > Ok, I fixed those problems. Now if the language is not available, > treesit-explore-mode raises an error instead of continuing, desktop-save > will not save the explorer buffer, and killing the source buffer also > kills the explorer buffer. I don't think the desktop-save part is correct: the test should be at desktop-read time, not at desktop-save time. Because the fact we had the language available when we saved the desktop doesn't guarantee we will have it available when restoring that desktop: it could be in a different build of Emacs or even on a different machine. I'm not sure I understand the problem which desktop-read has when restoring desktop with buffers in treesit-explore-mode, but if the problems are more than just warning messages, then desktop-read should detect these problems, emit an echo-area message, and refrain from restoring the mode. Like it does with buffers that visited files which are no longer there, for example.
bug-gnu-emacs@HIDDEN:bug#60880; Package emacs.
Full text available.Received: (at 60880) by debbugs.gnu.org; 19 Jan 2023 22:31:08 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 19 17:31:08 2023 Received: from localhost ([127.0.0.1]:44920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pIdR6-0002nm-75 for submit <at> debbugs.gnu.org; Thu, 19 Jan 2023 17:31:08 -0500 Received: from mail-pf1-f175.google.com ([209.85.210.175]:38517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <casouri@HIDDEN>) id 1pIdR2-0002nD-HO for 60880 <at> debbugs.gnu.org; Thu, 19 Jan 2023 17:31:06 -0500 Received: by mail-pf1-f175.google.com with SMTP id 207so2638666pfv.5 for <60880 <at> debbugs.gnu.org>; Thu, 19 Jan 2023 14:31:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=8l5RWG7bv1zkbqfw3lIX3xC1o1DlU7tSIj/BlzMF+H4=; b=BdUrNL2q4KUvlB8eaoyehiLR12rSbrvBgxGMerOQ7CML7c/MLmj2sGTFaouWwSpMUu 0wJk+xOd06AdZKW1Ms2xKq0JErMY6bj60FkxkRX5/lNzrZR8RSb9hItXQ0sAgOEbMAPC kl1RfAL4tXCZMFlOy/khlk8OYXcd8DjUTamHpcafpTU8WL4Advxpj8qQwmVof0DBbTmk VIVTDrIOJKIKWoTvePFbEZwmONWN0k+QuM5Je6kblkN6anbEaX46rrLqIhFmlGrbiqLP sGZevVyJIgeFZ7WI1JNv6Dgf0oee+dNnv5czd3s1G5DnJQKzLWnD844Y6fWpxP/x7WXC /5AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8l5RWG7bv1zkbqfw3lIX3xC1o1DlU7tSIj/BlzMF+H4=; b=2gntTg7GPciC2sQGfjQNA+RgG8975/3fKMZ5Q6wITbQHVvEbhnvjUcA+Uo40POpuTy RTSHoRvBtClWRFYaqWZIcozPtqsgWDl8MnqOk/LSWHQN6qPCBlYS6mvm4TrE+aBtP9is KBIl5NpXlf1/CXYJhb7hVog+QYZVuvsCbAUch7q0Y2Y6rSOXZ/RRHmHE5+aIIXnezaOv AZ+1J1gwLStq8ccI+Fo5qNwhtxrHMDf7icPbbR1zQqYcA9dnjeWiLG9gWedg2YP3Rq+H mqfk86KLrJ3JbeR572R/WsXStOQ5EPWnEodDo64l70pESrN1oDTn/hkwmJqToe+UgXv1 P2eA== X-Gm-Message-State: AFqh2kqsBTbCDVaZyG17phIuXH9pnAaxS7A5GCCSlgKWMQN6IiFJiaQz OqJ5KvOk4i0BCChxy4IqT784TWxUnKk= X-Google-Smtp-Source: AMrXdXt1NeIZkWoY0gcu8CPUJx148bAmSo+UQEulyfywWMcqe+f5/qyergzkSnyCiz+wI/Do5G7tRQ== X-Received: by 2002:a05:6a00:4c9c:b0:56e:a7a7:35a0 with SMTP id eb28-20020a056a004c9c00b0056ea7a735a0mr13652117pfb.25.1674167458600; Thu, 19 Jan 2023 14:30:58 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id f13-20020aa7968d000000b0056b4c5dde61sm12847908pfk.98.2023.01.19.14.30.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Jan 2023 14:30:58 -0800 (PST) From: Yuan Fu <casouri@HIDDEN> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: bug#60880: 30.0.50; tree-sitter `treesit-explore-mode' is buggy and does not behave properly Message-Id: <616F5C5A-1D12-4E14-90D4-8ABE7FD869BD@HIDDEN> Date: Thu, 19 Jan 2023 14:30:46 -0800 To: Mickey Petersen <mickey@HIDDEN> X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60880 Cc: 60880 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Mickey Petersen <mickey@HIDDEN> writes: > A medley of issues here: > > 1. Executing `treesit-explore-mode' on a buffer with no valid grammar > support causes the minor mode (and playground buffer) to stick around = and "load" anyway. > > 2. Bailing out of the grammar prompt does not, in actual fact, stop > explore mode from proceeding. Instead it creates an empty buffer and > it still engages the minor mode. > > 3. Killing the playground buffer does not remove the explore mode = buffer. > > 4. treesit-explore-mode is stored against a buffer during > `desktop-save' (and subsequently read with) `desktop-read'. Thus > broken buffers or files inherit the explore mode. This is especially > pernicious due to #1, #2, and #3. Ok, I fixed those problems. Now if the language is not available, treesit-explore-mode raises an error instead of continuing, desktop-save will not save the explorer buffer, and killing the source buffer also kills the explorer buffer. Invalid language doesn=E2=80=99t stop treesit-explore-mode from turning = on, even if it doesn=E2=80=99t create buffers, etc, since I think this is how = minor modes usually behave. Yuan
bug-gnu-emacs@HIDDEN:bug#60880; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 17 Jan 2023 13:49:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 17 08:49:47 2023 Received: from localhost ([127.0.0.1]:36120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pHmLS-0008QE-Rl for submit <at> debbugs.gnu.org; Tue, 17 Jan 2023 08:49:47 -0500 Received: from lists.gnu.org ([209.51.188.17]:38508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mickey@HIDDEN>) id 1pHmLP-0008Q1-92 for submit <at> debbugs.gnu.org; Tue, 17 Jan 2023 08:49:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <mickey@HIDDEN>) id 1pHmLL-0006a3-0H for bug-gnu-emacs@HIDDEN; Tue, 17 Jan 2023 08:49:39 -0500 Received: from mail-lo2gbr01on0706.outbound.protection.outlook.com ([2a01:111:f400:fe15::706] helo=GBR01-LO2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <mickey@HIDDEN>) id 1pHmLG-0005KQ-TD for bug-gnu-emacs@HIDDEN; Tue, 17 Jan 2023 08:49:38 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IMY5Z5GwV7YmpttdNrutzESwrOWih4Pt2886TcIq7F0HN+Sqz3KgC0HTmDmC/SMEfOUmwu2M2mlz+vCgI2YkpsgZszT6+tTYOvrFJ5/jpg3Y6sucu4BjRPBqPYRT7MW76/xgFFHlfRDMnw0I4RFI9ij9azn2zzdKXzpJpsYhnoSKPNLUiKQdoaO4uopeeA/WY7CqqhdZg0vwiQWpFJaO8xNzNUNlamOdSRMQysl6fI/8SbXOKMaK1laIG0l4YfSPAKIFKC1+Ud0u6LtTI42h3Pt+d5U7i+SUgm4c2zKHO5q4Wrrfjz9xshRChzGxozAufDpjRbOJS4oCoD+Zh46Kaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tUgpzQTsmFAhNZmkAjhGEr+9xDGBSAGG77cO72VpGZI=; b=fU7krpfhbGWw0CUzc0wmj2hkRbqbhY+9c4bs8j7GDdn4VmW1EmZKxie4zRvO9GHBeKhpbgolwm2HBMZxtYjBxo/CMWAlY9ZeMIZdhheojwPJcghyp8qQ1RMmE6JlpYIv9ieFrlqNXDus2npJ5EjektAZdfFxG7UpxrhVcS0YNdKQQ8ozt7Z7uQIbv0mGsAAxxNEIvI/63MkpPuP6wFhlN/PqERwo1HTExvjTEAVH6ElWAdv7PTTzmEEbR5uZ79mLvxs5aTuVL66///+XnO7wEdlmld2TGor/8FZeNjjT+UCo9gljcxfdbwKe5slSpueQ03c1Tw6q9Wp2FlEM3J194w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 178.79.136.144) smtp.rcpttodomain=gnu.org smtp.mailfrom=masteringemacs.org; dmarc=pass (p=none sp=none pct=100) action=none header.from=masteringemacs.org; dkim=pass (signature was verified) header.d=masteringemacs.org; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semantical.onmicrosoft.com; s=selector1-semantical-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tUgpzQTsmFAhNZmkAjhGEr+9xDGBSAGG77cO72VpGZI=; b=eTipvWb50AS6WqI6JmtjccnqOL5pOBbIMt4E4tjBJa0PB2SlsE8/l4U3YusRADPW0XjInEkr1mgoe/5Gc1qVDFXE3jMUWsNGXVab8htjbXZ7Alc0wtwyBbTf75cC7AlBu6x1/oduIJYLo7YJ2IBKoFjARjvvF+jRb8W4v9F59bQ= Received: from LO6P123CA0059.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:310::17) by LOYP265MB1791.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.23; Tue, 17 Jan 2023 13:44:29 +0000 Received: from LO2GBR01FT024.eop-gbr01.prod.protection.outlook.com (2603:10a6:600:310:cafe::90) by LO6P123CA0059.outlook.office365.com (2603:10a6:600:310::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.19 via Frontend Transport; Tue, 17 Jan 2023 13:44:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 178.79.136.144) smtp.mailfrom=masteringemacs.org; dkim=pass (signature was verified) header.d=masteringemacs.org;dmarc=pass action=none header.from=masteringemacs.org; Received-SPF: Pass (protection.outlook.com: domain of masteringemacs.org designates 178.79.136.144 as permitted sender) receiver=protection.outlook.com; client-ip=178.79.136.144; helo=semantical.co.uk; pr=C Received: from semantical.co.uk (178.79.136.144) by LO2GBR01FT024.mail.protection.outlook.com (10.152.42.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13 via Frontend Transport; Tue, 17 Jan 2023 13:44:28 +0000 Received: by semantical.co.uk (Postfix, from userid 5001) id 2F1B2114002; Tue, 17 Jan 2023 13:44:28 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=masteringemacs.org; s=masteringemacs.org; t=1673963068; bh=tUgpzQTsmFAhNZmkAjhGEr+9xDGBSAGG77cO72VpGZI=; h=From:To:Subject:Date:From; b=e2ntdwQPSrSxH+3RdmByWR/9yFHxQhe/CACId1UVBTMhgnGvBFHw+rP0bT5paST6N VWDPxuLIrc64sykxEUKP+MC/3+Qob/cRd0xgpdUjvWDxLR9eSnQ7yJqqcno/0gqjBu UtsXrv00HCcy6EXTExlY+k33ACLCEUaidotBe3wQ= X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on semantical.co.uk X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_RECEIVED, NO_RELAYS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 From: Mickey Petersen <mickey@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 30.0.50; tree-sitter `treesit-explore-mode' is buggy and does not behave properly Date: Tue, 17 Jan 2023 13:44:21 +0000 Message-ID: <87wn5ls2bu.fsf@HIDDEN> Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LO2GBR01FT024:EE_|LOYP265MB1791:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 31d2fef5-da98-48e5-a84a-08daf890f462 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8OfyT8+/xDiyxU0Et0HiHM6FenP8JADeLiq9v55beqZEOF8grbTbeWTrFNs3sijssdwhDXpDm9F3tHmQAtLTvFsWGYfHMwR/T21ryPZrO/D4awXYdjgLeZVZlNjwdhVcuvTV1DW3B/yc7DbYA7/jCvp8up0AjYBulGUlSR6bHTbSwrFR5g4e2T4vBaemncn+SxNkoeSB4NOw2D+vfDb7w8Q5bM1foLvr0kWj4NHfLc5+TYLgfTfdx4BNqNpH8qtaATX0jnr58+hcDsSXwowTqdbCdVmePQD6alA3epX1/ou8vNzzvIJsk8o5nj7WcLfteXyvyDglyamvWKIaydf5xWU+TiCWSeUF0DyVzjpTlsZEcz7kKQL3a1u3aR1LpNkPUGqzuBmgBcME9aBZnktMpzt80BPVcicIIX92cavb0SimZJoxECJigUlJ8HiWYKgfpYWlhHJ1LWcJtqd0PUBlzCSO6vOcEYsQCrimgh/FWl28JcGznBiitJtugT+Z+XUg2YD+Q4yzEl+ij80ruuEA/xFz09CWOUr04ofL1rDxq1ClKUU8rgDNOJwaWgTIPY4n62OfuffDD3w8c6p0jFB9j1M0dOED5frCUXClfHUoWeQx7F5SEyD2oa/FiUsWZphn7J6MbEobLdd94/5Ax3XMaKJQ0wqCamwhqCINyMqlDeQgni/eWRhtRFrhuxm265TqtVjBtPT3fPImV0hf+Tnzm6euNnjwSTxxtnhXfPQ5ALZgXyfFEf2boj3Kv3U6iXApXDkAnIWi5Mp/nVb48WoQDw== X-Forefront-Antispam-Report: CIP:178.79.136.144; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:semantical.co.uk; PTR:semantical.co.uk; CAT:NONE; SFS:(13230022)(346002)(396003)(136003)(376002)(39830400003)(451199015)(36840700001)(46966006)(82310400005)(36756003)(86362001)(6916009)(186003)(26005)(41300700001)(8676002)(70586007)(70206006)(6266002)(2616005)(47076005)(316002)(7596003)(6666004)(478600001)(2906002)(42186006)(7636003)(356005)(5660300002)(36860700001)(336012)(8936002)(40480700001)(38230200001)(81973001)(79816003)(14776008); DIR:OUT; SFP:1102; X-OriginatorOrg: masteringemacs.org X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2023 13:44:28.4806 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 31d2fef5-da98-48e5-a84a-08daf890f462 X-MS-Exchange-CrossTenant-Id: a4e27e3d-bab0-45e8-8942-e64cf9fbd34f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a4e27e3d-bab0-45e8-8942-e64cf9fbd34f; Ip=[178.79.136.144]; Helo=[semantical.co.uk] X-MS-Exchange-CrossTenant-AuthSource: LO2GBR01FT024.eop-gbr01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LOYP265MB1791 Received-SPF: pass client-ip=2a01:111:f400:fe15::706; envelope-from=mickey@HIDDEN; helo=GBR01-LO2-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.4 (--) A medley of issues here: 1. Executing `treesit-explore-mode' on a buffer with no valid grammar support causes the minor mode (and playground buffer) to stick around and "load" anyway. 2. Bailing out of the grammar prompt does not, in actual fact, stop explore mode from proceeding. Instead it creates an empty buffer and it still engages the minor mode. 3. Killing the playground buffer does not remove the explore mode buffer. 4. treesit-explore-mode is stored against a buffer during `desktop-save' (and subsequently read with) `desktop-read'. Thus broken buffers or files inherit the explore mode. This is especially pernicious due to #1, #2, and #3. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0) of 2023-01-17 built on mickey-work Repository revision: bb383a54910c3094e5d228e0af62bf70e36203ca Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12013000 System Description: Ubuntu 20.04.3 LTS Configured using: 'configure --with-native-compilation --with-json --with-mailutils --without-compress-install --with-imagemagick CC=gcc-10'
Mickey Petersen <mickey@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#60880; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.