X-Loop: help-debbugs@HIDDEN
Subject: bug#65519: 30.0.50; [FR Eglot] keymaps for useful functions
Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 25 Aug 2023 06:48:01 +0000
Resent-Message-ID: <handler.65519.B.169294603814746 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 65519
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: 65519 <at> debbugs.gnu.org
X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.169294603814746
(code B ref -1); Fri, 25 Aug 2023 06:48:01 +0000
Received: (at submit) by debbugs.gnu.org; 25 Aug 2023 06:47:18 +0000
Received: from localhost ([127.0.0.1]:39076 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qZQbG-0003pm-C9
for submit <at> debbugs.gnu.org; Fri, 25 Aug 2023 02:47:18 -0400
Received: from lists.gnu.org ([2001:470:142::17]:49582)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <gerd.moellmann@HIDDEN>) id 1qZQb9-0003p4-1s
for submit <at> debbugs.gnu.org; Fri, 25 Aug 2023 02:47:16 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <gerd.moellmann@HIDDEN>)
id 1qZQal-0004Ky-Rg
for bug-gnu-emacs@HIDDEN; Fri, 25 Aug 2023 02:46:51 -0400
Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <gerd.moellmann@HIDDEN>)
id 1qZQaj-0005dl-N4
for bug-gnu-emacs@HIDDEN; Fri, 25 Aug 2023 02:46:47 -0400
Received: by mail-ej1-x629.google.com with SMTP id
a640c23a62f3a-99bf1f632b8so69674866b.1
for <bug-gnu-emacs@HIDDEN>; Thu, 24 Aug 2023 23:46:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20221208; t=1692946004; x=1693550804;
h=mime-version:message-id:date:subject:to:from:from:to:cc:subject
:date:message-id:reply-to;
bh=rirShGT9zXJt3c8nhr0vdet+mxd8ohe3UYNPD381Q0o=;
b=LiwWXPJPcey9pZyWAxQC5B82yv9/AhhuZU5R1IgaOKek1ybBoBesXOImg8vOvYzMGv
TudU1lku/DdDqDSbwecGvle2AqLMVDhbGniM3tkiXaDa3GUP32yvrae3rx15qRBsuToL
vREWq/nakJ3QNcy8fCMWibDPVXXByaJ3I39rB7I+geFLmiTl47dbqVakwy98ulCGZean
aIP+1QycYX8WnUDlnxucKc52hfOfmv4TTeTXrEhJPCsTymYs41FpwIx8Lm0JOQkmbQhw
vVFfUe0XtR6Z3yMXlxo89AKvISVsIVsiIadve/dU3pqI8fxIQEryYJV7HLXTFgRtAkgv
FZIw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1692946004; x=1693550804;
h=mime-version:message-id:date:subject:to:from:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=rirShGT9zXJt3c8nhr0vdet+mxd8ohe3UYNPD381Q0o=;
b=bSILl9EphACmANN5uiFLmmIG/DFTDg7LYRwVdevx/W6o+BezxDp1GXYliXNylnP2mu
F+bs+E/yYwMZzW+3wJCuQwT64537sja6Y/0CUwna8dqsN5qw63duy3xjFSt5yr7UGKTl
4CQn+PhX6Nl+875kHZh3NvGNsSJ47FVNwn8IOEJ/qzPC6BxnUCA6Tb0F0zyB0LDeEsji
jukH58t+HnUboawV84bla/CFArHPnQORpCPmHwNLV2JGKqs4YAdUWulbOIJ4JaHvXvPO
ozIPQr3RW65ltJORoq3jiS61XKJO8M0N7EpxtPTq8y7tBsplYKdFWIs9o/MMMOS4PZdl
p0lg==
X-Gm-Message-State: AOJu0Ywiwz0hn4WCkzSz67dD7RMvOfKLm6CoaKx21n/iEksZiN2nGqdr
QJTT15Y6Myn1ud3NTmYtgvtrn+FaK4i+Zw==
X-Google-Smtp-Source: AGHT+IEKDOPi+PrvMHGXP2CEeJoP7+iEh2mPdJJJiquJHUXCLhtHkoX7xeHYLVQMNWFql6kvudu0tQ==
X-Received: by 2002:a17:906:186:b0:9a5:81cf:57c3 with SMTP id
6-20020a170906018600b009a581cf57c3mr177864ejb.38.1692946003727;
Thu, 24 Aug 2023 23:46:43 -0700 (PDT)
Received: from Mini.fritz.box (pd9e36a34.dip0.t-ipconnect.de. [217.227.106.52])
by smtp.gmail.com with ESMTPSA id
l7-20020a170906938700b009a2235ed496sm606503ejx.141.2023.08.24.23.46.43
for <bug-gnu-emacs@HIDDEN>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 24 Aug 2023 23:46:43 -0700 (PDT)
From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Date: Fri, 25 Aug 2023 08:46:42 +0200
Message-ID: <m21qfrsjot.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2a00:1450:4864:20::629;
envelope-from=gerd.moellmann@HIDDEN; helo=mail-ej1-x629.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
There are some useful eglot functions that can currently only invoked
with M-x, by default. I'm currently defining a keymap
(define-keymap :prefix 'my-eglot-bindings
"a" 'eglot-code-actions
"f" 'eglot-format
"h" 'eglot-inlay-hints-mode
"r" 'eglot-rename)
that I bind to a a prefix key in c-mode-common-hook.
Feature request: Could eglot-mode do something like that?
In GNU Emacs 30.0.50 (build 2, aarch64-apple-darwin22.6.0, NS
appkit-2299.70 Version 13.5 (Build 22G74)) of 2023-08-24 built on
Mini.fritz.box
Repository revision: 53c07bd04bf59f63e49af2c626714bf3fdd03ad6
Repository branch: scratch/pkg
Windowing system distributor 'Apple', version 10.3.2299
System Description: macOS 13.5
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Subject: bug#65519: Acknowledgement (30.0.50; [FR Eglot] keymaps for useful functions) Message-ID: <handler.65519.B.169294603814746.ack <at> debbugs.gnu.org> References: <m21qfrsjot.fsf@HIDDEN> X-Gnu-PR-Message: ack 65519 X-Gnu-PR-Package: emacs Reply-To: 65519 <at> debbugs.gnu.org Date: Fri, 25 Aug 2023 06:48:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 65519 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 65519: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D65519 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN
Subject: bug#65519: 30.0.50; [FR Eglot] keymaps for useful functions
Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 25 Aug 2023 09:35:02 +0000
Resent-Message-ID: <handler.65519.B65519.169295609210374 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 65519
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Cc: 65519 <at> debbugs.gnu.org
Received: via spool by 65519-submit <at> debbugs.gnu.org id=B65519.169295609210374
(code B ref 65519); Fri, 25 Aug 2023 09:35:02 +0000
Received: (at 65519) by debbugs.gnu.org; 25 Aug 2023 09:34:52 +0000
Received: from localhost ([127.0.0.1]:39279 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qZTDQ-0002hF-81
for submit <at> debbugs.gnu.org; Fri, 25 Aug 2023 05:34:52 -0400
Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:42412)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <joaotavora@HIDDEN>) id 1qZTDO-0002h3-ED
for 65519 <at> debbugs.gnu.org; Fri, 25 Aug 2023 05:34:51 -0400
Received: by mail-wr1-x42e.google.com with SMTP id
ffacd0b85a97d-313e742a787so476143f8f.1
for <65519 <at> debbugs.gnu.org>; Fri, 25 Aug 2023 02:34:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20221208; t=1692956079; x=1693560879;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=kutFQ6QW8XWJOIxG7UantxQdE4Vxy5b4k7Dbi+Sa2R8=;
b=CnR5wdddgHLG8SrA/liGQsIRfzuoUTSqGojVPWxu1nj7cLRvJI2R2slc1C+kY4pmWy
c9IC75PjqOXF6Ry5AdXl4Fkj2FitecGLcxrf+fd1tMKB54w1Wcu41ZdNYfOwq473It/a
52GxXb1QULLUC5vugdbLkA+3pSZxMpfQZUrKAaStsrOamjzs1dVl79d2uhPORLrf2209
Vdf6y3LBcoOq6BdB28zDI0G7+YjBfHMISwSVeEEIMfxXT0QZ4iM3GkVlsr4PLNI86f3T
132KtVt9rA+3/ZskK0PHlzZFDdjlkduPX4Kdnod1JhaoPa4/WnXdj/m0Hg595FhcGORY
SWzQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1692956079; x=1693560879;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=kutFQ6QW8XWJOIxG7UantxQdE4Vxy5b4k7Dbi+Sa2R8=;
b=PyHEt55tt0dNXv9u8umvidXkH3VsiDUgL+ouWf+cfxnbzIxD7bvPcmLCLmGvc6hXFp
VVOA6gv4AGh9A9FChZR5G1Y4EDWn/gqpe+txexVgRaD/y1ZhI3gmSadjyqhFuQVK/1Wi
BnLDy5aEnK2EUmBe5J+TeZDIOFA93t4q0T2DWRn12I0EAhP2nkTeCteWXrgKbd1/R/mp
ye0TUY36pQVeHSkMxsYvgQX5e6fwTmG6L2OppQeAzQdnl3gEIPwsMz/HVxeQv6jxSlOf
IJo5vFTzahkK1Du7vfKZVJl+u8iJn5J15IUyY5qkI8qGQTzIO+E9e1RY9geDO8adjW0X
10Gg==
X-Gm-Message-State: AOJu0Yx5Er2nzDh1q3HPym0xpdKsuveo/QP7r9TyQ0GJEE+SOWnl5y2W
G+EehRth/DDf86FCpSDktfQ/v8g8XuU/7g==
X-Google-Smtp-Source: AGHT+IF5TBsjBBLWmGaJPApsNJ+s4VLq5hwBDyV7P+LZalcriadYJp1L5Wfc9jnPRHdwih1lDN2ZAw==
X-Received: by 2002:a5d:4d06:0:b0:31c:2f95:8056 with SMTP id
z6-20020a5d4d06000000b0031c2f958056mr12925674wrt.23.1692956079393;
Fri, 25 Aug 2023 02:34:39 -0700 (PDT)
Received: from krug ([87.196.73.154]) by smtp.gmail.com with ESMTPSA id
j4-20020a5d6184000000b0030ae53550f5sm1698984wru.51.2023.08.25.02.34.38
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 25 Aug 2023 02:34:38 -0700 (PDT)
From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
In-Reply-To: <m21qfrsjot.fsf@HIDDEN> ("Gerd =?UTF-8?Q?M=C3=B6llmann?="'s message of "Fri, 25 Aug 2023 08:46:42 +0200")
References: <m21qfrsjot.fsf@HIDDEN>
Date: Fri, 25 Aug 2023 10:37:23 +0100
Message-ID: <87r0nrqx7w.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes:
> There are some useful eglot functions that can currently only invoked
> with M-x, by default. I'm currently defining a keymap
>
> (define-keymap :prefix 'my-eglot-bindings
> "a" 'eglot-code-actions
> "f" 'eglot-format
> "h" 'eglot-inlay-hints-mode
> "r" 'eglot-rename)
>
> that I bind to a a prefix key in c-mode-common-hook.
I think this is a fine way to go about it.
> Feature request: Could eglot-mode do something like that?
This request comes up often. The reason Eglot does this is partly
answered in the top bullet of eglot.el's description:
;; * Eglot's main job is to hook up the information that language
;; servers offer via LSP to Emacs's UI facilities: Xref for
;; definition-chasing, Flymake for diagnostics, Eldoc for at-point
;; documentation, etc. Eglot's job is generally *not* to provide
;; such a UI itself, though a small number of simple
;; counter-examples do exist, e.g. in the `eglot-rename' command or
;; the `eglot-inlay-hints-mode' minor mode. When a new UI is
;; evidently needed, consider adding a new package to Emacs, or
;; extending an existing one.
So this is how Eglot wants to sell itself: to be a low-profile
middle-man between Emacs and LSP. It doesn't always work and people
understandibly want Eglot to be more of a front-man.
I try to resist this temptation as much as possible because that leads
to bloat and duplicated functionality with idiosyncractic interfaces.
So I always push for other "standard" packages to provide the UI. But
as you can see in those 4 examples, I ended up being pragmatic and
putting the command in Eglot itself.
But it's not unthinkable (in fact, it's desired I think and I've looked
into it) that 'eglot-format' simply dissolves into Emacs's longstanding
'indent.el' machinery. And there's some talk of a "refactoring
interface" for Emacs in emacs-devel (I think). So that's where
'eglot-code-actions' and 'eglot-rename' should really live.
In short, I think it's OK to be pragmatic. Why not make a
eglot-bindings.el package?
Jo=C3=A3o
X-Loop: help-debbugs@HIDDEN
Subject: bug#65519: 30.0.50; [FR Eglot] keymaps for useful functions
Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 26 Aug 2023 05:21:02 +0000
Resent-Message-ID: <handler.65519.B65519.169302724631177 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 65519
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Cc: 65519 <at> debbugs.gnu.org
Received: via spool by 65519-submit <at> debbugs.gnu.org id=B65519.169302724631177
(code B ref 65519); Sat, 26 Aug 2023 05:21:02 +0000
Received: (at 65519) by debbugs.gnu.org; 26 Aug 2023 05:20:46 +0000
Received: from localhost ([127.0.0.1]:41472 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qZlj3-00086n-Tb
for submit <at> debbugs.gnu.org; Sat, 26 Aug 2023 01:20:46 -0400
Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:47299)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <gerd.moellmann@HIDDEN>) id 1qZliy-00086U-AU
for 65519 <at> debbugs.gnu.org; Sat, 26 Aug 2023 01:20:44 -0400
Received: by mail-ed1-x532.google.com with SMTP id
4fb4d7f45d1cf-52a06f5f556so2215622a12.2
for <65519 <at> debbugs.gnu.org>; Fri, 25 Aug 2023 22:20:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20221208; t=1693027228; x=1693632028;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=qcZpSSickkrHY3472TvHqVEwSzMreJDPEzOXxPpud5w=;
b=I+fSKYO/yFOkYL+JGy3uFtGnDnpA9NsRmR5QTcUhfGouFINcyCN0ma1MU3QZ0ehsoa
Q7/MfdwH8MtOrV9pgcwnaY6N9w0zqK2X13gHtPRwJClkHck+neLKitgcvTv/cEq22uaA
B+JQfmJVatBNBK+AvJAZJEXQRMz8bR/sm2s983ni5bnpHBEksfdroGx7rLxXnhahV70q
VUMqY+wcaXltC/U5QAsqKlZCqEyOanNW4Fzt18opqwdEFkwFciRAor/xegEz0jIs4sMJ
BXfg8FtvWtHz+Uh0mmowUjD47jnLMBiAv2Ga5pGviRyJQ7CAehvn3pdw92fgDdDE8i9H
6tkQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1693027228; x=1693632028;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=qcZpSSickkrHY3472TvHqVEwSzMreJDPEzOXxPpud5w=;
b=VBuyuilN4/rcucV6T60geOcxcsfJ4Y9cTs/j+p3Spz0RzlqoO2kFckm4DE5UTYkGGy
i/2tfuX8SNpUuMFpZc8O9ZUx3kK6+JvqlDw+GaJawLGrNGk03ZOyZlIIilZ91kk2citk
ldrdfxeisKDwXOm+3cfZClWe1mnw6nDJPXPIdWf43PQWOuLubQNxwxVZkHGyHr/Q71Q6
XBoY8ex/Nvu+ie7yfESSJ71lIdHVEIu0mIqYS1ap6QhVLguEd4n2DWIbZEj/7F7gftYf
YU//xMKFs0BIKxdzjm7lL5UDzjYrdSNlY46ULgEZGGABWBIrNeF+H4Bu6rB3O7YroQG+
GJHQ==
X-Gm-Message-State: AOJu0YytALRfcLmsTr0tyQaVoP1mnV0coyXw7mva01G0kxIskZbPlFBo
rKTzZV64A8SeZg9cKRCGHIn2GwfCobs=
X-Google-Smtp-Source: AGHT+IGCAj0lAJ205rOopXXkAjQp7s3weWxTLaN9Rx40wCYO0i/TPMQgyyXMpyjggQd3rS360MOX2w==
X-Received: by 2002:a17:906:209e:b0:99d:dd43:d427 with SMTP id
30-20020a170906209e00b0099ddd43d427mr17149455ejq.10.1693027228123;
Fri, 25 Aug 2023 22:20:28 -0700 (PDT)
Received: from Mini.fritz.box (pd9e36ea3.dip0.t-ipconnect.de.
[217.227.110.163]) by smtp.gmail.com with ESMTPSA id
x18-20020a170906805200b0097073f1ed84sm1695176ejw.4.2023.08.25.22.20.27
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 25 Aug 2023 22:20:27 -0700 (PDT)
From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
In-Reply-To: <87r0nrqx7w.fsf@HIDDEN> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Fri, 25 Aug 2023 10:37:23 +0100")
References: <m21qfrsjot.fsf@HIDDEN> <87r0nrqx7w.fsf@HIDDEN>
Date: Sat, 26 Aug 2023 07:20:26 +0200
Message-ID: <m2v8d2e5wl.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> writes:
> Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes:
>
>> There are some useful eglot functions that can currently only invoked
>> with M-x, by default. I'm currently defining a keymap
>>
>> (define-keymap :prefix 'my-eglot-bindings
>> "a" 'eglot-code-actions
>> "f" 'eglot-format
>> "h" 'eglot-inlay-hints-mode
>> "r" 'eglot-rename)
>>
>> that I bind to a a prefix key in c-mode-common-hook.
>
> I think this is a fine way to go about it.
>
>> Feature request: Could eglot-mode do something like that?
>
> This request comes up often. The reason Eglot does this is partly
> answered in the top bullet of eglot.el's description:
>
> ;; * Eglot's main job is to hook up the information that language
> ;; servers offer via LSP to Emacs's UI facilities: Xref for
> ;; definition-chasing, Flymake for diagnostics, Eldoc for at-point
> ;; documentation, etc. Eglot's job is generally *not* to provide
> ;; such a UI itself, though a small number of simple
> ;; counter-examples do exist, e.g. in the `eglot-rename' command or
> ;; the `eglot-inlay-hints-mode' minor mode. When a new UI is
> ;; evidently needed, consider adding a new package to Emacs, or
> ;; extending an existing one.
>
> So this is how Eglot wants to sell itself: to be a low-profile
> middle-man between Emacs and LSP. It doesn't always work and people
> understandibly want Eglot to be more of a front-man.
>
> I try to resist this temptation as much as possible because that leads
> to bloat and duplicated functionality with idiosyncractic interfaces.
Ok.
> So I always push for other "standard" packages to provide the UI. But
> as you can see in those 4 examples, I ended up being pragmatic and
> putting the command in Eglot itself.
>
> But it's not unthinkable (in fact, it's desired I think and I've looked
> into it) that 'eglot-format' simply dissolves into Emacs's longstanding
> 'indent.el' machinery. And there's some talk of a "refactoring
> interface" for Emacs in emacs-devel (I think). So that's where
> 'eglot-code-actions' and 'eglot-rename' should really live.
>
> In short, I think it's OK to be pragmatic. Why not make a
> eglot-bindings.el package?
You mean making an ELPA package? Sorry, that's too much effort for me.
Maybe someone else will do it.
Received: (at control) by debbugs.gnu.org; 2 Sep 2023 16:14:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 02 12:14:13 2023 Received: from localhost ([127.0.0.1]:38296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qcTGH-0003zH-82 for submit <at> debbugs.gnu.org; Sat, 02 Sep 2023 12:14:13 -0400 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]:62484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1qcTGE-0003z3-9M for control <at> debbugs.gnu.org; Sat, 02 Sep 2023 12:14:11 -0400 Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-500bdef7167so1173508e87.0 for <control <at> debbugs.gnu.org>; Sat, 02 Sep 2023 09:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693671234; x=1694276034; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=Z1IayO7v4+znO9wUkGeYVvTHeIR5OdRMudcetIsQXko=; b=VUA9LQ0awpbKRR/lrDlESMI6fwQ0J/LN23pTzXuwr/DTVw/ic/NpvpWfX1Eyt8oJoD kvpQ5E7rr+VDcks37/updw2Al7n0LIko8WIbd1cEcpZik5A/xda2BpL8BTX0kF4L+jxF JqiD/j/2+4As4Wj9d0MTXa46djG9I//brpI6T4AeSHnHTG9K0VgKKU9e6c7rRZBH7Js9 x1+JaSY5Q3QSkGunm703epzEXIym3kYoYDWlF7XNXbdrE+oVMDjeU2wdpMesx8YZDobX PVYB/p66vJRRjmuPiWZ8caMf4C/vBKBSrKhrwEVsWJiA4AWXtPIfXyNADRF8Q9D/FRIl hqEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693671234; x=1694276034; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Z1IayO7v4+znO9wUkGeYVvTHeIR5OdRMudcetIsQXko=; b=kxv4UUixALg9b98U7LBQ7taYXfD2JZpOURfXP8RhbvhB6P9FbB+XsPyyRHag57Pl7I XrVzFzKWr54q8SZ9kN2Y4rJpAawXeEEPgYdGatHwLiaOPgmQj0tFL2IH2x3rZ0MyHlR8 FNCvBDZaojzBaG4dBV+0CnlF9fjxUovF0qCyoLzm6ORfjHl0jIZK2ysAuPykdAdKR07A ySRDfAviBcoFormONMf7yGcllvzZC1/Vm00VIoDevgKVnQJzLexM0lP6EoQEB2Jd6Lhi 8DFdAyuwD0bhUrcLT5iHaTLxdUSL9+IaUlDRWRSsevxECW4NCuKhxgZAagsn2KPPOiF0 tMHg== X-Gm-Message-State: AOJu0YxOpB7++rLbycHBu+y3KNIL8ReBO94oh0eUT2TDATGRvDE6fuF0 gfaS+LQbHjNlfjZfbMzRdif9OW5QO1svSmlor7li7C/2zlw= X-Google-Smtp-Source: AGHT+IHC18N/fE/a/nnYAB4kOu8baLd2orj0Ul8EDKlpzsFeHb6YpkFcPnysJviaK/Lmvtg+mN8uUN7b2GT+letcCjs= X-Received: by 2002:a05:6512:2520:b0:500:d96e:f6eb with SMTP id be32-20020a056512252000b00500d96ef6ebmr1616385lfb.19.1693671234221; Sat, 02 Sep 2023 09:13:54 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 2 Sep 2023 09:13:53 -0700 From: Stefan Kangas <stefankangas@HIDDEN> MIME-Version: 1.0 Date: Sat, 2 Sep 2023 09:13:53 -0700 Message-ID: <CADwFkmkU1ROjm6EEw78FmNTU7Yk4MbcLZPEdbfPANrBnNCGDMw@HIDDEN> Subject: control message for bug #65519 To: control <at> debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) severity 65519 wishlist quit
Received: (at control) by debbugs.gnu.org; 11 Nov 2025 06:19:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 11 01:19:03 2025 Received: from localhost ([127.0.0.1]:42805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vIhiZ-0000yy-5l for submit <at> debbugs.gnu.org; Tue, 11 Nov 2025 01:19:03 -0500 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]:52571) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1vIhiX-0000yN-OV for control <at> debbugs.gnu.org; Tue, 11 Nov 2025 01:19:02 -0500 Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-b472842981fso493964166b.1 for <control <at> debbugs.gnu.org>; Mon, 10 Nov 2025 22:19:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762841935; x=1763446735; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:subject:from:to:message-id :date:from:to:cc:subject:date:message-id:reply-to; bh=Ox15Rwk8FtJU6sZxT7wCU3Kp4N7HZx9TBtqayCTjVoA=; b=ZziTinslrYYKAWokkN//6MvcDItG4nb9UB8uyLxt3X7SK2wlekNUhw7YEsVkufPk3R CRC+MptYflzHyY4ixk/ben1jUjhsKv6Pg2b4AsvyG+tmFTyatzVqBBoqQmn6V+wkAVEZ /O41N4FsAUK1k31kxFWL+EXYIlM94fMsug0GNHSIf1GbhOIIVXFvJM0VDW+uaMlJUOJ5 WZuOK96Xu7Z2NHumKufIXNsBQBx7s/1c4uojz8eCZOYtvuv2NUCztwZhOg7r7YW5nFXw 60NW0Bc4On11/epxSU05+/EP59uJSik5FRE5ILRm25rJjf0Qcra9PmRbApuTHISdmJVG sghQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762841935; x=1763446735; h=content-transfer-encoding:mime-version:subject:from:to:message-id :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ox15Rwk8FtJU6sZxT7wCU3Kp4N7HZx9TBtqayCTjVoA=; b=FxfU2lT7LV9qBuE2c0gIGnzfixkQ5WhltQn/Ye0mIqnqNvDLl/ahr1HcP5oGnyecm2 SrlnydXSg40NV2YSYZHP3+0msbVt1l6vGOYaH4UXmFuxrLUVtw6m7bgMlsjnfnfQu95t LEB2Ta5SzSktruoRYei3lZyIYKbZPx970D5rZC5AOYQSjMXNC1j0iH/hJDbMcQoz7EXy aresMKrNJafwY1pQnE0v30roq9POuFPbEJqBwlYvAdVu58BVGhwol0IZoVg0tkw1h2+d K54bhzq2dWkeTm8QGvHlBobFnk2D2cdPFE7QihrOgkm6kavAIlxzZ5XDM7fUGhmdxHlZ iIoA== X-Gm-Message-State: AOJu0YxFg3oSY+TQMyEi59qZ7PMX13gP4UN4tw5DnepvO0cI98mYDboZ 5pywB1SobvSDsYKDilCuWMJdCXdLO9OwIfWJRWxB1pefRJ6RBfwV8jj+24w6RlKn X-Gm-Gg: ASbGnctKvMoD/lveW5wegP7ZlSNVr7Hu+3IF0nbrXX1op5ZBBpVccFoeBR2QPHcobRZ M0xTk7aBbNzCK8DwaCHVQOW3J8JlUr8QgyHvk3p/Yu5j6ik8dItw2WGMW/fzdTyIxWL8bHoHdEJ 8qRq1wlv8PZO8nOap2dOskW9ulnnJJ1KLi51spiP1LLqKcg+XU2aJtxLFE5XgLS/XPVP7fA34qb tK728rupfDSSkk1TOUx+bUVH1o6JJxhRh87UIUJPyXggRcYYjOwMw4eAUe9Wfby3dQrrSfdYEHd IVFGbOQYS3S68v117mnKapdMGhio0MS8cMTnsO3J+Bc+ipGDcf/BjtRs1wgUwm7JM6lXxdJfFgU wSpz05ao2UWhuOXmarY1BT6TUF0CwJSTKRHc+u+5RQznVvzPNwplHnGUeuU/qHvHwBeEgsurIRE EVNgfYjUJtTLQdKjgRdmYp6peXtBqSpBb/hJypT8MzZBOD5e1p2A6TLoBoXvESqfcgnHSzCsWSM ehjrUt5Ydn3 X-Google-Smtp-Source: AGHT+IEpEKZJHBgCKO8FEDknbl0bxSqXRvqACqYAihHe/YbhGTp7Rh68136qkVP6YeH/9Qh74fEpDg== X-Received: by 2002:a17:906:d54b:b0:b6d:6d66:e8e9 with SMTP id a640c23a62f3a-b72e05da787mr1089542866b.61.1762841935249; Mon, 10 Nov 2025 22:18:55 -0800 (PST) Received: from pro4 (p200300e0b72b5600f983bb9036eda1ce.dip0.t-ipconnect.de. [2003:e0:b72b:5600:f983:bb90:36ed:a1ce]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b72bfa24d1fsm1254981466b.73.2025.11.10.22.18.54 for <control <at> debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Nov 2025 22:18:54 -0800 (PST) Date: Tue, 11 Nov 2025 07:18:54 +0100 Message-Id: <m2ecq5f5wx.fsf@HIDDEN> To: control <at> debbugs.gnu.org From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Subject: control message for bug #65519 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) close 65519 31.1 quit
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.