X-Loop: help-debbugs@HIDDEN Subject: bug#68804: [PATCH] Remove an unneeded sed command for emacs.service Resent-From: Lin Jian <me@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Mon, 29 Jan 2024 22:22:02 +0000 Resent-Message-ID: <handler.68804.B.170656689629068 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 68804 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 68804 <at> debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.170656689629068 (code B ref -1); Mon, 29 Jan 2024 22:22:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 Jan 2024 22:21:36 +0000 Received: from localhost ([127.0.0.1]:33644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rUa0V-0007Yl-V8 for submit <at> debbugs.gnu.org; Mon, 29 Jan 2024 17:21:36 -0500 Received: from lists.gnu.org ([2001:470:142::17]:57062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <me@HIDDEN>) id 1rUa0V-0007Ya-0w for submit <at> debbugs.gnu.org; Mon, 29 Jan 2024 17:21:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1rUa0A-00020T-DG for bug-gnu-emacs@HIDDEN; Mon, 29 Jan 2024 17:21:15 -0500 Received: from mail.linj.tech ([5.255.109.209]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1rUa08-0001IB-LB for bug-gnu-emacs@HIDDEN; Mon, 29 Jan 2024 17:21:14 -0500 From: Lin Jian <me@HIDDEN> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linj.tech; s=mail; t=1706566868; bh=lqx/4yLDlqCPozStgKVra984Kic38K+PXMjiTPEqIYk=; h=From:To:Subject:Date; b=w6yKilKjk02b6s0zHv/CT6mMcyUf7hq6h7TjcdcCugHahLTwMFjUrL2I3qNfxGGJE 5xSC/t2WaMPOxuRlz58Mi8/48Bp1dbJNk5KgWSb0dX5VjB7PS7sF3tWcRlUnu0J2mY weOAqJ982CO5R27QTrXaeMBXOMtqbyiUINMEf7epvUw0MR3Fh8ehKohUULSME76+AQ 64ODKoPgybwKABC/NHeNdbqale6ngj1sH9zbbZ9lrAfzE01qXIrftJFdtbj8bja/FR HJcAucWKC7tftz2z6Oo9S7WmPXGIMJBoFSRqRvHG48T9v7s7gQnWWUN7LYdELKce/q ALtjoitvIEeCg== Date: Tue, 30 Jan 2024 06:19:09 +0800 Message-ID: <87cytjye5u.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=5.255.109.209; envelope-from=me@HIDDEN; helo=mail.linj.tech X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Tags: patch After commit e5348f125ff03ac70713e5b227f9e51f759a587b on 2020-12-14, there is no ExecStop in etc/emacs.service. So there is no need to use sed to substitute emacsclient for the ExecStop key. I propose a patch to remove this unneeded sed command. In GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.18.0, Xaw3d scroll bars) Windowing system distributor 'The X.Org Foundation', version 11.0.12101010 System Description: NixOS 24.05 (Uakari) Configured using: 'configure --prefix=/nix/store/mzdvpxzkhlryxmbxwbih7bgvkzkw1ly7-emacs-29.1 --disable-build-details --with-modules --with-x-toolkit=lucid --with-xft --with-cairo --with-compress-install --with-toolkit-scroll-bars --with-native-compilation --without-imagemagick --without-small-ja-dic --with-tree-sitter --with-xinput2 --without-xwidgets' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Remove-an-unneeded-sed-command-for-emacs.service.patch From 665c80556750d15ad6ce988078a38c0964bacbf6 Mon Sep 17 00:00:00 2001 From: Lin Jian <me@HIDDEN> Date: Tue, 30 Jan 2024 06:12:43 +0800 Subject: [PATCH] Remove an unneeded sed command for emacs.service After commit e5348f125ff03ac70713e5b227f9e51f759a587b on 2020-12-14, there is no ExecStop in etc/emacs.service. * Makefile.in (install-etc): Remove an unneeded sed command for etc/emacs.service. Copyright-paperwork-exempt: yes --- Makefile.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/Makefile.in b/Makefile.in index 996f7b8d8c7..57df948a397 100644 --- a/Makefile.in +++ b/Makefile.in @@ -873,11 +873,9 @@ install-etc: rm -f $${tmp} umask 022; $(MKDIR_P) "$(DESTDIR)$(systemdunitdir)" tmp=etc/emacs.tmpservice; rm -f $${tmp}; \ - client_name=`echo emacsclient | sed '$(TRANSFORM)'`${EXEEXT}; \ sed -e '/^##/d' \ -e "/^Documentation/ s/emacs(1)/${EMACS_NAME}(1)/" \ -e "/^ExecStart/ s|emacs|${bindir}/${EMACS}|" \ - -e "/^ExecStop/ s|emacsclient|${bindir}/$${client_name}|" \ ${srcdir}/etc/emacs.service > $${tmp}; \ $(INSTALL_DATA) $${tmp} "$(DESTDIR)$(systemdunitdir)/${EMACS_NAME}.service"; \ rm -f $${tmp} -- 2.42.0 --=-=-=--
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Lin Jian <me@HIDDEN> Subject: bug#68804: Acknowledgement ([PATCH] Remove an unneeded sed command for emacs.service) Message-ID: <handler.68804.B.170656689629068.ack <at> debbugs.gnu.org> References: <87cytjye5u.fsf@HIDDEN> X-Gnu-PR-Message: ack 68804 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 68804 <at> debbugs.gnu.org Date: Mon, 29 Jan 2024 22:22:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 68804 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 68804: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D68804 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
Received: (at control) by debbugs.gnu.org; 30 Jan 2024 00:42:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 29 19:42:20 2024 Received: from localhost ([127.0.0.1]:33957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rUcCi-0005rR-2J for submit <at> debbugs.gnu.org; Mon, 29 Jan 2024 19:42:20 -0500 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:50328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1rUcCf-0005qz-Kg for control <at> debbugs.gnu.org; Mon, 29 Jan 2024 19:42:18 -0500 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-55ee686b5d5so2474407a12.0 for <control <at> debbugs.gnu.org>; Mon, 29 Jan 2024 16:42:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706575323; x=1707180123; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=uvrTPj3TgMdp+e9gspW/aEqjKwTA+7KluRz8V2dmifg=; b=CDgNf7nZnuD7JyDVDa653EodTTRmf6OnFZaCa4DId1lLtCQfWkiigkhbz5uP5vG8ja iOcWwFvAPhlIqI+32/Atg9AElXQEv2R4s3pp4jiq2IVPQnChUElvG8ADsEHVy1CDLoiO 6GRwAVV7QcP+sIqkpGRaWRax+ybxw9Ujhtg1SCNXSbRrB/hvC+DZMo+MGTtLU7XnTn22 exbRTP1vqV0SvOy7kVyDueHlv4kcHf1uuJpVE+bT54Kfxt7d3OKutz3PFzrRZWzrY6A6 n0SYZl7UQK03uywTN6+1PH3CRSIfoUCi2r2knv7CyHd467ZgS6+xOx+10iEZ711JdwSf MiCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706575323; x=1707180123; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uvrTPj3TgMdp+e9gspW/aEqjKwTA+7KluRz8V2dmifg=; b=Q1qJbhgthNppJbhJdVl2G4sqMk3gt/0DmjkLkIyBVnFWKCpfyER5V9/OvrXa1WnFFz 1wfqepdzTSkMptqM8vzPA8vV4t0PQhsElCgSf3Mha9nolhJJUBUzONm/fJQg2V3//J2s 94+6Nfgstl81XHjawgBC5OUQJmFddy824OlMOpB46qxLuEzy8Gh9alnCg9RnvRORqeO+ KXte0XVXT9KNUa8WdUBWyNIb28BgUyxxaSjix5wqXpu2IzSKwYPRxy67kNYMwHmktkRd dyP+hDssBMSHOjwdfaiFuRIgqpQfRjeSsMI0J1U2Iaf12B0sAHU8AdEj1JxSI7DRAFF8 Q1yQ== X-Gm-Message-State: AOJu0YzlNJR6ubShc2ltG4drUp3iJSsJYljYKVrmQ5n91mY463Xb4PYi /eA7bzmObTTkVU8wXHk0R/VeTCw197AXAjWd1MNDxdcPm+GnwRSK2hrzyPGYPZmaJTcPP/Sik4d rP+74Au7zwJPQOzYh/X31IbvZ0ZK6n+6Sgf0= X-Google-Smtp-Source: AGHT+IHzhl4sipfRiEq+vMDCf2FgzkB4rTCVY1N4UaIrM0Y/xmOmnn+Ul31djM16v2YW2I13GvySWy2E8aPFmBOIvPA= X-Received: by 2002:aa7:cc97:0:b0:55d:2b55:f1e2 with SMTP id p23-20020aa7cc97000000b0055d2b55f1e2mr4912403edt.37.1706575323328; Mon, 29 Jan 2024 16:42:03 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 29 Jan 2024 19:42:03 -0500 From: Stefan Kangas <stefankangas@HIDDEN> MIME-Version: 1.0 Date: Mon, 29 Jan 2024 19:42:03 -0500 Message-ID: <CADwFkmk10sWvy4RnQB6qQWkwEPXXhZONWoC1pLWeDNf0A5XSyw@HIDDEN> Subject: control message for bug #68804 To: control <at> debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) severity 68804 wishlist quit
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.