GNU logs - #68810, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#68810: 29.1; Recommending setting transfer.fsckObjects of git to true is not necessary
Resent-From: Lin Jian <me@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 29 Jan 2024 23:30:02 +0000
Resent-Message-ID: <handler.68810.B.17065709664286 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 68810 <at> debbugs.gnu.org
From: Lin Jian <me@HIDDEN>
Date: Tue, 30 Jan 2024 07:16:45 +0800
Message-ID: <87a5onlnwk.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=5.255.109.209; envelope-from=me@HIDDEN;
 helo=mail.linj.tech
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)


Recommendation about setting transfer.fsckObjects of git to true can be
found in admin/notes/git-workflow and CONTRIBUTE.  In addition, it is
set in autogen.sh.

This is triggered by a discussion[1] on emacs-devel.  The first commit
about this is cedd7cad092809a97c1ed7fb883b68fa844cea58 on 2016-01-31.
However, on 2016-02-04, another discussion[2] shows that git is secure
by default so setting this option is not necessary.

What about removing this unnecessary recommendation?

By the way, the same recommendation can be found on Emacswiki[3][4].

[1]: https://lists.gnu.org/r/emacs-devel/2016-01/msg01802.html
[2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813157#29
[3]: https://www.emacswiki.org/emacs/GitQuickStartForEmacsDevs
[4]: https://www.emacswiki.org/emacs/GitForEmacsDevs

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Lin Jian <me@HIDDEN>
Subject: bug#68810: Acknowledgement (29.1; Recommending setting
 transfer.fsckObjects of git to true is not necessary)
Message-ID: <handler.68810.B.17065709664286.ack <at> debbugs.gnu.org>
References: <87a5onlnwk.fsf@HIDDEN>
X-Gnu-PR-Message: ack 68810
X-Gnu-PR-Package: emacs
Reply-To: 68810 <at> debbugs.gnu.org
Date: Mon, 29 Jan 2024 23:30:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 68810 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
68810: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D68810
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#68810: 29.1; Recommending setting transfer.fsckObjects of git to true is not necessary
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 30 Jan 2024 00:41:02 +0000
Resent-Message-ID: <handler.68810.B68810.170657521422249 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Lin Jian <me@HIDDEN>, 68810 <at> debbugs.gnu.org
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <87a5onlnwk.fsf@HIDDEN>
References: <87a5onlnwk.fsf@HIDDEN>
MIME-Version: 1.0
Date: Mon, 29 Jan 2024 19:39:54 -0500
Message-ID: <CADwFkmmueusuTJQAQHxA-JT02zAw=o-R4OY5nU55r-H7oHrm_Q@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Lin Jian via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs@HIDDEN> writes:

> Recommendation about setting transfer.fsckObjects of git to true can be
> found in admin/notes/git-workflow and CONTRIBUTE.  In addition, it is
> set in autogen.sh.
>
> This is triggered by a discussion[1] on emacs-devel.  The first commit
> about this is cedd7cad092809a97c1ed7fb883b68fa844cea58 on 2016-01-31.
> However, on 2016-02-04, another discussion[2] shows that git is secure
> by default so setting this option is not necessary.
>
> What about removing this unnecessary recommendation?
>
> By the way, the same recommendation can be found on Emacswiki[3][4].
>
> [1]: https://lists.gnu.org/r/emacs-devel/2016-01/msg01802.html
> [2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813157#29
> [3]: https://www.emacswiki.org/emacs/GitQuickStartForEmacsDevs
> [4]: https://www.emacswiki.org/emacs/GitForEmacsDevs

Are you sure?  The git documentation says:

    transfer.fsckObjects

    When fetch.fsckObjects or receive.fsckObjects are not set, the value
    of this variable is used instead. Defaults to false.

    When set, the fetch or receive will abort in the case of a malformed
    object or a link to a nonexistent object. In addition, various other
    issues are checked for, including legacy issues (see fsck.<msg-id>),
    and potential security issues like the existence of a .GIT directory
    or a malicious .gitmodules file (see the release notes for v2.2.1
    and v2.17.1 for details). Other sanity and security checks may be
    added in future releases.

https://git-scm.com/docs/git-config#Documentation/git-config.txt-transferfsckObjects

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 30 Jan 2024 00:41:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 29 19:41:37 2024
Received: from localhost ([127.0.0.1]:33948 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rUcC1-0005pV-DY
	for submit <at> debbugs.gnu.org; Mon, 29 Jan 2024 19:41:37 -0500
Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]:58654)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1rUcC0-0005pF-4N
 for control <at> debbugs.gnu.org; Mon, 29 Jan 2024 19:41:36 -0500
Received: by mail-ed1-x52c.google.com with SMTP id
 4fb4d7f45d1cf-55a8fd60af0so3443269a12.1
 for <control <at> debbugs.gnu.org>; Mon, 29 Jan 2024 16:41:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1706575281; x=1707180081; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=nHkKUlHhuPGsMd4BVALjRU1cbahxVUiToM2rTo1C6MY=;
 b=hpeVvcqmy1jaI6t95yhdx3Em3FEXcf4fFAFq+KEPVEetBKk+8/f3UJv3Udl35nmVan
 hzGU83eR4tJVYOfcFIl6+Lf5sGUdR2FRQrgW8aIogWG+abVzUgg85sX0QOzzZ0Rke9Bz
 PwB1EYKyiJ2X1vv0IkfI85iPXzkl9YHM2qz3gMknR9EVmy96HuZ9vS9nVvaZgyeyfv7e
 yndOjRlY/wpgKw0MJmMB696IuOD96XSaYd50j3g5FyzZI42i/7qaZLobeQdmYmlaNGLx
 FlDlZyRXPSk2BhsMd3UOYSPiza0ZGey6w8OUOMNOtDF9eJ+KgsVrHjaNb+6r6vFJi0UZ
 bJKA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1706575281; x=1707180081;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=nHkKUlHhuPGsMd4BVALjRU1cbahxVUiToM2rTo1C6MY=;
 b=RSVHHgGeI+510wfoyuDMh6ZViKhPaZEKSowfnKJpz0Mgw9cyGIcdlE+HfSL35E6mrI
 /eteZwi+fJ/7qdM3Z/0vzC5ErG24j6ennYuy7l9AlTUb9YJuwfsKYU8lyh49f+ChbteG
 EXTOEiOtEq40ok8C8jnWYSMkZvFhBVVn58M9gFvHr1NIlBTmlpPnH9xMHrTcahwW4vf2
 UgqepWEBTOtVffQ7Dw4jghyyoM4mT/oE1dwwX4ORCAPZIMVd0N9mVD6xtA8rMU9OzPAU
 4TgzP7xinzcza9pLGNAK9eAlkSL/8n+ikT79IzUSe8lTAtXq1SzSNdLsYEZQ2/ZPivQ/
 +GKQ==
X-Gm-Message-State: AOJu0Yxzl5teuzAkRPRQciQnxXjh24tC1DWIN9PI+eHq1o1yoSxINuXv
 eKgfpSX2ANFWEhUFpURxYViZcfvDhXKoWsPtWbVbzjJsCKCSFiEy+Z8NlC+ip0XWmVqLLr29W0P
 rCChO2t0cAetP41NFD03AO9+RIaber2vERZA=
X-Google-Smtp-Source: AGHT+IHDkBaFKaVthgRPNAifdbePBF/PQlPCLL4MZsw+9P48gHN48hbuC9Ew+a0u52KzTsxX52Cd2gjQgIS6IE3tC4s=
X-Received: by 2002:a05:6402:2078:b0:55e:bbf5:d37d with SMTP id
 bd24-20020a056402207800b0055ebbf5d37dmr4586071edb.14.1706575281379; Mon, 29
 Jan 2024 16:41:21 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Mon, 29 Jan 2024 19:41:21 -0500
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Mon, 29 Jan 2024 19:41:21 -0500
Message-ID: <CADwFkmk6XLt0fCTXzfRYps8cdUcJMiu-D2cy397CNeAbWW0g_g@HIDDEN>
Subject: control message for bug #68810
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

severity 68810 wishlist
quit

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#68810: 29.1; Recommending setting transfer.fsckObjects of git to true is not necessary
Resent-From: Lin Jian <me@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 30 Jan 2024 12:15:01 +0000
Resent-Message-ID: <handler.68810.B68810.170661689128907 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 68810
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Kangas <stefankangas@HIDDEN>
Cc: 68810 <at> debbugs.gnu.org
Received: via spool by 68810-submit <at> debbugs.gnu.org id=B68810.170661689128907
          (code B ref 68810); Tue, 30 Jan 2024 12:15:01 +0000
Received: (at 68810) by debbugs.gnu.org; 30 Jan 2024 12:14:51 +0000
Received: from localhost ([127.0.0.1]:34507 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rUn0t-0007WB-4K
	for submit <at> debbugs.gnu.org; Tue, 30 Jan 2024 07:14:51 -0500
Received: from mail.linj.tech ([5.255.109.209]:58926)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1rUn0r-0007W2-3R
 for 68810 <at> debbugs.gnu.org; Tue, 30 Jan 2024 07:14:49 -0500
References: <87a5onlnwk.fsf@HIDDEN>
 <CADwFkmmueusuTJQAQHxA-JT02zAw=o-R4OY5nU55r-H7oHrm_Q@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linj.tech; s=mail;
 t=1706616878; bh=DnkvkSjTT8GpY6KvpTHVARWqfsKx8MDZ52zTx5HWS6Q=;
 h=References:From:To:Cc:Subject:Date:In-reply-to;
 b=rpsijOAuh4Mrn3DBm37ReW0VUVpNUP+9QFqT7dCABpn5yzCaV7lSXULiwgyPLYk0Z
 ixdG7lK7K1kZbQwtvK6Ky42FwRLb6E95fOQNwhNRlx9kaFTAjYaCGDW/+p4XZpWpNL
 +tuo+Uzsl5cCu1hG0Fym1RPgm5S4mbd2yafFrtDIkf62EckHXROcxAMfLXUtaGqNxK
 +QRd5JOMEt1l62ALWFYEGIFgFUvcE26MLjOlo5WvwPHFF98CSfSEkj+voLmemgwdeK
 covPTyZi+7QxJHwfT2mxDmWtDOGPsxTOTU7UQgQVZ9zvH++3ufcLPnFilqh/gtvU+c
 mPRrHP4s6CDcw==
From: Lin Jian <me@HIDDEN>
Date: Tue, 30 Jan 2024 19:57:16 +0800
In-reply-to: <CADwFkmmueusuTJQAQHxA-JT02zAw=o-R4OY5nU55r-H7oHrm_Q@HIDDEN>
Message-ID: <875xzbkogr.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


Stefan Kangas <stefankangas@HIDDEN> writes:

> Are you sure?

I am no expert of git.  So I am not sure.

That being said, have you read those links in my report?  My point is
that the motivation of setting transfer.fsckObjects in [1], i.e.,
security, is made invalid in [2] because git is secure by default.
However, related commits are made before (and after) [2].

[1]: https://lists.gnu.org/r/emacs-devel/2016-01/msg01802.html
[2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813157#29

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#68810: 29.1; Recommending setting transfer.fsckObjects of git to true is not necessary
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 30 Jan 2024 12:28:01 +0000
Resent-Message-ID: <handler.68810.B68810.170661767230445 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 68810
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Kangas <stefankangas@HIDDEN>
Cc: me@HIDDEN, 68810 <at> debbugs.gnu.org
Received: via spool by 68810-submit <at> debbugs.gnu.org id=B68810.170661767230445
          (code B ref 68810); Tue, 30 Jan 2024 12:28:01 +0000
Received: (at 68810) by debbugs.gnu.org; 30 Jan 2024 12:27:52 +0000
Received: from localhost ([127.0.0.1]:34530 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rUnDT-0007uy-Dx
	for submit <at> debbugs.gnu.org; Tue, 30 Jan 2024 07:27:51 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:55908)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rUnDQ-0007uj-RH
 for 68810 <at> debbugs.gnu.org; Tue, 30 Jan 2024 07:27:49 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rUnDC-0008Sf-8R; Tue, 30 Jan 2024 07:27:34 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=fh3jf72NKxkSrp7bo2/e0Q8Es17dHugHwB2XgcnWtKo=; b=IXz4aODybRBv
 YeJlbb+aPtqn6lmRyDsKSFhvEbu1s7xOLG3IgS3tUj4SRAuLyHK3GQrKNd60wA6LU8DxsjDnARsdF
 /jVKkxjOIEY2YpogsAE3NshRXMH1LlEl1+zzSna6WZSAMC1De5PZIM0M2PiyPd5H7UAbZ91eEovUe
 9sij9Csq+uLMqMzwSxUHXayQKrpIeC5INhOQVSL2KW8wzFIXS7C5LFMbln2wdD6Pu4/R4Lb/zog1T
 IHEPp3oGkpZ1fpoCgU59x4pBYbsb0YLlvJ4tJsdu0b4MOnuUN1E4URCsB+m1teajgy3Vb/TXulTWX
 lEaf2C2ZiSDfwGmEvrEQhw==;
Date: Tue, 30 Jan 2024 14:27:07 +0200
Message-Id: <86mssn2ehw.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CADwFkmmueusuTJQAQHxA-JT02zAw=o-R4OY5nU55r-H7oHrm_Q@HIDDEN>
 (message from Stefan Kangas on Mon, 29 Jan 2024 19:39:54 -0500)
References: <87a5onlnwk.fsf@HIDDEN>
 <CADwFkmmueusuTJQAQHxA-JT02zAw=o-R4OY5nU55r-H7oHrm_Q@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Kangas <stefankangas@HIDDEN>
> Date: Mon, 29 Jan 2024 19:39:54 -0500
> 
> Lin Jian via "Bug reports for GNU Emacs, the Swiss army knife of text
> editors" <bug-gnu-emacs@HIDDEN> writes:
> 
> > Recommendation about setting transfer.fsckObjects of git to true can be
> > found in admin/notes/git-workflow and CONTRIBUTE.  In addition, it is
> > set in autogen.sh.
> >
> > This is triggered by a discussion[1] on emacs-devel.  The first commit
> > about this is cedd7cad092809a97c1ed7fb883b68fa844cea58 on 2016-01-31.
> > However, on 2016-02-04, another discussion[2] shows that git is secure
> > by default so setting this option is not necessary.
> >
> > What about removing this unnecessary recommendation?
> >
> > By the way, the same recommendation can be found on Emacswiki[3][4].
> >
> > [1]: https://lists.gnu.org/r/emacs-devel/2016-01/msg01802.html
> > [2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813157#29
> > [3]: https://www.emacswiki.org/emacs/GitQuickStartForEmacsDevs
> > [4]: https://www.emacswiki.org/emacs/GitForEmacsDevs
> 
> Are you sure?  The git documentation says:
> 
>     transfer.fsckObjects
> 
>     When fetch.fsckObjects or receive.fsckObjects are not set, the value
>     of this variable is used instead. Defaults to false.
> 
>     When set, the fetch or receive will abort in the case of a malformed
>     object or a link to a nonexistent object. In addition, various other
>     issues are checked for, including legacy issues (see fsck.<msg-id>),
>     and potential security issues like the existence of a .GIT directory
>     or a malicious .gitmodules file (see the release notes for v2.2.1
>     and v2.17.1 for details). Other sanity and security checks may be
>     added in future releases.
> 
> https://git-scm.com/docs/git-config#Documentation/git-config.txt-transferfsckObjects

And I have another question: does this setting cause any harm, or can
cause any harm in some situations?  IOW, what are the downsides of
using this setting?

Last modified: Tue, 30 Jan 2024 12:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.