GNU bug report logs - #69466
Wrong colours for QA

Previous Next

To reply to this bug, email your comments to 69466 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: bug-guix <at> gnu.org
Subject: Wrong colours for QA
Date: Thu, 29 Feb 2024 11:49:40 +0100

Hello,

it looks like the dark green colour is wrongly chosen in QA,
for instance here:
   https://qa.guix.gnu.org/issue/69441
The issue has been reviewed, but "Comparison unavailable
Yet to process revision".

I think dark green should only appear when the package is reviewed
AND builds correctly (so would be light green without reviewing).

Andreas

Message #8 received at 69466 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Andreas Enge <andreas <at> enge.fr>
Cc: 69466 <at> debbugs.gnu.org
Subject: Re: bug#69466: Wrong colours for QA
Date: Mon, 22 Apr 2024 17:27:58 +0100

[Message part 1 (text/plain, inline)]

Andreas Enge <andreas <at> enge.fr> writes:

> it looks like the dark green colour is wrongly chosen in QA,
> for instance here:
>    https://qa.guix.gnu.org/issue/69441
> The issue has been reviewed, but "Comparison unavailable
> Yet to process revision".
>
> I think dark green should only appear when the package is reviewed
> AND builds correctly (so would be light green without reviewing).

When implementing this I chose to have the review trump any other status
since hopefully any failing builds will have been taken in to account by
the reviewer.

I think it's useful to highlight when there's a review regardless of the
other information that QA has.

1: https://git.savannah.gnu.org/cgit/guix/qa-frontpage.git/tree/guix-qa-frontpage/issue.scm#n163

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 69466 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 69466 <at> debbugs.gnu.org
Subject: Re: bug#69466: Wrong colours for QA
Date: Mon, 29 Apr 2024 15:42:13 +0200

Am Mon, Apr 22, 2024 at 05:27:58PM +0100 schrieb Christopher Baines:
> When implementing this I chose to have the review trump any other status
> since hopefully any failing builds will have been taken in to account by
> the reviewer.

My impression is that reviews happen often before the package has reached
the status of being built on QA.

Andreas

Message #14 received at 69466 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Andreas Enge <andreas <at> enge.fr>
Cc: 69466 <at> debbugs.gnu.org
Subject: Re: bug#69466: Wrong colours for QA
Date: Mon, 29 Apr 2024 15:29:28 +0100

[Message part 1 (text/plain, inline)]

Andreas Enge <andreas <at> enge.fr> writes:

> Am Mon, Apr 22, 2024 at 05:27:58PM +0100 schrieb Christopher Baines:
>> When implementing this I chose to have the review trump any other status
>> since hopefully any failing builds will have been taken in to account by
>> the reviewer.
>
> My impression is that reviews happen often before the package has reached
> the status of being built on QA.

I think that's fine too, QA is meant to be helpful not limiting.

I do still take this in to account when merging, not pushing things to
master if I'd like to see more things build, either just for substitute
availability, or because I'm on the lookout for build failures.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.