X-Loop: help-debbugs@HIDDEN Subject: bug#70432: 30.0.50; C-h for help not working with C-h k Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Wed, 17 Apr 2024 07:37:02 +0000 Resent-Message-ID: <handler.70432.B.171333939631980 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 70432 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 70432 <at> debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.171333939631980 (code B ref -1); Wed, 17 Apr 2024 07:37:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 Apr 2024 07:36:36 +0000 Received: from localhost ([127.0.0.1]:45624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rwzqN-0008JZ-BN for submit <at> debbugs.gnu.org; Wed, 17 Apr 2024 03:36:36 -0400 Received: from lists.gnu.org ([2001:470:142::17]:39768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1rwzqI-0008Iw-IO for submit <at> debbugs.gnu.org; Wed, 17 Apr 2024 03:36:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <gerd.moellmann@HIDDEN>) id 1rwzpy-0003Bh-Dm for bug-gnu-emacs@HIDDEN; Wed, 17 Apr 2024 03:36:10 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <gerd.moellmann@HIDDEN>) id 1rwzpw-00082D-5U for bug-gnu-emacs@HIDDEN; Wed, 17 Apr 2024 03:36:09 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-41551639550so32863505e9.2 for <bug-gnu-emacs@HIDDEN>; Wed, 17 Apr 2024 00:36:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713339366; x=1713944166; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=NhAZ+cty8UrLhXGxhPrxY8oo4e6dxS/a2nEq+47fDVA=; b=F0l7zwJFyqi0vEl0P7VK0f4eTs0hiE1V4Cw33uxaxfBgcv3jGB9GByGiMXHbrrgDEZ HoTHg1/mwMGO0aVCmpra9se9/SJUUweBlUXj2/cVPfmcFmwRbnL/fDWW1IBSdWG5lImL 5aO9CPvCYvDjm0tP68nQjy5rYjTzklgM8uvuygJnZ7HoZx21IoJl77DtQHwms4USBALf PGhnDM0V67vhaFiW13lzko+HnTNLIxpcJ+SaR8wlMtQZMUaEE/TBvdcjgwS25wPCJh7E ltpY/kpA1maOj5UB7/dJwIJdn0Kdj0n+OAMqo+nPv2Sh8JIa+egNW5PRTD26zCenpoPK SSTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713339366; x=1713944166; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NhAZ+cty8UrLhXGxhPrxY8oo4e6dxS/a2nEq+47fDVA=; b=F+9kY/xXMQS+chi3nxNgzZSC7CFLPTPMcoA4/AXNgzZ2AZ8BiswxTbEKFj+6fhfdQc bG/QBXdtGReWbIGoDNhBaroQw3YmHsAbJ5ndmuveb57I9xUo3n2JZlJPzKLzocERi9YW aH2DAeZHpeJ5bJ8Q1DtFDfmBOxPiv66nrSHFFD327HiDYF204BJiype4sDyBaJ7zWTfi CcWrORD/F4287wyndTSb5e+Xo1JFEXxsItporg1BTKyTnkS8cRKBBRVktDjg52qYkxuU PAT6FwtsHeloA6sOR/cEnZfp6nYdqB7mprE/+noCpAyNtjXlzfAIsvoveMoaRJdccIo5 gPfw== X-Gm-Message-State: AOJu0YyksWuwvk2TE2dgO+utwRsqx4ZY+fAYRxeaOqsTj5J6Dxm7urn/ d3qjpc5Z8pYbrvQdIwf0j2biemORHYygoO0ryFXR6du6IepGUucLy+3K94J4 X-Google-Smtp-Source: AGHT+IELf36iQ69gVf62hzj3+y3vwgEQARToWVtbkcuS+d3uRlk0/E0dd7vDLnQ2F9eoCJEjlV3ERg== X-Received: by 2002:a05:600c:3503:b0:418:21ac:d0ce with SMTP id h3-20020a05600c350300b0041821acd0cemr9671084wmq.37.1713339365837; Wed, 17 Apr 2024 00:36:05 -0700 (PDT) Received: from Pro.fritz.box (pd9e3638b.dip0.t-ipconnect.de. [217.227.99.139]) by smtp.gmail.com with ESMTPSA id j13-20020a05600c190d00b00418a386c17bsm1646683wmq.12.2024.04.17.00.36.05 for <bug-gnu-emacs@HIDDEN> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 00:36:05 -0700 (PDT) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Date: Wed, 17 Apr 2024 09:36:04 +0200 Message-ID: <m28r1cigpn.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=gerd.moellmann@HIDDEN; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) To reproduce 1. emacs -Q 2. C-h k C-x t 3. display says Press C-h for help 4. C-h => C-x t C-h is undefined In GNU Emacs 30.0.50 (build 1, x86_64-apple-darwin23.4.0, NS appkit-2487.50 Version 14.4.1 (Build 23E224)) of 2024-04-16 built on Pro.fritz.box Repository revision: 1be21dd95388037cfb71474a1fbd2a7d3583a80a Repository branch: master Windowing system distributor 'Apple', version 10.3.2487 System Description: macOS 14.4.1
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Subject: bug#70432: Acknowledgement (30.0.50; C-h for help not working with C-h k) Message-ID: <handler.70432.B.171333939631980.ack <at> debbugs.gnu.org> References: <m28r1cigpn.fsf@HIDDEN> X-Gnu-PR-Message: ack 70432 X-Gnu-PR-Package: emacs Reply-To: 70432 <at> debbugs.gnu.org Date: Wed, 17 Apr 2024 07:37:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 70432 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 70432: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D70432 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN Subject: bug#70432: 30.0.50; C-h for help not working with C-h k Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 18 Apr 2024 12:04:09 +0000 Resent-Message-ID: <handler.70432.B70432.171344179216863 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 70432 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>, Dmitry Gutov <dmitry@HIDDEN>, Stefan Monnier <monnier@HIDDEN> Cc: 70432 <at> debbugs.gnu.org Received: via spool by 70432-submit <at> debbugs.gnu.org id=B70432.171344179216863 (code B ref 70432); Thu, 18 Apr 2024 12:04:09 +0000 Received: (at 70432) by debbugs.gnu.org; 18 Apr 2024 12:03:12 +0000 Received: from localhost ([127.0.0.1]:52032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rxQTp-0004N6-1f for submit <at> debbugs.gnu.org; Thu, 18 Apr 2024 08:03:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rxQTg-0004Kw-2r for 70432 <at> debbugs.gnu.org; Thu, 18 Apr 2024 08:03:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rxQTK-0008E6-02; Thu, 18 Apr 2024 08:02:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=hWXlZANA2fTcEXEKM738gciBArw3wUqwWPGhTb8IYRs=; b=j3DKAWyAa7oeiYNEMyHt 637VMnDjiOPpAvICREoBA1HH8ZeUgMD9gfoZEIuoIvIKxersReax8KMxcSe+3+ECHKhvGoKaMDwya /t4mb3JDJwWuEywAIrjcu+y1bXkNzeQkAtgmFsm2wHo/F4Gi7gbsCui52GNLaLsQtIhfgvUfQkuaZ SMFWOYzJ+sBknzaKNWklHP4zYu/uJFPlYeip31u6jBozg9HqyBRsQfbV61A5eRs1gJ/mRrqVl0Vc5 ohDaAcuzzL66zgkT3bmmKCV2DgH9wugAwj+0GIT1P6RiBS6GjwrdRr+MeAIKxKXCbQU93Xl5Pa2tE m18LREQjJ/b+Bg==; Date: Thu, 18 Apr 2024 15:02:30 +0300 Message-Id: <86cyqmev55.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <m28r1cigpn.fsf@HIDDEN> (message from Gerd =?UTF-8?Q?M=C3=B6llmann?= on Wed, 17 Apr 2024 09:36:04 +0200) References: <m28r1cigpn.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Gerd Möllmann <gerd.moellmann@HIDDEN> > Date: Wed, 17 Apr 2024 09:36:04 +0200 > > To reproduce > > 1. emacs -Q > 2. C-h k C-x t > 3. display says Press C-h for help > 4. C-h > => C-x t C-h is undefined Because "C-x t C-h" is indeed undefined. I think it makes no sense to tell users about C-h that shows the available sequences when they already invoked a C-h command to ask about a particular sequence. So the patch below seems to be in order. Also, "C-h K" will need a similar treatment (which is complicated by the fact that it uses (interactive "k")). Dmitry and Stefan, any better ideas? diff --git a/lisp/help.el b/lisp/help.el index d4e39f0..e6117ec 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -1049,6 +1049,9 @@ help--read-key-sequence (let ((enable-disabled-menus-and-buttons t) (cursor-in-echo-area t) (side-event nil) + ;; Showing the list of key sequences makes no sense when they + ;; asked about a key sequence. + (echo-keystrokes-help nil) saved-yank-menu) (unwind-protect (let (last-modifiers key-list)
X-Loop: help-debbugs@HIDDEN Subject: bug#70432: 30.0.50; C-h for help not working with C-h k Resent-From: Stefan Monnier <monnier@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 18 Apr 2024 13:53:01 +0000 Resent-Message-ID: <handler.70432.B70432.17134483418560 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 70432 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN> Cc: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>, Dmitry Gutov <dmitry@HIDDEN>, 70432 <at> debbugs.gnu.org Received: via spool by 70432-submit <at> debbugs.gnu.org id=B70432.17134483418560 (code B ref 70432); Thu, 18 Apr 2024 13:53:01 +0000 Received: (at 70432) by debbugs.gnu.org; 18 Apr 2024 13:52:21 +0000 Received: from localhost ([127.0.0.1]:52560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rxSBW-0002Do-V0 for submit <at> debbugs.gnu.org; Thu, 18 Apr 2024 09:52:20 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:28231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <monnier@HIDDEN>) id 1rxSBU-0002Co-2c for 70432 <at> debbugs.gnu.org; Thu, 18 Apr 2024 09:52:17 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C16331000D6; Thu, 18 Apr 2024 09:51:56 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1713448315; bh=2FDCVX4kP5VOtuwGXD8efMA66WGqJmoDYZ94pE9rGOI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=MPkXcnoyeUyrXg5us3j97kYv4Tt7sl+bPHfPotNAZBeg5GX6G3VvN6CCeDSQIo7wf 8vcNH7CrUTzssYt6yZtGOh/2YrUJdODO5wAjzaKHc0dKXJmjalo2cesQGma+683CGZ 2ci5Q8ciEGpYg8yP+MNPzrRocdxXY+3brn9piIEWUiK723iuiova08CZTVxsH1f2rK 92w3MHTdgPQiShHRIR+gdK4E5WKYrBed7/oqNQ2zxqxeYzhKiggwPyM2WE851m1Dt9 C4l9J+q+YMH01G0o1PMjWRTX2/B/sKi++lH2HXfy5MLGSFl88QlDW4BYK3kDN1tEOq nysNK3pFGdjYg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D1719100044; Thu, 18 Apr 2024 09:51:55 -0400 (EDT) Received: from pastel (unknown [45.72.201.215]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8E7C5120384; Thu, 18 Apr 2024 09:51:55 -0400 (EDT) From: Stefan Monnier <monnier@HIDDEN> In-Reply-To: <86cyqmev55.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 18 Apr 2024 15:02:30 +0300") Message-ID: <jwvzftqvkz2.fsf-monnier+emacs@HIDDEN> References: <m28r1cigpn.fsf@HIDDEN> <86cyqmev55.fsf@HIDDEN> Date: Thu, 18 Apr 2024 09:51:54 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Dmitry and Stefan, any better ideas? > > diff --git a/lisp/help.el b/lisp/help.el > index d4e39f0..e6117ec 100644 > --- a/lisp/help.el > +++ b/lisp/help.el > @@ -1049,6 +1049,9 @@ help--read-key-sequence > (let ((enable-disabled-menus-and-buttons t) > (cursor-in-echo-area t) > (side-event nil) > + ;; Showing the list of key sequences makes no sense when they > + ;; asked about a key sequence. > + (echo-keystrokes-help nil) > saved-yank-menu) > (unwind-protect > (let (last-modifiers key-list) Loos OK to me, tho maybe it should be the other way around: we should bind it to non-nil around those places where we know it makes sense? Stefan
X-Loop: help-debbugs@HIDDEN Subject: bug#70432: 30.0.50; C-h for help not working with C-h k Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 18 Apr 2024 14:20:02 +0000 Resent-Message-ID: <handler.70432.B70432.171344997320901 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 70432 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier <monnier@HIDDEN> Cc: gerd.moellmann@HIDDEN, dmitry@HIDDEN, 70432 <at> debbugs.gnu.org Received: via spool by 70432-submit <at> debbugs.gnu.org id=B70432.171344997320901 (code B ref 70432); Thu, 18 Apr 2024 14:20:02 +0000 Received: (at 70432) by debbugs.gnu.org; 18 Apr 2024 14:19:33 +0000 Received: from localhost ([127.0.0.1]:52694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rxSbr-0005Ql-0o for submit <at> debbugs.gnu.org; Thu, 18 Apr 2024 10:19:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rxSbn-0005Oh-GM for 70432 <at> debbugs.gnu.org; Thu, 18 Apr 2024 10:19:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rxSbU-0000cy-Jl; Thu, 18 Apr 2024 10:19:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=9mTLX+bTJXvCD46U7NbOlGqLOSi04PomiY+PuP1ZihA=; b=JTkd/7uUqYxbZlThSbEw NbFEs9maMYuTscHumTFKVEybj/5MYMy5IUSV4qvyvC0d8Pjf1bqTXG+PK1DlacO6mgdkEozk1NmTb 6nRDvxpJvCarh5uFkSpMDCs5G13f0HVX/xnfJpr95yAw2VK/usrTnw86QL7vWQxKi5IYcE4hpSglV H4kyMQZt3NRetjtmM1aQMBZ9dENfFGE4K/3ApFEL47tQZtjBB8G84tftB3rrPbgXjXfCduMF+Ro2f qGiPZA4JHJxw4hxyekZz2npFS9NyLmcrpof2+S792ClWipicr2wLgSqD/22PsaHX9LDOFAsH98KWY eRMeZgzDrwUMpg==; Date: Thu, 18 Apr 2024 17:19:06 +0300 Message-Id: <867cgueoth.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <jwvzftqvkz2.fsf-monnier+emacs@HIDDEN> (message from Stefan Monnier on Thu, 18 Apr 2024 09:51:54 -0400) References: <m28r1cigpn.fsf@HIDDEN> <86cyqmev55.fsf@HIDDEN> <jwvzftqvkz2.fsf-monnier+emacs@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.6 (--) > From: Stefan Monnier <monnier@HIDDEN> > Cc: Gerd Möllmann <gerd.moellmann@HIDDEN>, Dmitry > Gutov > <dmitry@HIDDEN>, 70432 <at> debbugs.gnu.org > Date: Thu, 18 Apr 2024 09:51:54 -0400 > > > Dmitry and Stefan, any better ideas? > > > > diff --git a/lisp/help.el b/lisp/help.el > > index d4e39f0..e6117ec 100644 > > --- a/lisp/help.el > > +++ b/lisp/help.el > > @@ -1049,6 +1049,9 @@ help--read-key-sequence > > (let ((enable-disabled-menus-and-buttons t) > > (cursor-in-echo-area t) > > (side-event nil) > > + ;; Showing the list of key sequences makes no sense when they > > + ;; asked about a key sequence. > > + (echo-keystrokes-help nil) > > saved-yank-menu) > > (unwind-protect > > (let (last-modifiers key-list) > > Loos OK to me, tho maybe it should be the other way around: we should > bind it to non-nil around those places where we know it makes sense? It's a user option, so I don't think that would be a good idea.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.