GNU logs - #70999, boring messages

Message sent to bug-guix@HIDDEN:

Subject: bug#70999: Meson-build system fails to install license files
Resent-From: Dariqq <dariqq@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Fri, 17 May 2024 09:27:01 +0000
Resent-Message-ID: <handler.70999.B.171593801815451 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 70999 <at> debbugs.gnu.org
Message-ID: <3ec197ca-3e22-4108-8277-9960a4be88be@HIDDEN>
Date: Fri, 17 May 2024 09:26:38 +0000
MIME-Version: 1.0
Content-Language: en-US
From: Dariqq <dariqq@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Received-SPF: pass client-ip=185.67.36.65; envelope-from=dariqq@HIDDEN;
 helo=mout01.posteo.de
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Hi Guix,

I was trying to update a package using meson build system to its newest 
version and noticed in the build log

starting phase `install-license-files'
installing 0 license files from '.'
phase `install-license-files' succeeded after 0.0 seconds

Also other packages built using meson don't seem to have license files 
in the output.

I think the problem is that the "." directory is the "build" directory 
and not the source directory because in  meson configure phase we change 
directory to the build-dir.

The install-license-files function has an argument for specifying 
out-of-source builds and calling it with that set to #t seems to be able 
to find license files in the source directory in my limited testing.

Another option would be to specify the build dir in the ninja 
invocations without changing to it.

As meson only supports out-of-source builds I think this should be 
changed though I am unsure how to best do this.

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Dariqq <dariqq@HIDDEN>
Subject: bug#70999: Acknowledgement (Meson-build system fails to install
 license files)
Message-ID: <handler.70999.B.171593801815451.ack <at> debbugs.gnu.org>
References: <3ec197ca-3e22-4108-8277-9960a4be88be@HIDDEN>
X-Gnu-PR-Message: ack 70999
X-Gnu-PR-Package: guix
Reply-To: 70999 <at> debbugs.gnu.org
Date: Fri, 17 May 2024 09:27:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guix@HIDDEN

If you wish to submit further information on this problem, please
send it to 70999 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
70999: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D70999
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guix@HIDDEN:

Subject: bug#70999: Meson-build system fails to install license files
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Sat, 25 May 2024 09:38:01 +0000
Resent-Message-ID: <handler.70999.B70999.171662985119773 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Dariqq <dariqq@HIDDEN>
Cc: 70999 <at> debbugs.gnu.org
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
In-Reply-To: <3ec197ca-3e22-4108-8277-9960a4be88be@HIDDEN>
 (dariqq@HIDDEN's message of "Fri, 17 May 2024 09:26:38 +0000")
References: <3ec197ca-3e22-4108-8277-9960a4be88be@HIDDEN>
Date: Sat, 25 May 2024 11:37:14 +0200
Message-ID: <87plta2px1.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi Dariqq,

Dariqq <dariqq@HIDDEN> skribis:

> The install-license-files function has an argument for specifying
> out-of-source builds and calling it with that set to #t seems to be
> able to find license files in the source directory in my limited
> testing.

Yes, =E2=80=98meson-build-system=E2=80=99 should pass #:out-of-source? #t e=
xactly like
=E2=80=98cmake-build-system=E2=80=99 does.  That should solve the problem.

Thanks,
Ludo=E2=80=99.

Message sent to bug-guix@HIDDEN:

Subject: bug#70999: [PATCH] build-system/meson: Add #:out-of-source? argument to build system.
References: <3ec197ca-3e22-4108-8277-9960a4be88be@HIDDEN>
In-Reply-To: <3ec197ca-3e22-4108-8277-9960a4be88be@HIDDEN>
Resent-From: Dariqq <dariqq@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Sat, 25 May 2024 14:09:01 +0000
Resent-Message-ID: <handler.70999.B70999.17166461341077 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 70999 <at> debbugs.gnu.org
Cc: Dariqq <dariqq@HIDDEN>, ludo@HIDDEN
From: Dariqq <dariqq@HIDDEN>
Date: Sat, 25 May 2024 14:02:19 +0000
Message-ID: <55230dcd23f65c3caa3ea61ed2b18c672b389211.1716645739.git.dariqq@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Meson currently supports only out-of-source builds. Add the argument out-of-source? with default to #t such that the install-license-files phase searches for the license files in the source directory.

* guix/build-system/meson.scm (meson-build): Add out-of-source? argument.
(meson-cross-build): Likewise.

Change-Id: Ib59d9d93b34fd567f05f5f9a10293f6ab924e399
---
I have tested this with the tio package (both natively building and cross compiling) and seems to work. This will cause a lot of rebuild!
For the position of the argument I've put it above build-type to match the order in cmake-build-system.

 guix/build-system/meson.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/guix/build-system/meson.scm b/guix/build-system/meson.scm
index bf9ca15ecc..6c085fa1fe 100644
--- a/guix/build-system/meson.scm
+++ b/guix/build-system/meson.scm
@@ -176,6 +176,7 @@ (define* (meson-build name inputs
                       (outputs '("out"))
                       (configure-flags ''())
                       (search-paths '())
+                      (out-of-source? #t)
                       (build-type "debugoptimized")
                       (tests? #t)
                       (test-options ''())
@@ -225,6 +226,7 @@ (define* (meson-build name inputs
                              #$(if (pair? configure-flags)
                                    (sexp->gexp configure-flags)
                                    configure-flags)
+                             #:out-of-source? #$out-of-source?
                              #:build-type #$build-type
                              #:tests? #$tests?
                              #:test-options #$(sexp->gexp test-options)
@@ -257,7 +259,7 @@ (define* (meson-cross-build name
                             (configure-flags ''())
                             (search-paths '())
                             (native-search-paths '())
-
+                            (out-of-source? #t)
                             (build-type "debugoptimized")
                             (tests? #f)
                             (test-options ''())
@@ -338,6 +340,7 @@ (define* (meson-cross-build name
                                            ,@#$(if (pair? configure-flags)
                                                    (sexp->gexp configure-flags)
                                                    configure-flags))
+                       #:out-of-source? #$out-of-source?
                        #:build-type #$build-type
                        #:tests? #$tests?
                        #:test-options #$(sexp->gexp test-options)

base-commit: 9756d9d6345fb142944261174453ab0a597cc2e7
-- 
2.41.0

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 26 Jun 2024 15:35:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 26 11:35:11 2024
Received: from localhost ([127.0.0.1]:40113 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sMUfu-0006jp-Vs
	for submit <at> debbugs.gnu.org; Wed, 26 Jun 2024 11:35:11 -0400
Received: from mout01.posteo.de ([185.67.36.65]:34709)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dariqq@HIDDEN>) id 1sMUfs-0006jF-Q4
 for control <at> debbugs.gnu.org; Wed, 26 Jun 2024 11:35:10 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout01.posteo.de (Postfix) with ESMTPS id 5EB18240027
 for <control <at> debbugs.gnu.org>; Wed, 26 Jun 2024 17:34:58 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1719416098; bh=rB8p8gDj/o40I4aTksbPS/HDj7n0Q0fM2aJsx+fhAS0=;
 h=Message-ID:Date:MIME-Version:To:Subject:From:Content-Type:
 Content-Transfer-Encoding:From;
 b=gLEnDW3QSSVIRWWLCfz1eUtKvX0AiIshwzXhbBFGCK/2DoxuDfwvZthR/4iBV4CRU
 Y32WZnykxiTKuLG2ZnKuhz+Ydb7VW0p3WGjlCHE5uKXWCHqYAkcWihQG07AGBHzQyV
 fFasvps8q8An92Gl2IhEaOOs3lOZE/FOtI+A+d/lurnBsCqp62mZdgEbR4y47SOqoR
 wz0vkb6lJNhMDsTmcdtn6lF8AQRWuIShpjiKgwwGORhpKoUiJ60ea3idzYaLSq7F0n
 FkW/UT2h36tg76KIvAjoL40DkDJEsk8/dzEP7QNudGf13IBAsoUnBRoDCyR0CSWHEd
 PdXPXYthxIEog==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4W8Qk80fK3z6v08
 for <control <at> debbugs.gnu.org>; Wed, 26 Jun 2024 17:34:55 +0200 (CEST)
Message-ID: <de3e3370-ea6b-4a72-958c-94cee9859d29@HIDDEN>
Date: Wed, 26 Jun 2024 15:34:53 +0000
MIME-Version: 1.0
To: control <at> debbugs.gnu.org
Subject: control message for bug #70999
Content-Language: en-US
From: Dariqq <dariqq@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)


retitle 70999 [core-updates] Meson-build system fails to install license 
files
quit

Last modified: Wed, 26 Jun 2024 15:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.