GNU logs - #71037, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#71037] [PATCH 0/3] gnu: python-pydevd: Update to 2.9.6.
Resent-From: Nicolas Graves <ngraves@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 18 May 2024 12:41:01 +0000
Resent-Message-ID: <handler.71037.B.1716036017752 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 71037 <at> debbugs.gnu.org
Cc: ngraves@HIDDEN
From: Nicolas Graves <ngraves@HIDDEN>
Date: Sat, 18 May 2024 14:35:50 +0200
Message-ID: <20240518123734.9898-1-ngraves@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=87.98.181.248; envelope-from=ngraves@HIDDEN;
 helo=5.mo560.mail-out.ovh.net
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001,
 RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Nicolas Graves (3):
  gnu: python-pydevd: Move to pyproject-build-system.
  gnu: python-pydevd: Update to 2.9.6.
  gnu: python-pydevd: Improve package style.

 gnu/packages/python-xyz.scm | 210 ++++++++++++++++++------------------
 1 file changed, 102 insertions(+), 108 deletions(-)

-- 
2.41.0

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Nicolas Graves <ngraves@HIDDEN>
Subject: bug#71037: Acknowledgement ([PATCH 0/3] gnu: python-pydevd:
 Update to 2.9.6.)
Message-ID: <handler.71037.B.1716036017752.ack <at> debbugs.gnu.org>
References: <20240518123734.9898-1-ngraves@HIDDEN>
X-Gnu-PR-Message: ack 71037
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 71037 <at> debbugs.gnu.org
Date: Sat, 18 May 2024 12:41:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 71037 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
71037: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D71037
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#71037] [PATCH 1/3] gnu: python-pydevd: Move to pyproject-build-system.
References: <20240518123734.9898-1-ngraves@HIDDEN>
In-Reply-To: <20240518123734.9898-1-ngraves@HIDDEN>
Resent-From: Nicolas Graves <ngraves@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 18 May 2024 12:44:01 +0000
Resent-Message-ID: <handler.71037.B71037.1716036207884 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 71037 <at> debbugs.gnu.org
Cc: ngraves@HIDDEN
From: Nicolas Graves <ngraves@HIDDEN>
Date: Sat, 18 May 2024 14:43:05 +0200
Message-ID: <20240518124316.19861-1-ngraves@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

* gnu/packages/python-xyz.scm (python-pydevd):
  [build-system]: Move to pyproject-build-system.
  [arguments]: Replace 'check phase by 'pre-check phase and
  <#:test-flags>.

Change-Id: I8227ac8b1b6031c30c6d09480cacaa3347df21a7
---
 gnu/packages/python-xyz.scm | 46 ++++++++++++++++++-------------------
 1 file changed, 23 insertions(+), 23 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 8151355a418..c2039273429 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -16717,9 +16717,29 @@ (define-public python-pydevd
          (sha256
           (base32
            "1yd017dh6xgxrqcyf8kk8jrr0a3zw895yfjih0z5jghyf0rck38q"))))
-      (build-system python-build-system)
+      (build-system pyproject-build-system)
       (arguments
        (list
+        #:test-flags
+        #~(list "-n" (number->string (parallel-job-count))
+                "-k"
+                (string-append
+                 ;; The two "break_01" tests have been failing on
+                 ;; Python 3.10:
+                 ;; <https://github.com/fabioz/PyDev.Debugger/issues/222>.
+                 "not test_set_pydevd_break_01 "
+                 ;; This one fails for unknown reasons.
+                 "and not test_completion_sockets_and_messages "
+                 ;; the GUI event loop requires an X server.
+                 "and not test_gui_event_loop_custom "
+                 ;; This test validates that 'pydevd' is not in the
+                 ;; exception message, but it is due to being part
+                 ;; of the build file name present in the message.
+                 "and not test_evaluate_exception_trace "
+                 ;; These fail on systems with YAMA LSM’s ptrace
+                 ;; scope > 0. Upstream issue:
+                 ;; https://github.com/fabioz/PyDev.Debugger/issues/218
+                 "and not test_attach_to_pid"))
         #:phases
         #~(modify-phases %standard-phases
             (add-after 'unpack 'fix-tests
@@ -16758,30 +16778,10 @@ (define-public python-pydevd
                 (invoke #+(cxx-for-target) "-shared" "-o" "attach.so"
                         "-fPIC" "-nostartfiles"
                         "pydevd_attach_to_process/linux_and_mac/attach.cpp")))
-            (replace 'check
+            (add-before 'check 'pre-check
               (lambda* (#:key tests? #:allow-other-keys)
                 (when tests?
-                  (setenv "PYDEVD_USE_CYTHON" "YES")
-                  (invoke "pytest" "-vv"
-                          "-n" (number->string (parallel-job-count))
-                          "-k"
-                          (string-append
-                           ;; The two "break_01" tests have been failing on
-                           ;; Python 3.10:
-                           ;; <https://github.com/fabioz/PyDev.Debugger/issues/222>.
-                           "not test_set_pydevd_break_01 "
-                           ;; This one fails for unknown reasons.
-                           "and not test_completion_sockets_and_messages "
-                           ;; the GUI event loop requires an X server.
-                           "and not test_gui_event_loop_custom "
-                           ;; This test validates that 'pydevd' is not in the
-                           ;; exception message, but it is due to being part
-                           ;; of the build file name present in the message.
-                           "and not test_evaluate_exception_trace "
-                           ;; These fail on systems with YAMA LSM’s ptrace
-                           ;; scope > 0. Upstream issue:
-                           ;; https://github.com/fabioz/PyDev.Debugger/issues/218
-                           "and not test_attach_to_pid")))))
+                  (setenv "PYDEVD_USE_CYTHON" "YES"))))
             (add-after 'install 'install-attach-binary
               (lambda _
                 (install-file "attach.so"
-- 
2.41.0

Message sent to guix-patches@HIDDEN:

Subject: [bug#71037] [PATCH 2/3] gnu: python-pydevd: Update to 2.9.6.
Resent-From: Nicolas Graves <ngraves@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 18 May 2024 12:44:02 +0000
Resent-Message-ID: <handler.71037.B71037.1716036211901 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 71037 <at> debbugs.gnu.org
Cc: ngraves@HIDDEN
From: Nicolas Graves <ngraves@HIDDEN>
Date: Sat, 18 May 2024 14:43:06 +0200
Message-ID: <20240518124316.19861-2-ngraves@HIDDEN>
In-Reply-To: <20240518124316.19861-1-ngraves@HIDDEN>
References: <20240518124316.19861-1-ngraves@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

* gnu/packages/python-xyz.scm (python-pydevd): Update to 2.9.6.
  [arguments]<#:test-flags>: Adapt value.

Change-Id: I55cc8129fb78f0ee54519f45b31746a54881d84e
---
 gnu/packages/python-xyz.scm | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index c2039273429..fb12aba967f 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -16694,19 +16694,17 @@ (define-public python-file
 libmagic.")))
 
 (define-public python-pydevd
-  ;; Use the latest commit, which includes cleanups that removes Python 2
-  ;; syntax that would fail to build.
-  (let ((revision "0")
-        (commit "47e298499ef19563bb2ef5941a57046a35ae6868"))
     (package
       (name "python-pydevd")
-      (version (git-version "2.8.0" revision commit))
+      (version "2.9.6")
       (source
        (origin
          (method git-fetch)
          (uri (git-reference
                (url "https://github.com/fabioz/PyDev.Debugger")
-               (commit commit)))
+               (commit (string-append
+                        "pydev_debugger_"
+                        (string-join (string-split version #\.) "_")))))
          (modules '((guix build utils)))
          (snippet '(begin
                      ;; Delete pre-built binaries.
@@ -16716,7 +16714,7 @@ (define-public python-pydevd
          (file-name (git-file-name name version))
          (sha256
           (base32
-           "1yd017dh6xgxrqcyf8kk8jrr0a3zw895yfjih0z5jghyf0rck38q"))))
+           "1niqb6l3m03arfjh14k9k5i5bi56m8qmc3pyi1qkbvqqp5bkydac"))))
       (build-system pyproject-build-system)
       (arguments
        (list
@@ -16728,18 +16726,14 @@ (define-public python-pydevd
                  ;; Python 3.10:
                  ;; <https://github.com/fabioz/PyDev.Debugger/issues/222>.
                  "not test_set_pydevd_break_01 "
-                 ;; This one fails for unknown reasons.
-                 "and not test_completion_sockets_and_messages "
                  ;; the GUI event loop requires an X server.
                  "and not test_gui_event_loop_custom "
                  ;; This test validates that 'pydevd' is not in the
                  ;; exception message, but it is due to being part
                  ;; of the build file name present in the message.
                  "and not test_evaluate_exception_trace "
-                 ;; These fail on systems with YAMA LSM’s ptrace
-                 ;; scope > 0. Upstream issue:
-                 ;; https://github.com/fabioz/PyDev.Debugger/issues/218
-                 "and not test_attach_to_pid"))
+                 ;; This test fail with TimeoutError, no message on stderr.
+                 "and not test_soft_terminate "))
         #:phases
         #~(modify-phases %standard-phases
             (add-after 'unpack 'fix-tests
@@ -16802,7 +16796,7 @@ (define-public python-pydevd
       (synopsis "Python debugger")
       (description "PyDev.Debugger is a capable Python debugger used in PyDev
 and other @acronym{IDEs, Integrated Development Environments}.")
-      (license license:epl1.0))))
+      (license license:epl1.0)))
 
 (define-public python-debugpy
   (package
-- 
2.41.0

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#71037] [PATCH 3/3] gnu: python-pydevd: Improve package style.
Resent-From: Nicolas Graves <ngraves@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 18 May 2024 12:44:02 +0000
Resent-Message-ID: <handler.71037.B71037.1716036219917 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 71037
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 71037 <at> debbugs.gnu.org
Cc: ngraves@HIDDEN
Received: via spool by 71037-submit <at> debbugs.gnu.org id=B71037.1716036219917
          (code B ref 71037); Sat, 18 May 2024 12:44:02 +0000
Received: (at 71037) by debbugs.gnu.org; 18 May 2024 12:43:39 +0000
Received: from localhost ([127.0.0.1]:33291 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s8JPT-0000Ei-0R
	for submit <at> debbugs.gnu.org; Sat, 18 May 2024 08:43:38 -0400
Received: from 5.mo581.mail-out.ovh.net ([178.32.120.239]:53363)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ngraves@HIDDEN>) id 1s8JPQ-0000ES-4o
 for 71037 <at> debbugs.gnu.org; Sat, 18 May 2024 08:43:33 -0400
Received: from director9.ghost.mail-out.ovh.net (unknown [10.108.9.29])
 by mo581.mail-out.ovh.net (Postfix) with ESMTP id 4VhNmG6Cygz1GgC
 for <71037 <at> debbugs.gnu.org>; Sat, 18 May 2024 12:43:26 +0000 (UTC)
Received: from ghost-submission-6684bf9d7b-2csr6 (unknown [10.110.113.149])
 by director9.ghost.mail-out.ovh.net (Postfix) with ESMTPS id A12131FE00;
 Sat, 18 May 2024 12:43:26 +0000 (UTC)
Received: from ngraves.fr ([37.59.142.105])
 by ghost-submission-6684bf9d7b-2csr6 with ESMTPSA
 id 0bd5JG6iSGa81wAAJGEfkA
 (envelope-from <ngraves@HIDDEN>); Sat, 18 May 2024 12:43:26 +0000
Authentication-Results: garm.ovh; auth=pass
 (GARM-105G006f5b1b190-3341-44c8-8969-9db88554ed06,
 BDB7418199CE68AC6294CEC755C667778ECDC1D2) smtp.auth=ngraves@HIDDEN
X-OVh-ClientIp: 81.67.146.208
From: Nicolas Graves <ngraves@HIDDEN>
Date: Sat, 18 May 2024 14:43:07 +0200
Message-ID: <20240518124316.19861-3-ngraves@HIDDEN>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <20240518124316.19861-1-ngraves@HIDDEN>
References: <20240518124316.19861-1-ngraves@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Ovh-Tracer-Id: 11704292485853143778
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: 0
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvledrvdehiedggeehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepvdehleeiffehtedvlefhffffjeefgfduhfetkeevheeiteduiedugfekuedtheejnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepuddvjedrtddrtddruddpkedurdeijedrudegiedrvddtkedpfeejrdehledrudegvddruddtheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtohepjedutdefjeesuggvsggsuhhgshdrghhnuhdrohhrghdpoffvtefjohhsthepmhhoheekuddpmhhouggvpehsmhhtphhouhht
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* gnu/packages/python-xyz.scm (python-pydevd): Indent properly.

Change-Id: I854d32943416e5f9b7c8dd3602d975dde0d31153
---
 gnu/packages/python-xyz.scm | 204 ++++++++++++++++++------------------
 1 file changed, 102 insertions(+), 102 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index fb12aba967f..aaca34e0e29 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -16694,109 +16694,109 @@ (define-public python-file
 libmagic.")))
 
 (define-public python-pydevd
-    (package
-      (name "python-pydevd")
-      (version "2.9.6")
-      (source
-       (origin
-         (method git-fetch)
-         (uri (git-reference
-               (url "https://github.com/fabioz/PyDev.Debugger")
-               (commit (string-append
-                        "pydev_debugger_"
-                        (string-join (string-split version #\.) "_")))))
-         (modules '((guix build utils)))
-         (snippet '(begin
-                     ;; Delete pre-built binaries.
-                     (for-each delete-file (find-files "." "\\.(so|dylib|dll)"))
-                     ;; This source is generated via Cython.
-                     (delete-file "_pydevd_bundle/pydevd_cython.c")))
-         (file-name (git-file-name name version))
-         (sha256
-          (base32
-           "1niqb6l3m03arfjh14k9k5i5bi56m8qmc3pyi1qkbvqqp5bkydac"))))
-      (build-system pyproject-build-system)
-      (arguments
-       (list
-        #:test-flags
-        #~(list "-n" (number->string (parallel-job-count))
-                "-k"
-                (string-append
-                 ;; The two "break_01" tests have been failing on
-                 ;; Python 3.10:
-                 ;; <https://github.com/fabioz/PyDev.Debugger/issues/222>.
-                 "not test_set_pydevd_break_01 "
-                 ;; the GUI event loop requires an X server.
-                 "and not test_gui_event_loop_custom "
-                 ;; This test validates that 'pydevd' is not in the
-                 ;; exception message, but it is due to being part
-                 ;; of the build file name present in the message.
-                 "and not test_evaluate_exception_trace "
-                 ;; This test fail with TimeoutError, no message on stderr.
-                 "and not test_soft_terminate "))
-        #:phases
-        #~(modify-phases %standard-phases
-            (add-after 'unpack 'fix-tests
-              (lambda _
-                (substitute* "tests_python/test_convert_utilities.py"
-                  ;; Add missing trailing '/'.
-                  (("'\\\\\\\\usr\\\\\\\\bin\\\\\\\\') == '/usr/bin" all)
-                   (string-append all "/")))))
-            (add-after 'unpack 'patch-command-paths
-              (lambda* (#:key inputs #:allow-other-keys)
-                (substitute* "_pydevd_bundle/pydevd_api.py"
-                  (("'kill'")
-                   (format #f "~s" (search-input-file inputs "bin/kill")))
-                  (("'pgrep'")
-                   (format #f "~s" (search-input-file inputs "bin/pgrep"))))))
-            (add-after 'unpack 'generate-sources
-              (lambda _
-                (setenv "PYTHONPATH" (getcwd))
-                (invoke "python" "build_tools/build.py")))
-            (add-after 'unpack 'adjust-attach-binary-name
-              (lambda _
-                (substitute*
-                    '("pydevd_tracing.py"
-                      "pydevd_attach_to_process/add_code_to_python_process.py")
-                  (("def get_(target|python_helper_lib)_filename.*" all)
-                   (format #f "~a    return ~s~%" all
-                           (string-append #$output "/lib/attach.so"))))))
-            (add-after 'unpack 'patch-gdb
-              (lambda* (#:key inputs #:allow-other-keys)
-                (substitute*
-                    "pydevd_attach_to_process/add_code_to_python_process.py"
-                  (("'gdb',")
-                   (format #f "~s," (search-input-file inputs "bin/gdb"))))))
-            (add-after 'build 'build-attach-linux-binary
-              (lambda _
-                (invoke #+(cxx-for-target) "-shared" "-o" "attach.so"
-                        "-fPIC" "-nostartfiles"
-                        "pydevd_attach_to_process/linux_and_mac/attach.cpp")))
-            (add-before 'check 'pre-check
-              (lambda* (#:key tests? #:allow-other-keys)
-                (when tests?
-                  (setenv "PYDEVD_USE_CYTHON" "YES"))))
-            (add-after 'install 'install-attach-binary
-              (lambda _
-                (install-file "attach.so"
-                              (string-append #$output "/lib"))))
-            ;; Some modules aren't designed to be loadable by themselves, such
-            ;; as 'pydev_app_engine_debug_startup' and fail.
-            (delete 'sanity-check))))
-      (native-inputs
-       (list python-cython
-             python-numpy
-             python-psutil
-             python-pytest
-             python-pytest-xdist
-             python-trio
-             python-untangle))
-      (inputs (list coreutils gdb/pinned procps))
-      (home-page "https://github.com/fabioz/PyDev.Debugger/")
-      (synopsis "Python debugger")
-      (description "PyDev.Debugger is a capable Python debugger used in PyDev
+  (package
+    (name "python-pydevd")
+    (version "2.9.6")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/fabioz/PyDev.Debugger")
+             (commit (string-append
+                      "pydev_debugger_"
+                      (string-join (string-split version #\.) "_")))))
+       (modules '((guix build utils)))
+       (snippet '(begin
+                   ;; Delete pre-built binaries.
+                   (for-each delete-file (find-files "." "\\.(so|dylib|dll)"))
+                   ;; This source is generated via Cython.
+                   (delete-file "_pydevd_bundle/pydevd_cython.c")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1niqb6l3m03arfjh14k9k5i5bi56m8qmc3pyi1qkbvqqp5bkydac"))))
+    (build-system pyproject-build-system)
+    (arguments
+     (list
+      #:test-flags
+      #~(list "-n" (number->string (parallel-job-count))
+              "-k"
+              (string-append
+               ;; The two "break_01" tests have been failing on
+               ;; Python 3.10:
+               ;; <https://github.com/fabioz/PyDev.Debugger/issues/222>.
+               "not test_set_pydevd_break_01 "
+               ;; the GUI event loop requires an X server.
+               "and not test_gui_event_loop_custom "
+               ;; This test validates that 'pydevd' is not in the
+               ;; exception message, but it is due to being part
+               ;; of the build file name present in the message.
+               "and not test_evaluate_exception_trace "
+               ;; This test fail with TimeoutError, no message on stderr.
+               "and not test_soft_terminate "))
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'fix-tests
+            (lambda _
+              (substitute* "tests_python/test_convert_utilities.py"
+                ;; Add missing trailing '/'.
+                (("'\\\\\\\\usr\\\\\\\\bin\\\\\\\\') == '/usr/bin" all)
+                 (string-append all "/")))))
+          (add-after 'unpack 'patch-command-paths
+            (lambda* (#:key inputs #:allow-other-keys)
+              (substitute* "_pydevd_bundle/pydevd_api.py"
+                (("'kill'")
+                 (format #f "~s" (search-input-file inputs "bin/kill")))
+                (("'pgrep'")
+                 (format #f "~s" (search-input-file inputs "bin/pgrep"))))))
+          (add-after 'unpack 'generate-sources
+            (lambda _
+              (setenv "PYTHONPATH" (getcwd))
+              (invoke "python" "build_tools/build.py")))
+          (add-after 'unpack 'adjust-attach-binary-name
+            (lambda _
+              (substitute*
+                  '("pydevd_tracing.py"
+                    "pydevd_attach_to_process/add_code_to_python_process.py")
+                (("def get_(target|python_helper_lib)_filename.*" all)
+                 (format #f "~a    return ~s~%" all
+                         (string-append #$output "/lib/attach.so"))))))
+          (add-after 'unpack 'patch-gdb
+            (lambda* (#:key inputs #:allow-other-keys)
+              (substitute*
+                  "pydevd_attach_to_process/add_code_to_python_process.py"
+                (("'gdb',")
+                 (format #f "~s," (search-input-file inputs "bin/gdb"))))))
+          (add-after 'build 'build-attach-linux-binary
+            (lambda _
+              (invoke #+(cxx-for-target) "-shared" "-o" "attach.so"
+                      "-fPIC" "-nostartfiles"
+                      "pydevd_attach_to_process/linux_and_mac/attach.cpp")))
+          (add-before 'check 'pre-check
+            (lambda* (#:key tests? #:allow-other-keys)
+              (when tests?
+                (setenv "PYDEVD_USE_CYTHON" "YES"))))
+          (add-after 'install 'install-attach-binary
+            (lambda _
+              (install-file "attach.so"
+                            (string-append #$output "/lib"))))
+          ;; Some modules aren't designed to be loadable by themselves, such
+          ;; as 'pydev_app_engine_debug_startup' and fail.
+          (delete 'sanity-check))))
+    (native-inputs
+     (list python-cython
+           python-numpy
+           python-psutil
+           python-pytest
+           python-pytest-xdist
+           python-trio
+           python-untangle))
+    (inputs (list coreutils gdb/pinned procps))
+    (home-page "https://github.com/fabioz/PyDev.Debugger/")
+    (synopsis "Python debugger")
+    (description "PyDev.Debugger is a capable Python debugger used in PyDev
 and other @acronym{IDEs, Integrated Development Environments}.")
-      (license license:epl1.0)))
+    (license license:epl1.0)))
 
 (define-public python-debugpy
   (package
-- 
2.41.0

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 18 May 2024 12:49:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 18 08:49:13 2024
Received: from localhost ([127.0.0.1]:33316 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s8JUv-0000J7-HF
	for submit <at> debbugs.gnu.org; Sat, 18 May 2024 08:49:13 -0400
Received: from 4.mo550.mail-out.ovh.net ([46.105.76.26]:33877)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ngraves@HIDDEN>) id 1s8JUs-0000J1-TG
 for control <at> debbugs.gnu.org; Sat, 18 May 2024 08:49:11 -0400
Received: from director11.ghost.mail-out.ovh.net (unknown [10.108.17.34])
 by mo550.mail-out.ovh.net (Postfix) with ESMTP id 4VhNtn73kbz1RtR
 for <control <at> debbugs.gnu.org>; Sat, 18 May 2024 12:49:05 +0000 (UTC)
Received: from ghost-submission-6684bf9d7b-6bn84 (unknown [10.108.54.36])
 by director11.ghost.mail-out.ovh.net (Postfix) with ESMTPS id B8C2F1FE53
 for <control <at> debbugs.gnu.org>; Sat, 18 May 2024 12:49:05 +0000 (UTC)
Received: from ngraves.fr ([37.59.142.98])
 by ghost-submission-6684bf9d7b-6bn84 with ESMTPSA
 id Zqu4KMGjSGYyHAAATmkHXg (envelope-from <ngraves@HIDDEN>)
 for <control <at> debbugs.gnu.org>; Sat, 18 May 2024 12:49:05 +0000
Authentication-Results: garm.ovh; auth=pass
 (GARM-98R0025aa325c5-2f85-4ccd-b76a-535c2513ec77,
 BDB7418199CE68AC6294CEC755C667778ECDC1D2) smtp.auth=ngraves@HIDDEN
X-OVh-ClientIp: 81.67.146.208
From: Nicolas Graves <ngraves@HIDDEN>
To: control <at> debbugs.gnu.org
Subject: control message for bug #71037
Date: Sat, 18 May 2024 14:49:04 +0200
Message-ID: <87zfsncmkf.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Ovh-Tracer-Id: 11799712499272966757
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: 0
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvledrvdehiedggeeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvffufffkgggtsehttdertddttddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepueejleeileejfffhleetjedtleejheevudffleevgfdufeekhefgvddvveegveefnecukfhppeduvdejrddtrddtrddupdekuddrieejrddugeeirddvtdekpdefjedrheelrddugedvrdelkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtoheptghonhhtrhholhesuggvsggsuhhgshdrghhnuhdrohhrghdpoffvtefjohhsthepmhhoheehtddpmhhouggvpehsmhhtphhouhht
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


block 71037 by 70393
quit


-- 
Best regards,
Nicolas Graves

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 18 May 2024 13:08:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 18 09:08:56 2024
Received: from localhost ([127.0.0.1]:33393 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s8Jo0-0003Fn-AN
	for submit <at> debbugs.gnu.org; Sat, 18 May 2024 09:08:56 -0400
Received: from 2.mo560.mail-out.ovh.net ([188.165.53.149]:49627)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ngraves@HIDDEN>) id 1s8Jnw-0003Ff-O6
 for control <at> debbugs.gnu.org; Sat, 18 May 2024 09:08:54 -0400
Received: from director3.ghost.mail-out.ovh.net (unknown [10.109.176.161])
 by mo560.mail-out.ovh.net (Postfix) with ESMTP id 4VhPKW3mMRz1LTM
 for <control <at> debbugs.gnu.org>; Sat, 18 May 2024 13:08:47 +0000 (UTC)
Received: from ghost-submission-6684bf9d7b-q8d7r (unknown [10.110.178.153])
 by director3.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 5AC661FDF4
 for <control <at> debbugs.gnu.org>; Sat, 18 May 2024 13:08:47 +0000 (UTC)
Received: from ngraves.fr ([37.59.142.96])
 by ghost-submission-6684bf9d7b-q8d7r with ESMTPSA
 id qtRVE1+oSGZJbAEAtiunRw (envelope-from <ngraves@HIDDEN>)
 for <control <at> debbugs.gnu.org>; Sat, 18 May 2024 13:08:47 +0000
Authentication-Results: garm.ovh; auth=pass
 (GARM-96R001f88ffbc6-8193-4d33-9739-88f52ffe299f,
 BDB7418199CE68AC6294CEC755C667778ECDC1D2) smtp.auth=ngraves@HIDDEN
X-OVh-ClientIp: 81.67.146.208
From: Nicolas Graves <ngraves@HIDDEN>
To: control <at> debbugs.gnu.org
Subject: control message for bug #70995
Date: Sat, 18 May 2024 15:08:46 +0200
Message-ID: <87wmnrclnl.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Ovh-Tracer-Id: 12132415921319174757
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: 0
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvledrvdehiedggeelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvffufffkgggtsehttdertddttddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepueejleeileejfffhleetjedtleejheevudffleevgfdufeekhefgvddvveegveefnecukfhppeduvdejrddtrddtrddupdekuddrieejrddugeeirddvtdekpdefjedrheelrddugedvrdelieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtoheptghonhhtrhholhesuggvsggsuhhgshdrghhnuhdrohhrghdpoffvtefjohhsthepmhhoheeitddpmhhouggvpehsmhhtphhouhht
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


block 70995 by 71037
quit


-- 
Best regards,
Nicolas Graves

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#71037] [PATCH 0/3] gnu: python-pydevd: Update to 2.9.6.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 21 May 2024 02:43:02 +0000
Resent-Message-ID: <handler.71037.B71037.171625932724091 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 71037
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Nicolas Graves <ngraves@HIDDEN>
Cc: 71037 <at> debbugs.gnu.org
Received: via spool by 71037-submit <at> debbugs.gnu.org id=B71037.171625932724091
          (code B ref 71037); Tue, 21 May 2024 02:43:02 +0000
Received: (at 71037) by debbugs.gnu.org; 21 May 2024 02:42:07 +0000
Received: from localhost ([127.0.0.1]:46384 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s9FS3-0006GV-Io
	for submit <at> debbugs.gnu.org; Mon, 20 May 2024 22:42:07 -0400
Received: from mail-qv1-f53.google.com ([209.85.219.53]:43361)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1s9FRy-0006G1-83
 for 71037 <at> debbugs.gnu.org; Mon, 20 May 2024 22:42:06 -0400
Received: by mail-qv1-f53.google.com with SMTP id
 6a1803df08f44-6a0ffaa079dso30137376d6.1
 for <71037 <at> debbugs.gnu.org>; Mon, 20 May 2024 19:41:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1716259251; x=1716864051; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=X4AndYDVRSWQnV9oJDcTwWzQP1b0uWzuNpGx/F6EsPM=;
 b=WX7o0KGVxUcY46CNWtn+jCsouZgeBBKErWN9l+AaB4Fj51yXN+uQo2IulHvpcSetAI
 SGQpdOE3MTpyFy+o3A+enB+QfLqRaKA+/SWcappMnkShePRo8SyUhVokQy8r1Hzt5Vor
 N+vsYgYq52PD+NAZXt2lvHOGcD5DGiK63pa+eNoGd+wsxtTxHgIo4SZWGNWvgnWb8Dap
 9iErl0qhgzUjKXoQQZb1LuWg+RJM0+X6TyGU0xZz/rWTJHRj9+ppVO5j/x4iMf/1JxYm
 UgwPRcXP25DZ6fb8pPMDgTkcGg9RSIAwzxurzazGTJPbaZrrPF6VJ9Ev+eJcc67GQXG8
 gOOg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1716259251; x=1716864051;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=X4AndYDVRSWQnV9oJDcTwWzQP1b0uWzuNpGx/F6EsPM=;
 b=qC9P7jULiJy6yAi8eQclnCo6ci851ksrd2E58i6YCwZMNE7GKGu0KhMwapFrVBh+Bo
 V077bKyM6TMdSi3bv6tw7R30rjTBtNkECtrIPDYtzKYNXdtSqYrpE07aC0oih6h1GdQp
 cbV8mzvbvE6kIKSXk6rJNpZS70MKOd5vZdv6giwAUmSKMHw9fuPOKxUTU98yq6rF87KA
 JTpA4Jl/30dxfav2JwNeYw8tJX0VqLZ0CSQKmlKWAr2TLLZSDON44zK2TWsAE6M1r7zL
 c0Eji4rs9zYazx6bWmycWNU0jJNEhQJpcbabB7TfV6ExfutVm2dh2P3VeLcI6Meo0QCI
 K8aQ==
X-Gm-Message-State: AOJu0YzRF1TV5x+KX04H8xaC/Xi+aoZ6tx5KG3wcryeZSTHF+l+Lyg6y
 z92cEyZT9UXqJkIOrDZBnmrkUjav+3PQcImQeDWZ6fes+iQPEq2b8DZtuw==
X-Google-Smtp-Source: AGHT+IHN3UdweWcB7J+V/u/O96xHbjXEZmhwDM46GTrnM5iitWdUX3nlE93SF+jmE8pdG7yBwykCBg==
X-Received: by 2002:a05:6214:4808:b0:6aa:2697:2747 with SMTP id
 6a1803df08f44-6aa26973847mr84941626d6.13.1716259251055; 
 Mon, 20 May 2024 19:40:51 -0700 (PDT)
Received: from hurd (dsl-205-233-124-234.b2b2c.ca. [205.233.124.234])
 by smtp.gmail.com with ESMTPSA id
 6a1803df08f44-6a15f1852fdsm119347146d6.32.2024.05.20.19.40.50
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 20 May 2024 19:40:50 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
In-Reply-To: <20240518123734.9898-1-ngraves@HIDDEN> (Nicolas Graves's
 message of "Sat, 18 May 2024 14:35:50 +0200")
References: <20240518123734.9898-1-ngraves@HIDDEN>
Date: Mon, 20 May 2024 22:40:49 -0400
Message-ID: <87a5kjvqdq.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello!

Nicolas Graves <ngraves@HIDDEN> writes:

> Nicolas Graves (3):
>   gnu: python-pydevd: Move to pyproject-build-system.
>   gnu: python-pydevd: Update to 2.9.6.
>   gnu: python-pydevd: Improve package style.
>

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>

Also, thanks for refreshing/resubmitting the pydevd patch to upstream!

-- 
Thanks,
Maxim

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#71037] [PATCH 0/3] gnu: python-pydevd: Update to 2.9.6.
Resent-From: Nicolas Graves <ngraves@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 21 May 2024 07:52:02 +0000
Resent-Message-ID: <handler.71037.B71037.171627790017903 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 71037
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Cc: 71037 <at> debbugs.gnu.org
Received: via spool by 71037-submit <at> debbugs.gnu.org id=B71037.171627790017903
          (code B ref 71037); Tue, 21 May 2024 07:52:02 +0000
Received: (at 71037) by debbugs.gnu.org; 21 May 2024 07:51:40 +0000
Received: from localhost ([127.0.0.1]:47686 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s9KHb-0004eh-Lg
	for submit <at> debbugs.gnu.org; Tue, 21 May 2024 03:51:39 -0400
Received: from 6.mo576.mail-out.ovh.net ([46.105.50.107]:46563)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ngraves@HIDDEN>) id 1s9KHX-0004eZ-0z
 for 71037 <at> debbugs.gnu.org; Tue, 21 May 2024 03:51:37 -0400
Received: from director5.ghost.mail-out.ovh.net (unknown [10.108.17.234])
 by mo576.mail-out.ovh.net (Postfix) with ESMTP id 4Vk6801ppjz1kRS
 for <71037 <at> debbugs.gnu.org>; Tue, 21 May 2024 07:51:28 +0000 (UTC)
Received: from ghost-submission-6684bf9d7b-9ptzg (unknown [10.108.42.124])
 by director5.ghost.mail-out.ovh.net (Postfix) with ESMTPS id DC2B91FEC1;
 Tue, 21 May 2024 07:51:27 +0000 (UTC)
Received: from ngraves.fr ([37.59.142.96])
 by ghost-submission-6684bf9d7b-9ptzg with ESMTPSA
 id KGqXMX9STGa9QwAAY0E/3w
 (envelope-from <ngraves@HIDDEN>); Tue, 21 May 2024 07:51:27 +0000
Authentication-Results: garm.ovh; auth=pass
 (GARM-96R0019e290a93-f894-4001-9522-c4741be27486,
 D87B0241C65384DA2082D9EDB2ADC8E091228B9A) smtp.auth=ngraves@HIDDEN
X-OVh-ClientIp: 81.67.146.208
From: Nicolas Graves <ngraves@HIDDEN>
In-Reply-To: <87a5kjvqdq.fsf@HIDDEN>
References: <20240518123734.9898-1-ngraves@HIDDEN>
 <87a5kjvqdq.fsf@HIDDEN>
Date: Tue, 21 May 2024 09:51:27 +0200
Message-ID: <87bk4zsiv4.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Ovh-Tracer-Id: 5944751510114132552
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: -100
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvledrvdeiuddguddvfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfggtgesthdtredttddttdenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpefhgedtjeevtedvgeelieeugfetvedtleeigeeuhfdvjeetjeejffeuvdeiffdtffenucffohhmrghinhepghhithhhuhgsrdgtohhmnecukfhppeduvdejrddtrddtrddupdekuddrieejrddugeeirddvtdekpdefjedrheelrddugedvrdelieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtohepjedutdefjeesuggvsggsuhhgshdrghhnuhdrohhrghdpoffvtefjohhsthepmhhoheejiedpmhhouggvpehsmhhtphhouhht
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On 2024-05-20 22:40, Maxim Cournoyer wrote:

> Hello!
>
> Nicolas Graves <ngraves@HIDDEN> writes:
>
>> Nicolas Graves (3):
>>   gnu: python-pydevd: Move to pyproject-build-system.
>>   gnu: python-pydevd: Update to 2.9.6.
>>   gnu: python-pydevd: Improve package style.
>>
>
> Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>
>
> Also, thanks for refreshing/resubmitting the pydevd patch to upstream!

As a comment for my debugpy patch : we should probably care about that
too: https://github.com/microsoft/debugpy/issues/1585

Until this gets a proper answer, we should probably only update to
1.8.0, although I don't see why this should really diverge given the
commits.

I can't work on this today, but feel free to rebase the patch in 1.8.0
(should be easy, not much changes). Otherwise, I'll do it, but probably
not before next week.

-- 
Best regards,
Nicolas Graves

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#71037] [PATCH 0/3] gnu: python-pydevd: Update to 2.9.6.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 22 May 2024 00:10:01 +0000
Resent-Message-ID: <handler.71037.B71037.171633654931725 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 71037
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Nicolas Graves <ngraves@HIDDEN>
Cc: 71037 <at> debbugs.gnu.org
Received: via spool by 71037-submit <at> debbugs.gnu.org id=B71037.171633654931725
          (code B ref 71037); Wed, 22 May 2024 00:10:01 +0000
Received: (at 71037) by debbugs.gnu.org; 22 May 2024 00:09:09 +0000
Received: from localhost ([127.0.0.1]:51983 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s9ZXY-0008Fd-PF
	for submit <at> debbugs.gnu.org; Tue, 21 May 2024 20:09:09 -0400
Received: from mail-qt1-f170.google.com ([209.85.160.170]:57455)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1s9ZXV-0008F7-SD
 for 71037 <at> debbugs.gnu.org; Tue, 21 May 2024 20:09:07 -0400
Received: by mail-qt1-f170.google.com with SMTP id
 d75a77b69052e-43dfcbc4893so24184961cf.2
 for <71037 <at> debbugs.gnu.org>; Tue, 21 May 2024 17:09:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1716336474; x=1716941274; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=KSLS3whgfycnNHOJV49muy5zHe0two5CWLfNaVB/PeY=;
 b=VXWJFOASlqtawhMgKCEkcqk8Tj86VSpcfvyvHj9TYwlYBNZmHi6hZTNUDT2Mvz3MpR
 ApPY8cS2EeM9jEPP84J91Mtwfm0QzbzTZNEnmpws7sU2eV+Fl0tXLajOsLHv8OYhBTqp
 dppf4EGz86A+PuGo13MdWVcJnDKT0bxoeLxAi3JYPdzpfn1qgUIGNDqyJSE1ASmh5Svn
 FjyzDDgdyIi06fDOGPEMxzO64+N1LfKVgsoOwTUFV1z+KhyIjToKcpHwEqgReVZwird0
 dzQyeYW0m3BsUpZqLENeavzOC+e/eYOVESTxlX2K4jtDuLa+lEiBd/kgdAbeXT0AVhaA
 Fa5Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1716336474; x=1716941274;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=KSLS3whgfycnNHOJV49muy5zHe0two5CWLfNaVB/PeY=;
 b=bSFx7/WvleGO6CgVZ27CXKrk1Fk63pSW2oKhqq7bxVy+EVfw66yW1cr2MKHaCbKWvU
 PmxHqArt7PSp086uUYKdJYpa2GkpE3zPwuv8acjKMl9Wt09XvsWNLAyaRneuaSi4WxLi
 oDYaxk2TUKK3ORn5uCI65I5BX9Nh9TE1tmcCw/k1WTU3F1Q+Zh0JFBjePn0PxzMSS8yp
 gBP+KQ244KcoDXdQtyqpnSOol7vcH6oLQ+rZLmhHBqY8fWr1WNIvOusYyhvuf5gT3r0h
 7rz/GFVU3uJqKxjb2ZEL+8iLrjPWhqjPSOD4pS2wsjCzDNDJntanH6hDUMkkTQftmrs4
 LvXQ==
X-Gm-Message-State: AOJu0Ywy/rAdatd3d1ARkcZRCzN3KrLlhAd4HCD7wjbTIgxujbEjXgP2
 x66v3sDD0B5d+x7O2BNX7iFMYO3VOlN/q0KOmCDvMcS2E/JWad4QXqQTIw==
X-Google-Smtp-Source: AGHT+IEUGAt2ET9PN6vfLxCeNqf8qrnTaXS3vQ8TOBnEDWxWqOPRhsTtG77FWDS150yL9E7mYJjZ3w==
X-Received: by 2002:a05:622a:490:b0:43e:3935:ad7f with SMTP id
 d75a77b69052e-43f9e1f0e2amr6249601cf.68.1716336473835; 
 Tue, 21 May 2024 17:07:53 -0700 (PDT)
Received: from hurd (dsl-205-233-124-234.b2b2c.ca. [205.233.124.234])
 by smtp.gmail.com with ESMTPSA id
 d75a77b69052e-43df54ef4c9sm164873241cf.30.2024.05.21.17.07.52
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 21 May 2024 17:07:53 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
In-Reply-To: <87bk4zsiv4.fsf@HIDDEN> (Nicolas Graves's message of "Tue, 21
 May 2024 09:51:27 +0200")
References: <20240518123734.9898-1-ngraves@HIDDEN>
 <87a5kjvqdq.fsf@HIDDEN> <87bk4zsiv4.fsf@HIDDEN>
Date: Tue, 21 May 2024 20:07:52 -0400
Message-ID: <87zfsi4skn.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Nicolas,

Nicolas Graves <ngraves@HIDDEN> writes:

> On 2024-05-20 22:40, Maxim Cournoyer wrote:
>
>> Hello!
>>
>> Nicolas Graves <ngraves@HIDDEN> writes:
>>
>>> Nicolas Graves (3):
>>>   gnu: python-pydevd: Move to pyproject-build-system.
>>>   gnu: python-pydevd: Update to 2.9.6.
>>>   gnu: python-pydevd: Improve package style.
>>>
>>
>> Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>
>>
>> Also, thanks for refreshing/resubmitting the pydevd patch to upstream!
>
> As a comment for my debugpy patch : we should probably care about that
> too: https://github.com/microsoft/debugpy/issues/1585
>
> Until this gets a proper answer, we should probably only update to
> 1.8.0, although I don't see why this should really diverge given the
> commits.
>
> I can't work on this today, but feel free to rebase the patch in 1.8.0
> (should be easy, not much changes). Otherwise, I'll do it, but probably
> not before next week.

I'm not in a position to push on this right now, so I'll let you lead
the charge, even if that's in a week or two.  Thanks for doing so!

-- 
Thanks,
Maxim

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#71037] [PATCH 0/3] gnu: python-pydevd: Update to 2.9.6.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 24 Jun 2024 03:14:01 +0000
Resent-Message-ID: <handler.71037.B71037.17191988092065 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 71037
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Nicolas Graves <ngraves@HIDDEN>
Cc: 71037 <at> debbugs.gnu.org
Received: via spool by 71037-submit <at> debbugs.gnu.org id=B71037.17191988092065
          (code B ref 71037); Mon, 24 Jun 2024 03:14:01 +0000
Received: (at 71037) by debbugs.gnu.org; 24 Jun 2024 03:13:29 +0000
Received: from localhost ([127.0.0.1]:35584 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sLa92-0000XE-Rj
	for submit <at> debbugs.gnu.org; Sun, 23 Jun 2024 23:13:29 -0400
Received: from mail-qv1-f41.google.com ([209.85.219.41]:54684)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1sLa90-0000WW-Gu
 for 71037 <at> debbugs.gnu.org; Sun, 23 Jun 2024 23:13:27 -0400
Received: by mail-qv1-f41.google.com with SMTP id
 6a1803df08f44-6b52eb2ee2eso7205036d6.1
 for <71037 <at> debbugs.gnu.org>; Sun, 23 Jun 2024 20:13:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1719198740; x=1719803540; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=oB0B8MYY2ukiVxso5dxn0h/JHvt6a/sqlPn2pwMQXjc=;
 b=XIH/o5w1/rUUgu3uKTHVQTudklFsG85tLSRYkFwUs0HsxLZdyKGNHf2XsgBbjNtsp+
 zEGhGpRTDflbDvzSK54f9EUyG9fNWU5oq1Keg69xMnDOuvZd8oDcFscWB/cYYA43DVer
 USuiBcGUqJgIWzZTzzL1zhbPNwvKwWpTC66r1HzbLzK2qQSCvXayrgpIoKOYmewIYusl
 //MArQs7eXZ1jYtLrB7vT5sw001Gy++PRALmVepUOyq5e+6XKnidwLLovgYcNVIlnuqd
 y2vMzV9axIPQHc03jbcjREs5yfoQdWxudeq8jApzKpQKG+YBbipskh8aB9kwQ9+L069h
 bXKA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1719198740; x=1719803540;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=oB0B8MYY2ukiVxso5dxn0h/JHvt6a/sqlPn2pwMQXjc=;
 b=q/LkqqU9Y0CKCsAySNR06ldoW1AE5sz+Y4tWmWytPklw5w8JaSLfox07dMYp/AGZxN
 8AJkFtzZC1ZfgjGum4DbYiHIFBzEZQI0EBEdj0ZK1htJVkRjMqVezgpvXiJRyw/nBxUM
 WOSZ0mBC6vUeDGqBLpj1bkjEbpvpmJRnjYV4/OcShcL3RkACfpEgaak95pFDTZhn3Yf0
 TlKQy0WsNpVDPFFfDkHvD4eSy2cqQBjHIygcWo5WrUGzYhD+WpDaS/0lJVeMFxX/XFXx
 Ul11nUnMY7V2DB8aDEWae72b5prUDD2r9daEp61N/liy2xOoqm9oZXTfUv5fgrL7O0cE
 fklg==
X-Gm-Message-State: AOJu0Yz4MBluP6x0Eb6SjVd7EdfJQLGA0VODTBPe2NNzDVysCxlxjtQD
 G6yOagmtx3rFXVdG2JHORUrXhZmaY7ZEp7FF4yJgZJYyxVZxZQsI3mJYOdwoKKU=
X-Google-Smtp-Source: AGHT+IEcLZEzCFDd1LV3r5LQ6SZFT9wIQPec+bzAJ7+43tE3xTeoB0Fag+dSPXbkcqNmnGaVoatAtQ==
X-Received: by 2002:a05:6214:1630:b0:6b2:c840:7a2 with SMTP id
 6a1803df08f44-6b540aa8879mr35408776d6.45.1719198739570; 
 Sun, 23 Jun 2024 20:12:19 -0700 (PDT)
Received: from hurd (dsl-205-233-124-241.b2b2c.ca. [205.233.124.241])
 by smtp.gmail.com with ESMTPSA id
 6a1803df08f44-6b51ecfe854sm30535056d6.9.2024.06.23.20.12.18
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 23 Jun 2024 20:12:19 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
In-Reply-To: <87zfsi4skn.fsf@HIDDEN> (Maxim Cournoyer's message of "Tue, 21
 May 2024 20:07:52 -0400")
References: <20240518123734.9898-1-ngraves@HIDDEN>
 <87a5kjvqdq.fsf@HIDDEN> <87bk4zsiv4.fsf@HIDDEN>
 <87zfsi4skn.fsf@HIDDEN>
Date: Sun, 23 Jun 2024 23:12:18 -0400
Message-ID: <87le2v3ugd.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Nicolas,

Maxim Cournoyer <maxim.cournoyer@HIDDEN> writes:

> Hi Nicolas,
>
> Nicolas Graves <ngraves@HIDDEN> writes:
>
>> On 2024-05-20 22:40, Maxim Cournoyer wrote:
>>
>>> Hello!
>>>
>>> Nicolas Graves <ngraves@HIDDEN> writes:
>>>
>>>> Nicolas Graves (3):
>>>>   gnu: python-pydevd: Move to pyproject-build-system.
>>>>   gnu: python-pydevd: Update to 2.9.6.
>>>>   gnu: python-pydevd: Improve package style.
>>>>
>>>
>>> Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>
>>>
>>> Also, thanks for refreshing/resubmitting the pydevd patch to upstream!
>>
>> As a comment for my debugpy patch : we should probably care about that
>> too: https://github.com/microsoft/debugpy/issues/1585
>>
>> Until this gets a proper answer, we should probably only update to
>> 1.8.0, although I don't see why this should really diverge given the
>> commits.
>>
>> I can't work on this today, but feel free to rebase the patch in 1.8.0
>> (should be easy, not much changes). Otherwise, I'll do it, but probably
>> not before next week.
>
> I'm not in a position to push on this right now, so I'll let you lead
> the charge, even if that's in a week or two.  Thanks for doing so!

Did you have a chance to work on this remaining detail?  It's a great
series!

-- 
Thanks,
Maxim

Last modified: Mon, 24 Jun 2024 03:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.