GNU logs - #71209, boring messages


Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses
Resent-From: Noah Peart <noah.v.peart@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 26 May 2024 12:43:01 +0000
Resent-Message-ID: <handler.71209.B.17167273263151 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 71209
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: 71209 <at> debbugs.gnu.org
X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.17167273263151
          (code B ref -1); Sun, 26 May 2024 12:43:01 +0000
Received: (at submit) by debbugs.gnu.org; 26 May 2024 12:42:06 +0000
Received: from localhost ([127.0.0.1]:38559 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sBDCP-0000ol-Fy
	for submit <at> debbugs.gnu.org; Sun, 26 May 2024 08:42:05 -0400
Received: from lists.gnu.org ([209.51.188.17]:58364)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <noah.v.peart@HIDDEN>) id 1sBDCM-0000oc-Cv
 for submit <at> debbugs.gnu.org; Sun, 26 May 2024 08:42:03 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <noah.v.peart@HIDDEN>)
 id 1sBDCD-0008Pp-W7
 for bug-gnu-emacs@HIDDEN; Sun, 26 May 2024 08:41:54 -0400
Received: from mail-oa1-x30.google.com ([2001:4860:4864:20::30])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <noah.v.peart@HIDDEN>)
 id 1sBDCC-0004b2-7J
 for bug-gnu-emacs@HIDDEN; Sun, 26 May 2024 08:41:53 -0400
Received: by mail-oa1-x30.google.com with SMTP id
 586e51a60fabf-24ca03ad307so1386397fac.3
 for <bug-gnu-emacs@HIDDEN>; Sun, 26 May 2024 05:41:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1716727309; x=1717332109; darn=gnu.org;
 h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
 :date:message-id:reply-to;
 bh=+WlLBGcgI/UkQrJb9hrktJOzR9r3qgx+AmdM9cEqZnQ=;
 b=RfvuYh1XtxYj63fwxyVXp1NiDtaYfkZ2pohR2hEVRZaHldN/vJC9gRsXqvmQAjNK9z
 X3GSO6G10IPXteMhEFKxs4hDSdWmnhbbV+I0+entCFZbiRaLY+Xv6MG6xiYJFTuNU/SC
 hba1YgaJ8+UxvEdsgDL5Gaarr3CLzei3V2ft5LsG/el4OXmJVdgUkjFTrCElUkjUS2ox
 sAMntibtEKzL1NP1G0yeCDCLmSdgAesC14hq0P7XasLC8gzEdII1CC+Lw2ogmtpxULjf
 jcw0eBvpaCWNrvZUENO0j388R4BaliUJ4HdKCS6KjR77Xj/eRpc6CnAxUu1fzWyefZjN
 pa9Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1716727309; x=1717332109;
 h=to:subject:message-id:date:from:mime-version:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=+WlLBGcgI/UkQrJb9hrktJOzR9r3qgx+AmdM9cEqZnQ=;
 b=lFqkrPP50bSCSDPa78tQXvpLcU0e8BGTip82t7LeU87Ad1JtTHOIAuwz1QH2jue4aX
 w8vT8ZRu+7cfE+ShRj2QM0XTZQpcE6h93faUG+ibjuVk6nkIMxHuKFkFGHRcjqvJuesK
 RH6OACe97cQ2D75D7Es7j6wDqdCt0nPAwkNztQDP5HLZXiEy8aLg5Sc0Esk1miZazI2W
 qOxF8pam66iNs1v65GJRmx2h95EmKQEMaP4xNjzrY5/E+HpvOBc2JLGcX//aLNkniRJc
 A8/S1I+kqCYTeWN13lRARlUofNZUBG1BC2xxkBOiQYblTR7XRTedcQYF79RUioVYCGqy
 ZkYQ==
X-Gm-Message-State: AOJu0YyYaBFirrQeeLk+Ef+D4LMavxUObLGFqoyxZhgS+wXW+VgbWaKL
 JRCK8gnjk/4STSymJYWsTc71n0KYNqZgVKFfvEao/h8Ly4MK50ssctW5WQAjLr2IbSoSr4rHjuP
 BFM3FI4cawprlBwDoBkkxag/kwI6ZJYBPVOHa+w==
X-Google-Smtp-Source: AGHT+IFyXfhfa3cRlHA1Fx0FNvljCB+SnGPWyUzRbL/NZoYFBBH074FOBfJBNcLO4f1VdhFxri8YxZjC4gYeSNz6W0I=
X-Received: by 2002:a05:6870:718f:b0:24d:c894:81f6 with SMTP id
 586e51a60fabf-24dc8948c59mr5469057fac.33.1716727308710; Sun, 26 May 2024
 05:41:48 -0700 (PDT)
MIME-Version: 1.0
From: Noah Peart <noah.v.peart@HIDDEN>
Date: Sun, 26 May 2024 05:41:37 -0700
Message-ID: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN>
Content-Type: multipart/mixed; boundary="00000000000069cead06195ab9f9"
Received-SPF: pass client-ip=2001:4860:4864:20::30;
 envelope-from=noah.v.peart@HIDDEN; helo=mail-oa1-x30.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

--00000000000069cead06195ab9f9
Content-Type: multipart/alternative; boundary="00000000000069ceab06195ab9f7"

--00000000000069ceab06195ab9f7
Content-Type: text/plain; charset="UTF-8"

Tags: patch

Adds font-locking rule in go-ts-mode to give variables in range clauses
font-lock-variable-name-face (in feature 'definition).

For example, the following font-locking is added:

for idx, val := range arr {}
//     ^ font-lock-variable-name-face
//           ^ font-lock-variable-name-face

The patch also adds a test case.


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2024-05-21 built on noah-X580VD
Repository revision: 63d914e377f7cc37056de2503bfbeea831875037
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.4 LTS

Configured using:
 'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'

--00000000000069ceab06195ab9f7
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Tags: patch<br><br>Adds font-locking rule in go-ts-mode to=
 give variables in range clauses<br>font-lock-variable-name-face (in featur=
e &#39;definition).<br><br>For example, the following font-locking is added=
:<br><br>for idx, val :=3D range arr {}<br>//=C2=A0 =C2=A0 =C2=A0^ font-loc=
k-variable-name-face<br>//=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^ font-l=
ock-variable-name-face<br><br>The patch also adds a test case.<br><br><br>I=
n GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version<br>3.24.33,=
 cairo version 1.16.0) of 2024-05-21 built on noah-X580VD<br>Repository rev=
ision: 63d914e377f7cc37056de2503bfbeea831875037<br>Repository branch: maste=
r<br>Windowing system distributor &#39;The X.Org Foundation&#39;, version 1=
1.0.12101004<br>System Description: Ubuntu 22.04.4 LTS<br><br>Configured us=
ing:<br>=C2=A0&#39;configure --prefix=3D/usr/local --with-modules --with-tr=
ee-sitter<br>--with-threads --with-x-toolkit=3Dgtk3 --with-xwidgets --with-=
gnutls<br>--with-json --with-mailutils --with-jpeg --with-png --with-rsvg<b=
r>--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=3Dgcc-12<br>CXX=
=3Dgcc-12&#39;<br></div>

--00000000000069ceab06195ab9f7--

--00000000000069cead06195ab9f9
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-Add-font-locking-for-variables-in-go-ts-mode-range-c.patch"
Content-Disposition: attachment; 
	filename="0001-Add-font-locking-for-variables-in-go-ts-mode-range-c.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lwnj2otl0>
X-Attachment-Id: f_lwnj2otl0

RnJvbSAxYjZiMmE3MDAxZmYwNzlkODFhZjdkNDJjN2VlOThlOGU3MzE4MzkwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FoIFBlYXJ0IDxub2FoLnYucGVhcnRAZ21haWwuY29tPgpE
YXRlOiBTdW4sIDI2IE1heSAyMDI0IDA1OjM0OjM0IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gQWRk
IGZvbnQtbG9ja2luZyBmb3IgdmFyaWFibGVzIGluIGdvLXRzLW1vZGUgcmFuZ2UgY2xhdXNlcwoK
KiBsaXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLmVsIChnby10cy1tb2RlLS1mb250LWxvY2stc2V0
dGluZ3MpOgpBZGQgZm9udC1sb2NraW5nIHJ1bGUgZm9yIHZhcmlhYmxlIG5hbWVzIGluIHJhbmdl
IGNsYXVzZXMuCiogdGVzdC9saXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLXRlc3RzLmVsIChnby10
cy10ZXN0LWZvbnQtbG9jayk6CkFkZCBmb250LWxvY2tpbmcgdGVzdCBmb3IgZ28tdHMtbW9kZS4K
KiB0ZXN0L2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUtcmVzb3VyY2VzL2ZvbnQtbG9jay5nbzog
TmV3IGZpbGUKZm9yIGdvLXRzLW1vZGUgZm9udC1sb2NraW5nIHRlc3RzLgotLS0KIGxpc3AvcHJv
Z21vZGVzL2dvLXRzLW1vZGUuZWwgICAgICAgICAgICAgICAgICAgICAgICAgIHwgNSArKysrLQog
dGVzdC9saXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLXJlc291cmNlcy9mb250LWxvY2suZ28gfCA1
ICsrKysrCiB0ZXN0L2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUtdGVzdHMuZWwgICAgICAgICAg
ICAgICB8IDUgKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMSBkZWxl
dGlvbigtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IHRlc3QvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9k
ZS1yZXNvdXJjZXMvZm9udC1sb2NrLmdvCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvZ28t
dHMtbW9kZS5lbCBiL2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUuZWwKaW5kZXggYWVmMjI0YWIz
ZmEuLjQzZjdlMDQyNTkwIDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLmVs
CisrKyBiL2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUuZWwKQEAgLTE4MCw3ICsxODAsMTAgQEAg
Z28tdHMtbW9kZS0tZm9udC1sb2NrLXNldHRpbmdzCiAgICAgICAgICAgICAgKGlkZW50aWZpZXIp
IEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlCiAgICAgICAgICAgICAgKCIsIiAoaWRlbnRp
ZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpKikpCiAgICAgICh2YXJfc3BlYyBu
YW1lOiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UKLSAgICAgICAg
ICAgICAgICgiLCIgbmFtZTogKGlkZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1m
YWNlKSopKQorICAgICAgICAgICAgICAgKCIsIiBuYW1lOiAoaWRlbnRpZmllcikgQGZvbnQtbG9j
ay12YXJpYWJsZS1uYW1lLWZhY2UpKikKKyAgICAgKHJhbmdlX2NsYXVzZQorICAgICAgbGVmdDog
KGV4cHJlc3Npb25fbGlzdAorICAgICAgICAgICAgIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZh
cmlhYmxlLW5hbWUtZmFjZSkpKQogCiAgICA6bGFuZ3VhZ2UgJ2dvCiAgICA6ZmVhdHVyZSAnZnVu
Y3Rpb24KZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS1yZXNvdXJj
ZXMvZm9udC1sb2NrLmdvIGIvdGVzdC9saXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLXJlc291cmNl
cy9mb250LWxvY2suZ28KbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLjRl
N2E4ZTE3MTBiCi0tLSAvZGV2L251bGwKKysrIGIvdGVzdC9saXNwL3Byb2dtb2Rlcy9nby10cy1t
b2RlLXJlc291cmNlcy9mb250LWxvY2suZ28KQEAgLTAsMCArMSw1IEBACitmb3IgaWR4LCB2YWwg
Oj0gcmFuZ2UgYXJyIHt9CisvLyAgIF4gZm9udC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFjZQorLy8g
ICAgICAgIF4gZm9udC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFjZQorZm9yIGlkeCA6PSAwOyBpZHgg
PCBuOyBpZHgrKyB7fQorLy8gICBeIGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UKZGlmZiAt
LWdpdCBhL3Rlc3QvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS10ZXN0cy5lbCBiL3Rlc3QvbGlz
cC9wcm9nbW9kZXMvZ28tdHMtbW9kZS10ZXN0cy5lbAppbmRleCBmZDliNTdlODY5MS4uZjM2ZGJk
ZTUxMDMgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS10ZXN0cy5l
bAorKysgYi90ZXN0L2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUtdGVzdHMuZWwKQEAgLTI3LDUg
KzI3LDEwIEBAIGdvLXRzLW1vZGUtdGVzdC1pbmRlbnRhdGlvbgogICAoc2tpcC11bmxlc3MgKHRy
ZWVzaXQtcmVhZHktcCAnZ28pKQogICAoZXJ0LXRlc3QtZXJ0cy1maWxlIChlcnQtcmVzb3VyY2Ut
ZmlsZSAiaW5kZW50LmVydHMiKSkpCiAKKyhlcnQtZGVmdGVzdCBnby10cy10ZXN0LWZvbnQtbG9j
ayAoKQorICAoc2tpcC11bmxlc3MgKHRyZWVzaXQtcmVhZHktcCAnZ28pKQorICAobGV0ICgodHJl
ZXNpdC1mb250LWxvY2stbGV2ZWwgNCkpCisgICAgKGVydC1mb250LWxvY2stdGVzdC1maWxlIChl
cnQtcmVzb3VyY2UtZmlsZSAiZm9udC1sb2NrLmdvIikgJ2dvLXRzLW1vZGUpKSkKKwogKHByb3Zp
ZGUgJ2dvLXRzLW1vZGUtdGVzdHMpCiA7OzsgZ28tdHMtbW9kZS10ZXN0cy5lbCBlbmRzIGhlcmUK
LS0gCjIuMzQuMQoK
--00000000000069cead06195ab9f9--




Message sent:


Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Noah Peart <noah.v.peart@HIDDEN>
Subject: bug#71209: Acknowledgement ([PATCH] Add font-locking for
 variables in go-ts-mode range clauses)
Message-ID: <handler.71209.B.17167273263151.ack <at> debbugs.gnu.org>
References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN>
X-Gnu-PR-Message: ack 71209
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 71209 <at> debbugs.gnu.org
Date: Sun, 26 May 2024 12:43:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 71209 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
71209: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D71209
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems


Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses
Resent-From: Randy Taylor <dev@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 28 May 2024 02:47:01 +0000
Resent-Message-ID: <handler.71209.B71209.171686438715669 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 71209
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Noah Peart <noah.v.peart@HIDDEN>
Cc: 71209 <at> debbugs.gnu.org
Received: via spool by 71209-submit <at> debbugs.gnu.org id=B71209.171686438715669
          (code B ref 71209); Tue, 28 May 2024 02:47:01 +0000
Received: (at 71209) by debbugs.gnu.org; 28 May 2024 02:46:27 +0000
Received: from localhost ([127.0.0.1]:45516 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sBmr4-00044f-LI
	for submit <at> debbugs.gnu.org; Mon, 27 May 2024 22:46:26 -0400
Received: from mail-4022.proton.ch ([185.70.40.22]:52925)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dev@HIDDEN>) id 1sBmr1-00044N-2R
 for 71209 <at> debbugs.gnu.org; Mon, 27 May 2024 22:46:26 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev;
 s=protonmail2; t=1716864363; x=1717123563;
 bh=N1QGXRemRF2J5rKXqYeR0b80xI35O5zRAjuq8kN51AQ=;
 h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
 Message-ID:BIMI-Selector;
 b=OXjsbNw1ZEfV5ZUXJfHCiL4h5OBakfAU6iv/ST/lojDhLNcIxCYuvE1dGYH7xe6Ia
 TZQCUkWc9astfywG8EWAlFJzh4/4RIrJk/3KRpvMhvwIj+3b/a4ZvsM0tCvzRlBZi0
 QjfkuK0WNC0F94HilIAG0SXJXp8S0N9Zu2Jp6cbGFds3NpZ5z81mygvg9FZO5RGXOf
 YAifBytv2oN1GIzxT3cR9NeuuzjpxllnaJ1y9X5Up4KlSjfhphktvT+mv/Ii7G8p2l
 DZlQFMvEaWa0ORL32fMvF0yzsLkENdDF/GK4xw4ONurXVkKsa9OXi//1clf1B5pYfB
 gUymRhlpGn9tA==
Date: Tue, 28 May 2024 02:46:00 +0000
From: Randy Taylor <dev@HIDDEN>
Message-ID: <Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev>
In-Reply-To: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN>
References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN>
Feedback-ID: 44397038:user:proton
X-Pm-Message-ID: d5cea780f4fcbdb4435617335e287ecfdd06ca95
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Sunday, May 26th, 2024 at 08:41, Noah Peart <noah.v.peart@HIDDEN> wro=
te:

> Tags: patch
>=20
> Adds font-locking rule in go-ts-mode to give variables in range clauses
> font-lock-variable-name-face (in feature 'definition).
>=20
> For example, the following font-locking is added:
>=20
> for idx, val :=3D range arr {}
> // ^ font-lock-variable-name-face
> // ^ font-lock-variable-name-face
>=20
> The patch also adds a test case.
>=20
>=20
> In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
> 3.24.33, cairo version 1.16.0) of 2024-05-21 built on noah-X580VD
> Repository revision: 63d914e377f7cc37056de2503bfbeea831875037
> Repository branch: master
> Windowing system distributor 'The X.Org Foundation', version 11.0.1210100=
4
> System Description: Ubuntu 22.04.4 LTS
>=20
> Configured using:
> 'configure --prefix=3D/usr/local --with-modules --with-tree-sitter
> --with-threads --with-x-toolkit=3Dgtk3 --with-xwidgets --with-gnutls
> --with-json --with-mailutils --with-jpeg --with-png --with-rsvg
> --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=3Dgcc-12
> CXX=3Dgcc-12'

Thanks, but it seems we already highlight this when at treesit-font-lock-le=
vel 4?




Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses
Resent-From: Noah Peart <noah.v.peart@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 30 May 2024 13:28:01 +0000
Resent-Message-ID: <handler.71209.B71209.17170756512838 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 71209
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Randy Taylor <dev@HIDDEN>
Cc: 71209 <at> debbugs.gnu.org
Received: via spool by 71209-submit <at> debbugs.gnu.org id=B71209.17170756512838
          (code B ref 71209); Thu, 30 May 2024 13:28:01 +0000
Received: (at 71209) by debbugs.gnu.org; 30 May 2024 13:27:31 +0000
Received: from localhost ([127.0.0.1]:35651 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sCfoY-0000ji-Ro
	for submit <at> debbugs.gnu.org; Thu, 30 May 2024 09:27:31 -0400
Received: from mail-oi1-f175.google.com ([209.85.167.175]:55643)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <noah.v.peart@HIDDEN>) id 1sCfoT-0000jI-Mz
 for 71209 <at> debbugs.gnu.org; Thu, 30 May 2024 09:27:29 -0400
Received: by mail-oi1-f175.google.com with SMTP id
 5614622812f47-3c9b94951d5so383643b6e.3
 for <71209 <at> debbugs.gnu.org>; Thu, 30 May 2024 06:27:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1717075569; x=1717680369; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=zLoJ695Dhyl9jOOzoLFTrePqRinS4WgFdU28Twg+fnA=;
 b=W3A5ETchCGr42XFZIcJUhF5GhzoptGDIttqB3/j3BbVNsPrHQeUIAqIHbJGd5YHHyc
 3mr04OjpdIhgxeVtFeZeFGbV9h+Y6SlPmK0YnqXCIT6zsCq3rDqIu00U10sDf8cAmFIO
 +bqn0VmxiNqO+aTSnVLMnw82SxQqUkqvNOFW6jlWTfR87+TSmQ3KrrrnMKQ00+5rDGq9
 cEu59SdvqvthyzBMfhbxYk/TezTZ4/NkDIRnsH/HZgrhev6hGLrzqi79nrqVNVd6Rmtx
 wBid5ebMINYRDOhlMfIHcbBTACExHNLcGdEkZy6+kffw39DTJ2dzQjm0+7++yuTnjw0Q
 Q91w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1717075569; x=1717680369;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=zLoJ695Dhyl9jOOzoLFTrePqRinS4WgFdU28Twg+fnA=;
 b=Fg/tUmCFqpz7W9RirL0Opn9zGVUTxigalZcdgClzouKwZw1VmwjvvpNvHUepqe9foB
 GQ3XgwDpg0cM1nD9FoMs+SEwbKMdMlS4g46e+NKXGnbx36OSi7Bq7AQDsuvx0exTw8qh
 lQKc4bQ7wKE8HRMXh5r+CkAbCsFi8glOvGWXdRvx7BtqaWVviM2zh8UU0+ORpFuDpgrU
 cI+mAs/4rJycqMNTDBQgNwZxqgv9IqhZB+brXNc+dztVYJmzbEic/iumxvCKzWtVlw79
 zFPkaMmZzM8zg3AOhiYQGJHnqyhgaTF/fZDfxHJseqpuHFx7xQxrLYMwkAvKuQw3u3jK
 GLFw==
X-Gm-Message-State: AOJu0Yyz2Sga5OSRXMaA2nsRg/D/P2FB/3G24R/cEuLE9jHUaqLlbD6k
 sFLU/ZhphQIKL1uZjQHHuZa5IfXlL+ukq6LAmqyNtduqBSfiGgh+XkO/hxRdBGCvgCnyH2AibfK
 xyd2ChjzD8l7t/1GDixNcxy7yrKPXe8oOEjBGkQ==
X-Google-Smtp-Source: AGHT+IEiN7eynwJmNS0RAv2Srmki8hYbnWzLon3ZwbNarzGRIypYiTA+OTJEL4CGcsIvlv0GWu63WallyLdtTRdFYcw=
X-Received: by 2002:a05:6808:1a:b0:3d1:be9f:c9a3 with SMTP id
 5614622812f47-3d1dcbe9aaemr2101806b6e.0.1717075567894; Thu, 30 May 2024
 06:26:07 -0700 (PDT)
MIME-Version: 1.0
References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN>
 <Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev>
In-Reply-To: <Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev>
From: Noah Peart <noah.v.peart@HIDDEN>
Date: Thu, 30 May 2024 06:25:56 -0700
Message-ID: <CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@HIDDEN>
Content-Type: multipart/alternative; boundary="00000000000046e5730619abcf0b"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--00000000000046e5730619abcf0b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

> it seems we already highlight this when at treesit-font-lock-level 4?

They get highlighted with `font-lock-variable-use-face` at level 4, but
shouldn't
they be getting `font-lock-variable-name-face` in the 'definition feature?

On Mon, May 27, 2024 at 7:46=E2=80=AFPM Randy Taylor <dev@HIDDEN> wrote:

> On Sunday, May 26th, 2024 at 08:41, Noah Peart <noah.v.peart@HIDDEN>
> wrote:
>
> > Tags: patch
> >
> > Adds font-locking rule in go-ts-mode to give variables in range clauses
> > font-lock-variable-name-face (in feature 'definition).
> >
> > For example, the following font-locking is added:
> >
> > for idx, val :=3D range arr {}
> > // ^ font-lock-variable-name-face
> > // ^ font-lock-variable-name-face
> >
> > The patch also adds a test case.
> >
> >
> > In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
> > 3.24.33, cairo version 1.16.0) of 2024-05-21 built on noah-X580VD
> > Repository revision: 63d914e377f7cc37056de2503bfbeea831875037
> > Repository branch: master
> > Windowing system distributor 'The X.Org Foundation', version
> 11.0.12101004
> > System Description: Ubuntu 22.04.4 LTS
> >
> > Configured using:
> > 'configure --prefix=3D/usr/local --with-modules --with-tree-sitter
> > --with-threads --with-x-toolkit=3Dgtk3 --with-xwidgets --with-gnutls
> > --with-json --with-mailutils --with-jpeg --with-png --with-rsvg
> > --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=3Dgcc-12
> > CXX=3Dgcc-12'
>
> Thanks, but it seems we already highlight this when at
> treesit-font-lock-level 4?
>

--00000000000046e5730619abcf0b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">&gt; it seems we already highlight this when at treesit-fo=
nt-lock-level 4?<div><br></div><div>They get highlighted with `font-lock-va=
riable-use-face` at level 4, but shouldn&#39;t</div><div>they be getting `f=
ont-lock-variable-name-face` in the &#39;definition feature?</div></div><br=
><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, M=
ay 27, 2024 at 7:46=E2=80=AFPM Randy Taylor &lt;<a href=3D"mailto:dev@HIDDEN=
ev">dev@HIDDEN</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" s=
tyle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pad=
ding-left:1ex">On Sunday, May 26th, 2024 at 08:41, Noah Peart &lt;<a href=
=3D"mailto:noah.v.peart@HIDDEN" target=3D"_blank">noah.v.peart@HIDDEN=
</a>&gt; wrote:<br>
<br>
&gt; Tags: patch<br>
&gt; <br>
&gt; Adds font-locking rule in go-ts-mode to give variables in range clause=
s<br>
&gt; font-lock-variable-name-face (in feature &#39;definition).<br>
&gt; <br>
&gt; For example, the following font-locking is added:<br>
&gt; <br>
&gt; for idx, val :=3D range arr {}<br>
&gt; // ^ font-lock-variable-name-face<br>
&gt; // ^ font-lock-variable-name-face<br>
&gt; <br>
&gt; The patch also adds a test case.<br>
&gt; <br>
&gt; <br>
&gt; In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version<br>
&gt; 3.24.33, cairo version 1.16.0) of 2024-05-21 built on noah-X580VD<br>
&gt; Repository revision: 63d914e377f7cc37056de2503bfbeea831875037<br>
&gt; Repository branch: master<br>
&gt; Windowing system distributor &#39;The X.Org Foundation&#39;, version 1=
1.0.12101004<br>
&gt; System Description: Ubuntu 22.04.4 LTS<br>
&gt; <br>
&gt; Configured using:<br>
&gt; &#39;configure --prefix=3D/usr/local --with-modules --with-tree-sitter=
<br>
&gt; --with-threads --with-x-toolkit=3Dgtk3 --with-xwidgets --with-gnutls<b=
r>
&gt; --with-json --with-mailutils --with-jpeg --with-png --with-rsvg<br>
&gt; --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=3Dgcc-12<br>
&gt; CXX=3Dgcc-12&#39;<br>
<br>
Thanks, but it seems we already highlight this when at treesit-font-lock-le=
vel 4?<br>
</blockquote></div>

--00000000000046e5730619abcf0b--





Last modified: Thu, 30 May 2024 13:30:03 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.