Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 71209) by debbugs.gnu.org; 24 Dec 2024 03:03:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Dec 23 22:03:05 2024 Received: from localhost ([127.0.0.1]:58813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tPvCL-0003PI-1b for submit <at> debbugs.gnu.org; Mon, 23 Dec 2024 22:03:05 -0500 Received: from mail-ed1-f48.google.com ([209.85.208.48]:58429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tPvCI-0003Ol-5w for 71209 <at> debbugs.gnu.org; Mon, 23 Dec 2024 22:03:03 -0500 Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5d414b8af7bso8911263a12.0 for <71209 <at> debbugs.gnu.org>; Mon, 23 Dec 2024 19:03:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735009316; x=1735614116; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=sfEtA1yRk2TcQxfJtq3UZ4XzZM7jpt9kNChDk9P/arU=; b=SIp5JVRRpyst2iso95qocDLNmE6P2eeCw8XlN4WcK25AcPDpdekV1dHZFvAob/FSej RC1r05fANuMJus7CpAkY7DaitltUxOCWU0KFyFF/XJHYy+gcF0ox8m/KvbkWpSGq5tJ2 lQMw45Amjbg07WWufDztsR9ILaKCriXNT3SH30ZUNdjEkDLKpZ2C2D71GZPq88Nbw1uT bZLPLomQCtpkjzCaBzOYJfVBBcRyXYBoqiL78DdoykTRgLr9+MMSa8u5SqHNl111y3qv MdhSG/JfFp/Yh2aQGeDVSCZJhVta1Uj9kJtalg3TUsL9KUnN2MWyI4oL96IkdoOgsLVW a4KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735009316; x=1735614116; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sfEtA1yRk2TcQxfJtq3UZ4XzZM7jpt9kNChDk9P/arU=; b=u5jDAr2kKYag28Wgq/HE3FXln+qyKEtglcZbgPaDS/jo2qbV70gHSoQJ3meMGOX6ge dz2APSgZQG54NbERcgCJ40rJswMdZbuTuKUhLMPawTpWAjNgNaG5SV09lUIXA1FY1tnU LzGzMWACZBwBnFgHpZN47KOIZRuMgMzlVn5r5L+a3xQVjiSygaTQWhdfJwzj3s2ZZB51 q7+a6GE/L3zAOiBoZKwfEfpaTqrPJpePNDOl8n29GxHisCzlNBbQo7X0MtKg3RVoNaft vSfF192de+KqVoxcFvOdmGo3gum4ACNrAiNhJoFOB/i1QOYoQbGg93tjmN17CK1HkmqO ROzA== X-Forwarded-Encrypted: i=1; AJvYcCWJP9U1rOElvNbUve5hcAPBWKR6UPL+RPmXnfB8Dz5P776Aui8d0C7P/OdQ5tlbqVYrNEbJIA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yw3dUr8vEEGph2aQ90jsY+SZi6Pcc9WZtHvxxJEJNIf0t+zitcK ngDYLK4c6VShQnf/pxwCOliTcn/GxHNabmeX1SY4RU8nRbVBWf9Un9iBm2RHbaST/sIyj36lSC0 4UGF2NEgnq2obTizp7NusgIw53pQ= X-Gm-Gg: ASbGncvKukWa92AdJQc8Hg0iXgykhtpRXVSlg2e7NRGotEhL8MrU9C7l1QA1ExVmALY gihdGwxVUQ0lw4zBo4sgXK40ifQpuMfQAivrRW8g= X-Google-Smtp-Source: AGHT+IG+K5pFN8qlkJrrtXALcueu9+6wtmLu3PP3zKEoZ0zaTHLG4Qbl7i9g51WIN+5sFVLypPAsFAgnj9HLXvhBC90= X-Received: by 2002:a05:6402:4402:b0:5d2:60d9:a2a0 with SMTP id 4fb4d7f45d1cf-5d81de5d896mr14124017a12.33.1735009316435; Mon, 23 Dec 2024 19:01:56 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 24 Dec 2024 03:01:56 +0000 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <CAPVBTSfYEumHZeHRg4Bqnju4z--iG2ufLvwCyGC7OML0pAZHKQ@HIDDEN> (Noah Peart's message of "Thu, 27 Jun 2024 05:29:21 -0400") References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN> <Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev> <CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@HIDDEN> <AdChXDjyAulWCxyswxNe-7IMxwPnhNsGnE-QxJ3BN3-HqbU3GhOFti8yQLH_D-euvftZoKEHO6Bvwb1gXojFkT4JhTstpo8Ad-Dqp7nhebE=@rjt.dev> <CAPVBTSfxgw35QaZYJ1VDEGxG=X7tt4bq7LT5ah2MiyDq8pX7kw@HIDDEN> <6769ff22-14d3-4c6a-b0a2-dd53ec717f15@HIDDEN> <8634pewsej.fsf@HIDDEN> <8634oy7s3s.fsf@HIDDEN> <CAPVBTSfYEumHZeHRg4Bqnju4z--iG2ufLvwCyGC7OML0pAZHKQ@HIDDEN> MIME-Version: 1.0 Date: Tue, 24 Dec 2024 03:01:56 +0000 Message-ID: <CADwFkm=vRZSSeP-iGyn6L6e9+Kh9k61BozKca6piRN2v0iTxng@HIDDEN> Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses To: Noah Peart <noah.v.peart@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 71209 Cc: 71209 <at> debbugs.gnu.org, dmitry@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, dev@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.3 (/) Noah Peart <noah.v.peart@HIDDEN> writes: > Ah yes, sorry to be slow, I can submit a patch for those settings. I'll = take a look today! Any updates here? Thanks! > > On Thu, Jun 27, 2024 at 3:38=E2=80=AFAM Eli Zaretskii <eliz@HIDDEN> wrot= e: > > Ping! Ping! Noah, are you still interested in working on this? > > > Cc: 71209 <at> debbugs.gnu.org, dev@HIDDEN > > Date: Sat, 15 Jun 2024 10:56:36 +0300 > > From: Eli Zaretskii <eliz@HIDDEN> > > > > Ping! Noah, would you please answer Dmitry? > > > > > Cc: 71209 <at> debbugs.gnu.org > > > Date: Sat, 1 Jun 2024 17:13:57 +0300 > > > From: Dmitry Gutov <dmitry@HIDDEN> > > > > > > On 01/06/2024 04:42, Noah Peart wrote: > > > > > > > > I've been using these for c++, I think they are still missing > > > > > > > > ;; for (auto x: ...) > > > > (for_range_loop > > > > declarator: (identifier) @font-lock-variable-name-face) > > > > ;; auto& x > > > > (reference_declarator > > > > (identifier) @font-lock-variable-name-face) > > > > ;; auto[&] [x, y] > > > > (structured_binding_declarator > > > > _ [(identifier)] @font-lock-variable-name-face) > > > > > > > > I suppose most people keep the default font-locking for variable-n= ame > > > > and variable-use, so these missing rules go unnoticed. > > > > > > Do you want to submit a full patch with these as well? > > > > > > > > > > > > > > > > > > > >
bug-gnu-emacs@HIDDEN:bug#71209; Package emacs.
Full text available.Received: (at 71209) by debbugs.gnu.org; 4 Aug 2024 07:53:07 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 04 03:53:07 2024 Received: from localhost ([127.0.0.1]:55369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1saW38-0004rA-V7 for submit <at> debbugs.gnu.org; Sun, 04 Aug 2024 03:53:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1saW36-0004qR-Cy for 71209 <at> debbugs.gnu.org; Sun, 04 Aug 2024 03:53:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1saW2g-0002sw-5j; Sun, 04 Aug 2024 03:52:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=t5aBKW/kRpov25HVPS+QhLLiE85rIBP4yVivrRvXRPM=; b=Hea6T7ntjzusGgQj8OJl +0jaI/C/H8w7YN6jLqv8GbhSTZlUPagLHHkdy7edO8vys+nLcNxeiY9HldqSk1irGjSK8AB5TV4kP cAsfM2gluDdTflRKRFLh1/ByQOBTZsj4/N1bfIw56jFPZpQ16apt3abPDSA7z6s4dYBMwjkHcrzm1 u7UouYSpeFU2KrQFlEWvfaLowtRVjfh4Ik523aMMyc780uQlrAkDJRbLeSs58A/77ddLEv0YoZCPa nvVdKKmXKzNJVF/Dpvh1jWUytTUFkFaolKD82z3uuErFCqHGhcs3LhgYflA5ZW3wzrQb0hJVMpKKB ZqCoXEyulXncNw==; Date: Sun, 04 Aug 2024 10:52:36 +0300 Message-Id: <8634nku3ln.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: noah.v.peart@HIDDEN In-Reply-To: <867cdge6xj.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 20 Jul 2024 12:42:00 +0300) Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN> <Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev> <CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@HIDDEN> <AdChXDjyAulWCxyswxNe-7IMxwPnhNsGnE-QxJ3BN3-HqbU3GhOFti8yQLH_D-euvftZoKEHO6Bvwb1gXojFkT4JhTstpo8Ad-Dqp7nhebE=@rjt.dev> <CAPVBTSfxgw35QaZYJ1VDEGxG=X7tt4bq7LT5ah2MiyDq8pX7kw@HIDDEN> <6769ff22-14d3-4c6a-b0a2-dd53ec717f15@HIDDEN> <8634pewsej.fsf@HIDDEN> <8634oy7s3s.fsf@HIDDEN> <CAPVBTSfYEumHZeHRg4Bqnju4z--iG2ufLvwCyGC7OML0pAZHKQ@HIDDEN> <86a5iv55ej.fsf@HIDDEN> <867cdge6xj.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71209 Cc: 71209 <at> debbugs.gnu.org, dmitry@HIDDEN, dev@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Ping! Ping! Ping! Noah, are you there? > Cc: 71209 <at> debbugs.gnu.org, dmitry@HIDDEN, dev@HIDDEN > Date: Sat, 20 Jul 2024 12:42:00 +0300 > From: Eli Zaretskii <eliz@HIDDEN> > > Ping! Ping! Can we please make some progress here? > > > Cc: 71209 <at> debbugs.gnu.org, dmitry@HIDDEN, dev@HIDDEN > > Date: Sat, 06 Jul 2024 10:46:44 +0300 > > From: Eli Zaretskii <eliz@HIDDEN> > > > > Ping! Any progress with this? > > > > > From: Noah Peart <noah.v.peart@HIDDEN> > > > Date: Thu, 27 Jun 2024 05:29:21 -0400 > > > Cc: dmitry@HIDDEN, 71209 <at> debbugs.gnu.org, dev@HIDDEN > > > > > > Ah yes, sorry to be slow, I can submit a patch for those settings. I'll take a look today! > > > > > > On Thu, Jun 27, 2024 at 3:38 AM Eli Zaretskii <eliz@HIDDEN> wrote: > > > > > > Ping! Ping! Noah, are you still interested in working on this? > > > > > > > Cc: 71209 <at> debbugs.gnu.org, dev@HIDDEN > > > > Date: Sat, 15 Jun 2024 10:56:36 +0300 > > > > From: Eli Zaretskii <eliz@HIDDEN> > > > > > > > > Ping! Noah, would you please answer Dmitry? > > > > > > > > > Cc: 71209 <at> debbugs.gnu.org > > > > > Date: Sat, 1 Jun 2024 17:13:57 +0300 > > > > > From: Dmitry Gutov <dmitry@HIDDEN> > > > > > > > > > > On 01/06/2024 04:42, Noah Peart wrote: > > > > > > > > > > > > I've been using these for c++, I think they are still missing > > > > > > > > > > > > ;; for (auto x: ...) > > > > > > (for_range_loop > > > > > > declarator: (identifier) @font-lock-variable-name-face) > > > > > > ;; auto& x > > > > > > (reference_declarator > > > > > > (identifier) @font-lock-variable-name-face) > > > > > > ;; auto[&] [x, y] > > > > > > (structured_binding_declarator > > > > > > _ [(identifier)] @font-lock-variable-name-face) > > > > > > > > > > > > I suppose most people keep the default font-locking for variable-name > > > > > > and variable-use, so these missing rules go unnoticed. > > > > > > > > > > Do you want to submit a full patch with these as well? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
bug-gnu-emacs@HIDDEN:bug#71209; Package emacs.
Full text available.Received: (at 71209) by debbugs.gnu.org; 20 Jul 2024 09:42:12 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 20 05:42:12 2024 Received: from localhost ([127.0.0.1]:51737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sV6bU-0007xQ-8G for submit <at> debbugs.gnu.org; Sat, 20 Jul 2024 05:42:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sV6bR-0007xB-Mk for 71209 <at> debbugs.gnu.org; Sat, 20 Jul 2024 05:42:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sV6bM-0001al-0g; Sat, 20 Jul 2024 05:42:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=2en4q05iKy0aFnzZbEuhtPkXxc30UXy58409k+Mj9BY=; b=d+kQsOGG+3joUNL4IwoZ MDp8M2fn48LEWIBtZdBmOZ6La/PomT53d3Cjecx7//yKRn8gB5UV2nViaXFPLDj8mECMI78kTWvzn RgXFYYg7/CVgvIjrqDUHmT1wuufj16oWuDOP+qe4ml6QbM9IBbXJ8bWxADphQuZl1ghKgA6VUHNxO yagqaEUeQjGmCXeQNi82bkhgQQC9hb3nt68et77+gc3aqP2vrwQX0uUPOQGZ4E1b9sexrD5ToIl9e IwYiUOBo9ZRhqT+79xDJlh3ChQByQAJoEJKwLCsfvUPAn2yn7v6YOW7SrKGeExmxPcVz+c3R3P/ER BXpX8rafGQZI5Q==; Date: Sat, 20 Jul 2024 12:42:00 +0300 Message-Id: <867cdge6xj.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: noah.v.peart@HIDDEN In-Reply-To: <86a5iv55ej.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 06 Jul 2024 10:46:44 +0300) Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN> <Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev> <CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@HIDDEN> <AdChXDjyAulWCxyswxNe-7IMxwPnhNsGnE-QxJ3BN3-HqbU3GhOFti8yQLH_D-euvftZoKEHO6Bvwb1gXojFkT4JhTstpo8Ad-Dqp7nhebE=@rjt.dev> <CAPVBTSfxgw35QaZYJ1VDEGxG=X7tt4bq7LT5ah2MiyDq8pX7kw@HIDDEN> <6769ff22-14d3-4c6a-b0a2-dd53ec717f15@HIDDEN> <8634pewsej.fsf@HIDDEN> <8634oy7s3s.fsf@HIDDEN> <CAPVBTSfYEumHZeHRg4Bqnju4z--iG2ufLvwCyGC7OML0pAZHKQ@HIDDEN> <86a5iv55ej.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71209 Cc: 71209 <at> debbugs.gnu.org, dmitry@HIDDEN, dev@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Ping! Ping! Can we please make some progress here? > Cc: 71209 <at> debbugs.gnu.org, dmitry@HIDDEN, dev@HIDDEN > Date: Sat, 06 Jul 2024 10:46:44 +0300 > From: Eli Zaretskii <eliz@HIDDEN> > > Ping! Any progress with this? > > > From: Noah Peart <noah.v.peart@HIDDEN> > > Date: Thu, 27 Jun 2024 05:29:21 -0400 > > Cc: dmitry@HIDDEN, 71209 <at> debbugs.gnu.org, dev@HIDDEN > > > > Ah yes, sorry to be slow, I can submit a patch for those settings. I'll take a look today! > > > > On Thu, Jun 27, 2024 at 3:38 AM Eli Zaretskii <eliz@HIDDEN> wrote: > > > > Ping! Ping! Noah, are you still interested in working on this? > > > > > Cc: 71209 <at> debbugs.gnu.org, dev@HIDDEN > > > Date: Sat, 15 Jun 2024 10:56:36 +0300 > > > From: Eli Zaretskii <eliz@HIDDEN> > > > > > > Ping! Noah, would you please answer Dmitry? > > > > > > > Cc: 71209 <at> debbugs.gnu.org > > > > Date: Sat, 1 Jun 2024 17:13:57 +0300 > > > > From: Dmitry Gutov <dmitry@HIDDEN> > > > > > > > > On 01/06/2024 04:42, Noah Peart wrote: > > > > > > > > > > I've been using these for c++, I think they are still missing > > > > > > > > > > ;; for (auto x: ...) > > > > > (for_range_loop > > > > > declarator: (identifier) @font-lock-variable-name-face) > > > > > ;; auto& x > > > > > (reference_declarator > > > > > (identifier) @font-lock-variable-name-face) > > > > > ;; auto[&] [x, y] > > > > > (structured_binding_declarator > > > > > _ [(identifier)] @font-lock-variable-name-face) > > > > > > > > > > I suppose most people keep the default font-locking for variable-name > > > > > and variable-use, so these missing rules go unnoticed. > > > > > > > > Do you want to submit a full patch with these as well? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
bug-gnu-emacs@HIDDEN:bug#71209; Package emacs.
Full text available.Received: (at 71209) by debbugs.gnu.org; 6 Jul 2024 07:46:58 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 06 03:46:58 2024 Received: from localhost ([127.0.0.1]:45514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sQ08H-0005Yz-IX for submit <at> debbugs.gnu.org; Sat, 06 Jul 2024 03:46:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sQ08F-0005Ym-N2 for 71209 <at> debbugs.gnu.org; Sat, 06 Jul 2024 03:46:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sQ086-0005gy-K1; Sat, 06 Jul 2024 03:46:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=tPC4y8jJ5IxSAwN10gGlmS85B3F8BnFvzlTDX6ZAhdE=; b=C2xBIIIVSC5qUJZYclcP He1yA6W8PQq04tTlEeveuZZOpMgh3Dlz/0s3bumnkQUrLVLb7P3igh4ctz/wkD98ny4fp+SAop/If XVgmfwgx7qsOcYYj/OKOE/DRyUF7HaNfG9ahlncC+0Hl+qlAnKw3HwnD3S6RBENJy0ilNkyzKD+Mk CrNK2MuAjDuh6QDd5CZlUCqLrUb25CHBnHoJvn9K1faoa4lasLM6EdJtODGv4fy1YiHTh8JWuPAii E/DR9Se/dZaeX5fYXXzUO6+uJrjZlLLHJ/Fz1gGbOUzEv+I+Xs/LUYF20pobpoum6iKe6Ahe9bXIm aBYkEx2hhUocHg==; Date: Sat, 06 Jul 2024 10:46:44 +0300 Message-Id: <86a5iv55ej.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Noah Peart <noah.v.peart@HIDDEN> In-Reply-To: <CAPVBTSfYEumHZeHRg4Bqnju4z--iG2ufLvwCyGC7OML0pAZHKQ@HIDDEN> (message from Noah Peart on Thu, 27 Jun 2024 05:29:21 -0400) Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN> <Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev> <CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@HIDDEN> <AdChXDjyAulWCxyswxNe-7IMxwPnhNsGnE-QxJ3BN3-HqbU3GhOFti8yQLH_D-euvftZoKEHO6Bvwb1gXojFkT4JhTstpo8Ad-Dqp7nhebE=@rjt.dev> <CAPVBTSfxgw35QaZYJ1VDEGxG=X7tt4bq7LT5ah2MiyDq8pX7kw@HIDDEN> <6769ff22-14d3-4c6a-b0a2-dd53ec717f15@HIDDEN> <8634pewsej.fsf@HIDDEN> <8634oy7s3s.fsf@HIDDEN> <CAPVBTSfYEumHZeHRg4Bqnju4z--iG2ufLvwCyGC7OML0pAZHKQ@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71209 Cc: 71209 <at> debbugs.gnu.org, dmitry@HIDDEN, dev@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Ping! Any progress with this? > From: Noah Peart <noah.v.peart@HIDDEN> > Date: Thu, 27 Jun 2024 05:29:21 -0400 > Cc: dmitry@HIDDEN, 71209 <at> debbugs.gnu.org, dev@HIDDEN > > Ah yes, sorry to be slow, I can submit a patch for those settings. I'll take a look today! > > On Thu, Jun 27, 2024 at 3:38 AM Eli Zaretskii <eliz@HIDDEN> wrote: > > Ping! Ping! Noah, are you still interested in working on this? > > > Cc: 71209 <at> debbugs.gnu.org, dev@HIDDEN > > Date: Sat, 15 Jun 2024 10:56:36 +0300 > > From: Eli Zaretskii <eliz@HIDDEN> > > > > Ping! Noah, would you please answer Dmitry? > > > > > Cc: 71209 <at> debbugs.gnu.org > > > Date: Sat, 1 Jun 2024 17:13:57 +0300 > > > From: Dmitry Gutov <dmitry@HIDDEN> > > > > > > On 01/06/2024 04:42, Noah Peart wrote: > > > > > > > > I've been using these for c++, I think they are still missing > > > > > > > > ;; for (auto x: ...) > > > > (for_range_loop > > > > declarator: (identifier) @font-lock-variable-name-face) > > > > ;; auto& x > > > > (reference_declarator > > > > (identifier) @font-lock-variable-name-face) > > > > ;; auto[&] [x, y] > > > > (structured_binding_declarator > > > > _ [(identifier)] @font-lock-variable-name-face) > > > > > > > > I suppose most people keep the default font-locking for variable-name > > > > and variable-use, so these missing rules go unnoticed. > > > > > > Do you want to submit a full patch with these as well? > > > > > > > > > > > > > > > > > > > >
bug-gnu-emacs@HIDDEN:bug#71209; Package emacs.
Full text available.Received: (at 71209) by debbugs.gnu.org; 27 Jun 2024 09:30:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 27 05:30:43 2024 Received: from localhost ([127.0.0.1]:41016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sMlSl-0000X8-8t for submit <at> debbugs.gnu.org; Thu, 27 Jun 2024 05:30:43 -0400 Received: from mail-oa1-f50.google.com ([209.85.160.50]:45548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <noah.v.peart@HIDDEN>) id 1sMlSj-0000Wv-99 for 71209 <at> debbugs.gnu.org; Thu, 27 Jun 2024 05:30:42 -0400 Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-25c95299166so3882223fac.3 for <71209 <at> debbugs.gnu.org>; Thu, 27 Jun 2024 02:30:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719480573; x=1720085373; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=uu9URVVf2zfw8ZH72aZLjeuYKiosdBUzYW5BbAjmWtw=; b=iMBypmeznzVrdshp98YgXuXvc1lIhbDnh2CFzGXpuPaU1s1oDNEt1/i76aY3cn9he1 pNZk7qpcx6oZ3w6ReQDLbCtBZu2Xc/0ayWTiT5ex7qATqryEw4clRGBCqt8WaGgGAMnr hEf8SyBoBSHwJSPmSDT7xaCfXVxT6eju5M5D5VeyoIon3wYPP8zDJt+RI8RdK9AsDF/9 IaeogS7iIRFbzoFgpvX//B1DfkfnR2aJuOlsXEBvszrDpN1QrFchqmICNw6JQMVg6dDJ yyFQzr0aMkBgN3QdfJ0EnkwVJCedHBIfJEAl/bZzdoa1Jp5nA2MV89Z/nREL79JwLPOX fSmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719480573; x=1720085373; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uu9URVVf2zfw8ZH72aZLjeuYKiosdBUzYW5BbAjmWtw=; b=dECw6Tqbqc9rc2mgwO2U1j0OL0sVqTKr/k4KcrlekMady37ObOJxJ9PMmsGyQvVRDA Rvo4sTeDed83pYQ5YFUmXlK+aBMLC74B+4yBcp38ZGmz/vQbC9IXTcNqAmiOpTRBMfGG TpPftG+SGa79saZrTl/LmJSEKvxzeQqBdI6OC8MoYZz0zs4/Ba9crFA+N6LoydxmceVE XdxVDnQWp5cdFRMeZw39SkaU1a4rY0Wdn3gQdXatubgWHnFUw6If5DDJiOWMPtag2OJs hVCKoZlLdhXAO+dpqQHPlAJCBIW1ix7h9DzRFvsmZf2PLpLlZsKw8KbovhThIB0lQPSe FqGg== X-Forwarded-Encrypted: i=1; AJvYcCX9vpnfy7oaXsKnSyAETko2oC717yHqPm6TdKHEWtcer4RK7LHInfgFYBAsInltu1r/FQVKjJNMwWPKtOhXdqcgnWvSOuM= X-Gm-Message-State: AOJu0Yzruk4OX0opMAwAqwVlEZIv/LK+n7L8z4QtEUgRUzuGz7bnHHwb NNChrYY8zH2vWVdpOisQ3GhScO0EGt/l0UW+3x5rng0OpU0BdGA69ZXsezLNHYf3JMWQIs49psK gENdiGTqdc0/E6553/knpPVmDh1k= X-Google-Smtp-Source: AGHT+IEFAA8LDXtHGaniBqAYQ9kebzptGEDO2gdraPZGyEUawgxPnBNMn0P+RPPJSuKC3w5EWrA12n+rv5LykT71gN8= X-Received: by 2002:a05:6870:5a90:b0:258:42c8:867f with SMTP id 586e51a60fabf-25cfce0118dmr9791743fac.20.1719480572525; Thu, 27 Jun 2024 02:29:32 -0700 (PDT) MIME-Version: 1.0 References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN> <Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev> <CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@HIDDEN> <AdChXDjyAulWCxyswxNe-7IMxwPnhNsGnE-QxJ3BN3-HqbU3GhOFti8yQLH_D-euvftZoKEHO6Bvwb1gXojFkT4JhTstpo8Ad-Dqp7nhebE=@rjt.dev> <CAPVBTSfxgw35QaZYJ1VDEGxG=X7tt4bq7LT5ah2MiyDq8pX7kw@HIDDEN> <6769ff22-14d3-4c6a-b0a2-dd53ec717f15@HIDDEN> <8634pewsej.fsf@HIDDEN> <8634oy7s3s.fsf@HIDDEN> In-Reply-To: <8634oy7s3s.fsf@HIDDEN> From: Noah Peart <noah.v.peart@HIDDEN> Date: Thu, 27 Jun 2024 05:29:21 -0400 Message-ID: <CAPVBTSfYEumHZeHRg4Bqnju4z--iG2ufLvwCyGC7OML0pAZHKQ@HIDDEN> Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses To: Eli Zaretskii <eliz@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000b946be061bdbc44c" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71209 Cc: 71209 <at> debbugs.gnu.org, dmitry@HIDDEN, dev@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000b946be061bdbc44c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ah yes, sorry to be slow, I can submit a patch for those settings. I'll take a look today! On Thu, Jun 27, 2024 at 3:38=E2=80=AFAM Eli Zaretskii <eliz@HIDDEN> wrote: > Ping! Ping! Noah, are you still interested in working on this? > > > Cc: 71209 <at> debbugs.gnu.org, dev@HIDDEN > > Date: Sat, 15 Jun 2024 10:56:36 +0300 > > From: Eli Zaretskii <eliz@HIDDEN> > > > > Ping! Noah, would you please answer Dmitry? > > > > > Cc: 71209 <at> debbugs.gnu.org > > > Date: Sat, 1 Jun 2024 17:13:57 +0300 > > > From: Dmitry Gutov <dmitry@HIDDEN> > > > > > > On 01/06/2024 04:42, Noah Peart wrote: > > > > > > > > I've been using these for c++, I think they are still missing > > > > > > > > ;; for (auto x: ...) > > > > (for_range_loop > > > > declarator: (identifier) @font-lock-variable-name-face) > > > > ;; auto& x > > > > (reference_declarator > > > > (identifier) @font-lock-variable-name-face) > > > > ;; auto[&] [x, y] > > > > (structured_binding_declarator > > > > _ [(identifier)] @font-lock-variable-name-face) > > > > > > > > I suppose most people keep the default font-locking for variable-na= me > > > > and variable-use, so these missing rules go unnoticed. > > > > > > Do you want to submit a full patch with these as well? > > > > > > > > > > > > > > > > > > > > > --000000000000b946be061bdbc44c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Ah yes, sorry to=C2=A0be slow, I can submit a patch for th= ose settings.=C2=A0 I'll take a look today!</div><br><div class=3D"gmai= l_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, Jun 27, 2024 at 3:38= =E2=80=AFAM Eli Zaretskii <<a href=3D"mailto:eliz@HIDDEN">eliz@HIDDEN<= /a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0= px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">P= ing! Ping!=C2=A0 Noah, are you still interested in working on this?<br> <br> > Cc: <a href=3D"mailto:71209 <at> debbugs.gnu.org" target=3D"_blank">71209@d= ebbugs.gnu.org</a>, <a href=3D"mailto:dev@HIDDEN" target=3D"_blank">dev@rj= t.dev</a><br> > Date: Sat, 15 Jun 2024 10:56:36 +0300<br> > From: Eli Zaretskii <<a href=3D"mailto:eliz@HIDDEN" target=3D"_bla= nk">eliz@HIDDEN</a>><br> > <br> > Ping!=C2=A0 Noah, would you please answer Dmitry?<br> > <br> > > Cc: <a href=3D"mailto:71209 <at> debbugs.gnu.org" target=3D"_blank">71= 209 <at> debbugs.gnu.org</a><br> > > Date: Sat, 1 Jun 2024 17:13:57 +0300<br> > > From: Dmitry Gutov <<a href=3D"mailto:dmitry@HIDDEN" target= =3D"_blank">dmitry@HIDDEN</a>><br> > > <br> > > On 01/06/2024 04:42, Noah Peart wrote:<br> > > > <br> > > > I've been using these for c++, I think they are still mi= ssing<br> > > > <br> > > >=C2=A0 =C2=A0 =C2=A0 ;; for (auto x: ...)<br> > > >=C2=A0 =C2=A0 =C2=A0 (for_range_loop<br> > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0declarator: (identifier) @font-loc= k-variable-name-face)<br> > > >=C2=A0 =C2=A0 =C2=A0 ;; auto& x<br> > > >=C2=A0 =C2=A0 =C2=A0 (reference_declarator<br> > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0(identifier) @font-lock-variable-n= ame-face)<br> > > >=C2=A0 =C2=A0 =C2=A0 ;; auto[&] [x, y]<br> > > >=C2=A0 =C2=A0 =C2=A0 (structured_binding_declarator<br> > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0_ [(identifier)] @font-lock-variab= le-name-face)<br> > > > <br> > > > I suppose most people keep the default font-locking for vari= able-name<br> > > > and variable-use, so these missing rules go unnoticed.<br> > > <br> > > Do you want to submit a full patch with these as well?<br> > > <br> > > <br> > > <br> > > <br> > <br> > <br> > <br> > <br> </blockquote></div> --000000000000b946be061bdbc44c--
bug-gnu-emacs@HIDDEN:bug#71209; Package emacs.
Full text available.Received: (at 71209) by debbugs.gnu.org; 27 Jun 2024 07:38:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 27 03:38:44 2024 Received: from localhost ([127.0.0.1]:40900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sMjiO-00063S-Fh for submit <at> debbugs.gnu.org; Thu, 27 Jun 2024 03:38:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sMjiM-00063G-IN for 71209 <at> debbugs.gnu.org; Thu, 27 Jun 2024 03:38:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sMjiE-0002Be-Fr; Thu, 27 Jun 2024 03:38:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=VHKFeXfyHIBHV52aW2azH4lFDRYGSAsOTqzIWV6sVwg=; b=Q19u+32n8UhW9Km1xzSU 6YTUwKWLDOkjdi+0eWv8PHVB+rde6A+HG9WH9EScw4p+78erhPbqZ/HWoPhOgVk4UyQoztsACNVCM GEMNgQ6m+jmavQIljsWwK6SIFNKgdBlnhHMAf6vonprZRDoUjX+aRB7DftLdU8Ab7fDdPjcqNfMtj cf8tiiF7CUYD5Q7uIeneZR5AfChxLmsnzUXaNJsUl8+xbR9b21gh4DVqdFcbot9PQpvRvItH25sMb sInobJ6vTbfWKtGRSJmLBWiLq35WZpJQbUkpGY8tZASfBmZjfKHj7Rws4DkGWapv72QQDExtzGE8n H8UBkWvf9qFk+A==; Date: Thu, 27 Jun 2024 10:38:31 +0300 Message-Id: <8634oy7s3s.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: noah.v.peart@HIDDEN In-Reply-To: <8634pewsej.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 15 Jun 2024 10:56:36 +0300) Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN> <Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev> <CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@HIDDEN> <AdChXDjyAulWCxyswxNe-7IMxwPnhNsGnE-QxJ3BN3-HqbU3GhOFti8yQLH_D-euvftZoKEHO6Bvwb1gXojFkT4JhTstpo8Ad-Dqp7nhebE=@rjt.dev> <CAPVBTSfxgw35QaZYJ1VDEGxG=X7tt4bq7LT5ah2MiyDq8pX7kw@HIDDEN> <6769ff22-14d3-4c6a-b0a2-dd53ec717f15@HIDDEN> <8634pewsej.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71209 Cc: 71209 <at> debbugs.gnu.org, dmitry@HIDDEN, dev@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Ping! Ping! Noah, are you still interested in working on this? > Cc: 71209 <at> debbugs.gnu.org, dev@HIDDEN > Date: Sat, 15 Jun 2024 10:56:36 +0300 > From: Eli Zaretskii <eliz@HIDDEN> > > Ping! Noah, would you please answer Dmitry? > > > Cc: 71209 <at> debbugs.gnu.org > > Date: Sat, 1 Jun 2024 17:13:57 +0300 > > From: Dmitry Gutov <dmitry@HIDDEN> > > > > On 01/06/2024 04:42, Noah Peart wrote: > > > > > > I've been using these for c++, I think they are still missing > > > > > > ;; for (auto x: ...) > > > (for_range_loop > > > declarator: (identifier) @font-lock-variable-name-face) > > > ;; auto& x > > > (reference_declarator > > > (identifier) @font-lock-variable-name-face) > > > ;; auto[&] [x, y] > > > (structured_binding_declarator > > > _ [(identifier)] @font-lock-variable-name-face) > > > > > > I suppose most people keep the default font-locking for variable-name > > > and variable-use, so these missing rules go unnoticed. > > > > Do you want to submit a full patch with these as well? > > > > > > > > > > > >
bug-gnu-emacs@HIDDEN:bug#71209; Package emacs.
Full text available.Received: (at 71209) by debbugs.gnu.org; 15 Jun 2024 07:56:59 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 15 03:56:59 2024 Received: from localhost ([127.0.0.1]:51670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sIOHS-00031G-Jq for submit <at> debbugs.gnu.org; Sat, 15 Jun 2024 03:56:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sIOHQ-00030q-1t for 71209 <at> debbugs.gnu.org; Sat, 15 Jun 2024 03:56:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sIOHK-00080B-4O; Sat, 15 Jun 2024 03:56:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=D+5C+tk8RUI29NUAUU/HFg9Qlbtk4dC05laz6IDRu4M=; b=l7E8bZkVnbXoOQ+WR3Jd KHwJVVEO9GVvaUGUf5aFH9Rc5bhqEwicX//KhGn+BjdKvHRbVsOrc/TwuuRspTuLgonUMHPy1TQhl JbZGhfZnbr43IeM9R5JRj+C4QE9qdHb0BnxAnmYRfVNW5fpCCMnQtKXcHIM0hwCbhEWXlBSk9KIsi Yxn1vKO4/wJ2lHfPZgv0kzfyjSp85SKROWVe3EzeJEAfpVlRqa4fmBsVS3uWCKjJ7RQfx+d0C3cee OxU2ev7iZeWZMCRXRXhAhfOiF6QgEqbcAGuEj4N+iEjEVqCL1PTLiRo/feV8TT0tngoWz01JioLj7 WAyzQguw7Yk9Nw==; Date: Sat, 15 Jun 2024 10:56:36 +0300 Message-Id: <8634pewsej.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: noah.v.peart@HIDDEN, Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <6769ff22-14d3-4c6a-b0a2-dd53ec717f15@HIDDEN> (message from Dmitry Gutov on Sat, 1 Jun 2024 17:13:57 +0300) Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN> <Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev> <CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@HIDDEN> <AdChXDjyAulWCxyswxNe-7IMxwPnhNsGnE-QxJ3BN3-HqbU3GhOFti8yQLH_D-euvftZoKEHO6Bvwb1gXojFkT4JhTstpo8Ad-Dqp7nhebE=@rjt.dev> <CAPVBTSfxgw35QaZYJ1VDEGxG=X7tt4bq7LT5ah2MiyDq8pX7kw@HIDDEN> <6769ff22-14d3-4c6a-b0a2-dd53ec717f15@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71209 Cc: 71209 <at> debbugs.gnu.org, dev@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Ping! Noah, would you please answer Dmitry? > Cc: 71209 <at> debbugs.gnu.org > Date: Sat, 1 Jun 2024 17:13:57 +0300 > From: Dmitry Gutov <dmitry@HIDDEN> > > On 01/06/2024 04:42, Noah Peart wrote: > > > > I've been using these for c++, I think they are still missing > > > > ;; for (auto x: ...) > > (for_range_loop > > declarator: (identifier) @font-lock-variable-name-face) > > ;; auto& x > > (reference_declarator > > (identifier) @font-lock-variable-name-face) > > ;; auto[&] [x, y] > > (structured_binding_declarator > > _ [(identifier)] @font-lock-variable-name-face) > > > > I suppose most people keep the default font-locking for variable-name > > and variable-use, so these missing rules go unnoticed. > > Do you want to submit a full patch with these as well? > > > >
bug-gnu-emacs@HIDDEN:bug#71209; Package emacs.
Full text available.Received: (at 71209) by debbugs.gnu.org; 1 Jun 2024 14:14:19 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 01 10:14:19 2024 Received: from localhost ([127.0.0.1]:56972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sDPUx-0006zC-Hs for submit <at> debbugs.gnu.org; Sat, 01 Jun 2024 10:14:19 -0400 Received: from wfout1-smtp.messagingengine.com ([64.147.123.144]:54151) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1sDPUw-0006z1-Jq for 71209 <at> debbugs.gnu.org; Sat, 01 Jun 2024 10:14:19 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfout.west.internal (Postfix) with ESMTP id 377551C00098; Sat, 1 Jun 2024 10:14:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 01 Jun 2024 10:14:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1717251240; x=1717337640; bh=gm9BMq3NYxWbRO0yRmvWaiJJk5g3cyabmui+Buq0hm0=; b= h4pvoninMm+dMDmckzoCI8WAplCpn75J8AYv6mc7mR2RnOV94OjmfiquEg6xLYgT FZSW87eDQOUzp3PChji3Jhj0zWA1PngCcT5k7YgT3upxepBhOdqlJJbHSZUFwQu2 WvBewIUSA9lPZrrZ86EWRy4KAzYD9mS7ArQ9nyZu5+dv+JuOPjt+UxnMXWDbnDWG HrRRsNaZ4YEPy1/BRgBHKJna0hm0FvXTv2j7UOj1R7mKuHnWilZdqTxjMC5ifxYW OuT6z8E6Igv6Z0M9ZE3A6WcEsHLMIcowiiFKOb1jnGnlCiRDWbyswTUgOCxIuOr/ VcFx1HJF16bSEzSV/oV+Mw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1717251240; x= 1717337640; bh=gm9BMq3NYxWbRO0yRmvWaiJJk5g3cyabmui+Buq0hm0=; b=B nfH8MhVtbdrkN8aBZowHt015+nPxUMMlkgi/sWF8tDx6Rc83jfapXi4em2PekJ7o k4LR3hjFqaTDTpHIPhjZxgHl7M+kpEmX8n7rEsGKLU4jZQraQpwcN+NC77ecv4iU I7BxqxO816MOqjVycsEvKFfuUfyahoPWnGae+knmyVOswZHQlrQYRj9hiWjnkQ7L w5V+IVe00BMvLzi3V1PSfPqeeXwNw8waG+HIcdleAhQLZGG3lV0JIXP7znmUn3H7 UUHnhBXWD4sdDo/L8OsfLMgGkHYBj7Uh/IsCNCuHQO+cimg13A1fewWk0zZaN/ki p8CyZl158stxzSA1aHnzg== X-ME-Sender: <xms:qCxbZh-jqQJaLBrvXOZBUiNit3JkqP0V7csiuC1rUbZiSvsSkEwhRw> <xme:qCxbZltqUhVdezPRobUv8nuTxmahbqrF0VnwxoZZacP6ka8L0J_ugiE5kh6MO2kka iZoQWzi6KTRAMcuuMk> X-ME-Received: <xmr:qCxbZvBi6QxPm2J1RuL29oz5kcYxPSix-b2oCokzfUpqw9nmmp96cGtyL4UPI0KlrtRa> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdekkedgjeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepgeelfeetkefghfdvhfdtgeevveevteetgeetveegtedthefhudekteehffeu keeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: <xmx:qCxbZlcsZshynBJcjAPhGq0vC-UKj7KZir3uYMZfq22U0l9pOVxe_A> <xmx:qCxbZmPPzq0WaOu9-bWnMUHquh6b6rjP7lj7dK6DomvDS73ZC4Lbvg> <xmx:qCxbZnnbi1m6okcTVpvnv3h6KFkhLGRnqb80AzlSpMbEjC3YDEBkmg> <xmx:qCxbZgu65HvLlUHXkg2tbyeOkIuQt-oABw6EydpGYk0IhI1iw85V2A> <xmx:qCxbZjrXfC2lJCFz2JCxBQ2pD4wyWUgx2VFSx5csCVJy0b9YHXa0JEUE> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 1 Jun 2024 10:13:59 -0400 (EDT) Message-ID: <6769ff22-14d3-4c6a-b0a2-dd53ec717f15@HIDDEN> Date: Sat, 1 Jun 2024 17:13:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses To: Noah Peart <noah.v.peart@HIDDEN>, Randy Taylor <dev@HIDDEN> References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN> <Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev> <CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@HIDDEN> <AdChXDjyAulWCxyswxNe-7IMxwPnhNsGnE-QxJ3BN3-HqbU3GhOFti8yQLH_D-euvftZoKEHO6Bvwb1gXojFkT4JhTstpo8Ad-Dqp7nhebE=@rjt.dev> <CAPVBTSfxgw35QaZYJ1VDEGxG=X7tt4bq7LT5ah2MiyDq8pX7kw@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <CAPVBTSfxgw35QaZYJ1VDEGxG=X7tt4bq7LT5ah2MiyDq8pX7kw@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71209 Cc: 71209 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 01/06/2024 04:42, Noah Peart wrote: > > I've been using these for c++, I think they are still missing > > ;; for (auto x: ...) > (for_range_loop > declarator: (identifier) @font-lock-variable-name-face) > ;; auto& x > (reference_declarator > (identifier) @font-lock-variable-name-face) > ;; auto[&] [x, y] > (structured_binding_declarator > _ [(identifier)] @font-lock-variable-name-face) > > I suppose most people keep the default font-locking for variable-name > and variable-use, so these missing rules go unnoticed. Do you want to submit a full patch with these as well?
bug-gnu-emacs@HIDDEN:bug#71209; Package emacs.
Full text available.Received: (at 71209) by debbugs.gnu.org; 1 Jun 2024 14:13:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 01 10:13:38 2024 Received: from localhost ([127.0.0.1]:56967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sDPUI-0006xm-5a for submit <at> debbugs.gnu.org; Sat, 01 Jun 2024 10:13:38 -0400 Received: from wfout1-smtp.messagingengine.com ([64.147.123.144]:58575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1sDPUF-0006xX-7i for 71209 <at> debbugs.gnu.org; Sat, 01 Jun 2024 10:13:36 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfout.west.internal (Postfix) with ESMTP id 62CBF1C000CD; Sat, 1 Jun 2024 10:13:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 01 Jun 2024 10:13:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1717251197; x=1717337597; bh=V+3+DQnYlInqN4NfQVZZjBjhjCcJtwZH2UQ44uRjXbA=; b= N8TKp0z7sCEmR+Qb7YP+pbDukP1fV6rWyIjTlz/+XQDYGhsMxLSvpUmY8DvzfnNO 5I+ODrqFcFS1BAmPZcXeLT7VIxbFs9QE7ubg6pldkVjh87xgRwu3tJAkAwJbdkKc 95fv+t4qinJGiC+rdGjGw1YFphAJ0uhUa+A8HzRLJu3fSjydNZ8CJ+zTnGaMTXIG 5ME4gm3zAmTIyOaraZ7ZgzTijUufSbMAccrvQ4tKXADKzF84vRoleJ4RCdnOPVZr T4AzPuZG9BOXwVV0ZNr5VohsEVes+Ze0eFHfn0ZNRfqhaoBcdFPidJyO/vp8PG9y TjUM0tB6yGGJ1e44a8g4Iw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1717251197; x= 1717337597; bh=V+3+DQnYlInqN4NfQVZZjBjhjCcJtwZH2UQ44uRjXbA=; b=Q DTggoodBP9xiaanK+6oIDPt6wxqlBAFSONXzbaR126NN2E85yFBafIE6F9go0cjX qEZJtvfPmCP05AudLWZr0L2tSGPhWlAyTu1hqSHI55Yyxxey8s0QhPX0epChJL6z PLeWMduirVpJOtFGOWVg4IKbK6EkaaWn1YgBCBUzx8O2ziFr/HkB5XB7FNOEHFAD QrLXiIXOpORSs0nXL5L9oAB2QoG2BxPOc3GtboTY/Zvn0+oUp1amkFRFpQzwyqNy 8oANCFkniY1qjib8zk2A84fhA6iguQefcSMWisu2EYUWwh2foa9QJpIPMbylpY48 IiWxx0SpbvmH6BX0+w8tg== X-ME-Sender: <xms:fCxbZlSLgCO6u0K6_Du1ZeDB0tN2_Pjgwj841AozRfWscftDp6iylA> <xme:fCxbZuzmTiw7YOKftlj4bvLpv7FGUGc-mNYyQ_qvpP684pEvcoYxQQTjnGxj4u4cf OJtY3NDT0aeBCGov2w> X-ME-Received: <xmr:fCxbZq2yAEJ4A23jRRbAOYc9-2tQap7SVBTLBloImcLj_We9xxg8FFo2SAxIZ9w2aDFc> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdekkedgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepgeelfeetkefghfdvhfdtgeevveevteetgeetveegtedthefhudekteehffeu keeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: <xmx:fCxbZtDtMr2iziKw9TpoqmuvRqIz9ZXSkUwJiNmyT0Ga6_YolU8UEg> <xmx:fCxbZujlWyjgd9b16iKgnjq-Y9yd-bV9uI_kyErLJiy2Kun_6XNnWA> <xmx:fCxbZhrwdWJ3xrlXcq2zhohPloqTfrSv52bW1raVPgpaXoGBMxSBwg> <xmx:fCxbZpgohDhGBExqP7bmJ0xMoW6QaQy6qvMqA8BVvevBiLxa9VHtrw> <xmx:fSxbZvt-vrCwCpY0WEOXvZt0y9HejVJxapSSrc8ioYGaexSdni5O5KyF> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 1 Jun 2024 10:13:15 -0400 (EDT) Message-ID: <8349bbd4-21e5-4c11-aae9-28cef1aa231a@HIDDEN> Date: Sat, 1 Jun 2024 17:13:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses To: Noah Peart <noah.v.peart@HIDDEN>, Randy Taylor <dev@HIDDEN> References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN> <Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev> <CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@HIDDEN> <AdChXDjyAulWCxyswxNe-7IMxwPnhNsGnE-QxJ3BN3-HqbU3GhOFti8yQLH_D-euvftZoKEHO6Bvwb1gXojFkT4JhTstpo8Ad-Dqp7nhebE=@rjt.dev> <CAPVBTSfxgw35QaZYJ1VDEGxG=X7tt4bq7LT5ah2MiyDq8pX7kw@HIDDEN> <CAPVBTSd8cK7SkDQOaqOxRAtP+OukM-pMT7Cj2UYiOJggMUvGKg@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <CAPVBTSd8cK7SkDQOaqOxRAtP+OukM-pMT7Cj2UYiOJggMUvGKg@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71209 Cc: 71209 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 01/06/2024 04:50, Noah Peart wrote: > There is a similar issue with font-lock-property-name-face > and font-lock-property-use-face. I've noticed different modes > treat things differently. I think object fields in literals should get > property-name-face, but json-ts-mode, for example, > doesn't use font-lock-property-name-face at all. Yeah, that sounds about right. Probably needs some formalization, because for cases like json and html I wasn't 100% sure which semantics to choose, and unlike in programming code this didn't seem urgent at the time.
bug-gnu-emacs@HIDDEN:bug#71209; Package emacs.
Full text available.Received: (at 71209) by debbugs.gnu.org; 1 Jun 2024 02:06:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 31 22:06:32 2024 Received: from localhost ([127.0.0.1]:55542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sDE8d-0008M3-VF for submit <at> debbugs.gnu.org; Fri, 31 May 2024 22:06:32 -0400 Received: from mail-oa1-f50.google.com ([209.85.160.50]:43394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <noah.v.peart@HIDDEN>) id 1sDE8Z-0008Ll-2O for 71209 <at> debbugs.gnu.org; Fri, 31 May 2024 22:06:31 -0400 Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-250af9b3a13so37249fac.1 for <71209 <at> debbugs.gnu.org>; Fri, 31 May 2024 19:06:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717207510; x=1717812310; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=X9QQ4rHlUNzrEhSVmJFzqM06ZW0bVHPxzEl6ZnEFDeE=; b=fwhSj2toadqla2d8UXiGkVIzi5L57ekuCFFHmKDPoQE6ZTcIW+5sb678GQg9zBXW9A V1ZLuDvxk4CXI1Ol2llezLZgCKsRqI0aBsGsJ11x4XLcy3jylIiRwfFAg5+Zs39q/k3x K4N110dZOMtEyAOYHZuXf8q4OExdEsDSrqHs82V1o0S/1R2b2DUiqAbeImrbWHiENw5r aXs9uhMmuZ00tWjm8fBqpSf0tyQli/JxMbQgJGxrWspAEZeDfMB1cf6ZKFC7AQzmBbc2 R1K1wxjAPttoKgRAtgFObb5dBkhRmX0Ap1sTHgTA9hplo0bg7MQf50IN0jy9C1BwvXKZ I0Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717207510; x=1717812310; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=X9QQ4rHlUNzrEhSVmJFzqM06ZW0bVHPxzEl6ZnEFDeE=; b=DvV6hmAADXQHFPWEtbDmY7NXJhm/TxYhzD+pJIQDyY/bLuNpjRSQA//ngOpKCZRi5f VfIpoGDZnppBdEvD/7EMhTUKwwK8T4fW6/U7UXqkcgna5dgSUgFstsWF2Z2HWM6FXdVQ IZuClNjfrlfvhyfSVSAgK1blY/iExC6khI/0LQJMbJUIqEl2HwChzr0N0HfoQNkeVXlY Kxp2T0wGPvPlq+TGFuWBbcUBgALTsNGLtMHfTXcEcr3hvHLJ96VLCPwM5dVXiE6ftnt1 gvGs7n/Pcw2MbC2KLRoJaPJBnC/ccjrp5r2+teS/+kG7gehm+Aqw5SMZodKk8DvbA3Fs RNew== X-Forwarded-Encrypted: i=1; AJvYcCXjJCsKG2FnKNeRMZDq+2d13FeLKWgvNIEeucWJMbI7LDnwbB9gOaKumGrpU4Am8xblFUcAJ+YnXya5pdOuViaS+llYJqw= X-Gm-Message-State: AOJu0YxJRUIJWhCdqDUsve2fNuZfEJM9Cm4WIo7G2nyiWdTU8WwRweXR 9iqTTGsjtY229vCOvGe3wKNSrPnyKenGgUkTWONoqlqebjk0E/2l2Dd4B/+tHdyGk6dMdrZF3t4 2Ib0P3MWTsKUuIo4ADhdDLDKW1qvDF2SZdsBlpA== X-Google-Smtp-Source: AGHT+IGprW4RqM42Rv3tFD5bAmigLP9IaXOuVxVvGKvagafhDNzflfpTV+CzCWrwSBRb7xYbg/gPFr7JPfQwIR1alhA= X-Received: by 2002:a05:6870:440b:b0:24d:e843:2966 with SMTP id 586e51a60fabf-25065ad7153mr2734168fac.6.1717207510044; Fri, 31 May 2024 19:05:10 -0700 (PDT) MIME-Version: 1.0 References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN> <Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev> <CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@HIDDEN> <AdChXDjyAulWCxyswxNe-7IMxwPnhNsGnE-QxJ3BN3-HqbU3GhOFti8yQLH_D-euvftZoKEHO6Bvwb1gXojFkT4JhTstpo8Ad-Dqp7nhebE=@rjt.dev> <CAPVBTSfxgw35QaZYJ1VDEGxG=X7tt4bq7LT5ah2MiyDq8pX7kw@HIDDEN> <269722b9-1dcd-47e5-8f60-e8a2ff273259@HIDDEN> <CAPVBTSf0cx7BKyGjJbj0wbvBiodKdsCkRTf9NvDY9a-=bZpQsQ@HIDDEN> <bb1ea56c-d59b-433c-9eef-dfd53851b813@HIDDEN> In-Reply-To: <bb1ea56c-d59b-433c-9eef-dfd53851b813@HIDDEN> From: Noah Peart <noah.v.peart@HIDDEN> Date: Fri, 31 May 2024 19:04:58 -0700 Message-ID: <CAPVBTScGd1u8U7EBaJx9vE0iCaoqhUGuiFpteAk-XGgwFb1Rdg@HIDDEN> Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses To: Dmitry Gutov <dmitry@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000a457760619ca87f7" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 71209 Cc: 71209 <at> debbugs.gnu.org, Randy Taylor <dev@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.3 (/) --000000000000a457760619ca87f7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > Personally, I stay with the default, among other things because most of > the level 4 'variable' highlights just take the easy route and highlight > all the tokens that haven't been matched by any other existing rule. > That doesn't feel useful to me. I agree, I used level 4 with the use-face and name-faces being the same for while, but have since changed use-faces to be only a shade different from the default face. It's way more informative to have the decls solidly stand out. On Fri, May 31, 2024 at 6:59=E2=80=AFPM Dmitry Gutov <dmitry@HIDDEN> wro= te: > On 01/06/2024 04:56, Noah Peart wrote: > > > Only if you set treesit-font-lock-level to 4, right? > > > > Yea, that's true - I assumed most people(?) do, but I just realized > > I hadn't been doing that for years until tree-sitter - and now I've > > become obsessive compulsive about my fonts. > > I imagine most actual users just keep in on the default value. But a lot > customize it, of course, to get closer to "VS Code look". > > Personally, I stay with the default, among other things because most of > the level 4 'variable' highlights just take the easy route and highlight > all the tokens that haven't been matched by any other existing rule. > That doesn't feel useful to me. > --000000000000a457760619ca87f7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">> Personally, I stay with the default, among other thin= gs because most of<br>> the level 4 'variable' highlights just t= ake the easy route and highlight<br>> all the tokens that haven't be= en matched by any other existing rule.<br>> That doesn't feel useful= to me.<div class=3D"gmail-yj6qo"></div><br class=3D"gmail-Apple-interchang= e-newline"><div>I agree, I used level 4 with the use-face and name-faces be= ing the same</div><div>for while, but have since changed use-faces to be on= ly a shade different</div><div>from the default face.=C2=A0 It's way mo= re informative to have the decls=C2=A0solidly</div><div>stand out.</div></d= iv><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On = Fri, May 31, 2024 at 6:59=E2=80=AFPM Dmitry Gutov <<a href=3D"mailto:dmi= try@HIDDEN">dmitry@HIDDEN</a>> wrote:<br></div><blockquote class= =3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg= b(204,204,204);padding-left:1ex">On 01/06/2024 04:56, Noah Peart wrote:<br> >=C2=A0 > Only if you set treesit-font-lock-level to 4, right?<br> > <br> > Yea, that's true - I assumed most people(?) do, but I just realize= d<br> > I hadn't been doing that for years until tree-sitter - and now I&#= 39;ve<br> > become obsessive compulsive about my fonts.<br> <br> I imagine most actual users just keep in on the default value. But a lot <b= r> customize it, of course, to get closer to "VS Code look".<br> <br> Personally, I stay with the default, among other things because most of <br= > the level 4 'variable' highlights just take the easy route and high= light <br> all the tokens that haven't been matched by any other existing rule. <b= r> That doesn't feel useful to me.<br> </blockquote></div> --000000000000a457760619ca87f7--
bug-gnu-emacs@HIDDEN:bug#71209; Package emacs.
Full text available.Received: (at 71209) by debbugs.gnu.org; 1 Jun 2024 02:00:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 31 22:00:18 2024 Received: from localhost ([127.0.0.1]:55538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sDE2c-0008Cn-30 for submit <at> debbugs.gnu.org; Fri, 31 May 2024 22:00:18 -0400 Received: from wfhigh4-smtp.messagingengine.com ([64.147.123.155]:53969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1sDE2Y-0008CV-Fi for 71209 <at> debbugs.gnu.org; Fri, 31 May 2024 22:00:16 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfhigh.west.internal (Postfix) with ESMTP id 4423018000F9; Fri, 31 May 2024 21:59:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 31 May 2024 21:59:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1717207196; x=1717293596; bh=iPCidHidTucyvADXIofIl7jd82da8cGd1GQV32ExABU=; b= QwbgBaiiw3P7WOZyDXi6zvxdbC7wDeONaHiPMKzHsdNqXplZhOFWJu/u5qqvYaI2 8X7l2rrLIoD0dyxJkpc7qb357uJQjwYm/m0rqB41f79NHQN2XZOoI/MUGj7+QeKf d5gvF5cABPhSWh873vDKWSNgteQv87bc4RuZP1mrXZhSLRLmnHHixiaxnBP8TDz0 4jD3AZOfS73X6/dMhJPXsZeaO29X8frkJ1wsgxgIH+FxbjCPBgmYd9XBjbuJkaX0 3ir8ZCApdH5TuOsRZB76Ff92rWo9UBlkNWWxxMOVBq/wtubIFe7u4OM16lSeddJ9 M2NTBmbwxqoDCt2k/PLGTg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1717207196; x= 1717293596; bh=iPCidHidTucyvADXIofIl7jd82da8cGd1GQV32ExABU=; b=X OrWBo8zw0fp6j0ixk8el9Gls5oy5A0Vf2dShyxdbZVJFiSDA/FwJrILWE6+S7e0v Ym52fiZpjsCX7j08NzVe3i6jdum0ylCzeIT9rEGOJvY8mZWmsjxhfVj4nhRqo8q7 eZjCR0Uc92FiKTykJsqimK3k8ZqfjTdy03RfXxgTfdep3ZocySzXaYpwwZtCspSz lV+Io8C6179vUL0i8g011CjehN26RdzC0qlf+BWgU6zvcS0TEI0gqBC/XmG9bzOw /75UvMZ90xvKPYTt2Jrfa3E76hCv8v1Rm2oIUb+q5c/Ru54r9svP9Rr9DkX+54Gl sNC5Vx47VbNqyI3Q/ELhQ== X-ME-Sender: <xms:nIBaZo8lr5_cRAUV1Kxyr3o8ZYgcenV93Df3mY3erSlEpxVf6RY6Aw> <xme:nIBaZguUG0NUfOIqK7xFA4C5o6ploRYhu6NKDOpuRkdWju4Nh6Kshtfg70E_wY-nP MENDet-oGAJcqvqBRU> X-ME-Received: <xmr:nIBaZuBCRFXC-MxSx3Bn1M59XbcqzPiWXTQ4eIZ8QDI4kFLXkLjeQfpl-nUwJZr_2rma> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdekjedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: <xmx:nIBaZoclic0KeG2UZrpOd7dk57FkndL7mJAov8JF3NDQwW10hn6VbQ> <xmx:nIBaZtMI1KHLWkudAKgUbakCyDKITKm5wjiUNjVdBAVYIDeEpbSeMg> <xmx:nIBaZinwnwQ0Ys-n0SmXL3T1nPpJtqTGSLl-T4rucBTGo_bMwQjlyA> <xmx:nIBaZvuoRxCpG8-498QlvJbJpVxWrTgd9uikQlWM9wYzG-vIiFqzxQ> <xmx:nIBaZurRXAGYhXRugWZtgODGPNADtihOm0BPn1SJJf42O4P0bx2j3-Bq> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 31 May 2024 21:59:54 -0400 (EDT) Message-ID: <bb1ea56c-d59b-433c-9eef-dfd53851b813@HIDDEN> Date: Sat, 1 Jun 2024 04:59:53 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses To: Noah Peart <noah.v.peart@HIDDEN> References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN> <Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev> <CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@HIDDEN> <AdChXDjyAulWCxyswxNe-7IMxwPnhNsGnE-QxJ3BN3-HqbU3GhOFti8yQLH_D-euvftZoKEHO6Bvwb1gXojFkT4JhTstpo8Ad-Dqp7nhebE=@rjt.dev> <CAPVBTSfxgw35QaZYJ1VDEGxG=X7tt4bq7LT5ah2MiyDq8pX7kw@HIDDEN> <269722b9-1dcd-47e5-8f60-e8a2ff273259@HIDDEN> <CAPVBTSf0cx7BKyGjJbj0wbvBiodKdsCkRTf9NvDY9a-=bZpQsQ@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <CAPVBTSf0cx7BKyGjJbj0wbvBiodKdsCkRTf9NvDY9a-=bZpQsQ@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71209 Cc: 71209 <at> debbugs.gnu.org, Randy Taylor <dev@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 01/06/2024 04:56, Noah Peart wrote: > > Only if you set treesit-font-lock-level to 4, right? > > Yea, that's true - I assumed most people(?) do, but I just realized > I hadn't been doing that for years until tree-sitter - and now I've > become obsessive compulsive about my fonts. I imagine most actual users just keep in on the default value. But a lot customize it, of course, to get closer to "VS Code look". Personally, I stay with the default, among other things because most of the level 4 'variable' highlights just take the easy route and highlight all the tokens that haven't been matched by any other existing rule. That doesn't feel useful to me.
bug-gnu-emacs@HIDDEN:bug#71209; Package emacs.
Full text available.Received: (at 71209) by debbugs.gnu.org; 1 Jun 2024 01:57:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 31 21:57:30 2024 Received: from localhost ([127.0.0.1]:55533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sDDzu-000873-Hh for submit <at> debbugs.gnu.org; Fri, 31 May 2024 21:57:30 -0400 Received: from mail-oa1-f52.google.com ([209.85.160.52]:58814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <noah.v.peart@HIDDEN>) id 1sDDzs-00086q-UT for 71209 <at> debbugs.gnu.org; Fri, 31 May 2024 21:57:29 -0400 Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-250ac3acc6cso113796fac.1 for <71209 <at> debbugs.gnu.org>; Fri, 31 May 2024 18:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717206972; x=1717811772; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hrmSnM9+gbSJinA5yFdg5SxwHGH3zSmYHn3Zxj9zRUU=; b=MMoc9gXv4tPAGAgRvrQDGdd04zl45yxoeUmjF5KoYsyRqBGxLJQJc8eHKuPW87R6Bq UNarZNBH2umytZ5NiBxJYzoa12gZio2j/vq3VLs8BJKJdnlUvFZLXpVSS6FCwADvBvEu zqtpjs9eUL63mmfSAkmzE1M3fwTwbaBCd81HlEXmxjhkGmtsjQJCo3z5kDRp1W4ZL7VN CgfAFcviN3qiWTv2ZSOgbv418+++CgFmkzpQG0eiyga2NugIHJBeRKqqli5HijhGrx/I a1RhYUXh93JT+IL1w630auyvHBLF0nGwB4acVVpyOE0gWsjCKal0JPXCsfOqjabnpNp6 qo1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717206972; x=1717811772; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hrmSnM9+gbSJinA5yFdg5SxwHGH3zSmYHn3Zxj9zRUU=; b=UoutkPRKH43vlRi6W00LvAEuXrqbcoVkX4At7fGTDaxFLTD9KpLCh0ydB7LqHhjKNh N2RMlkA6hy8skrH8U6/LOcPJKx/7fh0uyHlcWCRwUTtJDh31iTjU0rsjNtxdj4OO4WbZ IVx7+6GY3F7jUbrna6JqIXbK6YXrKDVFX4uEQASI1yNH9egW0Z6gUepUOcue9u/zYjRR x6whRNRNBvv5X0v/ZaLVoNdvGfHqMtbu/B9hpWgy9f6ZvZHA5Bj1KU7jrBd8y0AhGZoo /QYg5KMfpJFcFi9B3cxwYDMMCkePQzIbT+xQILr/8ToerC9PzbEUjzsg1vHLmpcLTI2D EtGg== X-Forwarded-Encrypted: i=1; AJvYcCWJZnIMR5ln2+ZAf6s1biHLxUrWI7MyZFcp9Nn5tinjKpljiv95f/vw9HTk+USgcywxKWTsI7ai5/ZycpBn+iHGkNJi7uQ= X-Gm-Message-State: AOJu0Ywx5WJSrikM6yJnbWK6TmcVhwdO9uy+KoDWvoTVboX19OuWff0I KtCZvRzhds/rCQrSkk0MOnoLM/j6LjNuOpaIYXNPBu1jkH/CSkmBMrrzKKuvE/D/9yQuop0jjuw 6qKwT7/igPtKR9M5zADaKCjnWCEE= X-Google-Smtp-Source: AGHT+IE/1WbN8RWND7wsrx+w/L5DCSUL+OT545zcVTVzXfZzcWUXzPGUvgJx2Diw0zxpYuPiE9Aaf7+9q5xvV3HVKbs= X-Received: by 2002:a05:6870:2006:b0:24f:f2c5:69ae with SMTP id 586e51a60fabf-2508b7e2a2bmr4782882fac.16.1717206971876; Fri, 31 May 2024 18:56:11 -0700 (PDT) MIME-Version: 1.0 References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN> <Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev> <CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@HIDDEN> <AdChXDjyAulWCxyswxNe-7IMxwPnhNsGnE-QxJ3BN3-HqbU3GhOFti8yQLH_D-euvftZoKEHO6Bvwb1gXojFkT4JhTstpo8Ad-Dqp7nhebE=@rjt.dev> <CAPVBTSfxgw35QaZYJ1VDEGxG=X7tt4bq7LT5ah2MiyDq8pX7kw@HIDDEN> <269722b9-1dcd-47e5-8f60-e8a2ff273259@HIDDEN> In-Reply-To: <269722b9-1dcd-47e5-8f60-e8a2ff273259@HIDDEN> From: Noah Peart <noah.v.peart@HIDDEN> Date: Fri, 31 May 2024 18:56:00 -0700 Message-ID: <CAPVBTSf0cx7BKyGjJbj0wbvBiodKdsCkRTf9NvDY9a-=bZpQsQ@HIDDEN> Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses To: Dmitry Gutov <dmitry@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000908a840619ca6758" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 71209 Cc: 71209 <at> debbugs.gnu.org, Randy Taylor <dev@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.3 (/) --000000000000908a840619ca6758 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > Only if you set treesit-font-lock-level to 4, right? Yea, that's true - I assumed most people(?) do, but I just realized I hadn't been doing that for years until tree-sitter - and now I've become obsessive compulsive about my fonts. On Fri, May 31, 2024 at 6:51=E2=80=AFPM Dmitry Gutov <dmitry@HIDDEN> wro= te: > On 01/06/2024 04:42, Noah Peart wrote: > > I suppose most people keep the default font-locking for variable-name > > and variable-use, so these missing rules go unnoticed. > > Only if you set treesit-font-lock-level to 4, right? > --000000000000908a840619ca6758 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">> Only if you set treesit-font-lock-level to 4, right?<= div class=3D"gmail-yj6qo"></div><br><div>Yea, that's true - I assumed m= ost people(?) do, but I just realized</div><div>I hadn't been doing tha= t for years until tree-sitter - and now I've</div><div>become obsessive= compulsive about my fonts.</div></div><br><div class=3D"gmail_quote"><div = dir=3D"ltr" class=3D"gmail_attr">On Fri, May 31, 2024 at 6:51=E2=80=AFPM Dm= itry Gutov <<a href=3D"mailto:dmitry@HIDDEN">dmitry@HIDDEN</a>>= wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px = 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 01/06= /2024 04:42, Noah Peart wrote:<br> > I suppose most people keep the default font-locking for variable-name<= br> > and variable-use, so these missing rules go unnoticed.<br> <br> Only if you set treesit-font-lock-level to 4, right?<br> </blockquote></div> --000000000000908a840619ca6758--
bug-gnu-emacs@HIDDEN:bug#71209; Package emacs.
Full text available.
Received: (at 71209) by debbugs.gnu.org; 1 Jun 2024 01:56:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 31 21:56:58 2024
Received: from localhost ([127.0.0.1]:55529 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sDDzO-00085u-5m
for submit <at> debbugs.gnu.org; Fri, 31 May 2024 21:56:58 -0400
Received: from wfout2-smtp.messagingengine.com ([64.147.123.145]:33989)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <dmitry@HIDDEN>) id 1sDDzM-00085h-3f
for 71209 <at> debbugs.gnu.org; Fri, 31 May 2024 21:56:56 -0400
Received: from compute6.internal (compute6.nyi.internal [10.202.2.47])
by mailfout.west.internal (Postfix) with ESMTP id 9AAEE1C000AA;
Fri, 31 May 2024 21:56:38 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute6.internal (MEProxy); Fri, 31 May 2024 21:56:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc
:cc:content-transfer-encoding:content-type:content-type:date
:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:subject:subject:to:to; s=fm3; t=1717206998;
x=1717293398; bh=R+9VuWvoFoSjKODZ+DZ5X/oq9nPug1T6rdOI8MFqiGs=; b=
Z9AfPqqm/b5Irpeg45C+Gaahqe+8UjdqhIziA7cfaXBaVWJFzWMKAHjxO39Smrty
sKPnGNhrDbdUSKkmAVIfNQIW/DdyBsITfdEaxeslAFkpyTMxJAcEImfROoAGiySQ
oRThVFNTfx4W0El6DW0vcf35h3aVJGZhUB4zMrfPHx/zajg6Ep6hoPURVuVmlDfb
Has8BSePGkh2nvxFot4SMxMtf+UvSkjvYOCgARE7+n1VRRl5On/s6GpFi/3WUcBe
F0ZE43Kn7wCHpkGL13m9KSISbYIPuzgUuMnbzEgThAEDZ24n74iY6pBtvyvTCsQj
L1RqFMHWMRMn4Pq/2/aeTQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1717206998; x=
1717293398; bh=R+9VuWvoFoSjKODZ+DZ5X/oq9nPug1T6rdOI8MFqiGs=; b=l
KfiBWGr6odqTq9/DzdDGMva/mkpSiD45ahPODqawu2FFnQl80/8U20DoODGSH0aa
a3QHRrsrxCYieEW3c7plOjB5zwhfsQcFQ5pgctSMuHwECJzLgeerld7JdOqSvvLN
tqbLrJgkMgdR89dlz0kA9gDOko3+amfdiC1/LkTtWtLy1NMpWNPmQ8qtREBKOwe9
RUq7QoSNXHcTUJZSqLRqXF0Llp//FDOPR0wnOcYkVZyPvJDVeGmWIZ6JwIUyj/WS
Or2xw05yShYMs1DYhy3Wd1BxR8XRkCwS2JxI1QMh6atvbifZV9065Sgv2HqhFWyO
P6U4hZM4Dz6GRI2IXQGXQ==
X-ME-Sender: <xms:1n9aZkdqtYWQlmweLWdho9DiZbn4l7MTaiEEsz5P3y8VdrJlt_9MGw>
<xme:1n9aZmMmJL-3tLIkqTL9sEBzLerfpGNSsxZ1V7_zVfkShfXqOIFW5_9ZtuSNBFpFi
FX8Vw1rblwWyIYp1QQ>
X-ME-Received: <xmr:1n9aZliihRETWgBkxge8HVqctCsXCAfg78nFXsSN9coY0YQAAZW-1qEtEunhaCcTrk8D>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdekjedghedvucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi
thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth
htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu
jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug
hmihhtrhihsehguhhtohhvrdguvghv
X-ME-Proxy: <xmx:1n9aZp-bxMNUO9IV2xR2o6KpR3_HcMhFsePptYiNw-4V1XPKxvp6Wg>
<xmx:1n9aZgvhXpPN29re1NcHRSWjyrW-Zenx0i1aBHe87eoicm_5k-fdOg>
<xmx:1n9aZgFQoH6lYLqRKsAkQou7kpAVGeL_xPWmJhMtcCiQF3UBHVV7xA>
<xmx:1n9aZvOHrAMh1B-Rqw8P3qjh6Mj8t4XqfAXbnBFIKKUeq-BxLlJnNg>
<xmx:1n9aZsJUKPlxNUsdKItLR9nxWE_EI7R64Je17B7BWBRK-PG1agAEQemb>
Feedback-ID: i0e71465a:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
31 May 2024 21:56:36 -0400 (EDT)
Message-ID: <a8c3a42a-16fb-4380-9754-4dbebd97415c@HIDDEN>
Date: Sat, 1 Jun 2024 04:56:35 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
range clauses
To: Randy Taylor <dev@HIDDEN>, Noah Peart <noah.v.peart@HIDDEN>
References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN>
<Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev>
<CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@HIDDEN>
<AdChXDjyAulWCxyswxNe-7IMxwPnhNsGnE-QxJ3BN3-HqbU3GhOFti8yQLH_D-euvftZoKEHO6Bvwb1gXojFkT4JhTstpo8Ad-Dqp7nhebE=@rjt.dev>
Content-Language: en-US
From: Dmitry Gutov <dmitry@HIDDEN>
In-Reply-To: <AdChXDjyAulWCxyswxNe-7IMxwPnhNsGnE-QxJ3BN3-HqbU3GhOFti8yQLH_D-euvftZoKEHO6Bvwb1gXojFkT4JhTstpo8Ad-Dqp7nhebE=@rjt.dev>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 71209
Cc: 71209 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
On 01/06/2024 04:09, Randy Taylor wrote:
> On Thursday, May 30th, 2024 at 09:25, Noah Peart <noah.v.peart@HIDDEN> wrote:
>>> it seems we already highlight this when at treesit-font-lock-level 4?
>> They get highlighted with `font-lock-variable-use-face` at level 4, but shouldn't
>> they be getting `font-lock-variable-name-face` in the 'definition feature?
>>
>
> Indeed, thanks. Could someone please install the patch? Thanks in advance.
Now pushed to master. Thanks Noah!
> Seems like c++-ts-mode will need to get updated too, as with:
> for (const auto& i : things) {}
> i gets font-lock-variable-use-face. I wonder if any other ts modes
> have similar issues.
I would probably rather call those "missing features" rather than
issues. I've added such highlightings to some of the constructs for
several treesit modes last year, but more can be missing, so
contributions welcome.
bug-gnu-emacs@HIDDEN:bug#71209; Package emacs.
Full text available.
Received: (at 71209) by debbugs.gnu.org; 1 Jun 2024 01:52:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 31 21:52:23 2024
Received: from localhost ([127.0.0.1]:55524 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sDDux-0007ze-Bb
for submit <at> debbugs.gnu.org; Fri, 31 May 2024 21:52:23 -0400
Received: from mail-oa1-f51.google.com ([209.85.160.51]:60564)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <noah.v.peart@HIDDEN>) id 1sDDuv-0007zS-OX
for 71209 <at> debbugs.gnu.org; Fri, 31 May 2024 21:52:22 -0400
Received: by mail-oa1-f51.google.com with SMTP id
586e51a60fabf-24cbb884377so1431777fac.0
for <71209 <at> debbugs.gnu.org>; Fri, 31 May 2024 18:52:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1717206665; x=1717811465; darn=debbugs.gnu.org;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:from:to:cc:subject:date:message-id:reply-to;
bh=44Am0KC8Vpn92eF0obLQMAtqVC2dAONiMtEJDiY0Dw0=;
b=fDUPm8wjsNHvBATmw1ppwgRyhzr+DKqWraL/qWO2VkB7+JbIWB5RLUf5rGYjMnJ06S
zIzcW8kfmtLcRWyyIiBICxscWpxuLvFofTdSYfRhEvZ6Ln9vLO2V3xuRyimwCLcHLONS
DF/jk5fZkQn6tZUtkBn5j2RjXA80SrzZMcx7SB9PdCdwA0gsX/5DXccJg6km1BzqZG+g
oDgi7P60iECGVxsARojIpKPpUuZOhg4G3xd2Lgm++DQfR+WbXYMVGSX+0bFjA36Ndni5
uXHacbS2QecTZIpxRfHrUny2mkgr7NCQLTo/EnflF6VZ4Qq/PUwvcA/TpKIuAJKAEQQg
TOOg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1717206665; x=1717811465;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=44Am0KC8Vpn92eF0obLQMAtqVC2dAONiMtEJDiY0Dw0=;
b=kJiyeA+7oVyPqR9xllKD0wxXCL3HdMInbZqLnRChlHWyd1A1meX/Mgq+7MOoUOUx6l
COklduqyHkP3EnQBCDZbFCgpw1vluG9D0sHCB6galB1QbwfOaBhhBzsDSgm/ka6Ny4Dy
SQxmd56qpixt8jbD2rmo0oE8EdwJVcpk3yGpOVq2ho5cGi5lyGN9J9sjOjxcG93w1LW7
2fe+LTi5WI0fInCyGld2AASA5E20FLqQ3lyIRqoWaKIxabrEuKQzJv35RG8COnBIpfuE
EHvYnBH8QLka6hpTod+vzGP/ZPhuv5h/7iitq6f9BXb6Xczcs4TwM7oMgI/lQT6EJNUz
aTbg==
X-Gm-Message-State: AOJu0YzGNUhtqEMWsbf1170dMI/g8ub0pSo56bYT1VRbQzciYjiLA38j
qj98znhZbvUK1Z7BAAShMpk07rCv78G5jXf/MS/4ne0a8XKMBO7l0W16G1clJW3r9276OELUeIr
l5sIyeIhi1ttFAeDCUot+O7eFdq4=
X-Google-Smtp-Source: AGHT+IEGR49eMl/QO5kQ5oL7VBpbGnlI6cqof0+RryuZzh5FUf57paxF4s0Rp6xR/lVzTj2BKHYJOJgrCcgKNtJEjxY=
X-Received: by 2002:a05:6871:b07:b0:250:7d25:b3b7 with SMTP id
586e51a60fabf-2508c1b8a55mr3966814fac.53.1717206664525; Fri, 31 May 2024
18:51:04 -0700 (PDT)
MIME-Version: 1.0
References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN>
<Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev>
<CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@HIDDEN>
<AdChXDjyAulWCxyswxNe-7IMxwPnhNsGnE-QxJ3BN3-HqbU3GhOFti8yQLH_D-euvftZoKEHO6Bvwb1gXojFkT4JhTstpo8Ad-Dqp7nhebE=@rjt.dev>
<CAPVBTSfxgw35QaZYJ1VDEGxG=X7tt4bq7LT5ah2MiyDq8pX7kw@HIDDEN>
In-Reply-To: <CAPVBTSfxgw35QaZYJ1VDEGxG=X7tt4bq7LT5ah2MiyDq8pX7kw@HIDDEN>
From: Noah Peart <noah.v.peart@HIDDEN>
Date: Fri, 31 May 2024 18:50:52 -0700
Message-ID: <CAPVBTSd8cK7SkDQOaqOxRAtP+OukM-pMT7Cj2UYiOJggMUvGKg@HIDDEN>
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
range clauses
To: Randy Taylor <dev@HIDDEN>
Content-Type: multipart/alternative; boundary="0000000000003ec34f0619ca5513"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 71209
Cc: 71209 <at> debbugs.gnu.org, Dmitry Gutov <dmitry@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--0000000000003ec34f0619ca5513
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
There is a similar issue with font-lock-property-name-face
and font-lock-property-use-face. I've noticed different modes
treat things differently. I think object fields in literals should get
property-name-face, but json-ts-mode, for example,
doesn't use font-lock-property-name-face at all.
On Fri, May 31, 2024 at 6:42=E2=80=AFPM Noah Peart <noah.v.peart@HIDDEN>=
wrote:
> > c++-ts-mode will need to get updated too
>
> I've been using these for c++, I think they are still missing
>
> ;; for (auto x: ...)
> (for_range_loop
> declarator: (identifier) @font-lock-variable-name-face)
> ;; auto& x
> (reference_declarator
> (identifier) @font-lock-variable-name-face)
> ;; auto[&] [x, y]
> (structured_binding_declarator
> _ [(identifier)] @font-lock-variable-name-face)
>
> I suppose most people keep the default font-locking for variable-name
> and variable-use, so these missing rules go unnoticed.
>
> On Fri, May 31, 2024 at 6:09=E2=80=AFPM Randy Taylor <dev@HIDDEN> wrote:
>
>> On Thursday, May 30th, 2024 at 09:25, Noah Peart <noah.v.peart@HIDDEN=
>
>> wrote:
>> > > it seems we already highlight this when at treesit-font-lock-level 4=
?
>> > They get highlighted with `font-lock-variable-use-face` at level 4, bu=
t
>> shouldn't
>> > they be getting `font-lock-variable-name-face` in the 'definition
>> feature?
>> >
>>
>> Indeed, thanks. Could someone please install the patch? Thanks in advanc=
e.
>>
>> Seems like c++-ts-mode will need to get updated too, as with:
>> for (const auto& i : things) {}
>> i gets font-lock-variable-use-face. I wonder if any other ts modes
>> have similar issues.
>>
>
--0000000000003ec34f0619ca5513
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">There is a similar=C2=A0issue with font-lock-property-name=
-face=C2=A0<div>and font-lock-property-use-face.=C2=A0 I've noticed dif=
ferent modes</div><div>treat things differently.=C2=A0 I think object field=
s in literals should get=C2=A0</div><div>property-name-face, but json-ts-mo=
de, for example,</div><div>doesn't use font-lock-property-name-face at =
all.<br></div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=
=3D"gmail_attr">On Fri, May 31, 2024 at 6:42=E2=80=AFPM Noah Peart <<a h=
ref=3D"mailto:noah.v.peart@HIDDEN">noah.v.peart@HIDDEN</a>> wrote:=
<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8=
ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr=
">> c++-ts-mode will need to get updated too<div><br></div><div>I've=
been using these for c++, I think they are still missing</div><div><br></d=
iv><div>=C2=A0 =C2=A0 ;; for (auto x: ...)<br></div><div>=C2=A0 =C2=A0 (for=
_range_loop<br>=C2=A0 =C2=A0 =C2=A0declarator: (identifier) @font-lock-vari=
able-name-face)<br>=C2=A0 =C2=A0 ;; auto& x<br>=C2=A0 =C2=A0 (reference=
_declarator<br>=C2=A0 =C2=A0 =C2=A0(identifier) @font-lock-variable-name-fa=
ce)<br>=C2=A0 =C2=A0 ;; auto[&] [x, y]<br>=C2=A0 =C2=A0 (structured_bin=
ding_declarator<br>=C2=A0 =C2=A0 =C2=A0_ [(identifier)] @font-lock-variable=
-name-face)<br></div><div><br></div><div>I suppose most people keep the def=
ault font-locking for variable-name</div><div>and variable-use, so these mi=
ssing rules go unnoticed.</div></div><br><div class=3D"gmail_quote"><div di=
r=3D"ltr" class=3D"gmail_attr">On Fri, May 31, 2024 at 6:09=E2=80=AFPM Rand=
y Taylor <<a href=3D"mailto:dev@HIDDEN" target=3D"_blank">dev@HIDDEN</=
a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0p=
x 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On=
Thursday, May 30th, 2024 at 09:25, Noah Peart <<a href=3D"mailto:noah.v=
.peart@HIDDEN" target=3D"_blank">noah.v.peart@HIDDEN</a>> wrote:<b=
r>
> > it seems we already highlight this when at treesit-font-lock-leve=
l 4?<br>
> They get highlighted with `font-lock-variable-use-face` at level 4, bu=
t shouldn't<br>
> they be getting `font-lock-variable-name-face` in the 'definition =
feature?<br>
> <br>
<br>
Indeed, thanks. Could someone please install the patch? Thanks in advance.<=
br>
<br>
Seems like c++-ts-mode will need to get updated too, as with:<br>
for (const auto& i : things) {}<br>
i gets font-lock-variable-use-face. I wonder if any other ts modes<br>
have similar issues.<br>
</blockquote></div>
</blockquote></div>
--0000000000003ec34f0619ca5513--
bug-gnu-emacs@HIDDEN:bug#71209; Package emacs.
Full text available.Received: (at 71209) by debbugs.gnu.org; 1 Jun 2024 01:51:34 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 31 21:51:34 2024 Received: from localhost ([127.0.0.1]:55520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sDDu9-0007yD-VM for submit <at> debbugs.gnu.org; Fri, 31 May 2024 21:51:34 -0400 Received: from wfhigh4-smtp.messagingengine.com ([64.147.123.155]:42405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1sDDu6-0007xx-Er for 71209 <at> debbugs.gnu.org; Fri, 31 May 2024 21:51:32 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.west.internal (Postfix) with ESMTP id 0F91F180007D; Fri, 31 May 2024 21:51:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 31 May 2024 21:51:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1717206671; x=1717293071; bh=MU717e9vo/+ZS9aRXZw+gYiKDsx88MhM21UjJSXKsTQ=; b= QwhNqBdq4AjO1FQN1atZN2Qr6kKnsaT3b4AAwd+Kw+fSriybMHmi6MTK81gxu5s8 hqnui0DBqwtroMcI9Kd+2MfQQSHIr9JgnwwdgJput6uM5OV8kndSArYo21TqQWK+ lW8sn2HcG0kf7cZzupYTabXoSTLy1/AVIQ+9PJH1n+ZG2OMfmDbyBnp6i2yT7c3r E36aaPDokapeV+XAjUUkCvY0xg8AwC2trhGYr+uhVK4eoeArdL8tuuVY4Ssw/YJE u41Tlw/EbiYUUk8NVE+C+ytAdaqnsYvM5xPOG92w7Rh9nMlM8hKN2W5xVb+54nya lFtCBkRyxu3sa9e8Fgt2Kg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1717206671; x= 1717293071; bh=MU717e9vo/+ZS9aRXZw+gYiKDsx88MhM21UjJSXKsTQ=; b=e IWOB+ovGJqhiLTWwEecMnRSIbaww2Z01noB4xPnNeKdCsfKnaqjJ0RIeWcLStsWw OwUfq+s4DIwM2PjBg51ga3N7TxjsXUZB/O25QrJdegT3+rgiya0lTzgiJje1NnVv Iv7FPYDZ3aOrrcryOw7XO6ZZ6GqjDrV7/KO4tMgRgOZB6Urcj9b/9zuBk+/weT32 MXnKTFiCw+Mj6J+9JI5S4bs4xhI3WzZZO69rX9wKLEHkPQEMz+WWYSVWxQlyJ6AE Y0uZMSbnaV9h/DKntAxJ9jJ5QRpDr8zLcjxFBnnMmLxTjCTJnZOVd+Sa/BK1NmpL 0EaONo5AzrKhQoHpdNjZA== X-ME-Sender: <xms:j35aZsow-lUy3pDXB8sDaHesP6L8WSbOP0Gh1UgSLqPVxdthu-Z0fQ> <xme:j35aZipeitGl1LJDZ0isgX6pTwmCbdbyMaEZ9MBYS1Zg3lguTQ5bUhhc4XGQ4ar6M B113mi6cktn2j6E6ag> X-ME-Received: <xmr:j35aZhMsnLqLv8iik5JwOYk2xLb4jsKQndFNOZPIPY4GJmj2-R6JEYsRJTmMArigZsQQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdekjedghedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: <xmx:j35aZj5CfySUbxl6cUV9MDltgv2ijdLrUmtKxp66qzQ1D483qaxVVg> <xmx:j35aZr6sHvHyaiuDJKuTG40D-3wYKSnHmjA3T4oO6hFXxdkOcuxUKQ> <xmx:j35aZjjdUL0m1yQ4oNcaJZNOeBsjDz6YTcHr5PlRGYliRDpS8zzERA> <xmx:j35aZl4SbDTqxpZhDsznnbDRHE-a1-6C0B--ncBa4PIJggHhpNCXww> <xmx:j35aZtmxkkc8Xvtu0CQvPldxQSPUJhRVMTtidqD4pPr5exr7n9TnjPTA> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 31 May 2024 21:51:10 -0400 (EDT) Message-ID: <269722b9-1dcd-47e5-8f60-e8a2ff273259@HIDDEN> Date: Sat, 1 Jun 2024 04:51:08 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses To: Noah Peart <noah.v.peart@HIDDEN>, Randy Taylor <dev@HIDDEN> References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN> <Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev> <CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@HIDDEN> <AdChXDjyAulWCxyswxNe-7IMxwPnhNsGnE-QxJ3BN3-HqbU3GhOFti8yQLH_D-euvftZoKEHO6Bvwb1gXojFkT4JhTstpo8Ad-Dqp7nhebE=@rjt.dev> <CAPVBTSfxgw35QaZYJ1VDEGxG=X7tt4bq7LT5ah2MiyDq8pX7kw@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <CAPVBTSfxgw35QaZYJ1VDEGxG=X7tt4bq7LT5ah2MiyDq8pX7kw@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71209 Cc: 71209 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 01/06/2024 04:42, Noah Peart wrote: > I suppose most people keep the default font-locking for variable-name > and variable-use, so these missing rules go unnoticed. Only if you set treesit-font-lock-level to 4, right?
bug-gnu-emacs@HIDDEN:bug#71209; Package emacs.
Full text available.
Received: (at 71209) by debbugs.gnu.org; 1 Jun 2024 01:43:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 31 21:43:43 2024
Received: from localhost ([127.0.0.1]:55511 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sDDmZ-0007ma-Ix
for submit <at> debbugs.gnu.org; Fri, 31 May 2024 21:43:43 -0400
Received: from mail-oa1-f46.google.com ([209.85.160.46]:59844)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <noah.v.peart@HIDDEN>) id 1sDDmU-0007mJ-99
for 71209 <at> debbugs.gnu.org; Fri, 31 May 2024 21:43:42 -0400
Received: by mail-oa1-f46.google.com with SMTP id
586e51a60fabf-25074a27485so1124388fac.3
for <71209 <at> debbugs.gnu.org>; Fri, 31 May 2024 18:43:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1717206140; x=1717810940; darn=debbugs.gnu.org;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:from:to:cc:subject:date:message-id:reply-to;
bh=zYc+/0SvjoNf+tisL82mEpR/0n8JhTSW95AIr2x26yI=;
b=Hw1LLQ8GluQzAFE4qATiSgmI8Euobg3YNHEQsiVtjQ6tHIuVPZL3p1eHqbDIfrfWcE
HdqBW16aRFyn00zi+18RWQVtaXRfGujyvWMiJ+jMl1/hCN9kOdgPApWK3EIO0BL8btcL
eSIcjFqUY1kLUTimEhwqunAY7O19Cs2Um/dDVUm3h19E3ZsiQjRxfIVgFo5RcFy0OYTK
R/TLMfFmGipq/9RsAUhTRW8qqz64/vvm/QlFJioElhXZjQjK9v5lqRvdE6EvYITY0A8/
bvprqnIWkjqiKDt9ep4WsETbIufh9BkNKdrcUxPeX6v2KRHrJGS5Bvx4KnMyFhrDNRhq
tXhA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1717206140; x=1717810940;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=zYc+/0SvjoNf+tisL82mEpR/0n8JhTSW95AIr2x26yI=;
b=kGtTevFWjY+DR2u2mdGW3zm3d3PZ0ljvUj1uocRtTgtJIvnzrJ+/6CNBzO69Swta8O
dqN3JHQ6bSKNXP6kpdstgScWbANTqePewl7YRvM5PRbGLortjs0UFjPVi6ku0G9WRe3H
w2Dfv28LHw+SUDx42t263zI0e58NOMwJ4LVefwTwn3AhY/pBaQWpC/7s5FxbRAZo+PRU
Liznfglq7x89/NztGZ4FR1YZYy9tlnYKKbEC+HAwMObvUWr0yogmWRa7tln9R/p1KlAG
NFwHONegsLt4/009josZhYOhnesOyV5mIQQgLOuP6HcmqzaArJ3PEsgKX+wCDYXY01zB
lgPg==
X-Gm-Message-State: AOJu0Yy9Et+faTJaNS5MRNrk0xIPNTnPk/sNJfdrifDFrW0QYzczqfRh
2hgEhWlLattGi0MmPPA6DlPjSWq+RRaTulhkhB1/rKgmkWsZrDv17Pz4Mvsu4nQWhqjXKwVyWZv
LKnUxli3ztDbVfYyuI1B7joIf588=
X-Google-Smtp-Source: AGHT+IFGdTAerRyH8rJVJrcIA0coaRxV7IfxHSaUYV0qN7KZ4qVkAUKPx5m2+8p1gvXPGPUKQR/8nULAHoVsUvvh7wI=
X-Received: by 2002:a05:6870:858d:b0:24f:d207:2e00 with SMTP id
586e51a60fabf-2508bb742afmr4651045fac.51.1717206140396; Fri, 31 May 2024
18:42:20 -0700 (PDT)
MIME-Version: 1.0
References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN>
<Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev>
<CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@HIDDEN>
<AdChXDjyAulWCxyswxNe-7IMxwPnhNsGnE-QxJ3BN3-HqbU3GhOFti8yQLH_D-euvftZoKEHO6Bvwb1gXojFkT4JhTstpo8Ad-Dqp7nhebE=@rjt.dev>
In-Reply-To: <AdChXDjyAulWCxyswxNe-7IMxwPnhNsGnE-QxJ3BN3-HqbU3GhOFti8yQLH_D-euvftZoKEHO6Bvwb1gXojFkT4JhTstpo8Ad-Dqp7nhebE=@rjt.dev>
From: Noah Peart <noah.v.peart@HIDDEN>
Date: Fri, 31 May 2024 18:42:07 -0700
Message-ID: <CAPVBTSfxgw35QaZYJ1VDEGxG=X7tt4bq7LT5ah2MiyDq8pX7kw@HIDDEN>
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
range clauses
To: Randy Taylor <dev@HIDDEN>
Content-Type: multipart/alternative; boundary="000000000000012af00619ca3646"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 71209
Cc: 71209 <at> debbugs.gnu.org, Dmitry Gutov <dmitry@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--000000000000012af00619ca3646
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
> c++-ts-mode will need to get updated too
I've been using these for c++, I think they are still missing
;; for (auto x: ...)
(for_range_loop
declarator: (identifier) @font-lock-variable-name-face)
;; auto& x
(reference_declarator
(identifier) @font-lock-variable-name-face)
;; auto[&] [x, y]
(structured_binding_declarator
_ [(identifier)] @font-lock-variable-name-face)
I suppose most people keep the default font-locking for variable-name
and variable-use, so these missing rules go unnoticed.
On Fri, May 31, 2024 at 6:09=E2=80=AFPM Randy Taylor <dev@HIDDEN> wrote:
> On Thursday, May 30th, 2024 at 09:25, Noah Peart <noah.v.peart@HIDDEN>
> wrote:
> > > it seems we already highlight this when at treesit-font-lock-level 4?
> > They get highlighted with `font-lock-variable-use-face` at level 4, but
> shouldn't
> > they be getting `font-lock-variable-name-face` in the 'definition
> feature?
> >
>
> Indeed, thanks. Could someone please install the patch? Thanks in advance=
.
>
> Seems like c++-ts-mode will need to get updated too, as with:
> for (const auto& i : things) {}
> i gets font-lock-variable-use-face. I wonder if any other ts modes
> have similar issues.
>
--000000000000012af00619ca3646
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">> c++-ts-mode will need to get updated too<div><br></di=
v><div>I've been using these for c++, I think they are still missing</d=
iv><div><br></div><div>=C2=A0 =C2=A0 ;; for (auto x: ...)<br></div><div>=C2=
=A0 =C2=A0 (for_range_loop<br>=C2=A0 =C2=A0 =C2=A0declarator: (identifier) =
@font-lock-variable-name-face)<br>=C2=A0 =C2=A0 ;; auto& x<br>=C2=A0 =
=C2=A0 (reference_declarator<br>=C2=A0 =C2=A0 =C2=A0(identifier) @font-lock=
-variable-name-face)<br>=C2=A0 =C2=A0 ;; auto[&] [x, y]<br>=C2=A0 =C2=
=A0 (structured_binding_declarator<br>=C2=A0 =C2=A0 =C2=A0_ [(identifier)] =
@font-lock-variable-name-face)<br></div><div><br></div><div>I suppose most =
people keep the default font-locking for variable-name</div><div>and variab=
le-use, so these missing rules go unnoticed.</div></div><br><div class=3D"g=
mail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, May 31, 2024 at 6=
:09=E2=80=AFPM Randy Taylor <<a href=3D"mailto:dev@HIDDEN">dev@HIDDEN<=
/a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0=
px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">O=
n Thursday, May 30th, 2024 at 09:25, Noah Peart <<a href=3D"mailto:noah.=
v.peart@HIDDEN" target=3D"_blank">noah.v.peart@HIDDEN</a>> wrote:<=
br>
> > it seems we already highlight this when at treesit-font-lock-leve=
l 4?<br>
> They get highlighted with `font-lock-variable-use-face` at level 4, bu=
t shouldn't<br>
> they be getting `font-lock-variable-name-face` in the 'definition =
feature?<br>
> <br>
<br>
Indeed, thanks. Could someone please install the patch? Thanks in advance.<=
br>
<br>
Seems like c++-ts-mode will need to get updated too, as with:<br>
for (const auto& i : things) {}<br>
i gets font-lock-variable-use-face. I wonder if any other ts modes<br>
have similar issues.<br>
</blockquote></div>
--000000000000012af00619ca3646--
bug-gnu-emacs@HIDDEN:bug#71209; Package emacs.
Full text available.
Received: (at 71209) by debbugs.gnu.org; 1 Jun 2024 01:10:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 31 21:10:02 2024
Received: from localhost ([127.0.0.1]:55492 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sDDFx-0006vc-Rz
for submit <at> debbugs.gnu.org; Fri, 31 May 2024 21:10:02 -0400
Received: from mail-4018.proton.ch ([185.70.40.18]:26181)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <dev@HIDDEN>) id 1sDDFr-0006vK-SF
for 71209 <at> debbugs.gnu.org; Fri, 31 May 2024 21:10:00 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev;
s=protonmail2; t=1717204177; x=1717463377;
bh=Jsup472eKhMeEumYVnnWhtIJYFwU+KvdJ1NJWSkj9pY=;
h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
Message-ID:BIMI-Selector;
b=sv+FqB3sFROKHbRzjv13qzkQGr082dm72ryKq7cvoY4CMcqJRtSGFQN2nGO2QtFsM
Kt5YvdSvyTUTigb/3szmddNWz5swNT6r9t0i3F8TrKtw5WhueJjIKL/3NjuZESQ35T
JA1+nBDZcHYqv4vdKAN2Q7trKvOsa+FdaPehSeXxZx8Emls58e7mURnpBF0hdzQ/Km
3BeUSDzd6I+rjIbpW9FQwX7b8kwOOACc3aaIjSqJTsfOsD1TMXVVNvS+JTKeZ5GNtP
8Wb0JsY930BH8T7UUoaNCgqwZwapW8kXD8W0ps+Gspo75yWV/igdHM7iXsjbz/AAh9
xPnlhCfPEcNsw==
Date: Sat, 01 Jun 2024 01:09:34 +0000
To: Noah Peart <noah.v.peart@HIDDEN>
From: Randy Taylor <dev@HIDDEN>
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
range clauses
Message-ID: <AdChXDjyAulWCxyswxNe-7IMxwPnhNsGnE-QxJ3BN3-HqbU3GhOFti8yQLH_D-euvftZoKEHO6Bvwb1gXojFkT4JhTstpo8Ad-Dqp7nhebE=@rjt.dev>
In-Reply-To: <CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@HIDDEN>
References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN>
<Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev>
<CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@HIDDEN>
Feedback-ID: 44397038:user:proton
X-Pm-Message-ID: 1d8a650908bb382309f5fa6202f00d5dfda3a132
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 71209
Cc: 71209 <at> debbugs.gnu.org, Dmitry Gutov <dmitry@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
On Thursday, May 30th, 2024 at 09:25, Noah Peart <noah.v.peart@HIDDEN> w=
rote:
> > it seems we already highlight this when at treesit-font-lock-level 4?
> They get highlighted with `font-lock-variable-use-face` at level 4, but s=
houldn't
> they be getting `font-lock-variable-name-face` in the 'definition feature=
?
>=20
Indeed, thanks. Could someone please install the patch? Thanks in advance.
Seems like c++-ts-mode will need to get updated too, as with:
for (const auto& i : things) {}
i gets font-lock-variable-use-face. I wonder if any other ts modes
have similar issues.
bug-gnu-emacs@HIDDEN:bug#71209; Package emacs.
Full text available.Received: (at 71209) by debbugs.gnu.org; 30 May 2024 23:23:52 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 30 19:23:52 2024 Received: from localhost ([127.0.0.1]:52814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sCp7c-0005O6-MJ for submit <at> debbugs.gnu.org; Thu, 30 May 2024 19:23:52 -0400 Received: from fout5-smtp.messagingengine.com ([103.168.172.148]:47921) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1sCp7X-0005Nq-W1 for 71209 <at> debbugs.gnu.org; Thu, 30 May 2024 19:23:47 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.nyi.internal (Postfix) with ESMTP id C002913800C5; Thu, 30 May 2024 19:23:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 30 May 2024 19:23:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1717111407; x=1717197807; bh=C6YJKN4f3mMTHFN8GFhBnY7TI7LSvfowAsQcJprHZgk=; b= i1oj6I6Wlpgw9ZYwyoBtwFsdEpB+uFe8MCy2Qgpi2d+s+dm9BC29h7U8AoyBN2No YrcFZt1chne5DT9oOHlv4o1QK6XUN6uLg1XekEJLFyGcmVKAzTEh69JGflHzE7tW HVeAhcsW9j5/EDK1w1PfL/8un+TMeeuo5ypsGQM4dl8yP9Wjc8moXpDNHVTwPAC0 jl9Jk58NQoE0JgvilTMTN5uoBwN0o5k7OFFBxx9kQ1hCdFSozXS+FYy6vajAqnD2 qpFWYkWlidi/3TcYqLS9JDp3jnkX8XMn9GJdmacWJDoGukN2xzRyFQENGW3HZrEU HmwNvwqvCwTEh0sKxdRXaQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1717111407; x= 1717197807; bh=C6YJKN4f3mMTHFN8GFhBnY7TI7LSvfowAsQcJprHZgk=; b=A DosBaaMbS8fLGDSwc7q9fSDHkc5oKNR9yqP4WVaj0k8iESvFy2b47dqWe/i5oZtN OX0GIWvZLCIlCdYmIEpx8VSNJae+AsZSK+L1L7CnNnAXY5YVpE0IoWZ3ZjE5h0j3 LpNluxOSt0LUUs3k07Utvl5zk1uoSUdI3zdZWAZknoF/tAwvrcPdfBQgWrzUlaXS +PY+v4kJl0iZNOt3M5WHhlzHEZKJp93kRIcs5jd6SimEgv8LtvFvJuyZv3kYa+YF rDKa+4eC4bleQGj2ChE7dnz5kE1BAH7wuFGvlvaYWCM669iW5JW7PvovBw7TXcco xC5CA0MUIorndthUkhxqg== X-ME-Sender: <xms:bwpZZpH7jqNsPdRaITqeIVMlBkesIqrJ3XfxCoc6iQnfNmj6AC2L_w> <xme:bwpZZuV-hwlhDD24jfyhMeotjVKWYdPPNDgGGuUXxV0_twjkKpuKAqBF6eI2y_PkV z4LFhpDbNx55Spt_Zs> X-ME-Received: <xmr:bwpZZrIdL1MR7zRS8OrhJk_JCJjd3StpwKH60nKFkdfPM_hj5Gia0LKWzcppr67WMfpe> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdekhedgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: <xmx:bwpZZvH8uMD1nZVCxqoJxaLvZtZZpOOs_aaOBbZS-RWyhmujnL8sLQ> <xmx:bwpZZvX8c6rNTMlCtROxL0ova0KIcpiCaaD1S-gdtYnCiTgfhVGdew> <xmx:bwpZZqNuafGTpREz7hLS3EnjTMnizAdcabh8WXdMSLJA7BiM0OxZew> <xmx:bwpZZu0eLE5JprZMDueu9o_6mGdkbRdc3hj1Vz2dfIF2M5BtExTQdQ> <xmx:bwpZZqTlhbrQT_ZcDJrv48M1HrdxF_dLZo32l2JFO4gYB5Lo3cSbxSo2> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 30 May 2024 19:23:26 -0400 (EDT) Message-ID: <f7bf3fd0-cc35-476b-bca6-991c7831bc36@HIDDEN> Date: Fri, 31 May 2024 02:23:24 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses To: Noah Peart <noah.v.peart@HIDDEN>, Randy Taylor <dev@HIDDEN> References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN> <Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev> <CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71209 Cc: 71209 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 30/05/2024 16:25, Noah Peart wrote: > > it seems we already highlight this when at treesit-font-lock-level 4? > > They get highlighted with `font-lock-variable-use-face` at level 4, but > shouldn't > they be getting `font-lock-variable-name-face` in the 'definition feature? I think that's a good idea: the local variables idx and val are introduced on that line, so we could indeed call those occurrences "definitions".
bug-gnu-emacs@HIDDEN:bug#71209; Package emacs.
Full text available.
Received: (at 71209) by debbugs.gnu.org; 30 May 2024 13:27:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 30 09:27:31 2024
Received: from localhost ([127.0.0.1]:35651 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sCfoY-0000ji-Ro
for submit <at> debbugs.gnu.org; Thu, 30 May 2024 09:27:31 -0400
Received: from mail-oi1-f175.google.com ([209.85.167.175]:55643)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <noah.v.peart@HIDDEN>) id 1sCfoT-0000jI-Mz
for 71209 <at> debbugs.gnu.org; Thu, 30 May 2024 09:27:29 -0400
Received: by mail-oi1-f175.google.com with SMTP id
5614622812f47-3c9b94951d5so383643b6e.3
for <71209 <at> debbugs.gnu.org>; Thu, 30 May 2024 06:27:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1717075569; x=1717680369; darn=debbugs.gnu.org;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:from:to:cc:subject:date:message-id:reply-to;
bh=zLoJ695Dhyl9jOOzoLFTrePqRinS4WgFdU28Twg+fnA=;
b=W3A5ETchCGr42XFZIcJUhF5GhzoptGDIttqB3/j3BbVNsPrHQeUIAqIHbJGd5YHHyc
3mr04OjpdIhgxeVtFeZeFGbV9h+Y6SlPmK0YnqXCIT6zsCq3rDqIu00U10sDf8cAmFIO
+bqn0VmxiNqO+aTSnVLMnw82SxQqUkqvNOFW6jlWTfR87+TSmQ3KrrrnMKQ00+5rDGq9
cEu59SdvqvthyzBMfhbxYk/TezTZ4/NkDIRnsH/HZgrhev6hGLrzqi79nrqVNVd6Rmtx
wBid5ebMINYRDOhlMfIHcbBTACExHNLcGdEkZy6+kffw39DTJ2dzQjm0+7++yuTnjw0Q
Q91w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1717075569; x=1717680369;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=zLoJ695Dhyl9jOOzoLFTrePqRinS4WgFdU28Twg+fnA=;
b=Fg/tUmCFqpz7W9RirL0Opn9zGVUTxigalZcdgClzouKwZw1VmwjvvpNvHUepqe9foB
GQ3XgwDpg0cM1nD9FoMs+SEwbKMdMlS4g46e+NKXGnbx36OSi7Bq7AQDsuvx0exTw8qh
lQKc4bQ7wKE8HRMXh5r+CkAbCsFi8glOvGWXdRvx7BtqaWVviM2zh8UU0+ORpFuDpgrU
cI+mAs/4rJycqMNTDBQgNwZxqgv9IqhZB+brXNc+dztVYJmzbEic/iumxvCKzWtVlw79
zFPkaMmZzM8zg3AOhiYQGJHnqyhgaTF/fZDfxHJseqpuHFx7xQxrLYMwkAvKuQw3u3jK
GLFw==
X-Gm-Message-State: AOJu0Yyz2Sga5OSRXMaA2nsRg/D/P2FB/3G24R/cEuLE9jHUaqLlbD6k
sFLU/ZhphQIKL1uZjQHHuZa5IfXlL+ukq6LAmqyNtduqBSfiGgh+XkO/hxRdBGCvgCnyH2AibfK
xyd2ChjzD8l7t/1GDixNcxy7yrKPXe8oOEjBGkQ==
X-Google-Smtp-Source: AGHT+IEiN7eynwJmNS0RAv2Srmki8hYbnWzLon3ZwbNarzGRIypYiTA+OTJEL4CGcsIvlv0GWu63WallyLdtTRdFYcw=
X-Received: by 2002:a05:6808:1a:b0:3d1:be9f:c9a3 with SMTP id
5614622812f47-3d1dcbe9aaemr2101806b6e.0.1717075567894; Thu, 30 May 2024
06:26:07 -0700 (PDT)
MIME-Version: 1.0
References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN>
<Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev>
In-Reply-To: <Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev>
From: Noah Peart <noah.v.peart@HIDDEN>
Date: Thu, 30 May 2024 06:25:56 -0700
Message-ID: <CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@HIDDEN>
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
range clauses
To: Randy Taylor <dev@HIDDEN>
Content-Type: multipart/alternative; boundary="00000000000046e5730619abcf0b"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 71209
Cc: 71209 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--00000000000046e5730619abcf0b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
> it seems we already highlight this when at treesit-font-lock-level 4?
They get highlighted with `font-lock-variable-use-face` at level 4, but
shouldn't
they be getting `font-lock-variable-name-face` in the 'definition feature?
On Mon, May 27, 2024 at 7:46=E2=80=AFPM Randy Taylor <dev@HIDDEN> wrote:
> On Sunday, May 26th, 2024 at 08:41, Noah Peart <noah.v.peart@HIDDEN>
> wrote:
>
> > Tags: patch
> >
> > Adds font-locking rule in go-ts-mode to give variables in range clauses
> > font-lock-variable-name-face (in feature 'definition).
> >
> > For example, the following font-locking is added:
> >
> > for idx, val :=3D range arr {}
> > // ^ font-lock-variable-name-face
> > // ^ font-lock-variable-name-face
> >
> > The patch also adds a test case.
> >
> >
> > In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
> > 3.24.33, cairo version 1.16.0) of 2024-05-21 built on noah-X580VD
> > Repository revision: 63d914e377f7cc37056de2503bfbeea831875037
> > Repository branch: master
> > Windowing system distributor 'The X.Org Foundation', version
> 11.0.12101004
> > System Description: Ubuntu 22.04.4 LTS
> >
> > Configured using:
> > 'configure --prefix=3D/usr/local --with-modules --with-tree-sitter
> > --with-threads --with-x-toolkit=3Dgtk3 --with-xwidgets --with-gnutls
> > --with-json --with-mailutils --with-jpeg --with-png --with-rsvg
> > --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=3Dgcc-12
> > CXX=3Dgcc-12'
>
> Thanks, but it seems we already highlight this when at
> treesit-font-lock-level 4?
>
--00000000000046e5730619abcf0b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">> it seems we already highlight this when at treesit-fo=
nt-lock-level 4?<div><br></div><div>They get highlighted with `font-lock-va=
riable-use-face` at level 4, but shouldn't</div><div>they be getting `f=
ont-lock-variable-name-face` in the 'definition feature?</div></div><br=
><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, M=
ay 27, 2024 at 7:46=E2=80=AFPM Randy Taylor <<a href=3D"mailto:dev@HIDDEN=
ev">dev@HIDDEN</a>> wrote:<br></div><blockquote class=3D"gmail_quote" s=
tyle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pad=
ding-left:1ex">On Sunday, May 26th, 2024 at 08:41, Noah Peart <<a href=
=3D"mailto:noah.v.peart@HIDDEN" target=3D"_blank">noah.v.peart@HIDDEN=
</a>> wrote:<br>
<br>
> Tags: patch<br>
> <br>
> Adds font-locking rule in go-ts-mode to give variables in range clause=
s<br>
> font-lock-variable-name-face (in feature 'definition).<br>
> <br>
> For example, the following font-locking is added:<br>
> <br>
> for idx, val :=3D range arr {}<br>
> // ^ font-lock-variable-name-face<br>
> // ^ font-lock-variable-name-face<br>
> <br>
> The patch also adds a test case.<br>
> <br>
> <br>
> In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version<br>
> 3.24.33, cairo version 1.16.0) of 2024-05-21 built on noah-X580VD<br>
> Repository revision: 63d914e377f7cc37056de2503bfbeea831875037<br>
> Repository branch: master<br>
> Windowing system distributor 'The X.Org Foundation', version 1=
1.0.12101004<br>
> System Description: Ubuntu 22.04.4 LTS<br>
> <br>
> Configured using:<br>
> 'configure --prefix=3D/usr/local --with-modules --with-tree-sitter=
<br>
> --with-threads --with-x-toolkit=3Dgtk3 --with-xwidgets --with-gnutls<b=
r>
> --with-json --with-mailutils --with-jpeg --with-png --with-rsvg<br>
> --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=3Dgcc-12<br>
> CXX=3Dgcc-12'<br>
<br>
Thanks, but it seems we already highlight this when at treesit-font-lock-le=
vel 4?<br>
</blockquote></div>
--00000000000046e5730619abcf0b--
bug-gnu-emacs@HIDDEN:bug#71209; Package emacs.
Full text available.
Received: (at 71209) by debbugs.gnu.org; 28 May 2024 02:46:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 27 22:46:26 2024
Received: from localhost ([127.0.0.1]:45516 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sBmr4-00044f-LI
for submit <at> debbugs.gnu.org; Mon, 27 May 2024 22:46:26 -0400
Received: from mail-4022.proton.ch ([185.70.40.22]:52925)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <dev@HIDDEN>) id 1sBmr1-00044N-2R
for 71209 <at> debbugs.gnu.org; Mon, 27 May 2024 22:46:26 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev;
s=protonmail2; t=1716864363; x=1717123563;
bh=N1QGXRemRF2J5rKXqYeR0b80xI35O5zRAjuq8kN51AQ=;
h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
Message-ID:BIMI-Selector;
b=OXjsbNw1ZEfV5ZUXJfHCiL4h5OBakfAU6iv/ST/lojDhLNcIxCYuvE1dGYH7xe6Ia
TZQCUkWc9astfywG8EWAlFJzh4/4RIrJk/3KRpvMhvwIj+3b/a4ZvsM0tCvzRlBZi0
QjfkuK0WNC0F94HilIAG0SXJXp8S0N9Zu2Jp6cbGFds3NpZ5z81mygvg9FZO5RGXOf
YAifBytv2oN1GIzxT3cR9NeuuzjpxllnaJ1y9X5Up4KlSjfhphktvT+mv/Ii7G8p2l
DZlQFMvEaWa0ORL32fMvF0yzsLkENdDF/GK4xw4ONurXVkKsa9OXi//1clf1B5pYfB
gUymRhlpGn9tA==
Date: Tue, 28 May 2024 02:46:00 +0000
To: Noah Peart <noah.v.peart@HIDDEN>
From: Randy Taylor <dev@HIDDEN>
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
range clauses
Message-ID: <Lk8GVhHxj9l9YfGAD2qgrbdR62tNZ1XXxujRsud8RPCiyFZtUb1E_1_CLdZbk-9RUWKAZQcH6gcijrXwnudX9mj9J5xKUL-yZQQMQ5wJ94s=@rjt.dev>
In-Reply-To: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN>
References: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN>
Feedback-ID: 44397038:user:proton
X-Pm-Message-ID: d5cea780f4fcbdb4435617335e287ecfdd06ca95
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 71209
Cc: 71209 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
On Sunday, May 26th, 2024 at 08:41, Noah Peart <noah.v.peart@HIDDEN> wro=
te:
> Tags: patch
>=20
> Adds font-locking rule in go-ts-mode to give variables in range clauses
> font-lock-variable-name-face (in feature 'definition).
>=20
> For example, the following font-locking is added:
>=20
> for idx, val :=3D range arr {}
> // ^ font-lock-variable-name-face
> // ^ font-lock-variable-name-face
>=20
> The patch also adds a test case.
>=20
>=20
> In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
> 3.24.33, cairo version 1.16.0) of 2024-05-21 built on noah-X580VD
> Repository revision: 63d914e377f7cc37056de2503bfbeea831875037
> Repository branch: master
> Windowing system distributor 'The X.Org Foundation', version 11.0.1210100=
4
> System Description: Ubuntu 22.04.4 LTS
>=20
> Configured using:
> 'configure --prefix=3D/usr/local --with-modules --with-tree-sitter
> --with-threads --with-x-toolkit=3Dgtk3 --with-xwidgets --with-gnutls
> --with-json --with-mailutils --with-jpeg --with-png --with-rsvg
> --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=3Dgcc-12
> CXX=3Dgcc-12'
Thanks, but it seems we already highlight this when at treesit-font-lock-le=
vel 4?
bug-gnu-emacs@HIDDEN:bug#71209; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 26 May 2024 12:42:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 26 08:42:06 2024
Received: from localhost ([127.0.0.1]:38559 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sBDCP-0000ol-Fy
for submit <at> debbugs.gnu.org; Sun, 26 May 2024 08:42:05 -0400
Received: from lists.gnu.org ([209.51.188.17]:58364)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <noah.v.peart@HIDDEN>) id 1sBDCM-0000oc-Cv
for submit <at> debbugs.gnu.org; Sun, 26 May 2024 08:42:03 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <noah.v.peart@HIDDEN>)
id 1sBDCD-0008Pp-W7
for bug-gnu-emacs@HIDDEN; Sun, 26 May 2024 08:41:54 -0400
Received: from mail-oa1-x30.google.com ([2001:4860:4864:20::30])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <noah.v.peart@HIDDEN>)
id 1sBDCC-0004b2-7J
for bug-gnu-emacs@HIDDEN; Sun, 26 May 2024 08:41:53 -0400
Received: by mail-oa1-x30.google.com with SMTP id
586e51a60fabf-24ca03ad307so1386397fac.3
for <bug-gnu-emacs@HIDDEN>; Sun, 26 May 2024 05:41:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1716727309; x=1717332109; darn=gnu.org;
h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
:date:message-id:reply-to;
bh=+WlLBGcgI/UkQrJb9hrktJOzR9r3qgx+AmdM9cEqZnQ=;
b=RfvuYh1XtxYj63fwxyVXp1NiDtaYfkZ2pohR2hEVRZaHldN/vJC9gRsXqvmQAjNK9z
X3GSO6G10IPXteMhEFKxs4hDSdWmnhbbV+I0+entCFZbiRaLY+Xv6MG6xiYJFTuNU/SC
hba1YgaJ8+UxvEdsgDL5Gaarr3CLzei3V2ft5LsG/el4OXmJVdgUkjFTrCElUkjUS2ox
sAMntibtEKzL1NP1G0yeCDCLmSdgAesC14hq0P7XasLC8gzEdII1CC+Lw2ogmtpxULjf
jcw0eBvpaCWNrvZUENO0j388R4BaliUJ4HdKCS6KjR77Xj/eRpc6CnAxUu1fzWyefZjN
pa9Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1716727309; x=1717332109;
h=to:subject:message-id:date:from:mime-version:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=+WlLBGcgI/UkQrJb9hrktJOzR9r3qgx+AmdM9cEqZnQ=;
b=lFqkrPP50bSCSDPa78tQXvpLcU0e8BGTip82t7LeU87Ad1JtTHOIAuwz1QH2jue4aX
w8vT8ZRu+7cfE+ShRj2QM0XTZQpcE6h93faUG+ibjuVk6nkIMxHuKFkFGHRcjqvJuesK
RH6OACe97cQ2D75D7Es7j6wDqdCt0nPAwkNztQDP5HLZXiEy8aLg5Sc0Esk1miZazI2W
qOxF8pam66iNs1v65GJRmx2h95EmKQEMaP4xNjzrY5/E+HpvOBc2JLGcX//aLNkniRJc
A8/S1I+kqCYTeWN13lRARlUofNZUBG1BC2xxkBOiQYblTR7XRTedcQYF79RUioVYCGqy
ZkYQ==
X-Gm-Message-State: AOJu0YyYaBFirrQeeLk+Ef+D4LMavxUObLGFqoyxZhgS+wXW+VgbWaKL
JRCK8gnjk/4STSymJYWsTc71n0KYNqZgVKFfvEao/h8Ly4MK50ssctW5WQAjLr2IbSoSr4rHjuP
BFM3FI4cawprlBwDoBkkxag/kwI6ZJYBPVOHa+w==
X-Google-Smtp-Source: AGHT+IFyXfhfa3cRlHA1Fx0FNvljCB+SnGPWyUzRbL/NZoYFBBH074FOBfJBNcLO4f1VdhFxri8YxZjC4gYeSNz6W0I=
X-Received: by 2002:a05:6870:718f:b0:24d:c894:81f6 with SMTP id
586e51a60fabf-24dc8948c59mr5469057fac.33.1716727308710; Sun, 26 May 2024
05:41:48 -0700 (PDT)
MIME-Version: 1.0
From: Noah Peart <noah.v.peart@HIDDEN>
Date: Sun, 26 May 2024 05:41:37 -0700
Message-ID: <CAPVBTSenYw8YFVEJA-Mb2SzK2OPiGjgjOw3qUOEbH_VfEYJgDw@HIDDEN>
Subject: [PATCH] Add font-locking for variables in go-ts-mode range clauses
To: bug-gnu-emacs@HIDDEN
Content-Type: multipart/mixed; boundary="00000000000069cead06195ab9f9"
Received-SPF: pass client-ip=2001:4860:4864:20::30;
envelope-from=noah.v.peart@HIDDEN; helo=mail-oa1-x30.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)
--00000000000069cead06195ab9f9
Content-Type: multipart/alternative; boundary="00000000000069ceab06195ab9f7"
--00000000000069ceab06195ab9f7
Content-Type: text/plain; charset="UTF-8"
Tags: patch
Adds font-locking rule in go-ts-mode to give variables in range clauses
font-lock-variable-name-face (in feature 'definition).
For example, the following font-locking is added:
for idx, val := range arr {}
// ^ font-lock-variable-name-face
// ^ font-lock-variable-name-face
The patch also adds a test case.
In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2024-05-21 built on noah-X580VD
Repository revision: 63d914e377f7cc37056de2503bfbeea831875037
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.4 LTS
Configured using:
'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'
--00000000000069ceab06195ab9f7
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">Tags: patch<br><br>Adds font-locking rule in go-ts-mode to=
give variables in range clauses<br>font-lock-variable-name-face (in featur=
e 'definition).<br><br>For example, the following font-locking is added=
:<br><br>for idx, val :=3D range arr {}<br>//=C2=A0 =C2=A0 =C2=A0^ font-loc=
k-variable-name-face<br>//=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^ font-l=
ock-variable-name-face<br><br>The patch also adds a test case.<br><br><br>I=
n GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version<br>3.24.33,=
cairo version 1.16.0) of 2024-05-21 built on noah-X580VD<br>Repository rev=
ision: 63d914e377f7cc37056de2503bfbeea831875037<br>Repository branch: maste=
r<br>Windowing system distributor 'The X.Org Foundation', version 1=
1.0.12101004<br>System Description: Ubuntu 22.04.4 LTS<br><br>Configured us=
ing:<br>=C2=A0'configure --prefix=3D/usr/local --with-modules --with-tr=
ee-sitter<br>--with-threads --with-x-toolkit=3Dgtk3 --with-xwidgets --with-=
gnutls<br>--with-json --with-mailutils --with-jpeg --with-png --with-rsvg<b=
r>--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=3Dgcc-12<br>CXX=
=3Dgcc-12'<br></div>
--00000000000069ceab06195ab9f7--
--00000000000069cead06195ab9f9
Content-Type: text/x-patch; charset="US-ASCII";
name="0001-Add-font-locking-for-variables-in-go-ts-mode-range-c.patch"
Content-Disposition: attachment;
filename="0001-Add-font-locking-for-variables-in-go-ts-mode-range-c.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lwnj2otl0>
X-Attachment-Id: f_lwnj2otl0
RnJvbSAxYjZiMmE3MDAxZmYwNzlkODFhZjdkNDJjN2VlOThlOGU3MzE4MzkwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FoIFBlYXJ0IDxub2FoLnYucGVhcnRAZ21haWwuY29tPgpE
YXRlOiBTdW4sIDI2IE1heSAyMDI0IDA1OjM0OjM0IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gQWRk
IGZvbnQtbG9ja2luZyBmb3IgdmFyaWFibGVzIGluIGdvLXRzLW1vZGUgcmFuZ2UgY2xhdXNlcwoK
KiBsaXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLmVsIChnby10cy1tb2RlLS1mb250LWxvY2stc2V0
dGluZ3MpOgpBZGQgZm9udC1sb2NraW5nIHJ1bGUgZm9yIHZhcmlhYmxlIG5hbWVzIGluIHJhbmdl
IGNsYXVzZXMuCiogdGVzdC9saXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLXRlc3RzLmVsIChnby10
cy10ZXN0LWZvbnQtbG9jayk6CkFkZCBmb250LWxvY2tpbmcgdGVzdCBmb3IgZ28tdHMtbW9kZS4K
KiB0ZXN0L2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUtcmVzb3VyY2VzL2ZvbnQtbG9jay5nbzog
TmV3IGZpbGUKZm9yIGdvLXRzLW1vZGUgZm9udC1sb2NraW5nIHRlc3RzLgotLS0KIGxpc3AvcHJv
Z21vZGVzL2dvLXRzLW1vZGUuZWwgICAgICAgICAgICAgICAgICAgICAgICAgIHwgNSArKysrLQog
dGVzdC9saXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLXJlc291cmNlcy9mb250LWxvY2suZ28gfCA1
ICsrKysrCiB0ZXN0L2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUtdGVzdHMuZWwgICAgICAgICAg
ICAgICB8IDUgKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMSBkZWxl
dGlvbigtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IHRlc3QvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9k
ZS1yZXNvdXJjZXMvZm9udC1sb2NrLmdvCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvZ28t
dHMtbW9kZS5lbCBiL2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUuZWwKaW5kZXggYWVmMjI0YWIz
ZmEuLjQzZjdlMDQyNTkwIDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLmVs
CisrKyBiL2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUuZWwKQEAgLTE4MCw3ICsxODAsMTAgQEAg
Z28tdHMtbW9kZS0tZm9udC1sb2NrLXNldHRpbmdzCiAgICAgICAgICAgICAgKGlkZW50aWZpZXIp
IEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlCiAgICAgICAgICAgICAgKCIsIiAoaWRlbnRp
ZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpKikpCiAgICAgICh2YXJfc3BlYyBu
YW1lOiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UKLSAgICAgICAg
ICAgICAgICgiLCIgbmFtZTogKGlkZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1m
YWNlKSopKQorICAgICAgICAgICAgICAgKCIsIiBuYW1lOiAoaWRlbnRpZmllcikgQGZvbnQtbG9j
ay12YXJpYWJsZS1uYW1lLWZhY2UpKikKKyAgICAgKHJhbmdlX2NsYXVzZQorICAgICAgbGVmdDog
KGV4cHJlc3Npb25fbGlzdAorICAgICAgICAgICAgIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZh
cmlhYmxlLW5hbWUtZmFjZSkpKQogCiAgICA6bGFuZ3VhZ2UgJ2dvCiAgICA6ZmVhdHVyZSAnZnVu
Y3Rpb24KZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS1yZXNvdXJj
ZXMvZm9udC1sb2NrLmdvIGIvdGVzdC9saXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLXJlc291cmNl
cy9mb250LWxvY2suZ28KbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLjRl
N2E4ZTE3MTBiCi0tLSAvZGV2L251bGwKKysrIGIvdGVzdC9saXNwL3Byb2dtb2Rlcy9nby10cy1t
b2RlLXJlc291cmNlcy9mb250LWxvY2suZ28KQEAgLTAsMCArMSw1IEBACitmb3IgaWR4LCB2YWwg
Oj0gcmFuZ2UgYXJyIHt9CisvLyAgIF4gZm9udC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFjZQorLy8g
ICAgICAgIF4gZm9udC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFjZQorZm9yIGlkeCA6PSAwOyBpZHgg
PCBuOyBpZHgrKyB7fQorLy8gICBeIGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UKZGlmZiAt
LWdpdCBhL3Rlc3QvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS10ZXN0cy5lbCBiL3Rlc3QvbGlz
cC9wcm9nbW9kZXMvZ28tdHMtbW9kZS10ZXN0cy5lbAppbmRleCBmZDliNTdlODY5MS4uZjM2ZGJk
ZTUxMDMgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS10ZXN0cy5l
bAorKysgYi90ZXN0L2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUtdGVzdHMuZWwKQEAgLTI3LDUg
KzI3LDEwIEBAIGdvLXRzLW1vZGUtdGVzdC1pbmRlbnRhdGlvbgogICAoc2tpcC11bmxlc3MgKHRy
ZWVzaXQtcmVhZHktcCAnZ28pKQogICAoZXJ0LXRlc3QtZXJ0cy1maWxlIChlcnQtcmVzb3VyY2Ut
ZmlsZSAiaW5kZW50LmVydHMiKSkpCiAKKyhlcnQtZGVmdGVzdCBnby10cy10ZXN0LWZvbnQtbG9j
ayAoKQorICAoc2tpcC11bmxlc3MgKHRyZWVzaXQtcmVhZHktcCAnZ28pKQorICAobGV0ICgodHJl
ZXNpdC1mb250LWxvY2stbGV2ZWwgNCkpCisgICAgKGVydC1mb250LWxvY2stdGVzdC1maWxlIChl
cnQtcmVzb3VyY2UtZmlsZSAiZm9udC1sb2NrLmdvIikgJ2dvLXRzLW1vZGUpKSkKKwogKHByb3Zp
ZGUgJ2dvLXRzLW1vZGUtdGVzdHMpCiA7OzsgZ28tdHMtbW9kZS10ZXN0cy5lbCBlbmRzIGhlcmUK
LS0gCjIuMzQuMQoK
--00000000000069cead06195ab9f9--
Noah Peart <noah.v.peart@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#71209; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.