GNU logs - #72018, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#72018: 30.0.60; [PATCH] Don't emit a prompt when a background Eshell process is killed
Resent-From: Jim Porter <jporterbugs@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 09 Jul 2024 18:05:01 +0000
Resent-Message-ID: <handler.72018.B.17205482567434 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 72018 <at> debbugs.gnu.org
Content-Type: multipart/mixed; boundary="------------OLPez0swK1XLYct0OhuJJ91l"
Message-ID: <c2c8af49-100e-c97f-6890-9692a40e6329@HIDDEN>
Date: Tue, 9 Jul 2024 11:04:05 -0700
MIME-Version: 1.0
Content-Language: en-US
From: Jim Porter <jporterbugs@HIDDEN>
Received-SPF: pass client-ip=2607:f8b0:4864:20::12f;
 envelope-from=jporterbugs@HIDDEN; helo=mail-il1-x12f.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

This is a multi-part message in MIME format.
--------------OLPez0swK1XLYct0OhuJJ91l
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Steps to reproduce:

   emacs -Q -f eshell
   $ sleep 100 &
   $ kill -9 <sleep's process id>

After this, you'll see two Eshell prompts get emitted (one with a "[9]" 
for the exit status of "sleep"). We don't want to emit prompts when 
background processes die though.

This is a regression from Emacs 29, likely due to some changes I made to 
improve support for complex background commands. Eli, is this ok to 
merge to the release branch?
--------------OLPez0swK1XLYct0OhuJJ91l
Content-Type: text/plain; charset=UTF-8;
 name="0001-Don-t-emit-a-prompt-in-Eshell-when-a-background-comm.patch"
Content-Disposition: attachment;
 filename*0="0001-Don-t-emit-a-prompt-in-Eshell-when-a-background-comm.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSAzZTVhNzAyZjAxMzZjYzZhMDcxNTQ2YTg1NGFlYTU0NTM2Yzg3NzgzIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j
b20+CkRhdGU6IFR1ZSwgOSBKdWwgMjAyNCAxMDo0NTozNSAtMDcwMApTdWJqZWN0OiBbUEFU
Q0hdIERvbid0IGVtaXQgYSBwcm9tcHQgaW4gRXNoZWxsIHdoZW4gYSBiYWNrZ3JvdW5kIGNv
bW1hbmQgaXMKIGtpbGxlZAoKKiBsaXNwL2VzaGVsbC9lc2gtY21kLmVsIChlc2hlbGwtcmVz
dW1lLWNvbW1hbmQpOiBDaGVjayBmb3IKYmFja2dyb3VuZC1uZXNzIGJlZm9yZSByZXNldHRp
bmcgdGhlIHByb21wdC4KCiogdGVzdC9saXNwL2VzaGVsbC9lc2gtY21kLXRlc3RzLmVsCihl
c2gtY21kLXRlc3QvYmFja2dyb3VuZC9zaW1wbGUtY29tbWFuZCk6IE1ha2UgdGhlIHJlZ2V4
cCBhIGJpdApzdHJpY3Rlci4KKGVzaC1jbWQtdGVzdC9iYWNrZ3JvdW5kL2tpbGwpOiBOZXcg
dGVzdC4KLS0tCiBsaXNwL2VzaGVsbC9lc2gtY21kLmVsICAgICAgICAgICAgfCAgNyArKysr
Ky0tCiB0ZXN0L2xpc3AvZXNoZWxsL2VzaC1jbWQtdGVzdHMuZWwgfCAxNCArKysrKysrKysr
KysrLQogMiBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygt
KQoKZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwgYi9saXNwL2VzaGVsbC9l
c2gtY21kLmVsCmluZGV4IDBiMzEzNzEyN2QyLi5kMGRlNmU1NWNlNiAxMDA2NDQKLS0tIGEv
bGlzcC9lc2hlbGwvZXNoLWNtZC5lbAorKysgYi9saXNwL2VzaGVsbC9lc2gtY21kLmVsCkBA
IC0xMDQwLDggKzEwNDAsMTEgQEAgZXNoZWxsLXJlc3VtZS1jb21tYW5kCiAgICAgICAgICAg
ICAgICAgIChub3QgKHN0cmluZy1tYXRjaCBlc2hlbGwtcmVzZXQtc2lnbmFscyBzdGF0dXMp
KSkKICAgICAgICAgICAgIChlc2hlbGwtcmVzdW1lLWV2YWwgY29tbWFuZCkKICAgICAgICAg
ICAoZXNoZWxsLXJlbW92ZS1jb21tYW5kIGNvbW1hbmQpCi0gICAgICAgICAgKGRlY2xhcmUt
ZnVuY3Rpb24gZXNoZWxsLXJlc2V0ICJlc2gtbW9kZSIgKCZvcHRpb25hbCBuby1ob29rcykp
Ci0gICAgICAgICAgKGVzaGVsbC1yZXNldCkpKSkpKQorICAgICAgICAgIDs7IFJlc2V0IHRo
ZSBwcm9tcHQgaWYgdGhlIGNvbW1hbmQgd2UganVzdCBhYm9ydGVkIHdhcyBpbiB0aGUKKyAg
ICAgICAgICA7OyBmb3JlZ3JvdW5kLgorICAgICAgICAgICh1bmxlc3MgKGNhciBjb21tYW5k
KQorICAgICAgICAgICAgKGRlY2xhcmUtZnVuY3Rpb24gZXNoZWxsLXJlc2V0ICJlc2gtbW9k
ZSIgKCZvcHRpb25hbCBuby1ob29rcykpCisgICAgICAgICAgICAoZXNoZWxsLXJlc2V0KSkp
KSkpKQogCiAoZGVmdW4gZXNoZWxsLXJlc3VtZS1ldmFsIChjb21tYW5kKQogICAiRGVzdHJ1
Y3RpdmVseSBldmFsdWF0ZSBhIENPTU1BTkQgd2hpY2ggbWF5IG5lZWQgdG8gYmUgZGVmZXJy
ZWQuCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZXNoZWxsL2VzaC1jbWQtdGVzdHMuZWwgYi90
ZXN0L2xpc3AvZXNoZWxsL2VzaC1jbWQtdGVzdHMuZWwKaW5kZXggNzBlMTkwMWMxNjkuLmQ4
MTI0YTE5YWY2IDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvZXNoZWxsL2VzaC1jbWQtdGVzdHMu
ZWwKKysrIGIvdGVzdC9saXNwL2VzaGVsbC9lc2gtY21kLXRlc3RzLmVsCkBAIC0xMTMsNyAr
MTEzLDcgQEAgZXNoLWNtZC10ZXN0L2JhY2tncm91bmQvc2ltcGxlLWNvbW1hbmQKICAgICAo
d2l0aC10ZW1wLWVzaGVsbAogICAgICAoZXNoZWxsLW1hdGNoLWNvbW1hbmQtb3V0cHV0CiAg
ICAgICAoZm9ybWF0ICIqZWNobyBoaSA+ICM8JXM+ICYiIGJ1Zm5hbWUpCi0gICAgICAocngg
IltlY2hvIiAoPyAiLmV4ZSIpICJdICIgKCsgZGlnaXQpICJcbiIpKQorICAgICAgKHJ4IGJv
cyAiW2VjaG8iICg/ICIuZXhlIikgIl0gIiAoKyBkaWdpdCkgIlxuIikpCiAgICAgIChlc2hl
bGwtd2FpdC1mb3Itc3VicHJvY2VzcyB0KSkKICAgICAoc2hvdWxkIChlcXVhbCAoYnVmZmVy
LXN0cmluZykgImhpXG4iKSkpKQogCkBAIC0xMjksNiArMTI5LDE4IEBAIGVzaC1jbWQtdGVz
dC9iYWNrZ3JvdW5kL3N1YmNvbW1hbmQKICAgICAgKGVzaGVsbC13YWl0LWZvci1zdWJwcm9j
ZXNzIHQpKQogICAgIChzaG91bGQgKGVxdWFsIChidWZmZXItc3RyaW5nKSAib2xsZWhcbiIp
KSkpCiAKKyhlcnQtZGVmdGVzdCBlc2gtY21kLXRlc3QvYmFja2dyb3VuZC9raWxsICgpCisg
ICJNYWtlIHN1cmUgdGhhdCBhIGJhY2tncm91bmQgY29tbWFuZCB0aGF0IGdldHMga2lsbGVk
IGRvZXNuJ3QgZW1pdCBhIHByb21wdC4iCisgIChza2lwLXVubGVzcyAoZXhlY3V0YWJsZS1m
aW5kICJzbGVlcCIpKQorICAobGV0ICgoYmFja2dyb3VuZC1tZXNzYWdlIChyeCBib3MgIltz
bGVlcCIgKD8gIi5leGUiKSAiXSAiICgrIGRpZ2l0KSAiXG4iKSkpCisgICAgKHdpdGgtdGVt
cC1lc2hlbGwKKyAgICAgIChlc2hlbGwtbWF0Y2gtY29tbWFuZC1vdXRwdXQgIipzbGVlcCAx
MCAmIiBiYWNrZ3JvdW5kLW1lc3NhZ2UpCisgICAgICAoa2lsbC1wcm9jZXNzIChjYWFyIGVz
aGVsbC1wcm9jZXNzLWxpc3QpKQorICAgICAgKGVzaGVsbC13YWl0LWZvci1zdWJwcm9jZXNz
IHQpCisgICAgICA7OyBFbnN1cmUgd2UgZGlkbid0IGVtaXQgYW5vdGhlciBwcm9tcHQgYWZ0
ZXIga2lsbGluZyB0aGUKKyAgICAgIDs7IGJhY2tncm91bmQgcHJvY2Vzcy4KKyAgICAgIChz
aG91bGQgKGVzaGVsbC1tYXRjaC1vdXRwdXQgYmFja2dyb3VuZC1tZXNzYWdlKSkpKSkKKwog
DAogOzsgTGlzcCBmb3JtcwogCi0tIAoyLjI1LjEKCg==

--------------OLPez0swK1XLYct0OhuJJ91l--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Jim Porter <jporterbugs@HIDDEN>
Subject: bug#72018: Acknowledgement (30.0.60; [PATCH] Don't emit a prompt
 when a background Eshell process is killed)
Message-ID: <handler.72018.B.17205482567434.ack <at> debbugs.gnu.org>
References: <c2c8af49-100e-c97f-6890-9692a40e6329@HIDDEN>
X-Gnu-PR-Message: ack 72018
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 72018 <at> debbugs.gnu.org
Date: Tue, 09 Jul 2024 18:05:01 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 72018 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
72018: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72018
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#72018: 30.0.60; [PATCH] Don't emit a prompt when a background Eshell process is killed
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 10 Jul 2024 11:17:01 +0000
Resent-Message-ID: <handler.72018.B72018.172061018316307 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Jim Porter <jporterbugs@HIDDEN>
Cc: 72018 <at> debbugs.gnu.org
Date: Wed, 10 Jul 2024 14:16:05 +0300
Message-Id: <86frsho5u2.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <c2c8af49-100e-c97f-6890-9692a40e6329@HIDDEN> (message from
 Jim Porter on Tue, 9 Jul 2024 11:04:05 -0700)
References: <c2c8af49-100e-c97f-6890-9692a40e6329@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> Date: Tue, 9 Jul 2024 11:04:05 -0700
> From: Jim Porter <jporterbugs@HIDDEN>
> 
> This is a regression from Emacs 29, likely due to some changes I made to 
> improve support for complex background commands. Eli, is this ok to 
> merge to the release branch?

I don't think I understand the essence of the change, and thus cannot
appreciate its effects enough to be able to answer this.  What is the
significance of '(car command)' in this hunk:

> +          ;; Reset the prompt if the command we just aborted was in the
> +          ;; foreground.
> +          (unless (car command)
> +            (declare-function eshell-reset "esh-mode" (&optional no-hooks))
> +            (eshell-reset)))))))

IOW, why '(car command)' is used as an indication of a fore/background
command?  Also, why does the comment say "foreground" while your text
says we don't want the prompt if the killed program was in the
background?

Last modified: Wed, 10 Jul 2024 11:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.