Received: (at 72018) by debbugs.gnu.org; 10 Jul 2024 11:16:23 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jul 10 07:16:23 2024 Received: from localhost ([127.0.0.1]:54988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sRVJ9-0004Ev-9r for submit <at> debbugs.gnu.org; Wed, 10 Jul 2024 07:16:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sRVJ7-0004ET-6d for 72018 <at> debbugs.gnu.org; Wed, 10 Jul 2024 07:16:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sRVIu-0004ML-MH; Wed, 10 Jul 2024 07:16:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=j1WVJikiDBbRcwfeHkzKNHn+Ghi1flgpTmZ3l5A6OYc=; b=o0jYxd4kIQsC Z5tFIa9cgVqcq+6brQ/CSzXgGn7uRBPN0k1ruZId1pUWUWHoS9Q/kHEsjqBhexSGagWD7D58bqbKe grJHNNwBVjynU/2gkUiqlApVrVSIhVEba4nhZiWRF8LQKT7CHSsvuOp5GrtBDC9LTU6ya0BKSMTey FkG6N0kJkMlIsaO+DmrzytBpr+W8ulRg800ULrzc79d855RK2ADY1C/4jOMJLOZAwJ1nxCYNhSN4I 7NFAY4v5frKEDqvGOzPkhDQBYYCYOgLYPqXoj8L3cHZ8awOVWFW1aBmRMvzDMxxWtZQitwVNfHYZV VBsOqBxDF00kwNTUvxuWRg==; Date: Wed, 10 Jul 2024 14:16:05 +0300 Message-Id: <86frsho5u2.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Jim Porter <jporterbugs@HIDDEN> In-Reply-To: <c2c8af49-100e-c97f-6890-9692a40e6329@HIDDEN> (message from Jim Porter on Tue, 9 Jul 2024 11:04:05 -0700) Subject: Re: bug#72018: 30.0.60; [PATCH] Don't emit a prompt when a background Eshell process is killed References: <c2c8af49-100e-c97f-6890-9692a40e6329@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72018 Cc: 72018 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Tue, 9 Jul 2024 11:04:05 -0700 > From: Jim Porter <jporterbugs@HIDDEN> > > This is a regression from Emacs 29, likely due to some changes I made to > improve support for complex background commands. Eli, is this ok to > merge to the release branch? I don't think I understand the essence of the change, and thus cannot appreciate its effects enough to be able to answer this. What is the significance of '(car command)' in this hunk: > + ;; Reset the prompt if the command we just aborted was in the > + ;; foreground. > + (unless (car command) > + (declare-function eshell-reset "esh-mode" (&optional no-hooks)) > + (eshell-reset))))))) IOW, why '(car command)' is used as an indication of a fore/background command? Also, why does the comment say "foreground" while your text says we don't want the prompt if the killed program was in the background?
bug-gnu-emacs@HIDDEN:bug#72018; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 9 Jul 2024 18:04:16 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 09 14:04:16 2024 Received: from localhost ([127.0.0.1]:54042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sRFCK-0001vq-DB for submit <at> debbugs.gnu.org; Tue, 09 Jul 2024 14:04:16 -0400 Received: from lists.gnu.org ([209.51.188.17]:39894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jporterbugs@HIDDEN>) id 1sRFCI-0001vi-52 for submit <at> debbugs.gnu.org; Tue, 09 Jul 2024 14:04:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <jporterbugs@HIDDEN>) id 1sRFCC-00045n-92 for bug-gnu-emacs@HIDDEN; Tue, 09 Jul 2024 14:04:08 -0400 Received: from mail-il1-x12f.google.com ([2607:f8b0:4864:20::12f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <jporterbugs@HIDDEN>) id 1sRFCA-0001Xc-EP for bug-gnu-emacs@HIDDEN; Tue, 09 Jul 2024 14:04:07 -0400 Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-3817084f7dbso25035845ab.2 for <bug-gnu-emacs@HIDDEN>; Tue, 09 Jul 2024 11:04:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720548245; x=1721153045; darn=gnu.org; h=subject:from:to:content-language:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=zQ7+v9t2C2F6+a3q2/zafrYeZ/GhYO+C2vpjiNPpNso=; b=ZtOh9lhbmjNvWi80TWNYXOHGHIWZvy6IZOFXuO6m5KSg2jgR7ONH7B7AjdbWbaqjOZ 9s2DvDGOe5pwSnNg0S88DFI8RREPtrDHmUMfVc1zhBH7DZphZ3dQAWWixIudUAwuPjfE veRVQ1aElSBDCO2rWV8M2ZO7lPa5vR7h3gfWag6p357Am/EmMM7z3jcDNg6ovJ92aRiK DMp0RKFXnTK7x1c3NFCzCg3MmL5YbsRdTvkjhaOm0RKwW2QnhvDjrpADjqRdW3NPT24x u2CBEzr9G4VARVetCFHxJeBx34U9rkSbt5rSHwYRetfKJEMAZAnYr1dIvF8bvWVmiwqb 4uWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720548245; x=1721153045; h=subject:from:to:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zQ7+v9t2C2F6+a3q2/zafrYeZ/GhYO+C2vpjiNPpNso=; b=o+t9Zdoy0c0Jkpfda38Brfk/qPMTcgHpHOemDAH92HZblOI8rHnXK/jiKyCIscYo5P vvjCxBErvwwsrBr4fBkmS+awABmgUyTyuVBU+pRlS7t4Uly0MFXDLx/mumVGgqvA/iQ8 +MyVzJsQ6IUmM9/bP0KPST12zussC+zFl5pdUFZf+NSMsqwxj3txO6nknasJVRX9r0yU ym2AiySZhARMnTKOLaWXuaHwQpg9zlkmafp6aj4CJzFdHHKLKmDmP/TJc952tCbxbkUb wBWer3UrPZMEuSkrR4GB9XM57s0zp0XGgASomaRyqgc+SUN49XIT24LscSUaQ2+pT5r3 Mp+g== X-Gm-Message-State: AOJu0YyDRGgD/bApWCLiPs1rcssCzuwqBy/XW9n6SjNrzKzN6Yc4KBsQ coRnDKM26dLj2p7aE+VmjOLXrk74IBhpSQhZws5lKdPm7I3tRfmQtb5KZQ== X-Google-Smtp-Source: AGHT+IGeVgjBBmi9NWYDKFCBuykzVJJg+K0RnucJ8Tm5fNTIVzxQjL49vanKKNajJOTFjoQaEgjZug== X-Received: by 2002:a05:6e02:19c6:b0:375:cad3:5eb2 with SMTP id e9e14a558f8ab-38a57215a5bmr35506315ab.13.1720548245002; Tue, 09 Jul 2024 11:04:05 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-77d62c4c7b0sm1701225a12.53.2024.07.09.11.04.04 for <bug-gnu-emacs@HIDDEN> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jul 2024 11:04:04 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------OLPez0swK1XLYct0OhuJJ91l" Message-ID: <c2c8af49-100e-c97f-6890-9692a40e6329@HIDDEN> Date: Tue, 9 Jul 2024 11:04:05 -0700 MIME-Version: 1.0 X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US To: bug-gnu-emacs@HIDDEN From: Jim Porter <jporterbugs@HIDDEN> Subject: 30.0.60; [PATCH] Don't emit a prompt when a background Eshell process is killed Received-SPF: pass client-ip=2607:f8b0:4864:20::12f; envelope-from=jporterbugs@HIDDEN; helo=mail-il1-x12f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------OLPez0swK1XLYct0OhuJJ91l Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Steps to reproduce: emacs -Q -f eshell $ sleep 100 & $ kill -9 <sleep's process id> After this, you'll see two Eshell prompts get emitted (one with a "[9]" for the exit status of "sleep"). We don't want to emit prompts when background processes die though. This is a regression from Emacs 29, likely due to some changes I made to improve support for complex background commands. Eli, is this ok to merge to the release branch? --------------OLPez0swK1XLYct0OhuJJ91l Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-emit-a-prompt-in-Eshell-when-a-background-comm.patch" Content-Disposition: attachment; filename*0="0001-Don-t-emit-a-prompt-in-Eshell-when-a-background-comm.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAzZTVhNzAyZjAxMzZjYzZhMDcxNTQ2YTg1NGFlYTU0NTM2Yzg3NzgzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFR1ZSwgOSBKdWwgMjAyNCAxMDo0NTozNSAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIERvbid0IGVtaXQgYSBwcm9tcHQgaW4gRXNoZWxsIHdoZW4gYSBiYWNrZ3JvdW5kIGNv bW1hbmQgaXMKIGtpbGxlZAoKKiBsaXNwL2VzaGVsbC9lc2gtY21kLmVsIChlc2hlbGwtcmVz dW1lLWNvbW1hbmQpOiBDaGVjayBmb3IKYmFja2dyb3VuZC1uZXNzIGJlZm9yZSByZXNldHRp bmcgdGhlIHByb21wdC4KCiogdGVzdC9saXNwL2VzaGVsbC9lc2gtY21kLXRlc3RzLmVsCihl c2gtY21kLXRlc3QvYmFja2dyb3VuZC9zaW1wbGUtY29tbWFuZCk6IE1ha2UgdGhlIHJlZ2V4 cCBhIGJpdApzdHJpY3Rlci4KKGVzaC1jbWQtdGVzdC9iYWNrZ3JvdW5kL2tpbGwpOiBOZXcg dGVzdC4KLS0tCiBsaXNwL2VzaGVsbC9lc2gtY21kLmVsICAgICAgICAgICAgfCAgNyArKysr Ky0tCiB0ZXN0L2xpc3AvZXNoZWxsL2VzaC1jbWQtdGVzdHMuZWwgfCAxNCArKysrKysrKysr KysrLQogMiBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwgYi9saXNwL2VzaGVsbC9l c2gtY21kLmVsCmluZGV4IDBiMzEzNzEyN2QyLi5kMGRlNmU1NWNlNiAxMDA2NDQKLS0tIGEv bGlzcC9lc2hlbGwvZXNoLWNtZC5lbAorKysgYi9saXNwL2VzaGVsbC9lc2gtY21kLmVsCkBA IC0xMDQwLDggKzEwNDAsMTEgQEAgZXNoZWxsLXJlc3VtZS1jb21tYW5kCiAgICAgICAgICAg ICAgICAgIChub3QgKHN0cmluZy1tYXRjaCBlc2hlbGwtcmVzZXQtc2lnbmFscyBzdGF0dXMp KSkKICAgICAgICAgICAgIChlc2hlbGwtcmVzdW1lLWV2YWwgY29tbWFuZCkKICAgICAgICAg ICAoZXNoZWxsLXJlbW92ZS1jb21tYW5kIGNvbW1hbmQpCi0gICAgICAgICAgKGRlY2xhcmUt ZnVuY3Rpb24gZXNoZWxsLXJlc2V0ICJlc2gtbW9kZSIgKCZvcHRpb25hbCBuby1ob29rcykp Ci0gICAgICAgICAgKGVzaGVsbC1yZXNldCkpKSkpKQorICAgICAgICAgIDs7IFJlc2V0IHRo ZSBwcm9tcHQgaWYgdGhlIGNvbW1hbmQgd2UganVzdCBhYm9ydGVkIHdhcyBpbiB0aGUKKyAg ICAgICAgICA7OyBmb3JlZ3JvdW5kLgorICAgICAgICAgICh1bmxlc3MgKGNhciBjb21tYW5k KQorICAgICAgICAgICAgKGRlY2xhcmUtZnVuY3Rpb24gZXNoZWxsLXJlc2V0ICJlc2gtbW9k ZSIgKCZvcHRpb25hbCBuby1ob29rcykpCisgICAgICAgICAgICAoZXNoZWxsLXJlc2V0KSkp KSkpKQogCiAoZGVmdW4gZXNoZWxsLXJlc3VtZS1ldmFsIChjb21tYW5kKQogICAiRGVzdHJ1 Y3RpdmVseSBldmFsdWF0ZSBhIENPTU1BTkQgd2hpY2ggbWF5IG5lZWQgdG8gYmUgZGVmZXJy ZWQuCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZXNoZWxsL2VzaC1jbWQtdGVzdHMuZWwgYi90 ZXN0L2xpc3AvZXNoZWxsL2VzaC1jbWQtdGVzdHMuZWwKaW5kZXggNzBlMTkwMWMxNjkuLmQ4 MTI0YTE5YWY2IDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvZXNoZWxsL2VzaC1jbWQtdGVzdHMu ZWwKKysrIGIvdGVzdC9saXNwL2VzaGVsbC9lc2gtY21kLXRlc3RzLmVsCkBAIC0xMTMsNyAr MTEzLDcgQEAgZXNoLWNtZC10ZXN0L2JhY2tncm91bmQvc2ltcGxlLWNvbW1hbmQKICAgICAo d2l0aC10ZW1wLWVzaGVsbAogICAgICAoZXNoZWxsLW1hdGNoLWNvbW1hbmQtb3V0cHV0CiAg ICAgICAoZm9ybWF0ICIqZWNobyBoaSA+ICM8JXM+ICYiIGJ1Zm5hbWUpCi0gICAgICAocngg IltlY2hvIiAoPyAiLmV4ZSIpICJdICIgKCsgZGlnaXQpICJcbiIpKQorICAgICAgKHJ4IGJv cyAiW2VjaG8iICg/ICIuZXhlIikgIl0gIiAoKyBkaWdpdCkgIlxuIikpCiAgICAgIChlc2hl bGwtd2FpdC1mb3Itc3VicHJvY2VzcyB0KSkKICAgICAoc2hvdWxkIChlcXVhbCAoYnVmZmVy LXN0cmluZykgImhpXG4iKSkpKQogCkBAIC0xMjksNiArMTI5LDE4IEBAIGVzaC1jbWQtdGVz dC9iYWNrZ3JvdW5kL3N1YmNvbW1hbmQKICAgICAgKGVzaGVsbC13YWl0LWZvci1zdWJwcm9j ZXNzIHQpKQogICAgIChzaG91bGQgKGVxdWFsIChidWZmZXItc3RyaW5nKSAib2xsZWhcbiIp KSkpCiAKKyhlcnQtZGVmdGVzdCBlc2gtY21kLXRlc3QvYmFja2dyb3VuZC9raWxsICgpCisg ICJNYWtlIHN1cmUgdGhhdCBhIGJhY2tncm91bmQgY29tbWFuZCB0aGF0IGdldHMga2lsbGVk IGRvZXNuJ3QgZW1pdCBhIHByb21wdC4iCisgIChza2lwLXVubGVzcyAoZXhlY3V0YWJsZS1m aW5kICJzbGVlcCIpKQorICAobGV0ICgoYmFja2dyb3VuZC1tZXNzYWdlIChyeCBib3MgIltz bGVlcCIgKD8gIi5leGUiKSAiXSAiICgrIGRpZ2l0KSAiXG4iKSkpCisgICAgKHdpdGgtdGVt cC1lc2hlbGwKKyAgICAgIChlc2hlbGwtbWF0Y2gtY29tbWFuZC1vdXRwdXQgIipzbGVlcCAx MCAmIiBiYWNrZ3JvdW5kLW1lc3NhZ2UpCisgICAgICAoa2lsbC1wcm9jZXNzIChjYWFyIGVz aGVsbC1wcm9jZXNzLWxpc3QpKQorICAgICAgKGVzaGVsbC13YWl0LWZvci1zdWJwcm9jZXNz IHQpCisgICAgICA7OyBFbnN1cmUgd2UgZGlkbid0IGVtaXQgYW5vdGhlciBwcm9tcHQgYWZ0 ZXIga2lsbGluZyB0aGUKKyAgICAgIDs7IGJhY2tncm91bmQgcHJvY2Vzcy4KKyAgICAgIChz aG91bGQgKGVzaGVsbC1tYXRjaC1vdXRwdXQgYmFja2dyb3VuZC1tZXNzYWdlKSkpKSkKKwog DAogOzsgTGlzcCBmb3JtcwogCi0tIAoyLjI1LjEKCg== --------------OLPez0swK1XLYct0OhuJJ91l--
Jim Porter <jporterbugs@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#72018; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.