GNU logs - #72739, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#72739: [PATCH] * lisp/gnus/gnus-sum.el: Handle leafs with children in summary line
Resent-From: Blyte Scholar <bs@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 20 Aug 2024 22:10:02 +0000
Resent-Message-ID: <handler.72739.B.172419179831290 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 72739 <at> debbugs.gnu.org
From: Blyte Scholar <bs@HIDDEN>
Date: Tue, 20 Aug 2024 17:44:48 -0400
Message-ID: <87plq2c1in.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=198.12.76.26; envelope-from=bs@HIDDEN;
 helo=paras.blyte.net
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Mailman-Approved-At: Tue, 20 Aug 2024 18:09:54 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

--=-=-=
Content-Type: text/plain

Tags: patch

Tags: patch

Tags: patch


This patch adds customization options which handle the cases where a
thread leaf has both siblings and children. This allows using box
drawing characters to seamlessly connect all messages in a
thread. Previously, there would be messages could either be connected to
a sibling or a child, but not both.



In GNU Emacs 31.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version
 3.24.43, cairo version 1.18.0) of 2024-08-20 built on rhipidon
Repository revision: 5d435afc0e389e107fcee8d63405078341592f97
Repository branch: master
System Description: Fedora Linux 40 (Workstation Edition)

Configured using:
 'configure --with-imagemagick --with-tree-sitter
 --with-native-compilation=aot --with-pgtk'


--=-=-=
Content-Type: text/patch
Content-Disposition: attachment;
 filename=0001-lisp-gnus-gnus-sum.el-Handle-leafs-with-children-in-.patch

From fca49a37ec7cc0c512290de93dd8311ca5a012d6 Mon Sep 17 00:00:00 2001
From: Blyte Scholar <bs@HIDDEN>
Date: Tue, 20 Aug 2024 17:32:10 -0400
Subject: [PATCH] * lisp/gnus/gnus-sum.el: Handle leafs with children in
 summary line

(gnus-sum-thread-tree-leaf-with-other-root): New variable.
(gnus-sum-thread-tree-single-leaf-root): New variable.
(gnus-summary-prepare-threads):
Use gnus-sum-thread-tree-leaf-with-other-root and
gnus-sum-thread-single-leaf-root strings in summary line when they are
available.
---
 lisp/gnus/gnus-sum.el | 24 ++++++++++++++++++++++--
 1 file changed, 22 insertions(+), 2 deletions(-)

diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el
index a9caa83b15c..2fd342f3a0c 100644
--- a/lisp/gnus/gnus-sum.el
+++ b/lisp/gnus/gnus-sum.el
@@ -5193,12 +5193,26 @@ gnus-sum-thread-tree-leaf-with-other
   :type 'string
   :group 'gnus-thread)
 
+(defcustom gnus-sum-thread-tree-leaf-with-other-root nil
+  "With %B spec, used for a leaf with brothers and children.
+If nil use `gnus-sum-thread-tree-leaf-with-other' instead."
+  :version "31.1"
+  :type 'string
+  :group 'gnus-thread)
+
 (defcustom gnus-sum-thread-tree-single-leaf "\\-> "
   "With %B spec, used for a leaf without brothers."
   :version "22.1"
   :type 'string
   :group 'gnus-thread)
 
+(defcustom gnus-sum-thread-tree-single-leaf-root nil
+  "With %B spec, used for a leaf without brothers but children.
+If nil use `gnus-sum-thread-tree-leaf-single-leaf' instead."
+  :version "31.1"
+  :type 'string
+  :group 'gnus-thread)
+
 (defcustom gnus-summary-display-while-building nil
   "If non-nil, show and update the summary buffer as it's being built.
 If the value is t, update the buffer after every line is inserted.  If
@@ -5474,8 +5488,14 @@ gnus-summary-prepare-threads
 					  gnus-sum-thread-tree-indent))
 				      (cdr (reverse tree-stack))))
 		       (if (nth 1 thread)
-			   gnus-sum-thread-tree-leaf-with-other
-			 gnus-sum-thread-tree-single-leaf)))))
+                           (if (and gnus-sum-thread-tree-leaf-with-other-root
+                                    (cadar thread))
+                               gnus-sum-thread-tree-leaf-with-other-root
+			     gnus-sum-thread-tree-leaf-with-other)
+                         (if (and gnus-sum-thread-tree-single-leaf-root
+                                  (cadar thread))
+                             gnus-sum-thread-tree-single-leaf-root
+			   gnus-sum-thread-tree-single-leaf))))))
 	    (when (string= gnus-tmp-name "")
 	      (setq gnus-tmp-name gnus-tmp-from))
 	    (unless (numberp gnus-tmp-lines)
-- 
2.46.0


--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Blyte Scholar <bs@HIDDEN>
Subject: bug#72739: Acknowledgement ([PATCH] * lisp/gnus/gnus-sum.el:
 Handle leafs with children in summary line)
Message-ID: <handler.72739.B.172419179831290.ack <at> debbugs.gnu.org>
References: <87plq2c1in.fsf@HIDDEN>
X-Gnu-PR-Message: ack 72739
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 72739 <at> debbugs.gnu.org
Date: Tue, 20 Aug 2024 22:10:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 72739 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
72739: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72739
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#72739: [PATCH] * lisp/gnus/gnus-sum.el: Handle leafs with children in summary line
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 24 Aug 2024 09:16:01 +0000
Resent-Message-ID: <handler.72739.B72739.172449090731681 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Blyte Scholar <bs@HIDDEN>, eric@HIDDEN
Cc: 72739 <at> debbugs.gnu.org
Date: Sat, 24 Aug 2024 12:14:07 +0300
Message-Id: <864j7anuzk.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87plq2c1in.fsf@HIDDEN> (message
 from Blyte Scholar on Tue, 20 Aug 2024 17:44:48 -0400)
References: <87plq2c1in.fsf@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> From: Blyte Scholar <bs@HIDDEN>
> Date: Tue, 20 Aug 2024 17:44:48 -0400
> 
> Tags: patch
> 
> 
> This patch adds customization options which handle the cases where a
> thread leaf has both siblings and children. This allows using box
> drawing characters to seamlessly connect all messages in a
> thread. Previously, there would be messages could either be connected to
> a sibling or a child, but not both.

Eric, any comments?

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#72739: [PATCH] * lisp/gnus/gnus-sum.el: Handle leafs with children in summary line
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 31 Aug 2024 08:16:02 +0000
Resent-Message-ID: <handler.72739.B72739.172509213625597 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Blyte Scholar <bs@HIDDEN>, eric@HIDDEN
Cc: 72739 <at> debbugs.gnu.org
Date: Sat, 31 Aug 2024 11:14:25 +0300
Message-Id: <86frqlcdni.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87plq2c1in.fsf@HIDDEN> (message
 from Blyte Scholar on Tue, 20 Aug 2024 17:44:48 -0400)
References: <87plq2c1in.fsf@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> From: Blyte Scholar <bs@HIDDEN>
> Date: Tue, 20 Aug 2024 17:44:48 -0400
> 
> Tags: patch
> 
> 
> This patch adds customization options which handle the cases where a
> thread leaf has both siblings and children. This allows using box
> drawing characters to seamlessly connect all messages in a
> thread. Previously, there would be messages could either be connected to
> a sibling or a child, but not both.

Thanks.

Eric, any comments to the patch or the issue in general?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#72739: [PATCH] * lisp/gnus/gnus-sum.el: Handle leafs with children in summary line
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 07 Sep 2024 07:15:01 +0000
Resent-Message-ID: <handler.72739.B72739.172569325932743 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72739
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: eric@HIDDEN
Cc: 72739 <at> debbugs.gnu.org, bs@HIDDEN
Received: via spool by 72739-submit <at> debbugs.gnu.org id=B72739.172569325932743
          (code B ref 72739); Sat, 07 Sep 2024 07:15:01 +0000
Received: (at 72739) by debbugs.gnu.org; 7 Sep 2024 07:14:19 +0000
Received: from localhost ([127.0.0.1]:54620 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1smpeE-0008W2-Et
	for submit <at> debbugs.gnu.org; Sat, 07 Sep 2024 03:14:18 -0400
Received: from eggs.gnu.org ([209.51.188.92]:54474)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1smpeC-0008Vo-HY
 for 72739 <at> debbugs.gnu.org; Sat, 07 Sep 2024 03:14:17 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1smpe5-0004ae-QZ; Sat, 07 Sep 2024 03:14:09 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=/pj45V9f8zXSMBbuG9HkDa6PMKPpjDOD9spdv8wVso8=; b=kkUFHXYFdWJL
 t1NRWoSsPLgyFpxuVB5yBUpwy6S+S730u5MChHtO5A0KMaBM4Des6J/FgEt+xz3gI+pzMg7ZG7FWt
 Xz6DHPrTTR85083uhbNq4UXET1L8T57t9O1597Ev+LLLQdWRl5KVtXKf67Y5GPA6YgOM7hHq5WOkp
 cJuKojdQBia/Ea9Ik56UcOYXsuw47hZTQF8jyrhqs+Pu1SO9e9WYLW9PSUhMFbMAGntzRCtMvTMha
 sQF18f3S91rDt3R1iIPM1yv1GQCuug1bzuX27tC2Vza0K+ECzgJjxnTJcD2jAfyKf6Ws0vlQebtLD
 m+Nr54xohOolP3VTaPBqjA==;
Date: Sat, 07 Sep 2024 10:13:53 +0300
Message-Id: <86seucylzi.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <864j7anuzk.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 24
 Aug 2024 12:14:07 +0300)
References: <87plq2c1in.fsf@HIDDEN>
 <864j7anuzk.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Ping!

> Cc: 72739 <at> debbugs.gnu.org
> Date: Sat, 24 Aug 2024 12:14:07 +0300
> From: Eli Zaretskii <eliz@HIDDEN>
> 
> > From: Blyte Scholar <bs@HIDDEN>
> > Date: Tue, 20 Aug 2024 17:44:48 -0400
> > 
> > Tags: patch
> > 
> > 
> > This patch adds customization options which handle the cases where a
> > thread leaf has both siblings and children. This allows using box
> > drawing characters to seamlessly connect all messages in a
> > thread. Previously, there would be messages could either be connected to
> > a sibling or a child, but not both.
> 
> Eric, any comments?
> 
> 
> 
>

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.