Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org
.
Full text available.Received: (at 72739) by debbugs.gnu.org; 23 Feb 2025 23:34:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 23 18:34:18 2025 Received: from localhost ([127.0.0.1]:37379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tmLUH-0000FE-UF for submit <at> debbugs.gnu.org; Sun, 23 Feb 2025 18:34:18 -0500 Received: from mail-japanwestazon11021138.outbound.protection.outlook.com ([40.107.74.138]:39765 helo=OS0P286CU010.outbound.protection.outlook.com) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <acohen@HIDDEN>) id 1tmLUE-0000Ew-Ub for 72739 <at> debbugs.gnu.org; Sun, 23 Feb 2025 18:34:15 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UD/+ciIdZhug5ACEdLId7NVp6ftJw1bu2476NrutIZ12gTukcC56o/X/cs4EMFfjljoovakaKvkZ8KPYz+bExvIJB+MBsprFPJ6FeeKwU85FoSybDR4039Tqy62xyWrOh9Bjc6ENqzuFnyxBWq1cMZikVBP7vS7JvYkbra9Uy24W+0McBW+2AH6D33gmgu6C4kq2LDSYqzvkvKte/xd+/TwKutu+9hOX3Tatis7vOMqd/gW+ZlpEejNlj3lKFGNNBQTgyiUw/JkUjlLMqJ92D9Amt5cA1g4K4Bw+cQDZ/sM5EmPt5CVKQgpyEQopMyjMx1pXUuML40Elo27MQkb+Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e8sdB+IGSRYYF/zTD06yGsr/I6XEQuSt0153srhgJwA=; b=NTGOW+Q1qVTN09Cvkci141ursr3qHpStgtNtzXa5JOXx83H9+8bWfAjTKVhJcg/aczhvGNWFh2ylTCr4VPsv90Pwyivu6RzHQ0Tc5mFv+8hbMx9G3rvqQG/3ZNtsdbAo3hDZrSts/rNFYNNrS23QsrTL1PKg+Ackp1LLqr7IjwX11xp23X9dGWbxP94rsfMg3ONwszN3dXyddCpw6NG0CejkhVdxgNetIlVrcfM+p8H1c07eG8CrrjfYkrmvAoP1ao8O9NYwTJjbdMWlMvH72vBde9BOkBJTxlbOmyQnWxRPyIufJlSkSK8pU4VhPjyXnqlG9mfm3KcYZxv680WU5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ust.hk; dmarc=pass action=none header.from=ust.hk; dkim=pass header.d=ust.hk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ust.hk; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e8sdB+IGSRYYF/zTD06yGsr/I6XEQuSt0153srhgJwA=; b=BkKhXw3jZYF5+vEyCJz2sL2HqvZ0BrMpDmT30l7HnEy3FmIG9IDILaS/LdTjutWkPaxl8TUelfpwkfxT4yyPqqxqtSWUlIC3yoRGhxN9iJGmlZkweQfgeN6aP2kc8zPD/trZH1lJvDbPY6KtxJywL6YZLiARANApEkXdAtfIsnZErlnIyz4hc0F3QQjBKTibx2iRuVJThr32w9WBXqrl0FQB2ktIJfa1nVV2nx/NtSLJ927mkxQa2NC0cbJ6bJjpajlZLnsHxvccos/mqZFAMYRghI76qFqCGIUVVzF587aKtam25tKTBpCFNMpdlgbZRsu5RsEb41lCvBu2eEuo5Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ust.hk; Received: from OS3P286MB1877.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:1bf::11) by TYCP286MB2519.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:20e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.19; Sun, 23 Feb 2025 23:34:05 +0000 Received: from OS3P286MB1877.JPNP286.PROD.OUTLOOK.COM ([fe80::4b6e:c37e:4327:cfab]) by OS3P286MB1877.JPNP286.PROD.OUTLOOK.COM ([fe80::4b6e:c37e:4327:cfab%4]) with mapi id 15.20.8466.016; Sun, 23 Feb 2025 23:34:05 +0000 From: Andrew Cohen <acohen@HIDDEN> To: Stefan Kangas <stefankangas@HIDDEN> Subject: Re: bug#72739: [PATCH] * lisp/gnus/gnus-sum.el: Handle leafs with children in summary line In-Reply-To: <CADwFkm=aybp43DHWjY1+293hi3J5Awh-6jBiYdsSLH2MCa9W0g@HIDDEN> References: <87plq2c1in.fsf@HIDDEN> <CADwFkm=aybp43DHWjY1+293hi3J5Awh-6jBiYdsSLH2MCa9W0g@HIDDEN> Date: Mon, 24 Feb 2025 07:34:02 +0800 Message-ID: <87a5ackzh1.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain X-ClientProxiedBy: SG2PR01CA0179.apcprd01.prod.exchangelabs.com (2603:1096:4:28::35) To OS3P286MB1877.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:1bf::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3P286MB1877:EE_|TYCP286MB2519:EE_ X-MS-Office365-Filtering-Correlation-Id: 1d6cd694-e85b-4da2-3807-08dd54628ff3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?W1rZAmSLRNXx+IFtDW4038k6allYlCBUwEUcv0rkOlYcxN2lFCRzpT9YBHaZ?= =?us-ascii?Q?9jsEXL5uHt9mdk1bf2+wUgHCcogGgEH3F++J824FtULoJfza6udEcm9VVBPm?= =?us-ascii?Q?7mBNA5hkclE9zizGpixW18GGb8ZEFYrWOrupd6xDZ92zBauUwoEG2FA88ooI?= =?us-ascii?Q?i5F58qvGI20thycUbmL+lPkWyJ/v0J4YCOxpx7GoksfcXxfgW2Q7SljJYTTh?= =?us-ascii?Q?j7al2nEWROweAS/1KhCE9mXPKbu/bg56ZmabFwGBkk6vWMdNN1Y+z688Kp5/?= =?us-ascii?Q?F2j+NXWkr7zNeh5Tj8pp45EycDgnWM1pxrMckY5aaUOZzhicKDj4gRx+emPB?= =?us-ascii?Q?gdQKFu5ql/DSFtecRyyN021fJPM2pm7Y16k+0lUp0G1lfB8ajWesXEx0PMUY?= =?us-ascii?Q?0sPEf30MNWl19OEou++YdgHV5Bcxjs6MzJ6PQGPQDDspRpZhXb3mBSAWfHU6?= =?us-ascii?Q?9+uAAqMKGFbW+cbVRjL9y+rw+WPN8+IaARVsCyP97pCRXBgbzwnhpBdvUIHR?= =?us-ascii?Q?wjqftcomW3F0JFZD/+faCcnS+b3EKmIT5DGcskiO5gQwQ5EeDwau8zXb2ABE?= =?us-ascii?Q?Xk0OXeDkbiFHis0xSKz2wkClvB1Ho57CtVx5GHBKFfdJfCngdQODywlkZWAc?= =?us-ascii?Q?cAUIytSvrvegcbbCt4T8ienkWwtuHg3EO42O96xPMVJVcJ1qUdjz5uZv3izC?= =?us-ascii?Q?nwAOmX06cVPvtNmhHRUb/1xlaqnxHUYRBbdh1P53XDQU5dAY5O/UjD1gQnvu?= =?us-ascii?Q?vO1yafRL5EIxRzM+tZKBOQDiGmTT4H9BJhyhezjNbHeoDt1B+xHB/eR+ObKI?= =?us-ascii?Q?I3ap5ofsbmyr0alpCc5Fq0CZrXN3hR1/AsvE6Bw2PzAQ71XGcDp0bb1MXAvJ?= =?us-ascii?Q?vN2JtloZeGslpEDZXbqI/4pcdbxbJs5Ub+P4c8w/0Njr5jSYWidO6HMv/vKg?= =?us-ascii?Q?2el/yyC5SpydJo5G+Nh1afjEvBXObQm0uCHsu3JWZlsU+QEvvWWMLGEdMjmz?= =?us-ascii?Q?9jytid6OiZ6gIDhHmGk9LOttKNEQ5a09oYAJeDMy+4Q8qhQw2EUN8gp4aNP1?= =?us-ascii?Q?PbZ/w4j25bVml2hMGlZ3WzEZ1ZwgT1lkRrpzoJFCnCowDCpuqTSGSAP1oT+Z?= =?us-ascii?Q?3aJ5nJsxonCtF301i19CA+Tc0oSmWMU+idTrszD3UJA7PAKqry+usSTmfxWg?= =?us-ascii?Q?foH4HkUaXCl775Jd7DWNz4l2bI3uv+r7pjUS4ZUE5IRFh0wmJnDPk/VQ/0o8?= =?us-ascii?Q?F7WS9hprz8kh39gkybpsn+59bq0UXq/8ZhBO51Rt8nWlM8lY7NEX3eY1ptm7?= =?us-ascii?Q?7195RZpVdPPdnItDfK8JgEwIj0nVzkO8Tnhit0OcXFSISVWrVXO0lwsGV4xz?= =?us-ascii?Q?5Hr1dnvbLunicdWQwjMOSfT4A2hS?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS3P286MB1877.JPNP286.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vJ/+qCO6qrFfog0e+YRfwY5yQHnOzUIRN4k+6+rVPs89IwD6ng4pflVXLngf?= =?us-ascii?Q?d5Fug1k/Jg4ooHU+yTGQ6onslCVOFoNCbwAP2RXoyhTZ1DR+FU1n7VVvOGcj?= =?us-ascii?Q?vDu5xHQJpMvlIAeBxFShmPBErcD94+Lvo3/YGMCEs3VlZcm0V9VVCGH0hEuc?= =?us-ascii?Q?3AKG+QfqzJvIXmoWFfIdKjP+PQlHBi906hSZoZ85sC3KMAtCJjl9LGLvmITM?= =?us-ascii?Q?5H2f8Cb+4b5QbbhzIMrqx2AifiuE1nIbmBin0pHToGOzPqiE7u5niwpCJa7G?= =?us-ascii?Q?i5kYoooPwLcbq6NVRjm2cBIb2ojlOSC/qGPvFK05Zlg23uv18fkeQQZ/Q0Gj?= =?us-ascii?Q?+a/CWXibwhfhuTbErLtJ0PfbrMJb0Cn67/Nx0GO1YH6QxWQydJy/BEYX1qE7?= =?us-ascii?Q?dcPXq2zsWYGHPAGQXvxbXBXKB9mVZTNPek2YrtSUB1nX5XtLLzpZ69S3kHr4?= =?us-ascii?Q?Set1U9YejeN27A643PKn75hgXV4HGrnKx/gGz29yl46GmLW6Qzr/1whLQZ32?= =?us-ascii?Q?1aeve5B29DWTQEH/e0Qacao4Enw75XqPw41pXgrmZH6EzffMd8UWy9pGiRuD?= =?us-ascii?Q?v6Jboe3P7oYC+CORWPRynQ9/EKs54HgQdV1TurwsuO/iFG/9NuN5mLJUsoTi?= =?us-ascii?Q?5pis5w7cKRXcq16DF79SZpwehUVYUZlEeSjbpZPCK+OjJzaNxuiqqKuhzhH1?= =?us-ascii?Q?hRosVeLA8mOZaS/OL8yIbqnDWvXiGFm4c2oeArWP83opUTpbpad0E5UoSyS7?= =?us-ascii?Q?qjCrKUy50lG5FCTDDjR1jKZKEGBNO4JQxN4LX1Rzc1OGjOOGTgCtA6TY1tLp?= =?us-ascii?Q?gSwKRWLmTWLWAlm1Wx7EseMiEJnxiFu+FRRQd2Og3BOVD7WxsX0yqryWB9/5?= =?us-ascii?Q?Df41SNeMZVeihhokYyVLP21OgYYvEftFhW2K4HVdNmjODzUZvTnxF5jJgxWu?= =?us-ascii?Q?VTdE9kssz84QaSjMCeqcEt0ph1hwo+TOHDuolCWX+uKvbtQkXuuQ0uEHZKFY?= =?us-ascii?Q?A96c7ZPG8CdUuAhzPghlzIpjs+gtx+LGrrL4r235Zf2IWPM/3Six31iOjsIj?= =?us-ascii?Q?JIG8dQzFOUYTEDnPiFDW58D9ngFLSARySD608EbnkiOBEW3FgPNZEaoGvLCv?= =?us-ascii?Q?TCHRJFkKxOY+yi/3Hqi6jaxCw/lKNwGN8pA6+h30c88Oa7EI2ePqvDVHjiX+?= =?us-ascii?Q?l4ZvtRqhiFEVWUmf8QHXbmnEau3+NbOKhvmtc/ol/hl/wtVjf5TGccJXsdgq?= =?us-ascii?Q?PcBeoPr4X/VMNkdpWUxDiCa9mC2PbKDOhejak/BX+rGM8k6MuEHzUjvLleDJ?= =?us-ascii?Q?0oiwU1P11eBpqcQA5getvPK9aZdCRXigCCDZ1WXzJIRQEhI7iGamHtOQZ5kn?= =?us-ascii?Q?XICxt5ccGs8TwoNmUGh6esQJMbxCoZvhOxeWs9L003GCkkAgrmVuByorRaji?= =?us-ascii?Q?/DZi5VArXF00TvlE+i31pK8OtXc0L5S+qShDmlD8I92FQkYc/3k+Un6icPjG?= =?us-ascii?Q?pW0AFX2wLGmDe0fNbZwerGDB5bsfZmi5W33ydABd6BxCPvFbTQsUkCBnOJvm?= =?us-ascii?Q?Sj2vUP9GzyfGfAy6huBO4qaChv+WG4sOP2kT/aya?= X-OriginatorOrg: ust.hk X-MS-Exchange-CrossTenant-Network-Message-Id: 1d6cd694-e85b-4da2-3807-08dd54628ff3 X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB1877.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2025 23:34:05.6234 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: c917f3e2-9322-4926-9bb3-daca730413ca X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2UQtx3XzoCrQvX8/7Se1SEQweQbtwQR8W/9D/RhOJgVFVMpRwx6iTV9auyCnX4TH X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB2519 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 72739 Cc: Eric Abrahamsen <eric@HIDDEN>, 72739 <at> debbugs.gnu.org, Blyte Scholar <bs@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) I think this change is fine (I'm already using it:)). It would be good to also update the gnus manual to mention these two new threading variables. Also, the box drawing vertical lines have large gaps, so I set `line-spacing' to nil in gnus summary buffers, which minimizes (but does not eliminate) the gaps. Is there an alternative? >>>>> "SK" == Stefan Kangas <stefankangas@HIDDEN> writes: SK> Blyte Scholar <bs@HIDDEN> writes: >> This patch adds customization options which handle the cases >> where a thread leaf has both siblings and children. This allows >> using box drawing characters to seamlessly connect all messages >> in a thread. Previously, there would be messages could either be >> connected to a sibling or a child, but not both. SK> Andrew, Eric, could you please help review the below patch? >> From fca49a37ec7cc0c512290de93dd8311ca5a012d6 Mon Sep 17 00:00:00 >> 2001 From: Blyte Scholar <bs@HIDDEN> Date: Tue, 20 Aug 2024 >> 17:32:10 -0400 Subject: [PATCH] * lisp/gnus/gnus-sum.el: Handle >> leafs with children in summary line >> >> (gnus-sum-thread-tree-leaf-with-other-root): New variable. >> (gnus-sum-thread-tree-single-leaf-root): New variable. >> (gnus-summary-prepare-threads): Use >> gnus-sum-thread-tree-leaf-with-other-root and >> gnus-sum-thread-single-leaf-root strings in summary line when >> they are available. --- lisp/gnus/gnus-sum.el | 24 >> ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 >> deletions(-) >> >> diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index >> a9caa83b15c..2fd342f3a0c 100644 --- a/lisp/gnus/gnus-sum.el +++ >> b/lisp/gnus/gnus-sum.el @@ -5193,12 +5193,26 @@ >> gnus-sum-thread-tree-leaf-with-other :type 'string :group >> 'gnus-thread) >> >> +(defcustom gnus-sum-thread-tree-leaf-with-other-root nil + "With >> %B spec, used for a leaf with brothers and children. +If nil use >> `gnus-sum-thread-tree-leaf-with-other' instead." + :version >> "31.1" + :type 'string + :group 'gnus-thread) + (defcustom >> gnus-sum-thread-tree-single-leaf "\\-> " "With %B spec, used for >> a leaf without brothers." :version "22.1" :type 'string :group >> 'gnus-thread) >> >> +(defcustom gnus-sum-thread-tree-single-leaf-root nil + "With %B >> spec, used for a leaf without brothers but children. +If nil use >> `gnus-sum-thread-tree-leaf-single-leaf' instead." + :version >> "31.1" + :type 'string + :group 'gnus-thread) + (defcustom >> gnus-summary-display-while-building nil "If non-nil, show and >> update the summary buffer as it's being built. If the value is >> t, update the buffer after every line is inserted. If @@ -5474,8 >> +5488,14 @@ gnus-summary-prepare-threads >> gnus-sum-thread-tree-indent)) (cdr (reverse tree-stack)))) (if >> (nth 1 thread) - gnus-sum-thread-tree-leaf-with-other - >> gnus-sum-thread-tree-single-leaf))))) + (if (and >> gnus-sum-thread-tree-leaf-with-other-root + (cadar thread)) + >> gnus-sum-thread-tree-leaf-with-other-root + >> gnus-sum-thread-tree-leaf-with-other) + (if (and >> gnus-sum-thread-tree-single-leaf-root + (cadar thread)) + >> gnus-sum-thread-tree-single-leaf-root + >> gnus-sum-thread-tree-single-leaf)))))) (when (string= >> gnus-tmp-name "") (setq gnus-tmp-name gnus-tmp-from)) (unless >> (numberp gnus-tmp-lines) -- Andrew Cohen
bug-gnu-emacs@HIDDEN
:bug#72739
; Package emacs
.
Full text available.Received: (at 72739) by debbugs.gnu.org; 23 Feb 2025 00:26:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 22 19:26:04 2025 Received: from localhost ([127.0.0.1]:57988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tlzop-0004ZB-Kg for submit <at> debbugs.gnu.org; Sat, 22 Feb 2025 19:26:04 -0500 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:53347) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tlzom-0004Yc-Pg for 72739 <at> debbugs.gnu.org; Sat, 22 Feb 2025 19:26:01 -0500 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-5deb956aa5eso4194784a12.2 for <72739 <at> debbugs.gnu.org>; Sat, 22 Feb 2025 16:26:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740270355; x=1740875155; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=OKEYrFuPhpr3Nis9RWEgcEsRV3VzUaA4jPlpMCWml/s=; b=gMCRyByNjRpVTqmfL2a/zhNX9QTTB2GdJpSodhZEQ4uNvRJzdfOumzbxaHwwkjvVQD 3FdxT2Hv/pY/K+tN/tw9elV76W9RQVQGnQ45VqQEIN+S4tB9rtEJ7pA9B0TDs4IRLy19 hwjMoy0renhF+lymOW0O3UxKzBQ/YJxrdgNv3svvifTjU9RJfHdWOY8Pi6qX2Go2l7ck Ul3EEUomlGbIEqnlaX4lCziamiHIYF/ayE0mt6bwL4selFoCeOKbdK3FqgrQOOHvrbcN lcmHB8vzP08Sa6HwZKtQt6/LwYZxowymxDA799alQM7Z922q9+xhnk39q3V5U+HBSt8l E3CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740270355; x=1740875155; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OKEYrFuPhpr3Nis9RWEgcEsRV3VzUaA4jPlpMCWml/s=; b=CqldQnZVlpMIrxSI+t7k295NmK3c51/btjIcn6wM38MGTsFmsU3jHGzkSHOFxY9Vyt p9nzUQq0C7MbhaiYbKziam4njp/hfpakD2ic5y793Apvh9uPVou+fdsNkzCGTLQCPl8Y BlXsHs00ebE9hKqPYTRWLiNdDgefSOajxvrsUSJwiwMEvOfy1rTuKxk9k4zNoZeDqR2D yPog/pDY3pMK/WpBUWNoBhuB+Km7rCLCcHQlqGPhJKsC5vb5+8yJtC8jOLEd2c1SoOgo ZfeIJJeAxpdpLZ3CeSf6nbnp/4z7Gehm6EQBxWpSBm+zYknZKR4DFk3ieVzx09JFd7AC ajfQ== X-Gm-Message-State: AOJu0Yx4NaAMIwjUJBW+Sw7DZr6WVg6Ekpj+hcqE3i+cmsftZwhDvyfc lGibWJD/n+6gZbAyWo08per+o9aSdhQrLh/N5sYT8GNxGcno9GVbMJ5HP1HDpaV+S8LbZ4i5M1O TB+jSWBKXaQrKH81rNBlCZiT6LzE= X-Gm-Gg: ASbGncuve7fUtu6egG/3arfZ1gi1ML1l+koB7hWnZHeUx4lg7zjcWBl3k9vBrj/3E56 s7nK7LQfmuAqhzlSpDU/hEu2D5Xft5kEJcmT5CHNgPRjrPiQbvqVpRoudbXejvXcEmemzIqTGLu AWWHKy7do0 X-Google-Smtp-Source: AGHT+IH2xBIwANT7pfO+wPSrxAKFA8hYy303j3di1jpKqe4P90H/DkpLCqdsZj9mTYTdysTYXBpAsm371uOgdzISbTM= X-Received: by 2002:a05:6402:3554:b0:5de:594d:e9aa with SMTP id 4fb4d7f45d1cf-5e0b70df4ddmr18178942a12.8.1740270354643; Sat, 22 Feb 2025 16:25:54 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 23 Feb 2025 00:25:54 +0000 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <87plq2c1in.fsf@HIDDEN> References: <87plq2c1in.fsf@HIDDEN> MIME-Version: 1.0 Date: Sun, 23 Feb 2025 00:25:54 +0000 X-Gm-Features: AWEUYZnjTT_EIUYaUC8ObEqC6eirw2lCy5NcHU8p78enzXO_80nAzyC1H2Sx18g Message-ID: <CADwFkm=aybp43DHWjY1+293hi3J5Awh-6jBiYdsSLH2MCa9W0g@HIDDEN> Subject: Re: bug#72739: [PATCH] * lisp/gnus/gnus-sum.el: Handle leafs with children in summary line To: Blyte Scholar <bs@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72739 Cc: Andrew Cohen <acohen@HIDDEN>, 72739 <at> debbugs.gnu.org, Eric Abrahamsen <eric@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Blyte Scholar <bs@HIDDEN> writes: > This patch adds customization options which handle the cases where a > thread leaf has both siblings and children. This allows using box > drawing characters to seamlessly connect all messages in a > thread. Previously, there would be messages could either be connected to > a sibling or a child, but not both. Andrew, Eric, could you please help review the below patch? > From fca49a37ec7cc0c512290de93dd8311ca5a012d6 Mon Sep 17 00:00:00 2001 > From: Blyte Scholar <bs@HIDDEN> > Date: Tue, 20 Aug 2024 17:32:10 -0400 > Subject: [PATCH] * lisp/gnus/gnus-sum.el: Handle leafs with children in > summary line > > (gnus-sum-thread-tree-leaf-with-other-root): New variable. > (gnus-sum-thread-tree-single-leaf-root): New variable. > (gnus-summary-prepare-threads): > Use gnus-sum-thread-tree-leaf-with-other-root and > gnus-sum-thread-single-leaf-root strings in summary line when they are > available. > --- > lisp/gnus/gnus-sum.el | 24 ++++++++++++++++++++++-- > 1 file changed, 22 insertions(+), 2 deletions(-) > > diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el > index a9caa83b15c..2fd342f3a0c 100644 > --- a/lisp/gnus/gnus-sum.el > +++ b/lisp/gnus/gnus-sum.el > @@ -5193,12 +5193,26 @@ gnus-sum-thread-tree-leaf-with-other > :type 'string > :group 'gnus-thread) > > +(defcustom gnus-sum-thread-tree-leaf-with-other-root nil > + "With %B spec, used for a leaf with brothers and children. > +If nil use `gnus-sum-thread-tree-leaf-with-other' instead." > + :version "31.1" > + :type 'string > + :group 'gnus-thread) > + > (defcustom gnus-sum-thread-tree-single-leaf "\\-> " > "With %B spec, used for a leaf without brothers." > :version "22.1" > :type 'string > :group 'gnus-thread) > > +(defcustom gnus-sum-thread-tree-single-leaf-root nil > + "With %B spec, used for a leaf without brothers but children. > +If nil use `gnus-sum-thread-tree-leaf-single-leaf' instead." > + :version "31.1" > + :type 'string > + :group 'gnus-thread) > + > (defcustom gnus-summary-display-while-building nil > "If non-nil, show and update the summary buffer as it's being built. > If the value is t, update the buffer after every line is inserted. If > @@ -5474,8 +5488,14 @@ gnus-summary-prepare-threads > gnus-sum-thread-tree-indent)) > (cdr (reverse tree-stack)))) > (if (nth 1 thread) > - gnus-sum-thread-tree-leaf-with-other > - gnus-sum-thread-tree-single-leaf))))) > + (if (and gnus-sum-thread-tree-leaf-with-other-root > + (cadar thread)) > + gnus-sum-thread-tree-leaf-with-other-root > + gnus-sum-thread-tree-leaf-with-other) > + (if (and gnus-sum-thread-tree-single-leaf-root > + (cadar thread)) > + gnus-sum-thread-tree-single-leaf-root > + gnus-sum-thread-tree-single-leaf)))))) > (when (string= gnus-tmp-name "") > (setq gnus-tmp-name gnus-tmp-from)) > (unless (numberp gnus-tmp-lines)
bug-gnu-emacs@HIDDEN
:bug#72739
; Package emacs
.
Full text available.Received: (at 72739) by debbugs.gnu.org; 7 Sep 2024 07:14:19 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 07 03:14:18 2024 Received: from localhost ([127.0.0.1]:54620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1smpeE-0008W2-Et for submit <at> debbugs.gnu.org; Sat, 07 Sep 2024 03:14:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1smpeC-0008Vo-HY for 72739 <at> debbugs.gnu.org; Sat, 07 Sep 2024 03:14:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1smpe5-0004ae-QZ; Sat, 07 Sep 2024 03:14:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/pj45V9f8zXSMBbuG9HkDa6PMKPpjDOD9spdv8wVso8=; b=kkUFHXYFdWJL t1NRWoSsPLgyFpxuVB5yBUpwy6S+S730u5MChHtO5A0KMaBM4Des6J/FgEt+xz3gI+pzMg7ZG7FWt Xz6DHPrTTR85083uhbNq4UXET1L8T57t9O1597Ev+LLLQdWRl5KVtXKf67Y5GPA6YgOM7hHq5WOkp cJuKojdQBia/Ea9Ik56UcOYXsuw47hZTQF8jyrhqs+Pu1SO9e9WYLW9PSUhMFbMAGntzRCtMvTMha sQF18f3S91rDt3R1iIPM1yv1GQCuug1bzuX27tC2Vza0K+ECzgJjxnTJcD2jAfyKf6Ws0vlQebtLD m+Nr54xohOolP3VTaPBqjA==; Date: Sat, 07 Sep 2024 10:13:53 +0300 Message-Id: <86seucylzi.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: eric@HIDDEN In-Reply-To: <864j7anuzk.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 24 Aug 2024 12:14:07 +0300) Subject: Re: bug#72739: [PATCH] * lisp/gnus/gnus-sum.el: Handle leafs with children in summary line References: <87plq2c1in.fsf@HIDDEN> <864j7anuzk.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72739 Cc: 72739 <at> debbugs.gnu.org, bs@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Ping! > Cc: 72739 <at> debbugs.gnu.org > Date: Sat, 24 Aug 2024 12:14:07 +0300 > From: Eli Zaretskii <eliz@HIDDEN> > > > From: Blyte Scholar <bs@HIDDEN> > > Date: Tue, 20 Aug 2024 17:44:48 -0400 > > > > Tags: patch > > > > > > This patch adds customization options which handle the cases where a > > thread leaf has both siblings and children. This allows using box > > drawing characters to seamlessly connect all messages in a > > thread. Previously, there would be messages could either be connected to > > a sibling or a child, but not both. > > Eric, any comments? > > > >
bug-gnu-emacs@HIDDEN
:bug#72739
; Package emacs
.
Full text available.Received: (at 72739) by debbugs.gnu.org; 31 Aug 2024 08:15:36 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 31 04:15:36 2024 Received: from localhost ([127.0.0.1]:53896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1skJGi-0006en-30 for submit <at> debbugs.gnu.org; Sat, 31 Aug 2024 04:15:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1skJGg-0006eW-BL for 72739 <at> debbugs.gnu.org; Sat, 31 Aug 2024 04:15:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1skJFb-0007ld-4c; Sat, 31 Aug 2024 04:14:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=tyiVFsJ4UTgVDfrvq3qg2l/WLzanszSzB0zYz73IZLM=; b=aIBKk/qyysOp WF/Qbt+hZ6432xBpYQa7Nzn9PgVs3NByFzoOUxy9aaGtju9th1xXRW/0tkcJ59Mj3kSijkwnCs/VR 5291nSFw9w2uubNhj3oWtdKOTIabmI1N0EdQwBQGOzfZziOrsGHnfYRUbhXnGXFrmMw5olXgEyned G7mY4y4aKwmqyq6c/lHA4W9SvfnJ1Me0EzjVqS1IrAAS9JmbcpdGnYAwQ1tx/kYoVv+VYi6A8Ily5 HTNhR3THLf36LdLvpKZTPpwPcPv3mwpVK7uhqmG3LEqJII7Gfd70PzYhT5O9YZj2xoevvPxd9vmET StHi4G3KiHs+iYP5Nj/vOA==; Date: Sat, 31 Aug 2024 11:14:25 +0300 Message-Id: <86frqlcdni.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Blyte Scholar <bs@HIDDEN>, eric@HIDDEN In-Reply-To: <87plq2c1in.fsf@HIDDEN> (message from Blyte Scholar on Tue, 20 Aug 2024 17:44:48 -0400) Subject: Re: bug#72739: [PATCH] * lisp/gnus/gnus-sum.el: Handle leafs with children in summary line References: <87plq2c1in.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72739 Cc: 72739 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Blyte Scholar <bs@HIDDEN> > Date: Tue, 20 Aug 2024 17:44:48 -0400 > > Tags: patch > > > This patch adds customization options which handle the cases where a > thread leaf has both siblings and children. This allows using box > drawing characters to seamlessly connect all messages in a > thread. Previously, there would be messages could either be connected to > a sibling or a child, but not both. Thanks. Eric, any comments to the patch or the issue in general?
bug-gnu-emacs@HIDDEN
:bug#72739
; Package emacs
.
Full text available.Received: (at 72739) by debbugs.gnu.org; 24 Aug 2024 09:15:07 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 24 05:15:07 2024 Received: from localhost ([127.0.0.1]:40475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1shmrT-0008Ev-AE for submit <at> debbugs.gnu.org; Sat, 24 Aug 2024 05:15:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1shmrQ-0008EB-Rz for 72739 <at> debbugs.gnu.org; Sat, 24 Aug 2024 05:15:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1shmqY-0004QM-Od; Sat, 24 Aug 2024 05:14:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xvQ7O/yN18fouht+cRbSXEXs+zPS+tuAQJW5JX+pMDQ=; b=YqrFVxzAaPTu wFfwnF27XF2zYEvSuZHtfzkwAbPJiMN97LP0Q5w+CV/sWmfcZsbvKtJJYm2KI8Bf8IivBzwOjkRTs TyYkPDUrLPJQbpPS763bpsjeYNOMkBXTFdNaDgBvprnYWH/JZOPRVJ/taFhU0HjD07tRqXpbVfhlv qqbYi9kKEEa09PUJbDrpNziDzgt1pu1XT5dR6wLf+BJFf/L9HGVk4xrrci1pAEUZERgtND6HduIHc 39FKb05bWH1KabZ+Lad/enzb9mhfs8URCkYbAGvoypIfyIpk+A9yPlU8EO79xnmUVhSOLmkpYV5Qv pobjknjh0HptaIaPvpjUxw==; Date: Sat, 24 Aug 2024 12:14:07 +0300 Message-Id: <864j7anuzk.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Blyte Scholar <bs@HIDDEN>, eric@HIDDEN In-Reply-To: <87plq2c1in.fsf@HIDDEN> (message from Blyte Scholar on Tue, 20 Aug 2024 17:44:48 -0400) Subject: Re: bug#72739: [PATCH] * lisp/gnus/gnus-sum.el: Handle leafs with children in summary line References: <87plq2c1in.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72739 Cc: 72739 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Blyte Scholar <bs@HIDDEN> > Date: Tue, 20 Aug 2024 17:44:48 -0400 > > Tags: patch > > > This patch adds customization options which handle the cases where a > thread leaf has both siblings and children. This allows using box > drawing characters to seamlessly connect all messages in a > thread. Previously, there would be messages could either be connected to > a sibling or a child, but not both. Eric, any comments?
bug-gnu-emacs@HIDDEN
:bug#72739
; Package emacs
.
Full text available.Received: (at submit) by debbugs.gnu.org; 20 Aug 2024 22:09:58 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 20 18:09:58 2024 Received: from localhost ([127.0.0.1]:33758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sgX36-00088a-1E for submit <at> debbugs.gnu.org; Tue, 20 Aug 2024 18:09:58 -0400 Received: from lists.gnu.org ([209.51.188.17]:41158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <bs@HIDDEN>) id 1sgWg0-0007Wa-1j for submit <at> debbugs.gnu.org; Tue, 20 Aug 2024 17:46:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <bs@HIDDEN>) id 1sgWf6-0005lH-5B for bug-gnu-emacs@HIDDEN; Tue, 20 Aug 2024 17:45:16 -0400 Received: from paras.blyte.net ([198.12.76.26]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <bs@HIDDEN>) id 1sgWew-0001Yy-NR for bug-gnu-emacs@HIDDEN; Tue, 20 Aug 2024 17:45:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blyte.net; s=20240716; t=1724190291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=pLyxtqW6/7wLsSqvBFwd14C06uGmY7Fm33NQOoSqyx8=; b=GFmGvbZ7kgJswt3k0keIft4LATbGmXA7s/2beJubPtoNxS+WixPFRiJGhI9wLUNc7Vheq9 yFsRijUfj5ssm3IBc8Jsn1bt+NRuy1Xor5SasX02MSseKIP/LWuplF40JYBrfKhokgdX4a n9CnFfTrCGWdY77WrnaDksiXZUvLMjM= Received: from localhost (173-23-18-246.client.mchsi.com [173.23.18.246]) by paras.blyte.net (OpenSMTPD) with ESMTPSA id 4efb0dca (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <bug-gnu-emacs@HIDDEN>; Tue, 20 Aug 2024 17:44:50 -0400 (EDT) From: Blyte Scholar <bs@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: [PATCH] * lisp/gnus/gnus-sum.el: Handle leafs with children in summary line Date: Tue, 20 Aug 2024 17:44:48 -0400 Message-ID: <87plq2c1in.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=198.12.76.26; envelope-from=bs@HIDDEN; helo=paras.blyte.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 20 Aug 2024 18:09:54 -0400 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Tags: patch Tags: patch Tags: patch This patch adds customization options which handle the cases where a thread leaf has both siblings and children. This allows using box drawing characters to seamlessly connect all messages in a thread. Previously, there would be messages could either be connected to a sibling or a child, but not both. In GNU Emacs 31.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.43, cairo version 1.18.0) of 2024-08-20 built on rhipidon Repository revision: 5d435afc0e389e107fcee8d63405078341592f97 Repository branch: master System Description: Fedora Linux 40 (Workstation Edition) Configured using: 'configure --with-imagemagick --with-tree-sitter --with-native-compilation=aot --with-pgtk' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-lisp-gnus-gnus-sum.el-Handle-leafs-with-children-in-.patch From fca49a37ec7cc0c512290de93dd8311ca5a012d6 Mon Sep 17 00:00:00 2001 From: Blyte Scholar <bs@HIDDEN> Date: Tue, 20 Aug 2024 17:32:10 -0400 Subject: [PATCH] * lisp/gnus/gnus-sum.el: Handle leafs with children in summary line (gnus-sum-thread-tree-leaf-with-other-root): New variable. (gnus-sum-thread-tree-single-leaf-root): New variable. (gnus-summary-prepare-threads): Use gnus-sum-thread-tree-leaf-with-other-root and gnus-sum-thread-single-leaf-root strings in summary line when they are available. --- lisp/gnus/gnus-sum.el | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index a9caa83b15c..2fd342f3a0c 100644 --- a/lisp/gnus/gnus-sum.el +++ b/lisp/gnus/gnus-sum.el @@ -5193,12 +5193,26 @@ gnus-sum-thread-tree-leaf-with-other :type 'string :group 'gnus-thread) +(defcustom gnus-sum-thread-tree-leaf-with-other-root nil + "With %B spec, used for a leaf with brothers and children. +If nil use `gnus-sum-thread-tree-leaf-with-other' instead." + :version "31.1" + :type 'string + :group 'gnus-thread) + (defcustom gnus-sum-thread-tree-single-leaf "\\-> " "With %B spec, used for a leaf without brothers." :version "22.1" :type 'string :group 'gnus-thread) +(defcustom gnus-sum-thread-tree-single-leaf-root nil + "With %B spec, used for a leaf without brothers but children. +If nil use `gnus-sum-thread-tree-leaf-single-leaf' instead." + :version "31.1" + :type 'string + :group 'gnus-thread) + (defcustom gnus-summary-display-while-building nil "If non-nil, show and update the summary buffer as it's being built. If the value is t, update the buffer after every line is inserted. If @@ -5474,8 +5488,14 @@ gnus-summary-prepare-threads gnus-sum-thread-tree-indent)) (cdr (reverse tree-stack)))) (if (nth 1 thread) - gnus-sum-thread-tree-leaf-with-other - gnus-sum-thread-tree-single-leaf))))) + (if (and gnus-sum-thread-tree-leaf-with-other-root + (cadar thread)) + gnus-sum-thread-tree-leaf-with-other-root + gnus-sum-thread-tree-leaf-with-other) + (if (and gnus-sum-thread-tree-single-leaf-root + (cadar thread)) + gnus-sum-thread-tree-single-leaf-root + gnus-sum-thread-tree-single-leaf)))))) (when (string= gnus-tmp-name "") (setq gnus-tmp-name gnus-tmp-from)) (unless (numberp gnus-tmp-lines) -- 2.46.0 --=-=-=--
Blyte Scholar <bs@HIDDEN>
:bug-gnu-emacs@HIDDEN
.
Full text available.bug-gnu-emacs@HIDDEN
:bug#72739
; Package emacs
.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.