GNU logs - #73781, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#73781: [PATCH] Upgrade out-of-date dependencies with package-vc
Resent-From: Joseph Turner <joseph@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 12 Oct 2024 23:25:01 +0000
Resent-Message-ID: <handler.73781.B.172877545313876 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 73781 <at> debbugs.gnu.org
From: Joseph Turner <joseph@HIDDEN>
Date: Sun, 13 Oct 2024 01:23:38 +0200
Message-ID: <87jzechpmt.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=91.218.175.170;
 envelope-from=joseph@HIDDEN; helo=out-170.mta0.migadu.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

--=-=-=
Content-Type: text/plain

Tags: patch

I noticed this bug when working on hyperdrive.el, which I had installed
with package-vc-install-from-checkout.  I updated the version of its
transient.el dependency in the Package-Requires header and attempted to
reinstall, but it did not attempt to update the dependency.

I think the attached patch may not be the whole solution.  I applied it,
attempted package-vc-install-from-checkout again, and got this error:

package--with-response-buffer-1: https://melpa.org/packages/transient-20241004.1739.tar: Not found

Do we need to call package-refresh-contents at some point inside of
package-vc-install-dependencies?

Thank you!

Joseph


--=-=-=
Content-Type: text/patch
Content-Disposition: attachment;
 filename=0001-Upgrade-out-of-date-dependencies.patch

From fd05beab4903e3ba9f2a6866a00e924f8bcd5637 Mon Sep 17 00:00:00 2001
From: Joseph Turner <joseph@HIDDEN>
Date: Sun, 13 Oct 2024 01:10:02 +0200
Subject: [PATCH] Upgrade out-of-date dependencies

* lisp/emacs-lisp/package-vc.el (package-vc-install-dependencies): Pass
the specified package version when checking if a package is installed.
---
 lisp/emacs-lisp/package-vc.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
index e168096e153..58916637008 100644
--- a/lisp/emacs-lisp/package-vc.el
+++ b/lisp/emacs-lisp/package-vc.el
@@ -465,7 +465,7 @@ package-vc-install-dependencies
                   "Attempt to find all dependencies for PKG."
                   (cond
                    ((assq (car pkg) to-install)) ;inhibit cycles
-                   ((package-installed-p (car pkg)))
+                   ((package-installed-p (car pkg) (cadr pkg)))
                    ((let* ((pac package-archive-contents)
                            (desc (cadr (assoc (car pkg) pac))))
                       (if desc
-- 
2.46.0


--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Joseph Turner <joseph@HIDDEN>
Subject: bug#73781: Acknowledgement ([PATCH] Upgrade out-of-date
 dependencies with package-vc)
Message-ID: <handler.73781.B.172877545313876.ack <at> debbugs.gnu.org>
References: <87jzechpmt.fsf@HIDDEN>
X-Gnu-PR-Message: ack 73781
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 73781 <at> debbugs.gnu.org
Date: Sat, 12 Oct 2024 23:25:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 73781 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
73781: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D73781
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#73781: [PATCH] Upgrade out-of-date dependencies with package-vc
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 02 Jan 2025 02:15:02 +0000
Resent-Message-ID: <handler.73781.B73781.173578406311716 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Joseph Turner <joseph@HIDDEN>
Cc: Philip Kaludercic <philipk@HIDDEN>, 73781 <at> debbugs.gnu.org
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <87jzechpmt.fsf@HIDDEN> (Joseph Turner's message of
 "Sun, 13 Oct 2024 01:23:38 +0200")
References: <87jzechpmt.fsf@HIDDEN>
MIME-Version: 1.0
Date: Wed, 1 Jan 2025 20:14:18 -0600
Message-ID: <CADwFkmkJBJQDOxHLCkvhd9jn80HXfiDufwqjLMjBzYVvhJphxw@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Joseph Turner <joseph@HIDDEN> writes:

> Tags: patch
>
> I noticed this bug when working on hyperdrive.el, which I had installed
> with package-vc-install-from-checkout.  I updated the version of its
> transient.el dependency in the Package-Requires header and attempted to
> reinstall, but it did not attempt to update the dependency.
>
> I think the attached patch may not be the whole solution.  I applied it,
> attempted package-vc-install-from-checkout again, and got this error:
>
> package--with-response-buffer-1: https://melpa.org/packages/transient-20241004.1739.tar: Not found
>
> Do we need to call package-refresh-contents at some point inside of
> package-vc-install-dependencies?
>
> Thank you!
>
> Joseph

Philip, any comments?

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.