GNU logs - #74553, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#74553: [ELPA] [PATCH] register-list does not support framesets
Resent-From: Alex Bochannek <alex@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 27 Nov 2024 02:25:02 +0000
Resent-Message-ID: <handler.74553.B.173267428729547 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 74553 <at> debbugs.gnu.org
Cc: Philip Kaludercic <philipk@HIDDEN>
From: Alex Bochannek <alex@HIDDEN>
Date: Tue, 26 Nov 2024 18:18:18 -0800
Message-ID: <m2ed2xifmd.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=50.0.39.240; envelope-from=alex@HIDDEN;
 helo=mail.lapseofthought.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

--=-=-=
Content-Type: text/plain

Hello!

This is a follow-up to a comment I made on bug#73827. The register-list
package only supports frames, but not framesets. The below patch is not
particularly elegant, because framesets are saved as registers as type
frameset-register, so the frameset-p predicate does not apply here. This
is a pretty simple change and if there is a better way, I am obviously
open to it.

Also note that I did not remove support for the frame configurations. I
instead kept type "F" for both and updated the documentation. Because
neither the values of frames nor framesets can be edited, this did not
present an issue in testing.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
 filename=0001-Add-framesets-as-a-register-type.patch

From b5c881ef45a43b72c17dd27de2c3f9cd1c506fe1 Mon Sep 17 00:00:00 2001
From: Alex Bochannek <alex@HIDDEN>
Date: Tue, 26 Nov 2024 17:58:06 -0800
Subject: [PATCH] Add framesets as a register type

---
 register-list.el | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/register-list.el b/register-list.el
index 846d3efe49..435861cd32 100644
--- a/register-list.el
+++ b/register-list.el
@@ -294,9 +294,9 @@ The Key column displays the character used for this register.
 Hitting \\[register-list-call-handler-at-point] on the key will
 prompt for a replacement.
 
-The Type column displays the type of the register, either [F]rame
-\[N]umber [M]arkers [R]ectangle [S]string or [W]window.  Hitting
-\\[register-list-call-handler-at-point] on this column will
+The Type column displays the type of the register, either
+[F]rame/Frameset [N]umber [M]arkers [R]ectangle [S]tring or [W]indow.
+Hitting \\[register-list-call-handler-at-point] on this column will
 restrict the register list to this type of registers.  To quickly
 list a specific type, hit the type character among [FNMRSW].
 
@@ -466,7 +466,7 @@ the register or copy its value into the kill ring."
 		  (frame-parameter
 		   (window-configuration-frame (car value)) 'name)))
 	((string= "F" type)
-	 (format "[Frame configuration]"))
+	 (format "[Frame/Frameset configuration]"))
 	(t "[Error: unknown type]")))
 
 (defun register-list-get-type (key)
@@ -475,6 +475,7 @@ the register or copy its value into the kill ring."
       (cond ((stringp key) "S")
 	    ((markerp key) "M")
 	    ((numberp key) "N")
+	    ((equal 'frameset-register (type-of key)) "F")
 	    (t "error"))
     (cond ((window-configuration-p (car key)) "W")
 	  ((frame-configuration-p (car key)) "F")
-- 
2.39.5 (Apple Git-154)


--=-=-=
Content-Type: text/plain


-- 
Alex.

--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Alex Bochannek <alex@HIDDEN>
Subject: bug#74553: Acknowledgement ([ELPA] [PATCH] register-list does not
 support framesets)
Message-ID: <handler.74553.B.173267428729547.ack <at> debbugs.gnu.org>
References: <m2ed2xifmd.fsf@HIDDEN>
X-Gnu-PR-Message: ack 74553
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 74553 <at> debbugs.gnu.org
Date: Wed, 27 Nov 2024 02:25:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 74553 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
74553: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74553
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 2 Jan 2025 01:57:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 01 20:57:30 2025
Received: from localhost ([127.0.0.1]:41347 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tTASo-0002A4-0T
	for submit <at> debbugs.gnu.org; Wed, 01 Jan 2025 20:57:30 -0500
Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]:49394)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tTASl-00029m-Nt
 for control <at> debbugs.gnu.org; Wed, 01 Jan 2025 20:57:28 -0500
Received: by mail-ej1-x62f.google.com with SMTP id
 a640c23a62f3a-aaecf50578eso1407292166b.2
 for <control <at> debbugs.gnu.org>; Wed, 01 Jan 2025 17:57:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1735783041; x=1736387841; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=j5lf9N4ngjlQYV/LHklIVNLKC9twj5Eyg+rcpiUmru4=;
 b=Cvmhg8QRs6WRr0m4X/YlWI364NCdKjoZL6bZKC+9ijGr107WNGiLAAzApAknjD1oVe
 xIU8vqIFRh16LTPfvGnKBbmEIZuebL3yTUGj4PFv231Ijqsi3sTmduwXvC2Ii/zeDSCH
 0JOUlb4mUw7WT5kMG6loCG/SbsTeRJedI6FYi6Wrh3Ii/zkWttCD/+Lg3Hx8A0P3CWIg
 gcgg2LbiSmS9LvH9gqP/n+RmdUuelVxKGLF13GpchH8keuoFVjYX4xJtygyjcNq3Rq1C
 TIQI+4UbUXJLp9grprp4P9LxHTlEnq8scY6zjXCUjnKrgpEXcmcyaCDY7sL2pPnfygZt
 S7kg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1735783041; x=1736387841;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=j5lf9N4ngjlQYV/LHklIVNLKC9twj5Eyg+rcpiUmru4=;
 b=SJubOrAVYY3ayMRHrh/JWqBJ8PBODRbCREcg6z6uhL2+gIVDw3p+CnAs2WrHg7MvWT
 3daLEGMzeulDYy5s7+OditR2/NXmq/UEEko1WHpF6IqbcIL00o8xKGHagLm8vGULdPMb
 MQBMRZPKll05qrE3gZTIYOnbDmfnF7W580NdwXTIEwD3lxFFA+bBYgZ7H37yVVgG63Wh
 nRjSz4Ubz8rCiM0WzlZrdyUqqzpx+n7ksKoYSl1Lx5b13vDGxYND0g3TQzy8LClwNc1m
 cGbBF9Rj3YrHTR9tLqCol82KGJ3Zxbr2FfuWmyLMwRXYQgApTbp6nJCmH18F1fdxV4Wt
 lnHw==
X-Gm-Message-State: AOJu0YyIaDDmXvEqOntnqyDbeBHO91mg+Hf/h0O0o6jpvmsTgmKeYxP+
 Qp9RsB4+8+Trw2KvOR+vIaUmlvNjBjbGBeSgiJYma5kwrNoL8li6pF3RkAWqf0G3gChmNLx/ksN
 GZUqAYubaJQJImpyrnEG593U35YyA5+Ih
X-Gm-Gg: ASbGncvgfzVK4sVjHqurOsLslA7jYlUYWcNjS1XPO3+ow0DEDTbbicV0A89Gcfnxd2b
 gKqZBM7847IOL9ogAKkcSpDmWbdi/2d9kpbbBtJ3P
X-Google-Smtp-Source: AGHT+IGdxgv4kqAmCaBbguot9RIOF+beJoc3MMUlBkclJEYRjGbpxKmHxCt1Ig/J9CR3pGVAUofHGt0xPwss/PM79dw=
X-Received: by 2002:a17:906:dc92:b0:aab:da48:493e with SMTP id
 a640c23a62f3a-aac2ad88fdbmr4453251266b.21.1735783041339; Wed, 01 Jan 2025
 17:57:21 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Wed, 1 Jan 2025 19:57:21 -0600
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Wed, 1 Jan 2025 19:57:21 -0600
Message-ID: <CADwFkmk-0VB9OLC_ojVuBCaatkVoxkit2hdwvq4Ag2XLX+ZYmA@HIDDEN>
Subject: control message for bug #74553
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

severity 74553 wishlist
quit

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#74553: [ELPA] [PATCH] register-list does not support framesets
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 13 Feb 2025 10:07:02 +0000
Resent-Message-ID: <handler.74553.B74553.17394411698722 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Alex Bochannek <alex@HIDDEN>
Cc: 74553 <at> debbugs.gnu.org, Philip Kaludercic <philipk@HIDDEN>, Bastien Guerry <bzg@HIDDEN>
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <m2ed2xifmd.fsf@HIDDEN>
References: <m2ed2xifmd.fsf@HIDDEN>
MIME-Version: 1.0
Date: Thu, 13 Feb 2025 04:05:58 -0600
Message-ID: <CADwFkm=4aePPaZOP2GYppkjpL9JJ3gZj_=V7krDUxygZdX9ECA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Alex Bochannek <alex@HIDDEN> writes:

> Hello!
>
> This is a follow-up to a comment I made on bug#73827. The register-list
> package only supports frames, but not framesets. The below patch is not
> particularly elegant, because framesets are saved as registers as type
> frameset-register, so the frameset-p predicate does not apply here. This
> is a pretty simple change and if there is a better way, I am obviously
> open to it.
>
> Also note that I did not remove support for the frame configurations. I
> instead kept type "F" for both and updated the documentation. Because
> neither the values of frames nor framesets can be edited, this did not
> present an issue in testing.

Bastien, do you have any comments on the below patch?

> From b5c881ef45a43b72c17dd27de2c3f9cd1c506fe1 Mon Sep 17 00:00:00 2001
> From: Alex Bochannek <alex@HIDDEN>
> Date: Tue, 26 Nov 2024 17:58:06 -0800
> Subject: [PATCH] Add framesets as a register type
>
> ---
>  register-list.el | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/register-list.el b/register-list.el
> index 846d3efe49..435861cd32 100644
> --- a/register-list.el
> +++ b/register-list.el
> @@ -294,9 +294,9 @@ The Key column displays the character used for this register.
>  Hitting \\[register-list-call-handler-at-point] on the key will
>  prompt for a replacement.
>
> -The Type column displays the type of the register, either [F]rame
> -\[N]umber [M]arkers [R]ectangle [S]string or [W]window.  Hitting
> -\\[register-list-call-handler-at-point] on this column will
> +The Type column displays the type of the register, either
> +[F]rame/Frameset [N]umber [M]arkers [R]ectangle [S]tring or [W]indow.
> +Hitting \\[register-list-call-handler-at-point] on this column will
>  restrict the register list to this type of registers.  To quickly
>  list a specific type, hit the type character among [FNMRSW].
>
> @@ -466,7 +466,7 @@ the register or copy its value into the kill ring."
>  		  (frame-parameter
>  		   (window-configuration-frame (car value)) 'name)))
>  	((string= "F" type)
> -	 (format "[Frame configuration]"))
> +	 (format "[Frame/Frameset configuration]"))
>  	(t "[Error: unknown type]")))
>
>  (defun register-list-get-type (key)
> @@ -475,6 +475,7 @@ the register or copy its value into the kill ring."
>        (cond ((stringp key) "S")
>  	    ((markerp key) "M")
>  	    ((numberp key) "N")
> +	    ((equal 'frameset-register (type-of key)) "F")
>  	    (t "error"))
>      (cond ((window-configuration-p (car key)) "W")
>  	  ((frame-configuration-p (car key)) "F")
> --
> 2.39.5 (Apple Git-154)

Last modified: Thu, 13 Feb 2025 10:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.