GNU bug report logs - #74553
[ELPA] [PATCH] register-list does not support framesets

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: emacs; Severity: wishlist; Reported by: Alex Bochannek <alex@HIDDEN>; Keywords: patch; dated Wed, 27 Nov 2024 02:25:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 74553 <at> debbugs.gnu.org:


Received: (at 74553) by debbugs.gnu.org; 13 Feb 2025 10:06:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 13 05:06:08 2025
Received: from localhost ([127.0.0.1]:40667 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tiW6i-0002Gc-Fg
	for submit <at> debbugs.gnu.org; Thu, 13 Feb 2025 05:06:08 -0500
Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:47578)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tiW6f-0002Fy-Kx
 for 74553 <at> debbugs.gnu.org; Thu, 13 Feb 2025 05:06:06 -0500
Received: by mail-ed1-x536.google.com with SMTP id
 4fb4d7f45d1cf-5de3c29ebaeso828146a12.3
 for <74553 <at> debbugs.gnu.org>; Thu, 13 Feb 2025 02:06:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1739441159; x=1740045959; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=phxsZL7kafxr/QbLF/jgjfnpc5qffCLKr51ReeOSk6E=;
 b=eAa4AVFZEkbMhGN521NxSpKorByXrJyuiyLw90IA729cFeKwSJoP8TddY0E6sfefnI
 I5kEn52CxqEOmoU/zmjqtjsze1i42U3ogRH65MkekLaUQ/VaR8ue0+h/zDliHna0g1Gj
 h+KotP+0fgxAvHK/VczjS5lZStMCmCBttBJRJZ8wciGZofZQ+Zwu75wZbfdLfYX2xriQ
 Azyt5LfGuD1dKY00BSt2i9/4u9r5N6M3nClCUyuM0QoEFYGEiI93Zv/Ejpoh7j/y/mqb
 25JoXokRKjvW35bZOncVFOryTdi93C/li0etAfvMsCylxVek6j6og2Nr1PnqQPdDlvQ9
 IKvw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1739441159; x=1740045959;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=phxsZL7kafxr/QbLF/jgjfnpc5qffCLKr51ReeOSk6E=;
 b=D08jkwGUBkjc53kfk3C1ryd43Wu/DQT0+QjTxq5PB3gOa5RU/Oo8JTsywAiccKEZn/
 W1XD+Og6RG6jR7t7igU+CntGWpTZF7RDTZnW17aamej+3yXaHu6dgWh8p90rpqdNMfbW
 1deiuHAzDuX2boCzeuGiuDPpHH16LXqOfsAUROlazYPM+1O0i4rLgCZsKimIqZKm65D1
 eI1mVDsZkkpmLibIDe5WqV0RKymnhdxUZz2C20Eq5XDNDIUQc+CuWZAt8Wph/I0T/v5L
 wKgph1srKimf8TePuRQJ0D3uC4pTEp62Pp6juXIHOdtKeW9tL/2CEe0VOh1U0S+Y4RSO
 VWqQ==
X-Gm-Message-State: AOJu0YyxUoRczDkGjfi/oLnB0spHqS97aqfbjRfWA9YfMHTUpEZmK2K+
 9j+DUJlMZfXUvMVOymFHAYJZif1XOuemmCh1SGG9yow6fCThyqTiIZIcYtbJTq1wvk8wKq8Cd2L
 oxFzG95LU/byR93cJxxMDidn7l44=
X-Gm-Gg: ASbGncto5ggwl/0EAZ9oPoCky2GYjds++2aB8jzqSYoSShTnfWLlmtYP4Nt8FhRAvsT
 R+ULYJb+PQBPnRTigwZi4RPIhlufdxXG34364HzJigf3ZUSIAiQeuOFKEfrxoa7tsKOgtUXr+rw
 4=
X-Google-Smtp-Source: AGHT+IHP+bs2bIby5NLjH7GTQ0HXwEv1yWygpPTcUvMNv6x3qr4fwvF1yejx4KDPKLyEsFAbtxCfSk7meaS8u2I/e1w=
X-Received: by 2002:a05:6402:354e:b0:5d3:d4cf:fea0 with SMTP id
 4fb4d7f45d1cf-5deadde030cmr5539769a12.21.1739441159158; Thu, 13 Feb 2025
 02:05:59 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Thu, 13 Feb 2025 04:05:58 -0600
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <m2ed2xifmd.fsf@HIDDEN>
References: <m2ed2xifmd.fsf@HIDDEN>
MIME-Version: 1.0
Date: Thu, 13 Feb 2025 04:05:58 -0600
X-Gm-Features: AWEUYZnGUga0lfOMiNBfU5y0THj2QD63ylSzs3YwDfNYbBLin38BJl7jFaYz0gI
Message-ID: <CADwFkm=4aePPaZOP2GYppkjpL9JJ3gZj_=V7krDUxygZdX9ECA@HIDDEN>
Subject: Re: bug#74553: [ELPA] [PATCH] register-list does not support framesets
To: Alex Bochannek <alex@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74553
Cc: 74553 <at> debbugs.gnu.org, Philip Kaludercic <philipk@HIDDEN>,
 Bastien Guerry <bzg@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Alex Bochannek <alex@HIDDEN> writes:

> Hello!
>
> This is a follow-up to a comment I made on bug#73827. The register-list
> package only supports frames, but not framesets. The below patch is not
> particularly elegant, because framesets are saved as registers as type
> frameset-register, so the frameset-p predicate does not apply here. This
> is a pretty simple change and if there is a better way, I am obviously
> open to it.
>
> Also note that I did not remove support for the frame configurations. I
> instead kept type "F" for both and updated the documentation. Because
> neither the values of frames nor framesets can be edited, this did not
> present an issue in testing.

Bastien, do you have any comments on the below patch?

> From b5c881ef45a43b72c17dd27de2c3f9cd1c506fe1 Mon Sep 17 00:00:00 2001
> From: Alex Bochannek <alex@HIDDEN>
> Date: Tue, 26 Nov 2024 17:58:06 -0800
> Subject: [PATCH] Add framesets as a register type
>
> ---
>  register-list.el | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/register-list.el b/register-list.el
> index 846d3efe49..435861cd32 100644
> --- a/register-list.el
> +++ b/register-list.el
> @@ -294,9 +294,9 @@ The Key column displays the character used for this register.
>  Hitting \\[register-list-call-handler-at-point] on the key will
>  prompt for a replacement.
>
> -The Type column displays the type of the register, either [F]rame
> -\[N]umber [M]arkers [R]ectangle [S]string or [W]window.  Hitting
> -\\[register-list-call-handler-at-point] on this column will
> +The Type column displays the type of the register, either
> +[F]rame/Frameset [N]umber [M]arkers [R]ectangle [S]tring or [W]indow.
> +Hitting \\[register-list-call-handler-at-point] on this column will
>  restrict the register list to this type of registers.  To quickly
>  list a specific type, hit the type character among [FNMRSW].
>
> @@ -466,7 +466,7 @@ the register or copy its value into the kill ring."
>  		  (frame-parameter
>  		   (window-configuration-frame (car value)) 'name)))
>  	((string= "F" type)
> -	 (format "[Frame configuration]"))
> +	 (format "[Frame/Frameset configuration]"))
>  	(t "[Error: unknown type]")))
>
>  (defun register-list-get-type (key)
> @@ -475,6 +475,7 @@ the register or copy its value into the kill ring."
>        (cond ((stringp key) "S")
>  	    ((markerp key) "M")
>  	    ((numberp key) "N")
> +	    ((equal 'frameset-register (type-of key)) "F")
>  	    (t "error"))
>      (cond ((window-configuration-p (car key)) "W")
>  	  ((frame-configuration-p (car key)) "F")
> --
> 2.39.5 (Apple Git-154)
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#74553; Package emacs. Full text available.
Severity set to 'wishlist' from 'normal' Request was from Stefan Kangas <stefankangas@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 27 Nov 2024 02:24:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 26 21:24:46 2024
Received: from localhost ([127.0.0.1]:55913 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tG7jS-0007gV-FN
	for submit <at> debbugs.gnu.org; Tue, 26 Nov 2024 21:24:46 -0500
Received: from lists.gnu.org ([209.51.188.17]:34542)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <alex@HIDDEN>) id 1tG7jQ-0007gN-H1
 for submit <at> debbugs.gnu.org; Tue, 26 Nov 2024 21:24:44 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <alex@HIDDEN>)
 id 1tG7jO-0006v1-Gi
 for bug-gnu-emacs@HIDDEN; Tue, 26 Nov 2024 21:24:42 -0500
Received: from ns.lapseofthought.com ([50.0.39.240]
 helo=mail.lapseofthought.com)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <alex@HIDDEN>)
 id 1tG7jM-0007nJ-A0
 for bug-gnu-emacs@HIDDEN; Tue, 26 Nov 2024 21:24:42 -0500
Received: from awb-mbp-m3.local (c-24-23-131-202.hsd1.ca.comcast.net
 [24.23.131.202])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mail.lapseofthought.com (Postfix) with ESMTPSA id 4Xyjlt5sNgz3pt9S;
 Tue, 26 Nov 2024 18:18:18 -0800 (PST)
Authentication-Results: ORIGINATING;
 auth=pass smtp.auth=alex smtp.mailfrom=alex@HIDDEN
From: Alex Bochannek <alex@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [ELPA] [PATCH] register-list does not support framesets
Date: Tue, 26 Nov 2024 18:18:18 -0800
Message-ID: <m2ed2xifmd.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=50.0.39.240; envelope-from=alex@HIDDEN;
 helo=mail.lapseofthought.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
Cc: Philip Kaludercic <philipk@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

--=-=-=
Content-Type: text/plain

Hello!

This is a follow-up to a comment I made on bug#73827. The register-list
package only supports frames, but not framesets. The below patch is not
particularly elegant, because framesets are saved as registers as type
frameset-register, so the frameset-p predicate does not apply here. This
is a pretty simple change and if there is a better way, I am obviously
open to it.

Also note that I did not remove support for the frame configurations. I
instead kept type "F" for both and updated the documentation. Because
neither the values of frames nor framesets can be edited, this did not
present an issue in testing.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
 filename=0001-Add-framesets-as-a-register-type.patch

From b5c881ef45a43b72c17dd27de2c3f9cd1c506fe1 Mon Sep 17 00:00:00 2001
From: Alex Bochannek <alex@HIDDEN>
Date: Tue, 26 Nov 2024 17:58:06 -0800
Subject: [PATCH] Add framesets as a register type

---
 register-list.el | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/register-list.el b/register-list.el
index 846d3efe49..435861cd32 100644
--- a/register-list.el
+++ b/register-list.el
@@ -294,9 +294,9 @@ The Key column displays the character used for this register.
 Hitting \\[register-list-call-handler-at-point] on the key will
 prompt for a replacement.
 
-The Type column displays the type of the register, either [F]rame
-\[N]umber [M]arkers [R]ectangle [S]string or [W]window.  Hitting
-\\[register-list-call-handler-at-point] on this column will
+The Type column displays the type of the register, either
+[F]rame/Frameset [N]umber [M]arkers [R]ectangle [S]tring or [W]indow.
+Hitting \\[register-list-call-handler-at-point] on this column will
 restrict the register list to this type of registers.  To quickly
 list a specific type, hit the type character among [FNMRSW].
 
@@ -466,7 +466,7 @@ the register or copy its value into the kill ring."
 		  (frame-parameter
 		   (window-configuration-frame (car value)) 'name)))
 	((string= "F" type)
-	 (format "[Frame configuration]"))
+	 (format "[Frame/Frameset configuration]"))
 	(t "[Error: unknown type]")))
 
 (defun register-list-get-type (key)
@@ -475,6 +475,7 @@ the register or copy its value into the kill ring."
       (cond ((stringp key) "S")
 	    ((markerp key) "M")
 	    ((numberp key) "N")
+	    ((equal 'frameset-register (type-of key)) "F")
 	    (t "error"))
     (cond ((window-configuration-p (car key)) "W")
 	  ((frame-configuration-p (car key)) "F")
-- 
2.39.5 (Apple Git-154)


--=-=-=
Content-Type: text/plain


-- 
Alex.

--=-=-=--
Acknowledgement sent to Alex Bochannek <alex@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#74553; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 13 Feb 2025 10:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.