GNU logs - #74627, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#74627: .dir-locals.el warning messages are confusing
Resent-From: =?UTF-8?Q?Bj=C3=B6rn?= Lindqvist <bjourne@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 30 Nov 2024 17:21:01 +0000
Resent-Message-ID: <handler.74627.B.173298725522748 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 74627 <at> debbugs.gnu.org
MIME-Version: 1.0
From: =?UTF-8?Q?Bj=C3=B6rn?= Lindqvist <bjourne@HIDDEN>
Date: Sat, 30 Nov 2024 18:20:35 +0100
Message-ID: <CALG+76fJ3dh2ZQhRia3Gm2vvXiaD+3QQtHbc0OWi7yF8i3AP=w@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=2607:f8b0:4864:20::72d;
 envelope-from=bjourne@HIDDEN; helo=mail-qk1-x72d.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Warnings about potential security issues should be easy to understand,
but the warnings produced by .dir-locals.el are not. When I open a
file in the Emacs source code it shows:

    The local variables list in /home/bjourne/p/emacs/
    or .dir-locals.el contains values that may not be safe (*).

Why does it say "or"? What does the asterisk (*) mean? Could the
descriptions for "!" and "i" be clearer so it is more obvious what is
applied and what is ignored?


--=20
mvh/best regards Bj=C3=B6rn Lindqvist

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: =?UTF-8?Q?Bj=C3=B6rn?= Lindqvist <bjourne@HIDDEN>
Subject: bug#74627: Acknowledgement (.dir-locals.el warning messages are
 confusing)
Message-ID: <handler.74627.B.173298725522748.ack <at> debbugs.gnu.org>
References: <CALG+76fJ3dh2ZQhRia3Gm2vvXiaD+3QQtHbc0OWi7yF8i3AP=w@HIDDEN>
X-Gnu-PR-Message: ack 74627
X-Gnu-PR-Package: emacs
Reply-To: 74627 <at> debbugs.gnu.org
Date: Sat, 30 Nov 2024 17:21:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 74627 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
74627: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74627
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#74627: .dir-locals.el warning messages are confusing
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 05 Dec 2024 09:40:02 +0000
Resent-Message-ID: <handler.74627.B74627.17333915439844 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: =?UTF-8?Q?Bj=C3=B6rn?= Lindqvist <bjourne@HIDDEN>, Stefan Monnier <monnier@HIDDEN>
Cc: 74627 <at> debbugs.gnu.org
Date: Thu, 05 Dec 2024 11:38:51 +0200
Message-Id: <86a5daxydw.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CALG+76fJ3dh2ZQhRia3Gm2vvXiaD+3QQtHbc0OWi7yF8i3AP=w@HIDDEN>
 (message from =?UTF-8?Q?Bj=C3=B6rn?= Lindqvist on Sat, 30 Nov 2024 18:20:35
 +0100)
References: <CALG+76fJ3dh2ZQhRia3Gm2vvXiaD+3QQtHbc0OWi7yF8i3AP=w@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> From: Björn Lindqvist <bjourne@HIDDEN>
> Date: Sat, 30 Nov 2024 18:20:35 +0100
> 
> Warnings about potential security issues should be easy to understand,
> but the warnings produced by .dir-locals.el are not. When I open a
> file in the Emacs source code it shows:
> 
>     The local variables list in /home/bjourne/p/emacs/
>     or .dir-locals.el contains values that may not be safe (*).
> 
> Why does it say "or"?

Because that function is called with a single flag argument which
could be set non-nil either due to unsafe file-local variables or due
to .dir-locals.el.

> What does the asterisk (*) mean?

It means the variables marked with the asterisk in the list of
below this text could be unsafe.

> Could the descriptions for "!" and "i" be clearer so it is more
> obvious what is applied and what is ignored?

Please tell what is unclear there.  The current text is

  !  -- to apply the local variables list, and permanently mark these
	values (*) as safe (in the future, they will be set automatically.)
  i  -- to ignore the local variables list, and permanently mark these
	values (*) as ignored"

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#74627: .dir-locals.el warning messages are confusing
Resent-From: =?UTF-8?Q?Bj=C3=B6rn?= Lindqvist <bjourne@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 11 Dec 2024 08:20:01 +0000
Resent-Message-ID: <handler.74627.B74627.173390519319039 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Eli Zaretskii <eliz@HIDDEN>
Cc: Stefan Monnier <monnier@HIDDEN>, 74627 <at> debbugs.gnu.org
MIME-Version: 1.0
References: <CALG+76fJ3dh2ZQhRia3Gm2vvXiaD+3QQtHbc0OWi7yF8i3AP=w@HIDDEN>
 <86a5daxydw.fsf@HIDDEN>
In-Reply-To: <86a5daxydw.fsf@HIDDEN>
From: =?UTF-8?Q?Bj=C3=B6rn?= Lindqvist <bjourne@HIDDEN>
Date: Wed, 11 Dec 2024 09:18:33 +0100
Message-ID: <CALG+76f9OTpFuHgTye+gUoGNkjOR4bi8Rt8xsss7d3HZs9kwNA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hello Eli,

Den tors 5 dec. 2024 kl 10:38 skrev Eli Zaretskii <eliz@HIDDEN>:

> > Warnings about potential security issues should be easy to understand,
> > but the warnings produced by .dir-locals.el are not. When I open a
> > file in the Emacs source code it shows:
> >
> >     The local variables list in /home/bjourne/p/emacs/
> >     or .dir-locals.el contains values that may not be safe (*).
> >
> > Why does it say "or"?
>
> Because that function is called with a single flag argument which
> could be set non-nil either due to unsafe file-local variables or due
> to .dir-locals.el.

So there are multiple sources of unsafe variables, but the function
responsible for formulating the error message doesn't know what the
source is? Regardless of whether my guess is correct, the text should
not refer to the local variables in "/home/bjourne/p/emacs/" because
there can be no unsafe variables in directories (only files).

> > What does the asterisk (*) mean?
>
> It means the variables marked with the asterisk in the list of
> below this text could be unsafe.

Aha. Emacs lists both safe and unsafe variables. Why does it list the
safe ones? The warning would be much clearer if the safe variables
were omitted since they don't matter. That would make it clear what
variables "!" and "i" choices apply or mark as safe/ignored.


--
mvh/best regards Bj=C3=B6rn Lindqvist

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#74627: .dir-locals.el warning messages are confusing
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 11 Dec 2024 11:18:01 +0000
Resent-Message-ID: <handler.74627.B74627.173391585830619 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 74627
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: =?UTF-8?Q?Bj=C3=B6rn?= Lindqvist <bjourne@HIDDEN>,  Eli Zaretskii <eliz@HIDDEN>
Cc: Stefan Monnier <monnier@HIDDEN>, 74627 <at> debbugs.gnu.org
Received: via spool by 74627-submit <at> debbugs.gnu.org id=B74627.173391585830619
          (code B ref 74627); Wed, 11 Dec 2024 11:18:01 +0000
Received: (at 74627) by debbugs.gnu.org; 11 Dec 2024 11:17:38 +0000
Received: from localhost ([127.0.0.1]:33210 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tLKin-0007xm-PK
	for submit <at> debbugs.gnu.org; Wed, 11 Dec 2024 06:17:38 -0500
Received: from mail-ed1-f52.google.com ([209.85.208.52]:57506)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1tLKim-0007xV-30
 for 74627 <at> debbugs.gnu.org; Wed, 11 Dec 2024 06:17:36 -0500
Received: by mail-ed1-f52.google.com with SMTP id
 4fb4d7f45d1cf-5cfa1ec3b94so8941898a12.2
 for <74627 <at> debbugs.gnu.org>; Wed, 11 Dec 2024 03:17:36 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1733915795; x=1734520595; darn=debbugs.gnu.org;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=xDwUhP0f0FTIkEkMVSox0wEfb9Kn18YOhL2jzMySqxk=;
 b=TKiJE4N33Hz9Q2F1BXVEoosQfZrfj+M3QxkKtSCUsEzjhdZouYG0tQdHYgkwC4PqGV
 6O/bdxV+4uFkLYFjf3p2xMHHYqgGgTPc9/Cpp3w9fri6viqobviiSe0O26OOMKVnVjcL
 QGFKNi32EiOXu6tOQpF7ztDDLHFiGqx7sqfWs0yoa1XuvKWxriNQCtozKM5CyUYFZXGD
 Zztjeq7P/iETQMw2k2rJYREpe3Ju9pPaZAsvjLe3f/VDkiUV+15DSqw5wh6n4GUn/dtY
 NZ7vOXzuo5iXSkI8gIZQqhTki57P45TClNB4WQ70f1GXgb0MXSuLAzkd/oO8y1lygole
 kQWA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1733915795; x=1734520595;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:x-gm-message-state:from:to
 :cc:subject:date:message-id:reply-to;
 bh=xDwUhP0f0FTIkEkMVSox0wEfb9Kn18YOhL2jzMySqxk=;
 b=liaB714oJNzebblLC20BAXF9jkVNYvzCsSkjQzBL8GVKOwng1yR8bF+oUUmYucAHtn
 ObDofktuzmsEE36NwpsqMW+qx+NOcl+Hmo7Og5ZiK3oLHVx0iYeUwgslstmGP5p8TSPy
 3RXkQBef92AN0YidR87TbtjxDreieemodSwDuuUEUZLULElwZiQi8TrKQRzEMEHzguSF
 t5lYudtD+0U8suYV++oP1bCa4q9faI/zhmwduS/uB05Tc6dHYToN2N6BCEBRqf+TfjkJ
 /5IqqXB9w4lhYAurC5G83RCYgSuai1ppMuoOFCFLL/flYCurwVFH+RYlU63n54YlbC3E
 0Y1Q==
X-Forwarded-Encrypted: i=1;
 AJvYcCV6lzHiXFhv+OnFRqukQHI1976H1v8FQfE5EZgcrQsHiRMazRWOttTeewGQj9mktC2OOFrfwg==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YyJwn7kaggM7xs3AMsnQif+p/ytLyo053n/M7V7Ooy6bvKpEEME
 VVF+ZHDCiMPfpq6jR4bFf19p7Mfe1wUdNyJw9tk2pH3S1BVXLmTrZTYcK/ETN26nYGaxh/SmGWY
 nLQW9LO6U1DsUROMYSAXLoM7N5AA=
X-Gm-Gg: ASbGncv06Xb7EFVUJsztf9VKDIVfv3nVRAH0XHp+xkrfXKsUeba+5pmElysFYEJ89Yb
 g1EoITFss75sNUxC+HklvPI2rlHrCe3Cu2rARGw==
X-Google-Smtp-Source: AGHT+IGfsMh7Hd9IUF4nfjOdrFx2hYXZDBaQfPS3p0h+9PuGz3HtwHqfdXa0+Pbqtu2ChCakPVuWzcVR+T9suCoTmFA=
X-Received: by 2002:a05:6402:2688:b0:5d3:d8b9:674d with SMTP id
 4fb4d7f45d1cf-5d432f277c0mr2409177a12.0.1733915795032; Wed, 11 Dec 2024
 03:16:35 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Wed, 11 Dec 2024 03:16:34 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <CALG+76f9OTpFuHgTye+gUoGNkjOR4bi8Rt8xsss7d3HZs9kwNA@HIDDEN>
References: <CALG+76fJ3dh2ZQhRia3Gm2vvXiaD+3QQtHbc0OWi7yF8i3AP=w@HIDDEN>
 <86a5daxydw.fsf@HIDDEN>
 <CALG+76f9OTpFuHgTye+gUoGNkjOR4bi8Rt8xsss7d3HZs9kwNA@HIDDEN>
MIME-Version: 1.0
Date: Wed, 11 Dec 2024 03:16:34 -0800
Message-ID: <CADwFkm=MuazQpf1tHKsWCZ0oB70hHarRZODuL61uSVnMt_S0eQ@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Bj=C3=B6rn Lindqvist <bjourne@HIDDEN> writes:

> Aha. Emacs lists both safe and unsafe variables. Why does it list the
> safe ones? The warning would be much clearer if the safe variables
> were omitted since they don't matter. That would make it clear what
> variables "!" and "i" choices apply or mark as safe/ignored.

You have to see all of them to make an informed decision, I think.
Otherwise, an unsafe variable might be referring to a safe one, which is
the one containing the malicious bits.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#74627: .dir-locals.el warning messages are confusing
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 11 Dec 2024 15:01:02 +0000
Resent-Message-ID: <handler.74627.B74627.173392922521252 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 74627
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: =?UTF-8?Q?Bj=C3=B6rn?= Lindqvist <bjourne@HIDDEN>
Cc: monnier@HIDDEN, 74627 <at> debbugs.gnu.org
Received: via spool by 74627-submit <at> debbugs.gnu.org id=B74627.173392922521252
          (code B ref 74627); Wed, 11 Dec 2024 15:01:02 +0000
Received: (at 74627) by debbugs.gnu.org; 11 Dec 2024 15:00:25 +0000
Received: from localhost ([127.0.0.1]:35669 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tLOCO-0005Wi-W9
	for submit <at> debbugs.gnu.org; Wed, 11 Dec 2024 10:00:25 -0500
Received: from eggs.gnu.org ([209.51.188.92]:59126)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1tLOCM-0005TY-NN
 for 74627 <at> debbugs.gnu.org; Wed, 11 Dec 2024 10:00:23 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1tLOCH-0005cK-B8; Wed, 11 Dec 2024 10:00:17 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=QHyksHBRo5eRxmmw2zZh+PrcOL0GSmRrjOKGm/XHTOA=; b=jX2cvTang+B0N+DrQKWE
 Nyg6F0itZfZp67FAAFpXD4Q4waMGsglLUle1+TaNaU7xmxRtgYXmWTvSYH0nrcW8LwevWT1V8wY28
 zKLSnxEZa9loS/GlJn5WSoSg84nHmk//L0R3TxEuucvfzZsbkL/ypqKugIKL1ZzvofNvET+2+k/f0
 ED7utszYlRU1wAQQQnr06pNz0jq2vwvm22nOkl2vX1M3QDX80v+NzeEKIZ/QV2YdSUJ0gwmtWG1f7
 3XUi0a8cCCb4BAC9XsbodQMFGTp19YxTIYfejG0ECwZj3uWlW55YanGBf8/p5I57JQ+ypf9NAsTHY
 Xfb1bNPX/+pUeQ==;
Date: Wed, 11 Dec 2024 17:00:11 +0200
Message-Id: <864j3a464k.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CALG+76f9OTpFuHgTye+gUoGNkjOR4bi8Rt8xsss7d3HZs9kwNA@HIDDEN>
 (message from =?UTF-8?Q?Bj=C3=B6rn?= Lindqvist on Wed, 11 Dec 2024 09:18:33
 +0100)
References: <CALG+76fJ3dh2ZQhRia3Gm2vvXiaD+3QQtHbc0OWi7yF8i3AP=w@HIDDEN>
 <86a5daxydw.fsf@HIDDEN>
 <CALG+76f9OTpFuHgTye+gUoGNkjOR4bi8Rt8xsss7d3HZs9kwNA@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Björn Lindqvist <bjourne@HIDDEN>
> Date: Wed, 11 Dec 2024 09:18:33 +0100
> Cc: Stefan Monnier <monnier@HIDDEN>, 74627 <at> debbugs.gnu.org
> 
> Den tors 5 dec. 2024 kl 10:38 skrev Eli Zaretskii <eliz@HIDDEN>:
> 
> > > Warnings about potential security issues should be easy to understand,
> > > but the warnings produced by .dir-locals.el are not. When I open a
> > > file in the Emacs source code it shows:
> > >
> > >     The local variables list in /home/bjourne/p/emacs/
> > >     or .dir-locals.el contains values that may not be safe (*).
> > >
> > > Why does it say "or"?
> >
> > Because that function is called with a single flag argument which
> > could be set non-nil either due to unsafe file-local variables or due
> > to .dir-locals.el.
> 
> So there are multiple sources of unsafe variables, but the function
> responsible for formulating the error message doesn't know what the
> source is?

Yes, that's my reading of the code.

> Regardless of whether my guess is correct, the text should
> not refer to the local variables in "/home/bjourne/p/emacs/" because
> there can be no unsafe variables in directories (only files).

Well, we consider variables in .dir-locals.el as belonging to the
directory in which it lives.

> > > What does the asterisk (*) mean?
> >
> > It means the variables marked with the asterisk in the list of
> > below this text could be unsafe.
> 
> Aha. Emacs lists both safe and unsafe variables. Why does it list the
> safe ones? The warning would be much clearer if the safe variables
> were omitted since they don't matter. That would make it clear what
> variables "!" and "i" choices apply or mark as safe/ignored.

I can only guess: showing all of them lets you see the problematic one
in context.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#74627: .dir-locals.el warning messages are confusing
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 11 Dec 2024 15:32:02 +0000
Resent-Message-ID: <handler.74627.B74627.173393107628651 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 74627
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: =?UTF-8?Q?Bj=C3=B6rn?= Lindqvist <bjourne@HIDDEN>, 74627 <at> debbugs.gnu.org
Received: via spool by 74627-submit <at> debbugs.gnu.org id=B74627.173393107628651
          (code B ref 74627); Wed, 11 Dec 2024 15:32:02 +0000
Received: (at 74627) by debbugs.gnu.org; 11 Dec 2024 15:31:16 +0000
Received: from localhost ([127.0.0.1]:35738 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tLOgG-0007S3-9a
	for submit <at> debbugs.gnu.org; Wed, 11 Dec 2024 10:31:16 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11806)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1tLOgE-0007Rn-To
 for 74627 <at> debbugs.gnu.org; Wed, 11 Dec 2024 10:31:15 -0500
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 662288092E;
 Wed, 11 Dec 2024 10:31:04 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1733931063;
 bh=31NhHi7lPLGlGtAbYzgPHTGCHrZFUKgDyv2+xLT/PR0=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=I8fMeEWG75qeeN3uywQ/qj7w1PskmoK+t9WQ5AnfyCnZ3LZJY+qH/6cyBvbHcuRB7
 CkMP1vUcmi1OjIUDgGS2e6BYG1yJKpQLkuqN8WxrP6/6AkAhqGTXkjCU4WDYfn21cg
 vvbXmzsJFGLCaqB3G6D3UYrqYka8EpJQEQt3kuUuZdAxnPGhaXmm+KU9dv0HnEi8DG
 tOQ2LAOtn7kGosYKoYafOUSjkPVyir9gTl/V3XnerlXdwxU4lDFD4NsdwyssfMJgNk
 70GxGkVH9HwEOlGYGauJ4mpq+1HR3+nMZou2tUtG/lY1+my+VToNi5o4bz8Lo0b+/+
 NbZO0fzhjKJHw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id AD4DD80848;
 Wed, 11 Dec 2024 10:31:03 -0500 (EST)
Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9E6781202F4;
 Wed, 11 Dec 2024 10:31:03 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <864j3a464k.fsf@HIDDEN> (Eli Zaretskii's message of "Wed, 11 Dec
 2024 17:00:11 +0200")
Message-ID: <jwvttbaxmo4.fsf-monnier+emacs@HIDDEN>
References: <CALG+76fJ3dh2ZQhRia3Gm2vvXiaD+3QQtHbc0OWi7yF8i3AP=w@HIDDEN>
 <86a5daxydw.fsf@HIDDEN>
 <CALG+76f9OTpFuHgTye+gUoGNkjOR4bi8Rt8xsss7d3HZs9kwNA@HIDDEN>
 <864j3a464k.fsf@HIDDEN>
Date: Wed, 11 Dec 2024 10:31:03 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL 0.205 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>> Regardless of whether my guess is correct, the text should
>> not refer to the local variables in "/home/bjourne/p/emacs/" because
>> there can be no unsafe variables in directories (only files).
> Well, we consider variables in .dir-locals.el as belonging to the
> directory in which it lives.

I think it would be easier to understand for the reader if we can point
more precisely to the source (especially since now it can also come
from `.editorconfig`).


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#74627: .dir-locals.el warning messages are confusing
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 11 Dec 2024 16:56:02 +0000
Resent-Message-ID: <handler.74627.B74627.173393614119404 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 74627
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Monnier <monnier@HIDDEN>
Cc: bjourne@HIDDEN, 74627 <at> debbugs.gnu.org
Received: via spool by 74627-submit <at> debbugs.gnu.org id=B74627.173393614119404
          (code B ref 74627); Wed, 11 Dec 2024 16:56:02 +0000
Received: (at 74627) by debbugs.gnu.org; 11 Dec 2024 16:55:41 +0000
Received: from localhost ([127.0.0.1]:36067 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tLPzx-00052u-FZ
	for submit <at> debbugs.gnu.org; Wed, 11 Dec 2024 11:55:41 -0500
Received: from eggs.gnu.org ([209.51.188.92]:44990)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1tLPzv-00052L-Go
 for 74627 <at> debbugs.gnu.org; Wed, 11 Dec 2024 11:55:40 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1tLPzp-0005vL-GE; Wed, 11 Dec 2024 11:55:33 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=Dn/r+HS+xpHUKw/X0wZb0v/dnOUk0vuqkUScnKxDzGg=; b=LLmO3oSt2kEi1DEYnpVx
 D3QZ7fybfZqXUx2RHUg3D4tf+Qp5ixTe64vS1jid4AZ6zuWWo+VtAE7cIpkdq0cRwaZmKEoNaeXBP
 alJ4d0233uZ9caEXbNw7k5FftusVVBUIYQO1I0ypJDcGUbJfVg6Vm1+7hobjd/4TL6fl+pCc9Ncye
 cai9HmQL5nUP4BSzHBmt21FlU8ttMdDGnuqgRFopGTx3EAFFtTeforQVwEIxKRMmo18sE9UWQhgVG
 QSLe6rEM0p6xRMR5XxxA37SK0DGML7O6pp4MtfEv2e6bXHvZBG91OmaxJ22G7rBVOKvT3yvAqJM3e
 g4DKdfwaWTEbrg==;
Date: Wed, 11 Dec 2024 18:55:30 +0200
Message-Id: <86plly2m7x.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <jwvttbaxmo4.fsf-monnier+emacs@HIDDEN> (message from Stefan
 Monnier on Wed, 11 Dec 2024 10:31:03 -0500)
References: <CALG+76fJ3dh2ZQhRia3Gm2vvXiaD+3QQtHbc0OWi7yF8i3AP=w@HIDDEN>
 <86a5daxydw.fsf@HIDDEN>
 <CALG+76f9OTpFuHgTye+gUoGNkjOR4bi8Rt8xsss7d3HZs9kwNA@HIDDEN>
 <864j3a464k.fsf@HIDDEN> <jwvttbaxmo4.fsf-monnier+emacs@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Monnier <monnier@HIDDEN>
> Cc: Bj�rn Lindqvist <bjourne@HIDDEN>,
>   74627 <at> debbugs.gnu.org
> Date: Wed, 11 Dec 2024 10:31:03 -0500
> 
> >> Regardless of whether my guess is correct, the text should
> >> not refer to the local variables in "/home/bjourne/p/emacs/" because
> >> there can be no unsafe variables in directories (only files).
> > Well, we consider variables in .dir-locals.el as belonging to the
> > directory in which it lives.
> 
> I think it would be easier to understand for the reader if we can point
> more precisely to the source (especially since now it can also come
> from `.editorconfig`).

Sure, but that's not what I meant to explain.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 2 Jan 2025 01:56:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 01 20:56:11 2025
Received: from localhost ([127.0.0.1]:41327 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tTARW-00026E-LF
	for submit <at> debbugs.gnu.org; Wed, 01 Jan 2025 20:56:10 -0500
Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:59543)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tTARU-00025O-Vv
 for control <at> debbugs.gnu.org; Wed, 01 Jan 2025 20:56:09 -0500
Received: by mail-ed1-x52f.google.com with SMTP id
 4fb4d7f45d1cf-5d3bbb0f09dso18833207a12.2
 for <control <at> debbugs.gnu.org>; Wed, 01 Jan 2025 17:56:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1735782963; x=1736387763; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=NJ7xLwEtqqA4klhAs/N3r4NapIeoHa3TV3EL7GYochk=;
 b=QluaJXuFbDO1obav8LDVlZ0U22x12DbuF8iwi4kZTMp4p2EqIqy5vx0hMg8aMj1iTI
 eQ2VZK/sco9SCxmrJaxK2qMAwc4+xgYMBoZUOLw+g+wNXCQ6Ivrd96SZ2s2qjRkdFhor
 /vVD85YCxlogqLlkbEfNvEhLrZqkCgM2CmDi+fU8TzLH7aj3qYgHylkqmPQwxlGHaNW5
 FOUIMa7Whwc1StOoLWaVL4AcrBeAa/g66+LyW12tTEyGOe52Q/qAETpOYadbzIm422uH
 PKEktmql0O9buUUEAyspWSZGd9kGJOg8oWfCcNXI/B4hkOq2ycRhDPxH17Io0bNocEfr
 O+pQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1735782963; x=1736387763;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=NJ7xLwEtqqA4klhAs/N3r4NapIeoHa3TV3EL7GYochk=;
 b=GjWSYr9kpB/F0gHBUdtsxOO2JBAjXE5eI0FnHzJzdyE4uG8FjyPNEtEb2HJ/uFPGK3
 jP5/wFyWS/syBgwq9fI7GmrACSQC/7pbAtwuEakHmq7wiiHsFOEjBGIMwDG4h0zKklpO
 r187Koh59e4IAIJTVxFJObBl9HbOZjXm5X8aTcRv+tnI0pws4f2W8nF/yBFRNJKmXW5w
 FqEd+CojIBftNYJYfnifAZqPTlnmFWeq/S2ul2RgJBbiHZ6yy8/ojoPjFdiikfgPOzNe
 KVCFFeN2ky2eNN+pXwISyiKxWTmICxoJWZZI4uHBSItAZY4j+pnsUptLUjnSNMAYFPCB
 xAXQ==
X-Gm-Message-State: AOJu0YxP2CXNhxnPvHlrdB2NWuXnE9Zka21pw3KWfTk/QDjZ9Dat9VKw
 lkY0mRffzNATPUf/1qgkSubt9SFIqlSKcsNaC/UGF1N9Mn5KOO3cMhAq9hR0GKYoxGaKjrpVjNv
 JV+ULen+rTZKXpXS9Ka6PasJwqbWDV2Uc
X-Gm-Gg: ASbGncv85HU3MptFZw3ELkhJfel/UEDmqTgh1OjkAXaRfm0IVTwbsSP6vR0KUtzk1Zp
 UCF0UjMqBrO2pPBWdb6hDxNZ1LoYb/OP8UkqsXDDZ
X-Google-Smtp-Source: AGHT+IGwlicW9ZayaT1B6e1X3H0oMj0w0bdy7rrMOZDwW1/9rFk8upWkw2yRF6RbH2aCeRV4t8EuIwbZnsRpqyxEq7E=
X-Received: by 2002:a05:6402:27d4:b0:5cf:a1c1:5289 with SMTP id
 4fb4d7f45d1cf-5d81de48c0bmr31786385a12.21.1735782962834; Wed, 01 Jan 2025
 17:56:02 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Wed, 1 Jan 2025 19:56:02 -0600
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Wed, 1 Jan 2025 19:56:02 -0600
Message-ID: <CADwFkmmBTv9rbKyGAYQGuZUTPGkFB=DhR+H=JHBHR84rVjjRyg@HIDDEN>
Subject: control message for bug #74627
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

severity 74627 wishlist
quit

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.