Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 74627) by debbugs.gnu.org; 11 Dec 2024 16:55:41 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 11 11:55:41 2024 Received: from localhost ([127.0.0.1]:36067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tLPzx-00052u-FZ for submit <at> debbugs.gnu.org; Wed, 11 Dec 2024 11:55:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tLPzv-00052L-Go for 74627 <at> debbugs.gnu.org; Wed, 11 Dec 2024 11:55:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tLPzp-0005vL-GE; Wed, 11 Dec 2024 11:55:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Dn/r+HS+xpHUKw/X0wZb0v/dnOUk0vuqkUScnKxDzGg=; b=LLmO3oSt2kEi1DEYnpVx D3QZ7fybfZqXUx2RHUg3D4tf+Qp5ixTe64vS1jid4AZ6zuWWo+VtAE7cIpkdq0cRwaZmKEoNaeXBP alJ4d0233uZ9caEXbNw7k5FftusVVBUIYQO1I0ypJDcGUbJfVg6Vm1+7hobjd/4TL6fl+pCc9Ncye cai9HmQL5nUP4BSzHBmt21FlU8ttMdDGnuqgRFopGTx3EAFFtTeforQVwEIxKRMmo18sE9UWQhgVG QSLe6rEM0p6xRMR5XxxA37SK0DGML7O6pp4MtfEv2e6bXHvZBG91OmaxJ22G7rBVOKvT3yvAqJM3e g4DKdfwaWTEbrg==; Date: Wed, 11 Dec 2024 18:55:30 +0200 Message-Id: <86plly2m7x.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> In-Reply-To: <jwvttbaxmo4.fsf-monnier+emacs@HIDDEN> (message from Stefan Monnier on Wed, 11 Dec 2024 10:31:03 -0500) Subject: Re: bug#74627: .dir-locals.el warning messages are confusing References: <CALG+76fJ3dh2ZQhRia3Gm2vvXiaD+3QQtHbc0OWi7yF8i3AP=w@HIDDEN> <86a5daxydw.fsf@HIDDEN> <CALG+76f9OTpFuHgTye+gUoGNkjOR4bi8Rt8xsss7d3HZs9kwNA@HIDDEN> <864j3a464k.fsf@HIDDEN> <jwvttbaxmo4.fsf-monnier+emacs@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74627 Cc: bjourne@HIDDEN, 74627 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Stefan Monnier <monnier@HIDDEN> > Cc: Björn Lindqvist <bjourne@HIDDEN>, > 74627 <at> debbugs.gnu.org > Date: Wed, 11 Dec 2024 10:31:03 -0500 > > >> Regardless of whether my guess is correct, the text should > >> not refer to the local variables in "/home/bjourne/p/emacs/" because > >> there can be no unsafe variables in directories (only files). > > Well, we consider variables in .dir-locals.el as belonging to the > > directory in which it lives. > > I think it would be easier to understand for the reader if we can point > more precisely to the source (especially since now it can also come > from `.editorconfig`). Sure, but that's not what I meant to explain.
bug-gnu-emacs@HIDDEN:bug#74627; Package emacs.
Full text available.
Received: (at 74627) by debbugs.gnu.org; 11 Dec 2024 15:31:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 11 10:31:16 2024
Received: from localhost ([127.0.0.1]:35738 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tLOgG-0007S3-9a
for submit <at> debbugs.gnu.org; Wed, 11 Dec 2024 10:31:16 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11806)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1tLOgE-0007Rn-To
for 74627 <at> debbugs.gnu.org; Wed, 11 Dec 2024 10:31:15 -0500
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 662288092E;
Wed, 11 Dec 2024 10:31:04 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1733931063;
bh=31NhHi7lPLGlGtAbYzgPHTGCHrZFUKgDyv2+xLT/PR0=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=I8fMeEWG75qeeN3uywQ/qj7w1PskmoK+t9WQ5AnfyCnZ3LZJY+qH/6cyBvbHcuRB7
CkMP1vUcmi1OjIUDgGS2e6BYG1yJKpQLkuqN8WxrP6/6AkAhqGTXkjCU4WDYfn21cg
vvbXmzsJFGLCaqB3G6D3UYrqYka8EpJQEQt3kuUuZdAxnPGhaXmm+KU9dv0HnEi8DG
tOQ2LAOtn7kGosYKoYafOUSjkPVyir9gTl/V3XnerlXdwxU4lDFD4NsdwyssfMJgNk
70GxGkVH9HwEOlGYGauJ4mpq+1HR3+nMZou2tUtG/lY1+my+VToNi5o4bz8Lo0b+/+
NbZO0fzhjKJHw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id AD4DD80848;
Wed, 11 Dec 2024 10:31:03 -0500 (EST)
Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9E6781202F4;
Wed, 11 Dec 2024 10:31:03 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#74627: .dir-locals.el warning messages are confusing
In-Reply-To: <864j3a464k.fsf@HIDDEN> (Eli Zaretskii's message of "Wed, 11 Dec
2024 17:00:11 +0200")
Message-ID: <jwvttbaxmo4.fsf-monnier+emacs@HIDDEN>
References: <CALG+76fJ3dh2ZQhRia3Gm2vvXiaD+3QQtHbc0OWi7yF8i3AP=w@HIDDEN>
<86a5daxydw.fsf@HIDDEN>
<CALG+76f9OTpFuHgTye+gUoGNkjOR4bi8Rt8xsss7d3HZs9kwNA@HIDDEN>
<864j3a464k.fsf@HIDDEN>
Date: Wed, 11 Dec 2024 10:31:03 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL 0.205 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 74627
Cc: =?windows-1252?Q?Bj=F6rn?= Lindqvist <bjourne@HIDDEN>,
74627 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
>> Regardless of whether my guess is correct, the text should
>> not refer to the local variables in "/home/bjourne/p/emacs/" because
>> there can be no unsafe variables in directories (only files).
> Well, we consider variables in .dir-locals.el as belonging to the
> directory in which it lives.
I think it would be easier to understand for the reader if we can point
more precisely to the source (especially since now it can also come
from `.editorconfig`).
Stefan
bug-gnu-emacs@HIDDEN:bug#74627; Package emacs.
Full text available.Received: (at 74627) by debbugs.gnu.org; 11 Dec 2024 15:00:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 11 10:00:25 2024 Received: from localhost ([127.0.0.1]:35669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tLOCO-0005Wi-W9 for submit <at> debbugs.gnu.org; Wed, 11 Dec 2024 10:00:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tLOCM-0005TY-NN for 74627 <at> debbugs.gnu.org; Wed, 11 Dec 2024 10:00:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tLOCH-0005cK-B8; Wed, 11 Dec 2024 10:00:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=QHyksHBRo5eRxmmw2zZh+PrcOL0GSmRrjOKGm/XHTOA=; b=jX2cvTang+B0N+DrQKWE Nyg6F0itZfZp67FAAFpXD4Q4waMGsglLUle1+TaNaU7xmxRtgYXmWTvSYH0nrcW8LwevWT1V8wY28 zKLSnxEZa9loS/GlJn5WSoSg84nHmk//L0R3TxEuucvfzZsbkL/ypqKugIKL1ZzvofNvET+2+k/f0 ED7utszYlRU1wAQQQnr06pNz0jq2vwvm22nOkl2vX1M3QDX80v+NzeEKIZ/QV2YdSUJ0gwmtWG1f7 3XUi0a8cCCb4BAC9XsbodQMFGTp19YxTIYfejG0ECwZj3uWlW55YanGBf8/p5I57JQ+ypf9NAsTHY Xfb1bNPX/+pUeQ==; Date: Wed, 11 Dec 2024 17:00:11 +0200 Message-Id: <864j3a464k.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: =?utf-8?Q?Bj=C3=B6rn?= Lindqvist <bjourne@HIDDEN> In-Reply-To: <CALG+76f9OTpFuHgTye+gUoGNkjOR4bi8Rt8xsss7d3HZs9kwNA@HIDDEN> (message from =?utf-8?Q?Bj=C3=B6rn?= Lindqvist on Wed, 11 Dec 2024 09:18:33 +0100) Subject: Re: bug#74627: .dir-locals.el warning messages are confusing References: <CALG+76fJ3dh2ZQhRia3Gm2vvXiaD+3QQtHbc0OWi7yF8i3AP=w@HIDDEN> <86a5daxydw.fsf@HIDDEN> <CALG+76f9OTpFuHgTye+gUoGNkjOR4bi8Rt8xsss7d3HZs9kwNA@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74627 Cc: monnier@HIDDEN, 74627 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Björn Lindqvist <bjourne@HIDDEN> > Date: Wed, 11 Dec 2024 09:18:33 +0100 > Cc: Stefan Monnier <monnier@HIDDEN>, 74627 <at> debbugs.gnu.org > > Den tors 5 dec. 2024 kl 10:38 skrev Eli Zaretskii <eliz@HIDDEN>: > > > > Warnings about potential security issues should be easy to understand, > > > but the warnings produced by .dir-locals.el are not. When I open a > > > file in the Emacs source code it shows: > > > > > > The local variables list in /home/bjourne/p/emacs/ > > > or .dir-locals.el contains values that may not be safe (*). > > > > > > Why does it say "or"? > > > > Because that function is called with a single flag argument which > > could be set non-nil either due to unsafe file-local variables or due > > to .dir-locals.el. > > So there are multiple sources of unsafe variables, but the function > responsible for formulating the error message doesn't know what the > source is? Yes, that's my reading of the code. > Regardless of whether my guess is correct, the text should > not refer to the local variables in "/home/bjourne/p/emacs/" because > there can be no unsafe variables in directories (only files). Well, we consider variables in .dir-locals.el as belonging to the directory in which it lives. > > > What does the asterisk (*) mean? > > > > It means the variables marked with the asterisk in the list of > > below this text could be unsafe. > > Aha. Emacs lists both safe and unsafe variables. Why does it list the > safe ones? The warning would be much clearer if the safe variables > were omitted since they don't matter. That would make it clear what > variables "!" and "i" choices apply or mark as safe/ignored. I can only guess: showing all of them lets you see the problematic one in context.
bug-gnu-emacs@HIDDEN:bug#74627; Package emacs.
Full text available.Received: (at 74627) by debbugs.gnu.org; 11 Dec 2024 11:17:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 11 06:17:38 2024 Received: from localhost ([127.0.0.1]:33210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tLKin-0007xm-PK for submit <at> debbugs.gnu.org; Wed, 11 Dec 2024 06:17:38 -0500 Received: from mail-ed1-f52.google.com ([209.85.208.52]:57506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tLKim-0007xV-30 for 74627 <at> debbugs.gnu.org; Wed, 11 Dec 2024 06:17:36 -0500 Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5cfa1ec3b94so8941898a12.2 for <74627 <at> debbugs.gnu.org>; Wed, 11 Dec 2024 03:17:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733915795; x=1734520595; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=xDwUhP0f0FTIkEkMVSox0wEfb9Kn18YOhL2jzMySqxk=; b=TKiJE4N33Hz9Q2F1BXVEoosQfZrfj+M3QxkKtSCUsEzjhdZouYG0tQdHYgkwC4PqGV 6O/bdxV+4uFkLYFjf3p2xMHHYqgGgTPc9/Cpp3w9fri6viqobviiSe0O26OOMKVnVjcL QGFKNi32EiOXu6tOQpF7ztDDLHFiGqx7sqfWs0yoa1XuvKWxriNQCtozKM5CyUYFZXGD Zztjeq7P/iETQMw2k2rJYREpe3Ju9pPaZAsvjLe3f/VDkiUV+15DSqw5wh6n4GUn/dtY NZ7vOXzuo5iXSkI8gIZQqhTki57P45TClNB4WQ70f1GXgb0MXSuLAzkd/oO8y1lygole kQWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733915795; x=1734520595; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xDwUhP0f0FTIkEkMVSox0wEfb9Kn18YOhL2jzMySqxk=; b=liaB714oJNzebblLC20BAXF9jkVNYvzCsSkjQzBL8GVKOwng1yR8bF+oUUmYucAHtn ObDofktuzmsEE36NwpsqMW+qx+NOcl+Hmo7Og5ZiK3oLHVx0iYeUwgslstmGP5p8TSPy 3RXkQBef92AN0YidR87TbtjxDreieemodSwDuuUEUZLULElwZiQi8TrKQRzEMEHzguSF t5lYudtD+0U8suYV++oP1bCa4q9faI/zhmwduS/uB05Tc6dHYToN2N6BCEBRqf+TfjkJ /5IqqXB9w4lhYAurC5G83RCYgSuai1ppMuoOFCFLL/flYCurwVFH+RYlU63n54YlbC3E 0Y1Q== X-Forwarded-Encrypted: i=1; AJvYcCV6lzHiXFhv+OnFRqukQHI1976H1v8FQfE5EZgcrQsHiRMazRWOttTeewGQj9mktC2OOFrfwg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyJwn7kaggM7xs3AMsnQif+p/ytLyo053n/M7V7Ooy6bvKpEEME VVF+ZHDCiMPfpq6jR4bFf19p7Mfe1wUdNyJw9tk2pH3S1BVXLmTrZTYcK/ETN26nYGaxh/SmGWY nLQW9LO6U1DsUROMYSAXLoM7N5AA= X-Gm-Gg: ASbGncv06Xb7EFVUJsztf9VKDIVfv3nVRAH0XHp+xkrfXKsUeba+5pmElysFYEJ89Yb g1EoITFss75sNUxC+HklvPI2rlHrCe3Cu2rARGw== X-Google-Smtp-Source: AGHT+IGfsMh7Hd9IUF4nfjOdrFx2hYXZDBaQfPS3p0h+9PuGz3HtwHqfdXa0+Pbqtu2ChCakPVuWzcVR+T9suCoTmFA= X-Received: by 2002:a05:6402:2688:b0:5d3:d8b9:674d with SMTP id 4fb4d7f45d1cf-5d432f277c0mr2409177a12.0.1733915795032; Wed, 11 Dec 2024 03:16:35 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 11 Dec 2024 03:16:34 -0800 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <CALG+76f9OTpFuHgTye+gUoGNkjOR4bi8Rt8xsss7d3HZs9kwNA@HIDDEN> References: <CALG+76fJ3dh2ZQhRia3Gm2vvXiaD+3QQtHbc0OWi7yF8i3AP=w@HIDDEN> <86a5daxydw.fsf@HIDDEN> <CALG+76f9OTpFuHgTye+gUoGNkjOR4bi8Rt8xsss7d3HZs9kwNA@HIDDEN> MIME-Version: 1.0 Date: Wed, 11 Dec 2024 03:16:34 -0800 Message-ID: <CADwFkm=MuazQpf1tHKsWCZ0oB70hHarRZODuL61uSVnMt_S0eQ@HIDDEN> Subject: Re: bug#74627: .dir-locals.el warning messages are confusing To: =?UTF-8?Q?Bj=C3=B6rn_Lindqvist?= <bjourne@HIDDEN>, Eli Zaretskii <eliz@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74627 Cc: Stefan Monnier <monnier@HIDDEN>, 74627 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Bj=C3=B6rn Lindqvist <bjourne@HIDDEN> writes: > Aha. Emacs lists both safe and unsafe variables. Why does it list the > safe ones? The warning would be much clearer if the safe variables > were omitted since they don't matter. That would make it clear what > variables "!" and "i" choices apply or mark as safe/ignored. You have to see all of them to make an informed decision, I think. Otherwise, an unsafe variable might be referring to a safe one, which is the one containing the malicious bits.
bug-gnu-emacs@HIDDEN:bug#74627; Package emacs.
Full text available.Received: (at 74627) by debbugs.gnu.org; 11 Dec 2024 08:19:53 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 11 03:19:53 2024 Received: from localhost ([127.0.0.1]:32806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tLHwm-0004wz-Pw for submit <at> debbugs.gnu.org; Wed, 11 Dec 2024 03:19:53 -0500 Received: from mail-vs1-f42.google.com ([209.85.217.42]:42151) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <bjourne@HIDDEN>) id 1tLHwk-0004wi-N2 for 74627 <at> debbugs.gnu.org; Wed, 11 Dec 2024 03:19:51 -0500 Received: by mail-vs1-f42.google.com with SMTP id ada2fe7eead31-4aff1c57377so278232137.0 for <74627 <at> debbugs.gnu.org>; Wed, 11 Dec 2024 00:19:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733905125; x=1734509925; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fd4WZRAMppfxWi4u0jjbFDJ62z7daKXqbaqBARGOq5c=; b=evnFTMqES5p6Y3b5b+33VrKIJdeRuVNzT70CLQ+ejYH+Fr+1uN3lXE6b+bAcAIG1WV yzEW3m+wV/BhDOpqC2zp/uxFhLR2vqYJ7ByLRSj1rTqCZ1qK0hDGt9gSlZUgGNJSs1Et 85iSpk2qZF1F7VdX2z6HVOILT4OvMQwsuDLSL/LbgmdBqwHpCoes6c/EDVex4FmoeYcA 0X4DlYD6t4mjLg8QpXkELf0CLi3VgMpcN+MJfs8WScKcVeBVySzysM0YE6pAIFM14H2n xrrARfJXZ9jGKRgAUpO1JEElrrfAq4IGJvhUBpSNlddToJlqLJszmzGWMsfSDym191nP MM4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733905125; x=1734509925; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fd4WZRAMppfxWi4u0jjbFDJ62z7daKXqbaqBARGOq5c=; b=lT0kq6eEa7wVoIcjA26CN8tYJDdXnUhlCYOVIvqE2rLW5caXV+9rE8p9WVcfWAa7sn rvRxogLi3YPYvsK7z1Hn8MlAZTzaTVzuv6D0srjvZBYck7OlY6wPuGZwLJynmVSWhFJT Frt1GzcGv+IE9Qc3Ep/293U6RWqN5cbaYt6t4ZIhzm8fueS1jGug9+YKs6agh+Ki3glz Z1EC7dLHCc+rPMnpkG4E8t2qMTry9y+K1IzBFDx2rhayzWho1n9OTVHzBdRhC5cK0tul /cUUtyQwU5dCBstWVxn6z/b/Rg+fxUeyEQNinLgpQDVznmwyh3ZR2QUm8N0WccXddLTa nAqQ== X-Forwarded-Encrypted: i=1; AJvYcCXraehSJHuq/AHE5v29C6ZDeDSGZwFhQrVHpkxS9Y0ByHp1OknKJfoLqXSM36DnT3TyQ2xHYw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzJd31xH3/mzoSsk/oSTMqp9Mb8XHp3GTQff7AiYkLuqxRQ/d3R z0eEbrq6QsfEkN4osUxEcQwDm1ehEzgfFwwOOCfy/vVlyYPdWFUs+uNs04NBqm3v62iPn7AVB5B t0UfMAG6qhaSyVflq2Thcyrs8Ck4= X-Gm-Gg: ASbGncvMeBHc/I4pwsiurYhsjildh9TaL0tyEQXY/4lTI/4EeoGEtSdUKHAnNrFjDly sluspVXBkDEKXtMeP3pVdhMTAEpl8A7IYx+lnFjmIpkBxYpU4fZfXWUHDDRBiCmvD X-Google-Smtp-Source: AGHT+IFBQtkhVPjd99cgVrMmvAfMnwaYPpyHn0/Zdt6BDG6Z14fMSL4wHNt3alXTX/9206Sj/KyOuwt8lB9HOK9+KqM= X-Received: by 2002:a67:be0f:0:b0:4af:dcf3:b384 with SMTP id ada2fe7eead31-4b1d29c4cffmr1014433137.11.1733905125167; Wed, 11 Dec 2024 00:18:45 -0800 (PST) MIME-Version: 1.0 References: <CALG+76fJ3dh2ZQhRia3Gm2vvXiaD+3QQtHbc0OWi7yF8i3AP=w@HIDDEN> <86a5daxydw.fsf@HIDDEN> In-Reply-To: <86a5daxydw.fsf@HIDDEN> From: =?UTF-8?Q?Bj=C3=B6rn_Lindqvist?= <bjourne@HIDDEN> Date: Wed, 11 Dec 2024 09:18:33 +0100 Message-ID: <CALG+76f9OTpFuHgTye+gUoGNkjOR4bi8Rt8xsss7d3HZs9kwNA@HIDDEN> Subject: Re: bug#74627: .dir-locals.el warning messages are confusing To: Eli Zaretskii <eliz@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74627 Cc: Stefan Monnier <monnier@HIDDEN>, 74627 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hello Eli, Den tors 5 dec. 2024 kl 10:38 skrev Eli Zaretskii <eliz@HIDDEN>: > > Warnings about potential security issues should be easy to understand, > > but the warnings produced by .dir-locals.el are not. When I open a > > file in the Emacs source code it shows: > > > > The local variables list in /home/bjourne/p/emacs/ > > or .dir-locals.el contains values that may not be safe (*). > > > > Why does it say "or"? > > Because that function is called with a single flag argument which > could be set non-nil either due to unsafe file-local variables or due > to .dir-locals.el. So there are multiple sources of unsafe variables, but the function responsible for formulating the error message doesn't know what the source is? Regardless of whether my guess is correct, the text should not refer to the local variables in "/home/bjourne/p/emacs/" because there can be no unsafe variables in directories (only files). > > What does the asterisk (*) mean? > > It means the variables marked with the asterisk in the list of > below this text could be unsafe. Aha. Emacs lists both safe and unsafe variables. Why does it list the safe ones? The warning would be much clearer if the safe variables were omitted since they don't matter. That would make it clear what variables "!" and "i" choices apply or mark as safe/ignored. -- mvh/best regards Bj=C3=B6rn Lindqvist
bug-gnu-emacs@HIDDEN:bug#74627; Package emacs.
Full text available.Received: (at 74627) by debbugs.gnu.org; 5 Dec 2024 09:39:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Dec 05 04:39:03 2024 Received: from localhost ([127.0.0.1]:38303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tJ8K7-0002Yh-Bu for submit <at> debbugs.gnu.org; Thu, 05 Dec 2024 04:39:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tJ8K5-0002YA-J1 for 74627 <at> debbugs.gnu.org; Thu, 05 Dec 2024 04:39:02 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tJ8Jy-00032o-Hu; Thu, 05 Dec 2024 04:38:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=nOnhpPv0iT606Fro7I4aw6QvJDEIxUAQ7/h07YaQqUw=; b=HCOq9bghJYIh9qXy4vqf bUBhtcB8z91AP7U2k1P4DaJ2dbS9v02G51C2AbZ0ThFqYH0B4y7d7EhVwosvHzkP199S66P9jv7Ea z6Bql5SJJDBU3yh8H0NzxCboE2tyuqNo4BzGyeEEXx2PD1JwbCNJG9hI5s0ZbmZyKX89Bsw3dYed6 1nK8Q7jE75nV4k8o2ooPqT5zks/sx8iXGsU3kbRoZzEA+4Exq4Cqynr7GgnYUZgVQ8MHGii8W6283 yLbMu8FeHazDEM0yFCIuRmKWz+V+RjDWlZRUydB+YcQifQcSo2gfnQ+kBJ5skC6L/YAfjXRDtcIC8 HJPTCQBYK7bWTg==; Date: Thu, 05 Dec 2024 11:38:51 +0200 Message-Id: <86a5daxydw.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: =?utf-8?Q?Bj=C3=B6rn?= Lindqvist <bjourne@HIDDEN>, Stefan Monnier <monnier@HIDDEN> In-Reply-To: <CALG+76fJ3dh2ZQhRia3Gm2vvXiaD+3QQtHbc0OWi7yF8i3AP=w@HIDDEN> (message from =?utf-8?Q?Bj=C3=B6rn?= Lindqvist on Sat, 30 Nov 2024 18:20:35 +0100) Subject: Re: bug#74627: .dir-locals.el warning messages are confusing References: <CALG+76fJ3dh2ZQhRia3Gm2vvXiaD+3QQtHbc0OWi7yF8i3AP=w@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74627 Cc: 74627 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Björn Lindqvist <bjourne@HIDDEN> > Date: Sat, 30 Nov 2024 18:20:35 +0100 > > Warnings about potential security issues should be easy to understand, > but the warnings produced by .dir-locals.el are not. When I open a > file in the Emacs source code it shows: > > The local variables list in /home/bjourne/p/emacs/ > or .dir-locals.el contains values that may not be safe (*). > > Why does it say "or"? Because that function is called with a single flag argument which could be set non-nil either due to unsafe file-local variables or due to .dir-locals.el. > What does the asterisk (*) mean? It means the variables marked with the asterisk in the list of below this text could be unsafe. > Could the descriptions for "!" and "i" be clearer so it is more > obvious what is applied and what is ignored? Please tell what is unclear there. The current text is ! -- to apply the local variables list, and permanently mark these values (*) as safe (in the future, they will be set automatically.) i -- to ignore the local variables list, and permanently mark these values (*) as ignored"
bug-gnu-emacs@HIDDEN:bug#74627; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 30 Nov 2024 17:20:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 30 12:20:55 2024
Received: from localhost ([127.0.0.1]:48879 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tHR9L-0005uo-Af
for submit <at> debbugs.gnu.org; Sat, 30 Nov 2024 12:20:55 -0500
Received: from lists.gnu.org ([209.51.188.17]:40090)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <bjourne@HIDDEN>) id 1tHR9K-0005uh-8J
for submit <at> debbugs.gnu.org; Sat, 30 Nov 2024 12:20:54 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <bjourne@HIDDEN>) id 1tHR9I-0003Cu-QO
for bug-gnu-emacs@HIDDEN; Sat, 30 Nov 2024 12:20:53 -0500
Received: from mail-qk1-x72d.google.com ([2607:f8b0:4864:20::72d])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <bjourne@HIDDEN>) id 1tHR9G-00069s-6Q
for bug-gnu-emacs@HIDDEN; Sat, 30 Nov 2024 12:20:51 -0500
Received: by mail-qk1-x72d.google.com with SMTP id
af79cd13be357-7b65d1c707aso216594985a.0
for <bug-gnu-emacs@HIDDEN>; Sat, 30 Nov 2024 09:20:48 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1732987247; x=1733592047; darn=gnu.org;
h=content-transfer-encoding:to:subject:message-id:date:from
:mime-version:from:to:cc:subject:date:message-id:reply-to;
bh=gFzHUguu/ruzXTfdG1C4DYIHcxjj9Ls1mUIVJxtXt/M=;
b=NvR0U+hsYSTr7Y47okkWqxQNRUYDYUq4neadYWa1A90TolOvOiA33zAK0oYHQK4gAs
+sx9flYj5tWyvV2tjBvP0xup0g8bkZlNTCX9L/nZjBh6X/Fd+Ft6WYxVlrK/UBP6Fgkv
HF93jLKugFCv+JMqeQGfImrJbrc3gjOiDr5PeDio7WMtYhywnySMlstV1moSWFIP49qh
F++jgzC581YRivsBRO4/wcU9r4O47w2XvNWR8PsPjD2bTttdP1yQ4vdoi/4vfxa0I8Ou
vomTx2B9ImNt9A6X+NOfUjOBUgTjlCeKS5Gqv3FCcMyUZyhGM9Enxkl0HEKcPpE25csw
NYCg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1732987247; x=1733592047;
h=content-transfer-encoding:to:subject:message-id:date:from
:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=gFzHUguu/ruzXTfdG1C4DYIHcxjj9Ls1mUIVJxtXt/M=;
b=aFlPsEol9nRfrVnxrW15Uim66ShXZKcFBOCWCfOYjOdGQH4hTVWCMOrYtz1vi34SRb
+MyAAOxHahSlBjsUtN95SXmg7hv8Jij3mNK2rDw9fGt29tqxbHsL8SzkssajR4bvA/t3
Czs+0nsQW7aXRfcyKtayQOlGnGdnht6k9J5oH0zETezAlbTHn+Eu2yKXIgUEYPOCmsmH
x+7hMH7Q5Bipf0jzj9cUhjAQKX34J6TBZvU4qy6PNBFJqRYdHR0kQleCkhx0DxItt4Pc
yYJSkBGsOkcCZ5AlS6iBEwH0ToXmdpSTPx5uaU2Zle8vrIMY2JhEy9Ws0Y1REPFDlXyq
ClvQ==
X-Gm-Message-State: AOJu0YwhAldYWtJ6mJlOmOtxWUaADygl41SkWVz5j9rGJWfd/XK3pT4S
Pt/u8dicESP/aQfUljqEZNnCFoDNPIOT3tm62ck783TIKvuxI0gwS4BNA4js00Vk2vA+GdUgeHS
ILG9gXa9JjtHeKRAHWaaU+0eIJ/iE2ZsB
X-Gm-Gg: ASbGncv1g2hyylpWk3PL3dwzpd71YuPVq0d1IZOXgBS6YSv+0bD6n9juf9UlNaYFzMR
hVfMeU4PjpA1kEK5kCii7GUokUxxYDThbqtS2jji7jxJc1jVDc7ppPK0oHb4=
X-Google-Smtp-Source: AGHT+IHmBCDU6+wXDVv9Vn85oIfksIm9DLnmFoxaLP4kYZ2jZOAuQl8c+cqpcOLkTWusbk8191BJ8Hb1irUSEjpBY+w=
X-Received: by 2002:a05:620a:2812:b0:7af:c818:bca with SMTP id
af79cd13be357-7b67c44181dmr2178535285a.46.1732987246994; Sat, 30 Nov 2024
09:20:46 -0800 (PST)
MIME-Version: 1.0
From: =?UTF-8?Q?Bj=C3=B6rn_Lindqvist?= <bjourne@HIDDEN>
Date: Sat, 30 Nov 2024 18:20:35 +0100
Message-ID: <CALG+76fJ3dh2ZQhRia3Gm2vvXiaD+3QQtHbc0OWi7yF8i3AP=w@HIDDEN>
Subject: .dir-locals.el warning messages are confusing
To: bug-gnu-emacs@HIDDEN
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=2607:f8b0:4864:20::72d;
envelope-from=bjourne@HIDDEN; helo=mail-qk1-x72d.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)
Warnings about potential security issues should be easy to understand,
but the warnings produced by .dir-locals.el are not. When I open a
file in the Emacs source code it shows:
The local variables list in /home/bjourne/p/emacs/
or .dir-locals.el contains values that may not be safe (*).
Why does it say "or"? What does the asterisk (*) mean? Could the
descriptions for "!" and "i" be clearer so it is more obvious what is
applied and what is ignored?
--=20
mvh/best regards Bj=C3=B6rn Lindqvist
Björn Lindqvist <bjourne@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#74627; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.