X-Loop: help-debbugs@HIDDEN
Subject: bug#75141: [PATCH] Add button navigation to treesit-explorer
Resent-From: Gabriel Santos <gabrielsantosdesouza@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 27 Dec 2024 13:55:02 +0000
Resent-Message-ID: <handler.75141.B.17353076577756 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 75141
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: 75141 <at> debbugs.gnu.org
X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.17353076577756
(code B ref -1); Fri, 27 Dec 2024 13:55:02 +0000
Received: (at submit) by debbugs.gnu.org; 27 Dec 2024 13:54:17 +0000
Received: from localhost ([127.0.0.1]:45193 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tRAnB-000212-Ek
for submit <at> debbugs.gnu.org; Fri, 27 Dec 2024 08:54:17 -0500
Received: from lists.gnu.org ([209.51.188.17]:34736)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <gabrielsantosdesouza@HIDDEN>)
id 1tRAnA-00020u-6S
for submit <at> debbugs.gnu.org; Fri, 27 Dec 2024 08:54:16 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <gabrielsantosdesouza@HIDDEN>)
id 1tRAn9-0000IN-U0
for bug-gnu-emacs@HIDDEN; Fri, 27 Dec 2024 08:54:15 -0500
Received: from layka.disroot.org ([178.21.23.139])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <gabrielsantosdesouza@HIDDEN>)
id 1tRAn7-0006EM-On
for bug-gnu-emacs@HIDDEN; Fri, 27 Dec 2024 08:54:15 -0500
Received: from mail01.disroot.lan (localhost [127.0.0.1])
by disroot.org (Postfix) with ESMTP id BC2DA25C1B
for <bug-gnu-emacs@HIDDEN>; Fri, 27 Dec 2024 14:54:10 +0100 (CET)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from layka.disroot.org ([127.0.0.1])
by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP
id B1SUuuzudaSW for <bug-gnu-emacs@HIDDEN>;
Fri, 27 Dec 2024 14:54:09 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
t=1735307649; bh=LJv0UTFN5Tvaq7XDw+IElpL4wScI2JdWNeePqUxpjWw=;
h=From:To:Subject:Date;
b=VDaS4jX4JWVZKbqbFT4nNmlXISIPcLega3l3M6bPzbE/wTL0Sdp1/XqiHWpjfDBgE
ofoqIYPEZbARYbxAZPh5HiQ6OBjxpTLKYmUJ1VHmqFh2H/6/FivIjTx5wW6mRL9JeN
T9C+aMpXVEde+XixSdlPobgj1pA+jdHAjRLNNaWklRBgWN1xe7oRZWsFHlW3/O0aoH
IPRwwaoGKzTXaiF2G+qLYDEoWEsWsG4r4tRXoqkadPezFWJvL51rJZK1im5pCUzwdZ
NlXMTMOQElPLDYGz0LmrRE0MHZJeP8XITDdxRIHlW9WPlMNV7eyGMC/qrrB+2Kvhso
jeMuLMxVFN8+A==
From: Gabriel Santos <gabrielsantosdesouza@HIDDEN>
Date: Fri, 27 Dec 2024 10:54:04 -0300
Message-ID: <87msgh5j0j.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=178.21.23.139;
envelope-from=gabrielsantosdesouza@HIDDEN; helo=layka.disroot.org
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)
--=-=-=
Content-Type: text/plain
Greetings,
Currently, the only way to navigate through treesit-explorer is by the
use of C-n and C-p. Since this buffer is full of buttons, I decided to
add button navigation to it.
This patch adds button navigation to treesit-explorer, for the following
keys:
* forward-button
- f
- n
- TAB
* backward-button
- b
- p
- <backtab>
* Points of discussion
Maybe that's too many keys? The only ones I think that don't really fit
that much are "f" and "b", because they can also go down, but there's no
harm in having extra keys.
Regards,
--
Gabriel Santos
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0001-Add-button-navigation-to-treesit-explorer.patch
Content-Description: [PATCH] Add button navigation to treesit-explorer
From d78745581bdf7daf77602eb0bd06b6bdccc3c3c6 Mon Sep 17 00:00:00 2001
From: Gabriel Santos <gabrielsantosdesouza@HIDDEN>
Date: Fri, 27 Dec 2024 10:43:20 -0300
Subject: [PATCH] Add button navigation to treesit-explorer
* lisp/treesit.el (treesit--explorer-tree-mode-map):
Define it as a child of special-mode-map, adding multiple
keys for button navigation.
---
lisp/treesit.el | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/lisp/treesit.el b/lisp/treesit.el
index eb3e26fff7e..9925f8ee014 100644
--- a/lisp/treesit.el
+++ b/lisp/treesit.el
@@ -3907,6 +3907,17 @@ covers point. PARSER-NAME are unique."
"Mode for displaying syntax trees for `treesit-explore-mode'."
nil)
+(defvar-keymap treesit--explorer-tree-mode-map
+ :doc "Keymap for the treesit tree explorer.
+Navigates from button to button."
+ :parent special-mode-map
+ "n" #'forward-button
+ "p" #'backward-button
+ "f" #'forward-button
+ "b" #'backward-button
+ "TAB" #'forward-button
+ "<backtab>" #'backward-button)
+
(defun treesit-explorer-switch-parser (parser)
"Switch explorer to use PARSER."
(interactive
--
2.47.0
--=-=-=--
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Gabriel Santos <gabrielsantosdesouza@HIDDEN> Subject: bug#75141: Acknowledgement ([PATCH] Add button navigation to treesit-explorer) Message-ID: <handler.75141.B.17353076577756.ack <at> debbugs.gnu.org> References: <87msgh5j0j.fsf@HIDDEN> X-Gnu-PR-Message: ack 75141 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 75141 <at> debbugs.gnu.org Date: Fri, 27 Dec 2024 13:55:03 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 75141 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 75141: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75141 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
Received: (at control) by debbugs.gnu.org; 2 Jan 2025 01:24:12 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 01 20:24:12 2025 Received: from localhost ([127.0.0.1]:41118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tT9wa-0000Jf-EO for submit <at> debbugs.gnu.org; Wed, 01 Jan 2025 20:24:12 -0500 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]:44163) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tT9wY-0000JQ-SV for control <at> debbugs.gnu.org; Wed, 01 Jan 2025 20:24:11 -0500 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5d3e6274015so19110218a12.0 for <control <at> debbugs.gnu.org>; Wed, 01 Jan 2025 17:24:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735781050; x=1736385850; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=f6sx+kHPfTPn6SwC/cDQ0YRU3vQFCcB1hRRr55AhyvI=; b=PFHZ9v1f64+TsAWNpUckBULPLzKdp2Cnidh2+liIUVHR6kDTEYETA7kjzy3mQb9suw 5tpPVuzWyGVFlZi89cxfglhEbdKH4YfxaT4dT8wkv3+X6x9pswKXAT6IAXxkLiRZRUhA VoQbbPMUemTeyIeBTJfcRtlRZD6uBcAQbfue7EHtBYq0EybWA/ZAMfa0I4M9e8tC9bPR k2/6YlKliLLOwFMHSaCFsnARtAkjNXR+sRhclm3tfszo3ZfqKbaC1GoasSfql+qqaoTu eztF7BzCZtIVDSxVS9YciT+uh+IR3YrUdPhGuucPgn+48Y7jN1Zuy6mn8L+fKU753OKL 8JzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735781050; x=1736385850; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=f6sx+kHPfTPn6SwC/cDQ0YRU3vQFCcB1hRRr55AhyvI=; b=isgKV3tfWxMOl51bf5QT2em20qTciiWHJz/OgD/RvtJ6F+8aQAIUzdM2RpYIjXWBnt 5Ic6ZYPVL8kdPcg6kHB4EoXy558XuohrjOxAPtuvWUxTbGUqoex8ti8voFOjyhocEFQ8 GHBl/Z6dhPxU5kOMzZ4f7ehTw9aou3wgVP+czvKnngfi/mAcpAjPbIthIz2vdbo+xwAp 9sR3NckMC99YWxtGlDn2GMnD8+2DSat5wJa/h94GmvZITa8AM6jghk/1No8xCAosOX8u dx1qbHj29kl/oceaaFJimBv/bObsKWH9oETjh+W7gPbztodnVBdQzK9sXtDLPgmIlVwx SFww== X-Gm-Message-State: AOJu0YwYFCJEFBTG9agaTZ0/ykvsmp/2kmn0Ed+Pz2fD+eYlLf2awVpK 7x8pdDd+a02pzOswExHo7CZQXes7ACBtLTQlByEQARon3deo7EyVCvh57hOgfx62tS3kq/afP6Q hx2DgHuiG1E8aZRY6di9ByMVBXpyHR8Fb X-Gm-Gg: ASbGncvbFym3aQhPYnxz53UkI7YCaCTtjYN+v94cN5fHxEBZInx3KVLY5+mMRZcTm9h D2K+MwmYFR0jfsYW6F5TK0/uPpHO8EcOcCghoLAB2 X-Google-Smtp-Source: AGHT+IH9LTEHcZLkzMJeX7leEL0wC9W83QnOA8G3ylUCs94BD8Do+JE8mX5OtD+G/jO5/WwAr4fh1Ym9EgizjMCx7es= X-Received: by 2002:a05:6402:13cf:b0:5cf:e71c:ff88 with SMTP id 4fb4d7f45d1cf-5d81dd83bc0mr32214652a12.4.1735781049602; Wed, 01 Jan 2025 17:24:09 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 1 Jan 2025 19:24:09 -0600 From: Stefan Kangas <stefankangas@HIDDEN> MIME-Version: 1.0 Date: Wed, 1 Jan 2025 19:24:09 -0600 Message-ID: <CADwFkmm4yrxheh26ysvD0R85oerU5oB5_H+KQ_BwQ5+hcQsFig@HIDDEN> Subject: control message for bug #75141 To: control <at> debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) severity 75141 wishlist quit
X-Loop: help-debbugs@HIDDEN
Subject: bug#75141: [PATCH] Add button navigation to treesit-explorer
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 04 Jan 2025 11:59:02 +0000
Resent-Message-ID: <handler.75141.B75141.173599188614836 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75141
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Gabriel Santos <gabrielsantosdesouza@HIDDEN>, Yuan Fu <casouri@HIDDEN>
Cc: 75141 <at> debbugs.gnu.org
Received: via spool by 75141-submit <at> debbugs.gnu.org id=B75141.173599188614836
(code B ref 75141); Sat, 04 Jan 2025 11:59:02 +0000
Received: (at 75141) by debbugs.gnu.org; 4 Jan 2025 11:58:06 +0000
Received: from localhost ([127.0.0.1]:53717 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tU2n7-0003rE-LW
for submit <at> debbugs.gnu.org; Sat, 04 Jan 2025 06:58:05 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:53152)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tU2n5-0003qj-SW
for 75141 <at> debbugs.gnu.org; Sat, 04 Jan 2025 06:58:04 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1tU2n0-0000iW-0O; Sat, 04 Jan 2025 06:57:58 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=WPcgTSRgj9Yro5RmD2YrlL0doR/4jRBozJhu1CvWFOU=; b=sVuR3Gol1loB
f0T0jYqI2vhqFlVcEH9RTL4lLE5ydP61uE8SrVIra+SMXo5vTfeF/mTEIfNFfGCphUGA3QZxxEkt8
Ln/gCgXZ+Q7y9hnQxbH9txJKpbMbJ6hlLL49ShD43h7A/ia9D0D4Ca+O/olpERRMZA2UcsS/l7TWd
qtQc2rzE22wjkE19sG+i4jai6tXO0j+9NQ+2Ci/b1HV0hJH5H6xdBwrDz4nJYDfDA3DwsvOk75CbS
AVlhQPsSAp1hdv2OihJjCp16nNyt6/69wQnK9e3etpyVqIsvmZp0bGzFDKT9UpxnqnCDQM9o1t55W
EUoSgoSgu2c2B1UDa+KtmA==;
Date: Sat, 04 Jan 2025 13:57:51 +0200
Message-Id: <868qrqeqps.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87msgh5j0j.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN)
References: <87msgh5j0j.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Date: Fri, 27 Dec 2024 10:54:04 -0300
> From: Gabriel Santos via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>
> Greetings,
>
> Currently, the only way to navigate through treesit-explorer is by the
> use of C-n and C-p. Since this buffer is full of buttons, I decided to
> add button navigation to it.
>
> This patch adds button navigation to treesit-explorer, for the following
> keys:
>
> * forward-button
> - f
> - n
> - TAB
>
> * backward-button
> - b
> - p
> - <backtab>
>
> * Points of discussion
>
> Maybe that's too many keys? The only ones I think that don't really fit
> that much are "f" and "b", because they can also go down, but there's no
> harm in having extra keys.
Thanks.
Yuan, any comments?
X-Loop: help-debbugs@HIDDEN
Subject: bug#75141: [PATCH] Add button navigation to treesit-explorer
Resent-From: Yuan Fu <casouri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 04 Jan 2025 20:03:02 +0000
Resent-Message-ID: <handler.75141.B75141.17360209818101 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75141
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 75141 <at> debbugs.gnu.org, Gabriel Santos <gabrielsantosdesouza@HIDDEN>
Received: via spool by 75141-submit <at> debbugs.gnu.org id=B75141.17360209818101
(code B ref 75141); Sat, 04 Jan 2025 20:03:02 +0000
Received: (at 75141) by debbugs.gnu.org; 4 Jan 2025 20:03:01 +0000
Received: from localhost ([127.0.0.1]:57518 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tUAMP-00026b-AM
for submit <at> debbugs.gnu.org; Sat, 04 Jan 2025 15:03:01 -0500
Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:46433)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <casouri@HIDDEN>) id 1tUAMN-00026P-Ix
for 75141 <at> debbugs.gnu.org; Sat, 04 Jan 2025 15:03:00 -0500
Received: by mail-pl1-x632.google.com with SMTP id
d9443c01a7336-21649a7bcdcso181095535ad.1
for <75141 <at> debbugs.gnu.org>; Sat, 04 Jan 2025 12:02:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1736020978; x=1736625778; darn=debbugs.gnu.org;
h=to:references:message-id:content-transfer-encoding:cc:date
:in-reply-to:from:subject:mime-version:from:to:cc:subject:date
:message-id:reply-to;
bh=c2RcD6Lae6EkQgqkzhxQCwktHtjaOLtHSHeZ4rYG+98=;
b=FkU94321dHzxBMfxuw1QcHi1ioTHYdtQpVBTgRfU0afSAOKjc7OAPMQNGgcCRZGGNo
cIZdkrL51+P6wr5yMpBFK7MZsmoxNQvnXYWkYmBYGvvxzlUFjyzEkuGKNAaSZaMMbrL8
BmFJMi7Zs5D+WSu5kuNmOMIt7j/oPeTUQrahaKJ9oOBQwbi03OHbr93lNEbUkPTYxdDY
VOExvHHA7SRf5DRMD75lKnkqZDwzzeVve6LPffgz1kTE8hxRJR1kQAdqceISAcpGDWTL
7YhTF7aj9TNvbHUDCQWAfrv61+NSmFq11lMAN6vzUJ6rnynuwQ86lUMt/b80iBFIJ+Lh
bJbQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1736020978; x=1736625778;
h=to:references:message-id:content-transfer-encoding:cc:date
:in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=c2RcD6Lae6EkQgqkzhxQCwktHtjaOLtHSHeZ4rYG+98=;
b=FbYW+okek8pWuS9uipl7LbshihY5oCTxfsBufT94N2Bg9uqXxDZrE1feElcmDg9b1A
EJ8a7EMGQViXGPtYnjKzBsiRKHnrK37mo4Qw9O7MSn2N5P7s17zXVOrfxKx8hy3rx92l
mbStUSrCvfBmtOtedjI5ZkCjlN5e23NPsZr7geT7tund1HcRsxBbsgf9pzGxF1+XcNUF
Qjg5z6OiGL9aAOmYuIXHxbF8kGufePJTNg5gBdPvEqWzwRgMwntfvn26lIQ29lUVQfJe
J4eO5IZu3CGW4tBaOyGYgZyDfXgYU2XNIdph4PiSse9HfvLcRZ/HvWAZrWp/1p1JfpGZ
aXpw==
X-Forwarded-Encrypted: i=1;
AJvYcCXiV8jIwxoGQLMe6JS6F69HJwcIVT26BlaKCjiV1h48zWQDQBlJCnN4ruEQaI/eLPNEhcyxgg==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YzrlIkF4Ky4Nw4/rCoIay4QxxwNVc5lAY108TyMSXbbIevfPpm5
9AVBH9JGP1nr+BKD+7F+MsQzAja3xg8h7mjczmvZ1WCU20j5BPVj
X-Gm-Gg: ASbGncvUNkQ4yJygBZkXCU0EhPFJ0bgBhdGfcFjI3cA7nXRSyJl7AUn3TWgUT7immnu
7Ig5sAUrVjglw0pr240EuGTIQHFsVWa6WsILPcu1LIvAD2TOjlJUFR12PPa5DOKenJI4GNiiGRc
VQLV7F6PERdUcOPclx9RlHN3PRJo4bB2vjkLbcSFfTaTap72pDl+1mEf2/KleCWKVx+i72QHN+S
rBQIooWGz5dhZzWND0NbplCEVXM4s1hA+olU+xaUepnx9340FR6Jb+dcUr/HAiIKujm5Jt//j9Q
5nCv
X-Google-Smtp-Source: AGHT+IG+vCZYxUjS/bn8euYzijuj+HT27fMniOo7Tb/Nj7if6jlADyONwNawwhLA5As82DSuJipa7w==
X-Received: by 2002:a17:902:d587:b0:216:5af7:eb2a with SMTP id
d9443c01a7336-219e6ebb70bmr810909795ad.33.1736020978476;
Sat, 04 Jan 2025 12:02:58 -0800 (PST)
Received: from smtpclient.apple ([2601:646:8f81:6120:c496:8cdf:4c5d:3617])
by smtp.gmail.com with ESMTPSA id
d9443c01a7336-219dc96e94dsm266162685ad.67.2025.01.04.12.02.57
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Sat, 04 Jan 2025 12:02:57 -0800 (PST)
Content-Type: text/plain;
charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\))
From: Yuan Fu <casouri@HIDDEN>
In-Reply-To: <868qrqeqps.fsf@HIDDEN>
Date: Sat, 4 Jan 2025 12:02:46 -0800
Content-Transfer-Encoding: quoted-printable
Message-Id: <965F4039-B541-4FD8-98D0-E34ACAAE4FA0@HIDDEN>
References: <87msgh5j0j.fsf@HIDDEN> <868qrqeqps.fsf@HIDDEN>
X-Mailer: Apple Mail (2.3776.700.51)
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
> On Jan 4, 2025, at 3:57=E2=80=AFAM, Eli Zaretskii <eliz@HIDDEN> =
wrote:
>=20
>> Date: Fri, 27 Dec 2024 10:54:04 -0300
>> From: Gabriel Santos via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>>=20
>> Greetings,
>>=20
>> Currently, the only way to navigate through treesit-explorer is by =
the
>> use of C-n and C-p. Since this buffer is full of buttons, I decided =
to
>> add button navigation to it.
>>=20
>> This patch adds button navigation to treesit-explorer, for the =
following
>> keys:
>>=20
>> * forward-button
>> - f
>> - n
>> - TAB
>>=20
>> * backward-button
>> - b
>> - p
>> - <backtab>
>>=20
>> * Points of discussion
>>=20
>> Maybe that's too many keys? The only ones I think that don't really =
fit
>> that much are "f" and "b", because they can also go down, but there's =
no
>> harm in having extra keys.
>=20
> Thanks.
>=20
> Yuan, any comments?
Sounds good! Though would using both f/b and n/p for the same thing a =
bit wasteful? Maybe we can start with n/p TAB/<backtab>?
Yuan=
X-Loop: help-debbugs@HIDDEN
Subject: bug#75141: [PATCH] Add button navigation to treesit-explorer
Resent-From: Gabriel Santos <gabrielsantosdesouza@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 04 Jan 2025 20:27:02 +0000
Resent-Message-ID: <handler.75141.B75141.173602237312218 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75141
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Yuan Fu <casouri@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>
Cc: 75141 <at> debbugs.gnu.org
Received: via spool by 75141-submit <at> debbugs.gnu.org id=B75141.173602237312218
(code B ref 75141); Sat, 04 Jan 2025 20:27:02 +0000
Received: (at 75141) by debbugs.gnu.org; 4 Jan 2025 20:26:13 +0000
Received: from localhost ([127.0.0.1]:57563 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tUAir-0003B0-1K
for submit <at> debbugs.gnu.org; Sat, 04 Jan 2025 15:26:13 -0500
Received: from layka.disroot.org ([178.21.23.139]:40772)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <gabrielsantosdesouza@HIDDEN>)
id 1tUAil-0003Al-TR
for 75141 <at> debbugs.gnu.org; Sat, 04 Jan 2025 15:26:11 -0500
Received: from mail01.disroot.lan (localhost [127.0.0.1])
by disroot.org (Postfix) with ESMTP id 1415D25B9F;
Sat, 4 Jan 2025 21:26:06 +0100 (CET)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from layka.disroot.org ([127.0.0.1])
by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP
id uwvQovGDP6fO; Sat, 4 Jan 2025 21:26:00 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
t=1736022360; bh=7Dx5BcKqceBjMxt2XJCLhfL1nqPcwp66Y8iII0ckOd8=;
h=Date:From:To:CC:Subject:In-Reply-To:References;
b=ILcMLKtSBe/WkZjN2FapVtvwLIff8NDZVQMTVmM9g/iMKll3CZDTUZT01vy2beZ6q
floczm09IfjlluZdtNuNYT7X76c/X2QqYOApZQlM3M4wjypbWRlaiGa6TJaI2uvXGv
FhcUT4fhzr1yY+Nx1xkScYop7DIYYfzXtiC2OhZSG9s+8DIZY2oYD5VvUoB/ylc6xI
ToxCagu16wW2I9Y9a0oZr4oSuWOAX89lKN9djnigJWSc2DOZzshvBctzjrviTxWsJD
GB65F8/3TrhKl5k6e1ug1ocE53kGKLiq6oNcn+3ch07XgPopVyLvf2M/6Tc+ve5Lml
2RtOumZGvu9IA==
Date: Sat, 04 Jan 2025 17:25:54 -0300
From: Gabriel Santos <gabrielsantosdesouza@HIDDEN>
In-Reply-To: <965F4039-B541-4FD8-98D0-E34ACAAE4FA0@HIDDEN>
References: <87msgh5j0j.fsf@HIDDEN> <868qrqeqps.fsf@HIDDEN>
<965F4039-B541-4FD8-98D0-E34ACAAE4FA0@HIDDEN>
Message-ID: <4E739AB3-EC2A-48E0-94A1-A2E68DA24954@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
>Sounds good! Though would using both f/b and n/p for the same thing a bit =
wasteful? Maybe we can start with n/p TAB/<backtab>?
Yes, that seems to be best, I'll update the patch now=2E
--
Gabriel Santos
X-Loop: help-debbugs@HIDDEN
Subject: bug#75141: [PATCH] Add button navigation to treesit-explorer
References: <87msgh5j0j.fsf@HIDDEN>
In-Reply-To: <87msgh5j0j.fsf@HIDDEN>
Resent-From: Gabriel Santos <gabrielsantosdesouza@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 04 Jan 2025 21:18:02 +0000
Resent-Message-ID: <handler.75141.B75141.173602544420971 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75141
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: 75141 <at> debbugs.gnu.org
Cc: Eli Zaretskii <eliz@HIDDEN>, Yuan Fu <casouri@HIDDEN>
Received: via spool by 75141-submit <at> debbugs.gnu.org id=B75141.173602544420971
(code B ref 75141); Sat, 04 Jan 2025 21:18:02 +0000
Received: (at 75141) by debbugs.gnu.org; 4 Jan 2025 21:17:24 +0000
Received: from localhost ([127.0.0.1]:57689 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tUBWN-0005SA-NU
for submit <at> debbugs.gnu.org; Sat, 04 Jan 2025 16:17:23 -0500
Received: from layka.disroot.org ([178.21.23.139]:49840)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <gabrielsantosdesouza@HIDDEN>)
id 1tUBWL-0005S1-HG
for 75141 <at> debbugs.gnu.org; Sat, 04 Jan 2025 16:17:22 -0500
Received: from mail01.disroot.lan (localhost [127.0.0.1])
by disroot.org (Postfix) with ESMTP id B05F925BFA;
Sat, 4 Jan 2025 22:17:19 +0100 (CET)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from layka.disroot.org ([127.0.0.1])
by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP
id Xk83x2SSl9j8; Sat, 4 Jan 2025 22:17:16 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
t=1736025434; bh=jSfFrYMCPlyghW0c41tIO8rqY4pzBydeCaZ5r53tpgk=;
h=From:To:Cc:Subject:Date;
b=gVc+JRfIWvSFYjfHqGDcT+U/bfE1VeuhxLoyJdqihC5hlW68VsPXHSXwZo5I8zG9V
DaB1QxCW0j6W4QAg8SHzzpun7Xga4jjb9bSL9ReHUCGsL6iQvaZ32A9rh8SFljF1e7
31ZzKp1sxM1d/iKkq98uP2VdVx1gP69z8VOip/WK9Mu6mhyeOWOBbe8cHzEuUz2D8H
A41QhB44GkkmeTPaL4S4TvOBWzJ+/LqD0WYRFcXn06mjIkZYk+5eGge707OmpbXJT3
HnmOIkVkKGSDiBTWKj4/d5G9ysbjwf3Zx7em3VMxSUsWSIsIva8jr4omu9N3e/I3xp
lgK75OhkZUJxA==
From: Gabriel Santos <gabrielsantosdesouza@HIDDEN>
Date: Sat, 04 Jan 2025 18:17:10 -0300
Message-ID: <87pll28ejt.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
Here is the updated patch, with "f" and "b" removed.
--
Gabriel Santos
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0001-Add-button-navigation-to-treesit-explorer.patch
Content-Description: [PATCH] Add button navigation to treesit-explorer
From 1224d220985edd9de0731b26c0be96eb9f6b35a1 Mon Sep 17 00:00:00 2001
From: Gabriel Santos <gabrielsantosdesouza@HIDDEN>
Date: Fri, 27 Dec 2024 10:43:20 -0300
Subject: [PATCH] Add button navigation to treesit-explorer
* lisp/treesit.el (treesit--explorer-tree-mode-map):
Define it as a child of special-mode-map,
adding keys for button navigation.
---
lisp/treesit.el | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/lisp/treesit.el b/lisp/treesit.el
index e643eb48654..ef27a370bc2 100644
--- a/lisp/treesit.el
+++ b/lisp/treesit.el
@@ -4041,6 +4041,16 @@ covers point. PARSER-NAME are unique."
"Mode for displaying syntax trees for `treesit-explore-mode'."
nil)
+(defvar-keymap treesit--explorer-tree-mode-map
+ :doc "Keymap for the treesit tree explorer.
+
+Navigates from button to button."
+ :parent special-mode-map
+ "n" #'forward-button
+ "p" #'backward-button
+ "TAB" #'forward-button
+ "<backtab>" #'backward-button)
+
(defun treesit-explorer-switch-parser (parser)
"Switch explorer to use PARSER."
(interactive
--
2.47.1
--=-=-=--
X-Loop: help-debbugs@HIDDEN
Subject: bug#75141: [PATCH] Add button navigation to treesit-explorer
Resent-From: Gabriel Santos <gabrielsantosdesouza@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 08 Jan 2025 14:33:02 +0000
Resent-Message-ID: <handler.75141.B75141.173634672222502 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75141
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Yuan Fu <casouri@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 75141 <at> debbugs.gnu.org
Received: via spool by 75141-submit <at> debbugs.gnu.org id=B75141.173634672222502
(code B ref 75141); Wed, 08 Jan 2025 14:33:02 +0000
Received: (at 75141) by debbugs.gnu.org; 8 Jan 2025 14:32:02 +0000
Received: from localhost ([127.0.0.1]:46561 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tVX6H-0005qr-Vv
for submit <at> debbugs.gnu.org; Wed, 08 Jan 2025 09:32:02 -0500
Received: from layka.disroot.org ([178.21.23.139]:52148)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <gabrielsantosdesouza@HIDDEN>)
id 1tVX6E-0005qX-SX
for 75141 <at> debbugs.gnu.org; Wed, 08 Jan 2025 09:31:59 -0500
Received: from mail01.disroot.lan (localhost [127.0.0.1])
by disroot.org (Postfix) with ESMTP id 047CC25888;
Wed, 8 Jan 2025 15:31:57 +0100 (CET)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from layka.disroot.org ([127.0.0.1])
by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP
id g_TufnSJwYAe; Wed, 8 Jan 2025 15:31:56 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
t=1736346716; bh=b+4wzUuI2hPNa8Z34rYIbsHvZnmDczs+XZjBIr/k8sk=;
h=Date:From:To:CC:Subject:In-Reply-To:References;
b=Z7n0as2zAMlvoX8flPYvCORPFN6jf5nzy9dI2k9g4HLjhEdPjj1+8t3Uv0DbCnX0S
/K5EmiqVKEDck6BfGQ/l6JodkvqaD7TAdNpXkait+uNc7329y5Cq2PLWFfU9maL+3G
KhMlJX3YOPxsKj5fzqJxw1fSTOUvG2Xyh3Xi4IJXKripI6OOVtbRqWPjwRUBis7bh3
OwXlduDx5QV3lAbElDMctxUI0jfyyetQTttxNARDNMH5ynrm9KobCNJ2BYvGw5b9Vy
XNgAy0AfZleN8HsZhNQYJbCwVkDjKWrnp46yymkOm9SWEaBkFr42O9osNXNu/MRqLo
PQbTTYq1Mp5cg==
Date: Wed, 08 Jan 2025 11:31:52 -0300
From: Gabriel Santos <gabrielsantosdesouza@HIDDEN>
In-Reply-To: <E8383DF2-495D-4151-A12C-A6B7D8B6B1B1@HIDDEN>
References: <87sepy8grz.fsf@HIDDEN>
<E8383DF2-495D-4151-A12C-A6B7D8B6B1B1@HIDDEN>
Message-ID: <DC2B5252-E9E2-4CC0-8A0C-164760F731DC@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
>Thanks! Have signed the copyright assignment? If you have, I=E2=80=99ll ap=
ply it to master=2E
Yes, I've signed the copyright assignment=2E You can apply the patch=2E Ha=
ppy to be contributing!
--
Gabriel Santos
MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Stefan Kangas <stefankangas@HIDDEN> Subject: bug#75141: closed ([PATCH] Add button navigation to treesit-explorer) CC: tracker <at> debbugs.gnu.org Message-ID: <handler.75141.D75141.173776360114524.ackdone <at> debbugs.gnu.org> References: <CADwFkmk2kT016n5i3d=gznfX58L+jn2XXaCh4Y7LF30=egP=-w@HIDDEN> <87msgh5j0j.fsf@HIDDEN> X-Gnu-PR-Message: closed 75141 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Date: Sat, 25 Jan 2025 00:07:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1737763622-14567-0" This is a multi-part message in MIME format... ------------=_1737763622-14567-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Fri, 24 Jan 2025 18:06:32 -0600 with message-id <CADwFkmk2kT016n5i3d=3DgznfX58L+jn2XXaCh4Y7LF30=3DegP=3D-w@= mail.gmail.com> and subject line Re: bug#75141: [PATCH] Add button navigation to treesit-ex= plorer has caused the debbugs.gnu.org bug report #75141, regarding [PATCH] Add button navigation to treesit-explorer to be marked as done. (If you believe you have received this mail in error, please contact help-debbugs@HIDDEN) --=20 75141: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75141 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems ------------=_1737763622-14567-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 27 Dec 2024 13:54:17 +0000 Received: from localhost ([127.0.0.1]:45193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tRAnB-000212-Ek for submit <at> debbugs.gnu.org; Fri, 27 Dec 2024 08:54:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:34736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <gabrielsantosdesouza@HIDDEN>) id 1tRAnA-00020u-6S for submit <at> debbugs.gnu.org; Fri, 27 Dec 2024 08:54:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <gabrielsantosdesouza@HIDDEN>) id 1tRAn9-0000IN-U0 for bug-gnu-emacs@HIDDEN; Fri, 27 Dec 2024 08:54:15 -0500 Received: from layka.disroot.org ([178.21.23.139]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <gabrielsantosdesouza@HIDDEN>) id 1tRAn7-0006EM-On for bug-gnu-emacs@HIDDEN; Fri, 27 Dec 2024 08:54:15 -0500 Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id BC2DA25C1B for <bug-gnu-emacs@HIDDEN>; Fri, 27 Dec 2024 14:54:10 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id B1SUuuzudaSW for <bug-gnu-emacs@HIDDEN>; Fri, 27 Dec 2024 14:54:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1735307649; bh=LJv0UTFN5Tvaq7XDw+IElpL4wScI2JdWNeePqUxpjWw=; h=From:To:Subject:Date; b=VDaS4jX4JWVZKbqbFT4nNmlXISIPcLega3l3M6bPzbE/wTL0Sdp1/XqiHWpjfDBgE ofoqIYPEZbARYbxAZPh5HiQ6OBjxpTLKYmUJ1VHmqFh2H/6/FivIjTx5wW6mRL9JeN T9C+aMpXVEde+XixSdlPobgj1pA+jdHAjRLNNaWklRBgWN1xe7oRZWsFHlW3/O0aoH IPRwwaoGKzTXaiF2G+qLYDEoWEsWsG4r4tRXoqkadPezFWJvL51rJZK1im5pCUzwdZ NlXMTMOQElPLDYGz0LmrRE0MHZJeP8XITDdxRIHlW9WPlMNV7eyGMC/qrrB+2Kvhso jeMuLMxVFN8+A== From: Gabriel Santos <gabrielsantosdesouza@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: [PATCH] Add button navigation to treesit-explorer Date: Fri, 27 Dec 2024 10:54:04 -0300 Message-ID: <87msgh5j0j.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=178.21.23.139; envelope-from=gabrielsantosdesouza@HIDDEN; helo=layka.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Greetings, Currently, the only way to navigate through treesit-explorer is by the use of C-n and C-p. Since this buffer is full of buttons, I decided to add button navigation to it. This patch adds button navigation to treesit-explorer, for the following keys: * forward-button - f - n - TAB * backward-button - b - p - <backtab> * Points of discussion Maybe that's too many keys? The only ones I think that don't really fit that much are "f" and "b", because they can also go down, but there's no harm in having extra keys. Regards, -- Gabriel Santos --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-button-navigation-to-treesit-explorer.patch Content-Description: [PATCH] Add button navigation to treesit-explorer From d78745581bdf7daf77602eb0bd06b6bdccc3c3c6 Mon Sep 17 00:00:00 2001 From: Gabriel Santos <gabrielsantosdesouza@HIDDEN> Date: Fri, 27 Dec 2024 10:43:20 -0300 Subject: [PATCH] Add button navigation to treesit-explorer * lisp/treesit.el (treesit--explorer-tree-mode-map): Define it as a child of special-mode-map, adding multiple keys for button navigation. --- lisp/treesit.el | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/lisp/treesit.el b/lisp/treesit.el index eb3e26fff7e..9925f8ee014 100644 --- a/lisp/treesit.el +++ b/lisp/treesit.el @@ -3907,6 +3907,17 @@ covers point. PARSER-NAME are unique." "Mode for displaying syntax trees for `treesit-explore-mode'." nil) +(defvar-keymap treesit--explorer-tree-mode-map + :doc "Keymap for the treesit tree explorer. +Navigates from button to button." + :parent special-mode-map + "n" #'forward-button + "p" #'backward-button + "f" #'forward-button + "b" #'backward-button + "TAB" #'forward-button + "<backtab>" #'backward-button) + (defun treesit-explorer-switch-parser (parser) "Switch explorer to use PARSER." (interactive -- 2.47.0 --=-=-=-- ------------=_1737763622-14567-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 75141-done) by debbugs.gnu.org; 25 Jan 2025 00:06:41 +0000 Received: from localhost ([127.0.0.1]:47693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tbThB-0003mC-4R for submit <at> debbugs.gnu.org; Fri, 24 Jan 2025 19:06:41 -0500 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]:61756) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tbTh8-0003lr-JP for 75141-done <at> debbugs.gnu.org; Fri, 24 Jan 2025 19:06:39 -0500 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-aaee0b309adso382033266b.3 for <75141-done <at> debbugs.gnu.org>; Fri, 24 Jan 2025 16:06:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737763592; x=1738368392; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=GGh8IJa4vvVeMvNDbP0Uhmd2jlai2vwwfmoqbTGbZ98=; b=KdL+Nml8rLuAp9UoU5qhVq7K6KiEKU0oVfjp1LL5wh9a+xHdyPlZEnkpaMAQDjPmR3 E4Mo51UjdZX7d3rlhdTUSMQNwV/nK3hzeXVy8CTCd0xdpTt0LaDej/+UEFtvO+B0MeJh fS37yRAPGsKoSAxb5cpFJbHwAmRwgzBHOid4STJ+y6ec5Jb3Xs+6jPvutSCy5DJHjDa8 xdvtDn6ySMBNPpySVTV2m4HDiVuaxWjOC6nFDDccYVanTR12qbjaQ50hzPAC5A4X6TJi 0G7H8dbgUxrbBr+xDQYtWd6sQk7GcDz85dNNZlf01lznKzSJMxpTkOerCQ485Hq5ooQk KcvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737763592; x=1738368392; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GGh8IJa4vvVeMvNDbP0Uhmd2jlai2vwwfmoqbTGbZ98=; b=HZuKnNKczon5qtSPhhxz1MPoohWxC5wVCrrHVu9nyBMFhgnX20SeumL+H7drJ/LYXB I7K/HmSfyzcPGnFD09FSV75YVtxq/xElAQhl6jYMMDsCxlFb/TDrEpxwwyvtst/X7UV/ yh1L1T2aeDOFXjZ3p6yUlChquoZW8oD4FdfWtpF9UfVYAoiL1odrtz+szk2Uloiiw5fi /VODQDg12m8DMIw2Lywuz7WGtBvlsWJROoV8I9VqVA82n85ixs0pWaB7S0adYumCF5x7 ITkAKb0H04W1Jpb/nadKlZXxt1PMREEFmCQRTpgwD35u0yCG86ymb91ZRK+uCmtD4Qlz fB/g== X-Gm-Message-State: AOJu0YzqfAX/O4Jz3XssFFM0+iGpUI3c3wYtZ0kKoSzu3Qkqa8RMRgkr X45vmMVi6ojVWVK+2e+cpvw4BZYQqjBkUXD7FfK+wDJ53oBZjwMdnhnvqgXm96SASpZH/Qvy0nT vGAn8/fkIl8E4RHRYd9zJAJ3XitvxVA4m X-Gm-Gg: ASbGncupnmkOh82HMoXOsFd0gf/6FAM9z4Kvrqv9RjKVzHoXmb0P23FHcldGIqk0Vyl M0utwcrBNpW767cgw0kueMMTMXzWDGOjAaOHoqDCkgL1AEF2/qLYnwzrwlZnk3CI= X-Google-Smtp-Source: AGHT+IEhDwCC6RZCS5ImBzyndyG/2Xn4bgf9Zc12jzXyEAlpHmm8VaQc9WLYY7HLJgqBTNE+8rKCvecWKK2U424+XYk= X-Received: by 2002:a17:906:4fcb:b0:aa6:90a8:f5ff with SMTP id a640c23a62f3a-ab38b3fbfe3mr3227119266b.50.1737763592312; Fri, 24 Jan 2025 16:06:32 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 24 Jan 2025 18:06:32 -0600 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <87pll28ejt.fsf@HIDDEN> (Gabriel Santos's message of "Sat, 04 Jan 2025 18:17:10 -0300") References: <87msgh5j0j.fsf@HIDDEN> <87pll28ejt.fsf@HIDDEN> MIME-Version: 1.0 Date: Fri, 24 Jan 2025 18:06:32 -0600 X-Gm-Features: AWEUYZkQtudfxE0rPXGTZEiEqQwH5INgikQtaiBb473rRMkVk2cHzzvbAjbFmtY Message-ID: <CADwFkmk2kT016n5i3d=gznfX58L+jn2XXaCh4Y7LF30=egP=-w@HIDDEN> Subject: Re: bug#75141: [PATCH] Add button navigation to treesit-explorer To: Gabriel Santos <gabrielsantosdesouza@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 75141-done Cc: Eli Zaretskii <eliz@HIDDEN>, Yuan Fu <casouri@HIDDEN>, 75141-done <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Gabriel Santos <gabrielsantosdesouza@HIDDEN> writes: > Here is the updated patch, with "f" and "b" removed. Thanks! It seems like Yuan already installed it, but never closed the bug. So I'm doing that now. > > -- > Gabriel Santos > >>From 1224d220985edd9de0731b26c0be96eb9f6b35a1 Mon Sep 17 00:00:00 2001 > From: Gabriel Santos <gabrielsantosdesouza@HIDDEN> > Date: Fri, 27 Dec 2024 10:43:20 -0300 > Subject: [PATCH] Add button navigation to treesit-explorer > > * lisp/treesit.el (treesit--explorer-tree-mode-map): > Define it as a child of special-mode-map, > adding keys for button navigation. > --- > lisp/treesit.el | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/lisp/treesit.el b/lisp/treesit.el > index e643eb48654..ef27a370bc2 100644 > --- a/lisp/treesit.el > +++ b/lisp/treesit.el > @@ -4041,6 +4041,16 @@ covers point. PARSER-NAME are unique." > "Mode for displaying syntax trees for `treesit-explore-mode'." > nil) > > +(defvar-keymap treesit--explorer-tree-mode-map > + :doc "Keymap for the treesit tree explorer. > + > +Navigates from button to button." > + :parent special-mode-map > + "n" #'forward-button > + "p" #'backward-button > + "TAB" #'forward-button > + "<backtab>" #'backward-button) > + > (defun treesit-explorer-switch-parser (parser) > "Switch explorer to use PARSER." > (interactive ------------=_1737763622-14567-0--
MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Gabriel Santos <gabrielsantosdesouza@HIDDEN> Subject: bug#75141: closed (Re: bug#75141: [PATCH] Add button navigation to treesit-explorer) Message-ID: <handler.75141.D75141.173776360114524.notifdone <at> debbugs.gnu.org> References: <CADwFkmk2kT016n5i3d=gznfX58L+jn2XXaCh4Y7LF30=egP=-w@HIDDEN> <87msgh5j0j.fsf@HIDDEN> X-Gnu-PR-Message: they-closed 75141 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 75141 <at> debbugs.gnu.org Date: Sat, 25 Jan 2025 00:07:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1737763622-14567-1" This is a multi-part message in MIME format... ------------=_1737763622-14567-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #75141: [PATCH] Add button navigation to treesit-explorer which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 75141 <at> debbugs.gnu.org. --=20 75141: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75141 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems ------------=_1737763622-14567-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 75141-done) by debbugs.gnu.org; 25 Jan 2025 00:06:41 +0000 Received: from localhost ([127.0.0.1]:47693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tbThB-0003mC-4R for submit <at> debbugs.gnu.org; Fri, 24 Jan 2025 19:06:41 -0500 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]:61756) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tbTh8-0003lr-JP for 75141-done <at> debbugs.gnu.org; Fri, 24 Jan 2025 19:06:39 -0500 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-aaee0b309adso382033266b.3 for <75141-done <at> debbugs.gnu.org>; Fri, 24 Jan 2025 16:06:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737763592; x=1738368392; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=GGh8IJa4vvVeMvNDbP0Uhmd2jlai2vwwfmoqbTGbZ98=; b=KdL+Nml8rLuAp9UoU5qhVq7K6KiEKU0oVfjp1LL5wh9a+xHdyPlZEnkpaMAQDjPmR3 E4Mo51UjdZX7d3rlhdTUSMQNwV/nK3hzeXVy8CTCd0xdpTt0LaDej/+UEFtvO+B0MeJh fS37yRAPGsKoSAxb5cpFJbHwAmRwgzBHOid4STJ+y6ec5Jb3Xs+6jPvutSCy5DJHjDa8 xdvtDn6ySMBNPpySVTV2m4HDiVuaxWjOC6nFDDccYVanTR12qbjaQ50hzPAC5A4X6TJi 0G7H8dbgUxrbBr+xDQYtWd6sQk7GcDz85dNNZlf01lznKzSJMxpTkOerCQ485Hq5ooQk KcvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737763592; x=1738368392; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GGh8IJa4vvVeMvNDbP0Uhmd2jlai2vwwfmoqbTGbZ98=; b=HZuKnNKczon5qtSPhhxz1MPoohWxC5wVCrrHVu9nyBMFhgnX20SeumL+H7drJ/LYXB I7K/HmSfyzcPGnFD09FSV75YVtxq/xElAQhl6jYMMDsCxlFb/TDrEpxwwyvtst/X7UV/ yh1L1T2aeDOFXjZ3p6yUlChquoZW8oD4FdfWtpF9UfVYAoiL1odrtz+szk2Uloiiw5fi /VODQDg12m8DMIw2Lywuz7WGtBvlsWJROoV8I9VqVA82n85ixs0pWaB7S0adYumCF5x7 ITkAKb0H04W1Jpb/nadKlZXxt1PMREEFmCQRTpgwD35u0yCG86ymb91ZRK+uCmtD4Qlz fB/g== X-Gm-Message-State: AOJu0YzqfAX/O4Jz3XssFFM0+iGpUI3c3wYtZ0kKoSzu3Qkqa8RMRgkr X45vmMVi6ojVWVK+2e+cpvw4BZYQqjBkUXD7FfK+wDJ53oBZjwMdnhnvqgXm96SASpZH/Qvy0nT vGAn8/fkIl8E4RHRYd9zJAJ3XitvxVA4m X-Gm-Gg: ASbGncupnmkOh82HMoXOsFd0gf/6FAM9z4Kvrqv9RjKVzHoXmb0P23FHcldGIqk0Vyl M0utwcrBNpW767cgw0kueMMTMXzWDGOjAaOHoqDCkgL1AEF2/qLYnwzrwlZnk3CI= X-Google-Smtp-Source: AGHT+IEhDwCC6RZCS5ImBzyndyG/2Xn4bgf9Zc12jzXyEAlpHmm8VaQc9WLYY7HLJgqBTNE+8rKCvecWKK2U424+XYk= X-Received: by 2002:a17:906:4fcb:b0:aa6:90a8:f5ff with SMTP id a640c23a62f3a-ab38b3fbfe3mr3227119266b.50.1737763592312; Fri, 24 Jan 2025 16:06:32 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 24 Jan 2025 18:06:32 -0600 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <87pll28ejt.fsf@HIDDEN> (Gabriel Santos's message of "Sat, 04 Jan 2025 18:17:10 -0300") References: <87msgh5j0j.fsf@HIDDEN> <87pll28ejt.fsf@HIDDEN> MIME-Version: 1.0 Date: Fri, 24 Jan 2025 18:06:32 -0600 X-Gm-Features: AWEUYZkQtudfxE0rPXGTZEiEqQwH5INgikQtaiBb473rRMkVk2cHzzvbAjbFmtY Message-ID: <CADwFkmk2kT016n5i3d=gznfX58L+jn2XXaCh4Y7LF30=egP=-w@HIDDEN> Subject: Re: bug#75141: [PATCH] Add button navigation to treesit-explorer To: Gabriel Santos <gabrielsantosdesouza@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 75141-done Cc: Eli Zaretskii <eliz@HIDDEN>, Yuan Fu <casouri@HIDDEN>, 75141-done <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Gabriel Santos <gabrielsantosdesouza@HIDDEN> writes: > Here is the updated patch, with "f" and "b" removed. Thanks! It seems like Yuan already installed it, but never closed the bug. So I'm doing that now. > > -- > Gabriel Santos > >>From 1224d220985edd9de0731b26c0be96eb9f6b35a1 Mon Sep 17 00:00:00 2001 > From: Gabriel Santos <gabrielsantosdesouza@HIDDEN> > Date: Fri, 27 Dec 2024 10:43:20 -0300 > Subject: [PATCH] Add button navigation to treesit-explorer > > * lisp/treesit.el (treesit--explorer-tree-mode-map): > Define it as a child of special-mode-map, > adding keys for button navigation. > --- > lisp/treesit.el | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/lisp/treesit.el b/lisp/treesit.el > index e643eb48654..ef27a370bc2 100644 > --- a/lisp/treesit.el > +++ b/lisp/treesit.el > @@ -4041,6 +4041,16 @@ covers point. PARSER-NAME are unique." > "Mode for displaying syntax trees for `treesit-explore-mode'." > nil) > > +(defvar-keymap treesit--explorer-tree-mode-map > + :doc "Keymap for the treesit tree explorer. > + > +Navigates from button to button." > + :parent special-mode-map > + "n" #'forward-button > + "p" #'backward-button > + "TAB" #'forward-button > + "<backtab>" #'backward-button) > + > (defun treesit-explorer-switch-parser (parser) > "Switch explorer to use PARSER." > (interactive ------------=_1737763622-14567-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 27 Dec 2024 13:54:17 +0000 Received: from localhost ([127.0.0.1]:45193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tRAnB-000212-Ek for submit <at> debbugs.gnu.org; Fri, 27 Dec 2024 08:54:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:34736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <gabrielsantosdesouza@HIDDEN>) id 1tRAnA-00020u-6S for submit <at> debbugs.gnu.org; Fri, 27 Dec 2024 08:54:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <gabrielsantosdesouza@HIDDEN>) id 1tRAn9-0000IN-U0 for bug-gnu-emacs@HIDDEN; Fri, 27 Dec 2024 08:54:15 -0500 Received: from layka.disroot.org ([178.21.23.139]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <gabrielsantosdesouza@HIDDEN>) id 1tRAn7-0006EM-On for bug-gnu-emacs@HIDDEN; Fri, 27 Dec 2024 08:54:15 -0500 Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id BC2DA25C1B for <bug-gnu-emacs@HIDDEN>; Fri, 27 Dec 2024 14:54:10 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id B1SUuuzudaSW for <bug-gnu-emacs@HIDDEN>; Fri, 27 Dec 2024 14:54:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1735307649; bh=LJv0UTFN5Tvaq7XDw+IElpL4wScI2JdWNeePqUxpjWw=; h=From:To:Subject:Date; b=VDaS4jX4JWVZKbqbFT4nNmlXISIPcLega3l3M6bPzbE/wTL0Sdp1/XqiHWpjfDBgE ofoqIYPEZbARYbxAZPh5HiQ6OBjxpTLKYmUJ1VHmqFh2H/6/FivIjTx5wW6mRL9JeN T9C+aMpXVEde+XixSdlPobgj1pA+jdHAjRLNNaWklRBgWN1xe7oRZWsFHlW3/O0aoH IPRwwaoGKzTXaiF2G+qLYDEoWEsWsG4r4tRXoqkadPezFWJvL51rJZK1im5pCUzwdZ NlXMTMOQElPLDYGz0LmrRE0MHZJeP8XITDdxRIHlW9WPlMNV7eyGMC/qrrB+2Kvhso jeMuLMxVFN8+A== From: Gabriel Santos <gabrielsantosdesouza@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: [PATCH] Add button navigation to treesit-explorer Date: Fri, 27 Dec 2024 10:54:04 -0300 Message-ID: <87msgh5j0j.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=178.21.23.139; envelope-from=gabrielsantosdesouza@HIDDEN; helo=layka.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Greetings, Currently, the only way to navigate through treesit-explorer is by the use of C-n and C-p. Since this buffer is full of buttons, I decided to add button navigation to it. This patch adds button navigation to treesit-explorer, for the following keys: * forward-button - f - n - TAB * backward-button - b - p - <backtab> * Points of discussion Maybe that's too many keys? The only ones I think that don't really fit that much are "f" and "b", because they can also go down, but there's no harm in having extra keys. Regards, -- Gabriel Santos --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-button-navigation-to-treesit-explorer.patch Content-Description: [PATCH] Add button navigation to treesit-explorer From d78745581bdf7daf77602eb0bd06b6bdccc3c3c6 Mon Sep 17 00:00:00 2001 From: Gabriel Santos <gabrielsantosdesouza@HIDDEN> Date: Fri, 27 Dec 2024 10:43:20 -0300 Subject: [PATCH] Add button navigation to treesit-explorer * lisp/treesit.el (treesit--explorer-tree-mode-map): Define it as a child of special-mode-map, adding multiple keys for button navigation. --- lisp/treesit.el | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/lisp/treesit.el b/lisp/treesit.el index eb3e26fff7e..9925f8ee014 100644 --- a/lisp/treesit.el +++ b/lisp/treesit.el @@ -3907,6 +3907,17 @@ covers point. PARSER-NAME are unique." "Mode for displaying syntax trees for `treesit-explore-mode'." nil) +(defvar-keymap treesit--explorer-tree-mode-map + :doc "Keymap for the treesit tree explorer. +Navigates from button to button." + :parent special-mode-map + "n" #'forward-button + "p" #'backward-button + "f" #'forward-button + "b" #'backward-button + "TAB" #'forward-button + "<backtab>" #'backward-button) + (defun treesit-explorer-switch-parser (parser) "Switch explorer to use PARSER." (interactive -- 2.47.0 --=-=-=-- ------------=_1737763622-14567-1--
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.