GNU bug report logs - #75141
[PATCH] Add button navigation to treesit-explorer

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: wishlist; Reported by: Gabriel Santos <gabrielsantosdesouza@HIDDEN>; Keywords: patch; Done: Stefan Kangas <stefankangas@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 75141-done <at> debbugs.gnu.org:

Received: (at 75141-done) by debbugs.gnu.org; 25 Jan 2025 00:06:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 24 19:06:41 2025
Received: from localhost ([127.0.0.1]:47693 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tbThB-0003mC-4R
	for submit <at> debbugs.gnu.org; Fri, 24 Jan 2025 19:06:41 -0500
Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]:61756)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tbTh8-0003lr-JP
 for 75141-done <at> debbugs.gnu.org; Fri, 24 Jan 2025 19:06:39 -0500
Received: by mail-ej1-x633.google.com with SMTP id
 a640c23a62f3a-aaee0b309adso382033266b.3
 for <75141-done <at> debbugs.gnu.org>; Fri, 24 Jan 2025 16:06:38 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1737763592; x=1738368392; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=GGh8IJa4vvVeMvNDbP0Uhmd2jlai2vwwfmoqbTGbZ98=;
 b=KdL+Nml8rLuAp9UoU5qhVq7K6KiEKU0oVfjp1LL5wh9a+xHdyPlZEnkpaMAQDjPmR3
 E4Mo51UjdZX7d3rlhdTUSMQNwV/nK3hzeXVy8CTCd0xdpTt0LaDej/+UEFtvO+B0MeJh
 fS37yRAPGsKoSAxb5cpFJbHwAmRwgzBHOid4STJ+y6ec5Jb3Xs+6jPvutSCy5DJHjDa8
 xdvtDn6ySMBNPpySVTV2m4HDiVuaxWjOC6nFDDccYVanTR12qbjaQ50hzPAC5A4X6TJi
 0G7H8dbgUxrbBr+xDQYtWd6sQk7GcDz85dNNZlf01lznKzSJMxpTkOerCQ485Hq5ooQk
 KcvQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1737763592; x=1738368392;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=GGh8IJa4vvVeMvNDbP0Uhmd2jlai2vwwfmoqbTGbZ98=;
 b=HZuKnNKczon5qtSPhhxz1MPoohWxC5wVCrrHVu9nyBMFhgnX20SeumL+H7drJ/LYXB
 I7K/HmSfyzcPGnFD09FSV75YVtxq/xElAQhl6jYMMDsCxlFb/TDrEpxwwyvtst/X7UV/
 yh1L1T2aeDOFXjZ3p6yUlChquoZW8oD4FdfWtpF9UfVYAoiL1odrtz+szk2Uloiiw5fi
 /VODQDg12m8DMIw2Lywuz7WGtBvlsWJROoV8I9VqVA82n85ixs0pWaB7S0adYumCF5x7
 ITkAKb0H04W1Jpb/nadKlZXxt1PMREEFmCQRTpgwD35u0yCG86ymb91ZRK+uCmtD4Qlz
 fB/g==
X-Gm-Message-State: AOJu0YzqfAX/O4Jz3XssFFM0+iGpUI3c3wYtZ0kKoSzu3Qkqa8RMRgkr
 X45vmMVi6ojVWVK+2e+cpvw4BZYQqjBkUXD7FfK+wDJ53oBZjwMdnhnvqgXm96SASpZH/Qvy0nT
 vGAn8/fkIl8E4RHRYd9zJAJ3XitvxVA4m
X-Gm-Gg: ASbGncupnmkOh82HMoXOsFd0gf/6FAM9z4Kvrqv9RjKVzHoXmb0P23FHcldGIqk0Vyl
 M0utwcrBNpW767cgw0kueMMTMXzWDGOjAaOHoqDCkgL1AEF2/qLYnwzrwlZnk3CI=
X-Google-Smtp-Source: AGHT+IEhDwCC6RZCS5ImBzyndyG/2Xn4bgf9Zc12jzXyEAlpHmm8VaQc9WLYY7HLJgqBTNE+8rKCvecWKK2U424+XYk=
X-Received: by 2002:a17:906:4fcb:b0:aa6:90a8:f5ff with SMTP id
 a640c23a62f3a-ab38b3fbfe3mr3227119266b.50.1737763592312; Fri, 24 Jan 2025
 16:06:32 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Fri, 24 Jan 2025 18:06:32 -0600
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <87pll28ejt.fsf@HIDDEN> (Gabriel Santos's message of "Sat,
 04 Jan 2025 18:17:10 -0300")
References: <87msgh5j0j.fsf@HIDDEN> <87pll28ejt.fsf@HIDDEN>
MIME-Version: 1.0
Date: Fri, 24 Jan 2025 18:06:32 -0600
X-Gm-Features: AWEUYZkQtudfxE0rPXGTZEiEqQwH5INgikQtaiBb473rRMkVk2cHzzvbAjbFmtY
Message-ID: <CADwFkmk2kT016n5i3d=gznfX58L+jn2XXaCh4Y7LF30=egP=-w@HIDDEN>
Subject: Re: bug#75141: [PATCH] Add button navigation to treesit-explorer
To: Gabriel Santos <gabrielsantosdesouza@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 75141-done
Cc: Eli Zaretskii <eliz@HIDDEN>, Yuan Fu <casouri@HIDDEN>,
 75141-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Gabriel Santos <gabrielsantosdesouza@HIDDEN> writes:

> Here is the updated patch, with "f" and "b" removed.

Thanks!  It seems like Yuan already installed it, but never closed the
bug.  So I'm doing that now.

>
> --
> Gabriel Santos
>
>>From 1224d220985edd9de0731b26c0be96eb9f6b35a1 Mon Sep 17 00:00:00 2001
> From: Gabriel Santos <gabrielsantosdesouza@HIDDEN>
> Date: Fri, 27 Dec 2024 10:43:20 -0300
> Subject: [PATCH] Add button navigation to treesit-explorer
>
> * lisp/treesit.el (treesit--explorer-tree-mode-map):
> Define it as a child of special-mode-map,
> adding keys for button navigation.
> ---
>  lisp/treesit.el | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/lisp/treesit.el b/lisp/treesit.el
> index e643eb48654..ef27a370bc2 100644
> --- a/lisp/treesit.el
> +++ b/lisp/treesit.el
> @@ -4041,6 +4041,16 @@ covers point.  PARSER-NAME are unique."
>    "Mode for displaying syntax trees for `treesit-explore-mode'."
>    nil)
>
> +(defvar-keymap treesit--explorer-tree-mode-map
> +  :doc "Keymap for the treesit tree explorer.
> +
> +Navigates from button to button."
> +  :parent special-mode-map
> +  "n" #'forward-button
> +  "p" #'backward-button
> +  "TAB" #'forward-button
> +  "<backtab>" #'backward-button)
> +
>  (defun treesit-explorer-switch-parser (parser)
>    "Switch explorer to use PARSER."
>    (interactive

Notification sent to Gabriel Santos <gabrielsantosdesouza@HIDDEN>:
bug acknowledged by developer. Full text available.

Reply sent to Stefan Kangas <stefankangas@HIDDEN>:
You have taken responsibility. Full text available.