GNU logs - #75410, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#75410: [PATCH] image-dired: Add extra keybinds for navigation
Resent-From: Gabriel Santos <gabrielsantosdesouza@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 06 Jan 2025 20:09:01 +0000
Resent-Message-ID: <handler.75410.B.173619408431553 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 75410 <at> debbugs.gnu.org
Cc: Stefan Kangas <stefankangas@HIDDEN>
From: Gabriel Santos <gabrielsantosdesouza@HIDDEN>
Date: Mon, 06 Jan 2025 17:07:24 -0300
Message-ID: <87o70j4sg3.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=178.21.23.139;
 envelope-from=gabrielsantosdesouza@HIDDEN; helo=layka.disroot.org
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

--=-=-=
Content-Type: text/plain

Greetings,

I discovered this mode through a blog post from Sacha:

<https://sachachua.com/blog/2025/01/using-image-dired-to-browse-the-latest-screenshots-from-multiple-directories/>

And I really liked it.

Though, I felt that it was missing something:

Some keybinds for navigation besides C-n and C-p, like those found in
other read-only modes, such as dired-mode.

This patch binds the following keys in `image-dired-thumbnail-mode-map':

- "f" :: `image-dired-forward-image'
- "b" :: `image-dired-backward-image'
- "n" :: `image-dired-next-line'
- "p" :: `image-dired-previous-line'
- "a" :: `image-dired-move-beginning-of-line'
- "e" :: `image-dired-move-end-of-line'

These keys are currently unused in the mode.

Regards,

--
Gabriel Santos


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0001-image-dired--Add-extra-keybinds-for-navigation.patch
Content-Description: [PATCH] image-dired: Add extra keybinds for navigation

From 8f7a1234ce7642f587e435347bf7ba22b397ce18 Mon Sep 17 00:00:00 2001
From: Gabriel Santos <gabrielsantosdesouza@HIDDEN>
Date: Mon, 6 Jan 2025 16:56:31 -0300
Subject: [PATCH] image-dired: Add extra keybinds for navigation

* lisp/image/image-dired.el (image-dired-thumbnail-mode-map):
Bind previously unused keys for alternative navigation.
---
 lisp/image/image-dired.el | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el
index 71c272e4388..b35199c60d4 100644
--- a/lisp/image/image-dired.el
+++ b/lisp/image/image-dired.el
@@ -944,6 +944,15 @@ You probably want to use this together with
 
 (defvar-keymap image-dired-thumbnail-mode-map
   :doc "Keymap for `image-dired-thumbnail-mode'."
+
+  ;; Regular navigation
+  "f"          #'image-dired-forward-image
+  "b"          #'image-dired-backward-image
+  "n"          #'image-dired-next-line
+  "p"          #'image-dired-previous-line
+  "a"          #'image-dired-move-beginning-of-line
+  "e"          #'image-dired-move-end-of-line
+
   "d"          #'image-dired-flag-thumb-original-file
   "<delete>"   #'image-dired-flag-thumb-original-file
   "m"          #'image-dired-mark-thumb-original-file
-- 
2.47.1


--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Gabriel Santos <gabrielsantosdesouza@HIDDEN>
Subject: bug#75410: Acknowledgement ([PATCH] image-dired: Add extra
 keybinds for navigation)
Message-ID: <handler.75410.B.173619408431553.ack <at> debbugs.gnu.org>
References: <87o70j4sg3.fsf@HIDDEN>
X-Gnu-PR-Message: ack 75410
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 75410 <at> debbugs.gnu.org
Date: Mon, 06 Jan 2025 20:09:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 75410 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
75410: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75410
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 21 Jan 2025 02:27:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 20 21:27:56 2025
Received: from localhost ([127.0.0.1]:52659 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ta3zg-0004W5-E9
	for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 21:27:56 -0500
Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]:48639)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1ta3ze-0004Vo-Fp
 for control <at> debbugs.gnu.org; Mon, 20 Jan 2025 21:27:54 -0500
Received: by mail-ed1-x533.google.com with SMTP id
 4fb4d7f45d1cf-5d9f0a6adb4so10409036a12.1
 for <control <at> debbugs.gnu.org>; Mon, 20 Jan 2025 18:27:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1737426468; x=1738031268; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=9dxakQjLNH2ZCcEsIr5Vfwnw6rW3yf/QXbMDe9nmUb0=;
 b=XMrvPeiQ9cww4MulycOehV75o+KEccbn5w3/AJLCaCZ4yzvIgPl7f4jdC4JJ7WF0XK
 5+v11UshGc2Qc9zOhmntCdUZfObb6HNExuGvN5AgThQDhNb9/kN06pUMJxXFvcUOixSF
 vL+wzAz/21cyEQ8UVvudXOXZ/kfWNW9xC9/184yrzCm3zUCzAELmkErahTzRmdQNXeBz
 fknseqAA2z4zJw3igu/kwE+UWoEagaNi34jQYoHpoe/aXg6GLuGyhVdrV4NDCI5wcknN
 saWkGzNE1HPFZervO30SY9YSgA6sDigIkqtlVnECoh7c0xFt4fNTeBnfqwHJvOcEaXZ3
 QltQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1737426468; x=1738031268;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=9dxakQjLNH2ZCcEsIr5Vfwnw6rW3yf/QXbMDe9nmUb0=;
 b=YZF7c1roD1gFNbe6QW8ghYC30lZXJk8EKjeSdjQO76m49DwfM9Tz8kT5UAbn84VS+2
 /udkme50M9+9KDL5X6knj+n3LWxhaFQdPXGpuPYbB8XouQrGdnu6GrajKiz9usPBdZDR
 RRA+AvynFCu8LFP4mADf/CUlQ/WBHGwyyOx7qpJhTdtY/COVgVXNyH90SUErsmJl+Jtt
 sHZ2MO1VbrYIODMCtB/o02CsvwJsGcZutbmY/W6pcNEajDGn+Br0AKW7zqlN3NSGB3vl
 hDDAp6oRViHYIPIGZXfti5ANY6K2dSQfI6K8zJanhz16R81z3ymgeaMCL8ruIurA9VzU
 oB4w==
X-Gm-Message-State: AOJu0Yw0g9HtHVWtNan3V1nitN6IgWkDdJsA1/mduqRXvOHbNCHpAqFR
 KGAL+fdcqrosZCsLF6Ii06WRfHixI+O0IvCRoQh9SjCB6V3+Pk2KWcRjWnsfA55i4AcZgrlEBHj
 ykAGFMSMBTJ9qMJ4yWRH7TfJzFtdnBG7e
X-Gm-Gg: ASbGncux6hq1EEZffNU1HxUX4cACjSvqmFBSzrp7YCZ2FCyCSKIE5UCU6d3XVF8MZsH
 L3Ga/d1s+Pvcx9h6OQ9BFcETWgLO/Uerov2KHnFJm/70YgxBWRvUcMQ==
X-Google-Smtp-Source: AGHT+IEhxlPzPzqgrgACPv/dmrmQqTAHNhtUlQXg895YtUgSBqstNsgrUas6/ZU3vp8kC0QcwzM5fU8xkHghKdbuOdA=
X-Received: by 2002:a05:6402:2681:b0:5d0:bcdd:ff9c with SMTP id
 4fb4d7f45d1cf-5db7d2dc2admr14034848a12.2.1737426468226; Mon, 20 Jan 2025
 18:27:48 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Mon, 20 Jan 2025 20:27:47 -0600
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Mon, 20 Jan 2025 20:27:47 -0600
X-Gm-Features: AbW1kvYBZ92vCpLCbNAcv8vNtJPJx5LDnIyZG1vzcFMHTYmA8T4dJ3X8X8mW5bY
Message-ID: <CADwFkmmC_OeYhZZicGgoX3YgqzamJV87_xQcGm6UabCgDpbHQg@HIDDEN>
Subject: control message for bug #75410
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

severity 75410 wishlist
quit

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#75410: [PATCH] image-dired: Add extra keybinds for navigation
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 25 Jan 2025 00:06:01 +0000
Resent-Message-ID: <handler.75410.B75410.173776352514382 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Gabriel Santos <gabrielsantosdesouza@HIDDEN>
Cc: 75410 <at> debbugs.gnu.org
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <87o70j4sg3.fsf@HIDDEN> (Gabriel Santos's message of "Mon,
 06 Jan 2025 17:07:24 -0300")
References: <87o70j4sg3.fsf@HIDDEN>
MIME-Version: 1.0
Date: Fri, 24 Jan 2025 18:05:15 -0600
Message-ID: <CADwFkm=9xk74mPD_xfYn54dMd4zQ2wqySm-vZOGvMnVXNoKhuA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Gabriel Santos <gabrielsantosdesouza@HIDDEN> writes:

> Greetings,
>
> I discovered this mode through a blog post from Sacha:
>
> <https://sachachua.com/blog/2025/01/using-image-dired-to-browse-the-latest-screenshots-from-multiple-directories/>
>
> And I really liked it.

That's good to hear!

> Though, I felt that it was missing something:
>
> Some keybinds for navigation besides C-n and C-p, like those found in
> other read-only modes, such as dired-mode.
>
> This patch binds the following keys in `image-dired-thumbnail-mode-map':
>
> - "f" :: `image-dired-forward-image'
> - "b" :: `image-dired-backward-image'
> - "n" :: `image-dired-next-line'
> - "p" :: `image-dired-previous-line'
> - "a" :: `image-dired-move-beginning-of-line'
> - "e" :: `image-dired-move-end-of-line'
>
> These keys are currently unused in the mode.
>
> Regards,

Thanks for the patch!  I think this is a good idea, and the patch looks
good to go, but such a change should be announced in NEWS, to let people
know about it.

Could you please resubmit with such an addition?

Last modified: Sat, 25 Jan 2025 00:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.