Received: (at 75410) by debbugs.gnu.org; 25 Jan 2025 00:05:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 24 19:05:24 2025 Received: from localhost ([127.0.0.1]:47689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tbTfw-0003ju-IG for submit <at> debbugs.gnu.org; Fri, 24 Jan 2025 19:05:24 -0500 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]:61441) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tbTfu-0003jb-02 for 75410 <at> debbugs.gnu.org; Fri, 24 Jan 2025 19:05:22 -0500 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5d3f28a4fccso3907148a12.2 for <75410 <at> debbugs.gnu.org>; Fri, 24 Jan 2025 16:05:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737763516; x=1738368316; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=MbJteffx08xLtUX78BL1khXJdJEep6W5j9ZnHDtnHa4=; b=kCoETuQIFyKiA+nzR/g3k+U4xhdPuf9Jj/+Z9Tv+n1beouZvkxQkCjQfuqTFZt9Uej HI5sehblIPVrTCNJk9KgZKUMns8Snaa082GOf8AsAB+RhZpWIHfQNI+4/ynmF+l1D1vf hGKA1VxRgebtmRvvpDAc65KDSg/up1Muy65sJXefWEQ6YLvjvxT0gqsy9LnNAeUuQ62Y OmtGR6tHmOqzn7Dz9LRJSLl9rJq/Jd9OtElwpVhYLDC9//LEMiuOnOAtq6CKwGu8rvrw 2cr45Hl3hNT7zmw0hmKQT2PC3LEANwghpus9TDvCqmZdP0ZoNDKF3xPJwy8GDgYuYfrE DRAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737763516; x=1738368316; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MbJteffx08xLtUX78BL1khXJdJEep6W5j9ZnHDtnHa4=; b=PxYyjlI3gIRkxFxEaOOjyQevzWiWXheIXxQ07De+HMtPorVcX74Sa1svSSsX2Tq8TK UU/lfm1DEHpndB+x3fJGF531Q/w0xlEWBmy+H5s9Zfk+OuaojwFfC4vq8Z69nhQUjO8I xsI9bHRFDtAJoNIyBmGLLEbWvRv9YAJLdFQegdPH0QVyxTaRcAOpGHQQTPMNq/4BVhyu mcWoz+SGnFnodHa4Fv/FoDIC/dWrvjAeV252OdBQ2VGj8WhmGmvtiWezux+aFNVDrpFo wrNTnlSKOWHaZaIZ3+i0nGhVdCbO2liAnSklIX7gVRBxoRGkgeaGxbKNkYMDiNb0wKM2 Lk8Q== X-Gm-Message-State: AOJu0Yw79NnJ/ekLFhYkCSp5f70Q3p2KPoD4Z4c3U1Ih7PCzkTcDdQzb cahKq2UADlzeC6O3GsGMQDfQLnAmMhPklzy+F+d2U6/KgjJTk5NYWq8zi0TUSxR8Doij1rXsSdc GdiQOFHIeSmctQwUmZv8swX/S2fU= X-Gm-Gg: ASbGncvVmjax7a4SXPRGFoPNrexbJwpD8YF+fVpuO+BxHscerDRvWLIYLENLb2M7Bod NBVxmmDtX1yJPQFJJcf8O/rwPt4U3ciApOF0K1ZaPFH9vZPqlw8vXJ+zGMclLffk= X-Google-Smtp-Source: AGHT+IHA9hxkCW56J+yLIrxcODVNt2zf8RUZvjkWVUVBOsmA1vhYu7mf9kvtq4O/YbssJaRXZtXRzYbELUHXkAC+occ= X-Received: by 2002:a05:6402:26d5:b0:5dc:2077:8017 with SMTP id 4fb4d7f45d1cf-5dc20778312mr1638776a12.8.1737763515575; Fri, 24 Jan 2025 16:05:15 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 24 Jan 2025 18:05:15 -0600 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <87o70j4sg3.fsf@HIDDEN> (Gabriel Santos's message of "Mon, 06 Jan 2025 17:07:24 -0300") References: <87o70j4sg3.fsf@HIDDEN> MIME-Version: 1.0 Date: Fri, 24 Jan 2025 18:05:15 -0600 X-Gm-Features: AWEUYZn7cvCkJQP8GiMRZ-XucvObk71ktnibmrtytF1iSCrpkhXbtHx4bHIz_bE Message-ID: <CADwFkm=9xk74mPD_xfYn54dMd4zQ2wqySm-vZOGvMnVXNoKhuA@HIDDEN> Subject: Re: bug#75410: [PATCH] image-dired: Add extra keybinds for navigation To: Gabriel Santos <gabrielsantosdesouza@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 75410 Cc: 75410 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Gabriel Santos <gabrielsantosdesouza@HIDDEN> writes: > Greetings, > > I discovered this mode through a blog post from Sacha: > > <https://sachachua.com/blog/2025/01/using-image-dired-to-browse-the-latest-screenshots-from-multiple-directories/> > > And I really liked it. That's good to hear! > Though, I felt that it was missing something: > > Some keybinds for navigation besides C-n and C-p, like those found in > other read-only modes, such as dired-mode. > > This patch binds the following keys in `image-dired-thumbnail-mode-map': > > - "f" :: `image-dired-forward-image' > - "b" :: `image-dired-backward-image' > - "n" :: `image-dired-next-line' > - "p" :: `image-dired-previous-line' > - "a" :: `image-dired-move-beginning-of-line' > - "e" :: `image-dired-move-end-of-line' > > These keys are currently unused in the mode. > > Regards, Thanks for the patch! I think this is a good idea, and the patch looks good to go, but such a change should be announced in NEWS, to let people know about it. Could you please resubmit with such an addition?
bug-gnu-emacs@HIDDEN:bug#75410; Package emacs.
Full text available.Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at submit) by debbugs.gnu.org; 6 Jan 2025 20:08:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 06 15:08:04 2025 Received: from localhost ([127.0.0.1]:40222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tUtON-0008Cr-PS for submit <at> debbugs.gnu.org; Mon, 06 Jan 2025 15:08:04 -0500 Received: from lists.gnu.org ([2001:470:142::17]:55124) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <gabrielsantosdesouza@HIDDEN>) id 1tUtOM-0008C9-6l for submit <at> debbugs.gnu.org; Mon, 06 Jan 2025 15:08:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <gabrielsantosdesouza@HIDDEN>) id 1tUtOD-0000Na-Bn for bug-gnu-emacs@HIDDEN; Mon, 06 Jan 2025 15:07:53 -0500 Received: from layka.disroot.org ([178.21.23.139]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <gabrielsantosdesouza@HIDDEN>) id 1tUtOA-00048g-5A for bug-gnu-emacs@HIDDEN; Mon, 06 Jan 2025 15:07:52 -0500 Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 92E722594B; Mon, 6 Jan 2025 21:07:35 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 3qeRuywPNRtq; Mon, 6 Jan 2025 21:07:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1736194050; bh=yZwXsqjZTDhmDHRD9msZ+CtDnhipEbtTj0M00JKMeoA=; h=From:To:Cc:Subject:Date; b=lmuvco3Eb0X0vzMB9DvVtFdDQJveDomChV8siRQItZo0W5uFMBSOw1EogqR2Ovg5u lkiWgRPI6Uv7iZRj3jk9X1sYIdB9STHdtDPrEk9R98+/45v3A1nUwMv+SY1wLv5U58 wW2ZQ1R4aU8VObgP1KJTMP27n6uIGnZpXfkor2nS5kYwz05Zb3q/XAQdkhtGKfpL8U rWmvYAy1I58WqsdhDH/MaJD4UROpXZUIbS3SfqnWB0GtZtzR8j7eh4zGaHlIPJ474e ueQZFkpA/Vrn94VoP59EBi0bwjPcscBTEnQvdUrzTiJ9jlGiA1Q+LBQOJJyIdIN2MN nEDUi7vLUk+XQ== From: Gabriel Santos <gabrielsantosdesouza@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: [PATCH] image-dired: Add extra keybinds for navigation Date: Mon, 06 Jan 2025 17:07:24 -0300 Message-ID: <87o70j4sg3.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=178.21.23.139; envelope-from=gabrielsantosdesouza@HIDDEN; helo=layka.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Greetings, I discovered this mode through a blog post from Sacha: <https://sachachua.com/blog/2025/01/using-image-dired-to-browse-the-latest-screenshots-from-multiple-directories/> And I really liked it. Though, I felt that it was missing something: Some keybinds for navigation besides C-n and C-p, like those found in other read-only modes, such as dired-mode. This patch binds the following keys in `image-dired-thumbnail-mode-map': - "f" :: `image-dired-forward-image' - "b" :: `image-dired-backward-image' - "n" :: `image-dired-next-line' - "p" :: `image-dired-previous-line' - "a" :: `image-dired-move-beginning-of-line' - "e" :: `image-dired-move-end-of-line' These keys are currently unused in the mode. Regards, -- Gabriel Santos --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-image-dired--Add-extra-keybinds-for-navigation.patch Content-Description: [PATCH] image-dired: Add extra keybinds for navigation From 8f7a1234ce7642f587e435347bf7ba22b397ce18 Mon Sep 17 00:00:00 2001 From: Gabriel Santos <gabrielsantosdesouza@HIDDEN> Date: Mon, 6 Jan 2025 16:56:31 -0300 Subject: [PATCH] image-dired: Add extra keybinds for navigation * lisp/image/image-dired.el (image-dired-thumbnail-mode-map): Bind previously unused keys for alternative navigation. --- lisp/image/image-dired.el | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index 71c272e4388..b35199c60d4 100644 --- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el @@ -944,6 +944,15 @@ You probably want to use this together with (defvar-keymap image-dired-thumbnail-mode-map :doc "Keymap for `image-dired-thumbnail-mode'." + + ;; Regular navigation + "f" #'image-dired-forward-image + "b" #'image-dired-backward-image + "n" #'image-dired-next-line + "p" #'image-dired-previous-line + "a" #'image-dired-move-beginning-of-line + "e" #'image-dired-move-end-of-line + "d" #'image-dired-flag-thumb-original-file "<delete>" #'image-dired-flag-thumb-original-file "m" #'image-dired-mark-thumb-original-file -- 2.47.1 --=-=-=--
Gabriel Santos <gabrielsantosdesouza@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#75410; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.