GNU logs - #75490, boring messages

Message sent to stefankangas@HIDDEN, philipk@HIDDEN, bug-gnu-emacs@HIDDEN:

Subject: bug#75490: 30.0.93; package-upgrade-all - show upgradeable packages
Resent-From: Daniel Mendler <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: stefankangas@HIDDEN, philipk@HIDDEN, bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 11 Jan 2025 11:25:01 +0000
Resent-Message-ID: <handler.75490.B.173659465524895 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 75490 <at> debbugs.gnu.org
Cc: Stefan Kangas <stefankangas@HIDDEN>, Philip Kaludercic <philipk@HIDDEN>
From: Daniel Mendler <mail@HIDDEN>
Date: Sat, 11 Jan 2025 12:23:42 +0100
Message-ID: <87ed19mw5d.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2a01:4f8:c012:9177::1;
 envelope-from=mail@HIDDEN; helo=mail.qxqx.de
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

Currently `package-upgrade-all' displays the number of packages to
upgrade. I suggest to instead show a list of the names of the packages
which are about to be upgraded. This way the user has a better chance to
review the packages before they get installed. Of course the user can
have better control by going via the `list-packages' interface. However
I argue that package.el should not offer UIs and confirmations which
omit relevant information in order to improve security.

The current `package-upgrade-all' confirmation is as follows:

(when (and query
           (not (yes-or-no-p
                 (if (length= upgradeable 1)
                     "One package to upgrade.  Do it? "
                   (format "%s packages to upgrade.  Do it?"
                           (length upgradeable))))))
  (user-error "Upgrade aborted"))

I suggest to replace it with this:

(when (and query
           (not (yes-or-no-p
                 (format
                  "Upgrade %s?"
                  (mapconcat #'symbol-name upgradeable ", ")))))
  (user-error "Upgrade aborted"))

If the list gets too long, a popup window could be used. See also the
related bug#74604 regarding diffs on package upgrade.

Daniel

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Daniel Mendler <mail@HIDDEN>
Subject: bug#75490: Acknowledgement (30.0.93; package-upgrade-all - show
 upgradeable packages)
Message-ID: <handler.75490.B.173659465524895.ack <at> debbugs.gnu.org>
References: <87ed19mw5d.fsf@HIDDEN>
X-Gnu-PR-Message: ack 75490
X-Gnu-PR-Package: emacs
Reply-To: 75490 <at> debbugs.gnu.org
Date: Sat, 11 Jan 2025 11:25:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Stefan Kangas <stefankangas@HIDDEN>, Philip Kaludercic <philipk@posteo=
.net>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 75490 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
75490: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75490
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#75490: 30.0.93; package-upgrade-all - show upgradeable packages
Resent-From: Ship Mints <shipmints@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 11 Jan 2025 11:40:02 +0000
Resent-Message-ID: <handler.75490.B75490.173659556527806 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Daniel Mendler <mail@HIDDEN>
Cc: 75490 <at> debbugs.gnu.org, Philip Kaludercic <philipk@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
References: <87ed19mw5d.fsf@HIDDEN>
In-Reply-To: <87ed19mw5d.fsf@HIDDEN>
From: Ship Mints <shipmints@HIDDEN>
Date: Sat, 11 Jan 2025 06:37:52 -0500
Message-ID: <CAN+1HbrpDN66aY07-nZnqn3ukMBQmPfqa72YFnmt8-Hkp4-djg@HIDDEN>
Content-Type: multipart/alternative; boundary="0000000000003e2e96062b6ca9a5"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--0000000000003e2e96062b6ca9a5
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

package-upgrade, when invoked interactively, does show the list of
upgradeable packages. When combined with a decent minibuffer completion
configuration (like Daniel's Vertico), I can cherry-pick or select all. I
agree package-update-all has a poor interface and I do not use it.
package-upgrade perhaps should also refresh the package list when called
interactively and suppress that behavior with a prefix argument.

In the security vein, package-upgrade commands could also show both the
current version(s) and the target version(s) which would be convenient and
assist people willing to put in the work to actually look at package
sources before they upgrade.

On Sat, Jan 11, 2025 at 6:25=E2=80=AFAM Daniel Mendler via Bug reports for =
GNU
Emacs, the Swiss army knife of text editors <bug-gnu-emacs@HIDDEN> wrote:

> Currently `package-upgrade-all' displays the number of packages to
> upgrade. I suggest to instead show a list of the names of the packages
> which are about to be upgraded. This way the user has a better chance to
> review the packages before they get installed. Of course the user can
> have better control by going via the `list-packages' interface. However
> I argue that package.el should not offer UIs and confirmations which
> omit relevant information in order to improve security.
>
> The current `package-upgrade-all' confirmation is as follows:
>
> (when (and query
>            (not (yes-or-no-p
>                  (if (length=3D upgradeable 1)
>                      "One package to upgrade.  Do it? "
>                    (format "%s packages to upgrade.  Do it?"
>                            (length upgradeable))))))
>   (user-error "Upgrade aborted"))
>
> I suggest to replace it with this:
>
> (when (and query
>            (not (yes-or-no-p
>                  (format
>                   "Upgrade %s?"
>                   (mapconcat #'symbol-name upgradeable ", ")))))
>   (user-error "Upgrade aborted"))
>
> If the list gets too long, a popup window could be used. See also the
> related bug#74604 regarding diffs on package upgrade.
>
> Daniel
>
>
>
>

--0000000000003e2e96062b6ca9a5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:monospac=
e">package-upgrade, when invoked interactively, does show the list of upgra=
deable packages. When combined with a decent minibuffer completion configur=
ation (like Daniel&#39;s Vertico), I can cherry-pick or select all. I agree=
 package-update-all has a poor interface and I do not use=C2=A0it. package-=
upgrade perhaps should also refresh the package list when called interactiv=
ely and suppress that behavior with a prefix argument.</div><div class=3D"g=
mail_default" style=3D"font-family:monospace"><br></div><div class=3D"gmail=
_default" style=3D"font-family:monospace">In the security=C2=A0vein, packag=
e-upgrade commands could also show both the current version(s) and the targ=
et version(s) which would be convenient and assist people willing to put in=
 the work to actually look at package sources before they upgrade.</div></d=
iv><br><div class=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr" cl=
ass=3D"gmail_attr">On Sat, Jan 11, 2025 at 6:25=E2=80=AFAM Daniel Mendler v=
ia Bug reports for GNU Emacs, the Swiss army knife of text editors &lt;<a h=
ref=3D"mailto:bug-gnu-emacs@HIDDEN">bug-gnu-emacs@HIDDEN</a>&gt; wrote:<b=
r></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex=
;border-left:1px solid rgb(204,204,204);padding-left:1ex">Currently `packag=
e-upgrade-all&#39; displays the number of packages to<br>
upgrade. I suggest to instead show a list of the names of the packages<br>
which are about to be upgraded. This way the user has a better chance to<br=
>
review the packages before they get installed. Of course the user can<br>
have better control by going via the `list-packages&#39; interface. However=
<br>
I argue that package.el should not offer UIs and confirmations which<br>
omit relevant information in order to improve security.<br>
<br>
The current `package-upgrade-all&#39; confirmation is as follows:<br>
<br>
(when (and query<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(not (yes-or-no-p<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(if (length=
=3D upgradeable 1)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0&quot;One package to upgrade.=C2=A0 Do it? &quot;<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(forma=
t &quot;%s packages to upgrade.=C2=A0 Do it?&quot;<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0(length upgradeable))))))<br>
=C2=A0 (user-error &quot;Upgrade aborted&quot;))<br>
<br>
I suggest to replace it with this:<br>
<br>
(when (and query<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(not (yes-or-no-p<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(format<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 &quot;Upgrad=
e %s?&quot;<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (mapconcat #=
&#39;symbol-name upgradeable &quot;, &quot;)))))<br>
=C2=A0 (user-error &quot;Upgrade aborted&quot;))<br>
<br>
If the list gets too long, a popup window could be used. See also the<br>
related bug#74604 regarding diffs on package upgrade.<br>
<br>
Daniel<br>
<br>
<br>
<br>
</blockquote></div>

--0000000000003e2e96062b6ca9a5--

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#75490: 30.0.93; package-upgrade-all - show upgradeable packages
Resent-From: Daniel Mendler <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 11 Jan 2025 11:56:02 +0000
Resent-Message-ID: <handler.75490.B75490.173659654331191 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Ship Mints <shipmints@HIDDEN>
Cc: 75490 <at> debbugs.gnu.org, Philip Kaludercic <philipk@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN>
From: Daniel Mendler <mail@HIDDEN>
In-Reply-To: <CAN+1HbrpDN66aY07-nZnqn3ukMBQmPfqa72YFnmt8-Hkp4-djg@HIDDEN>
 (Ship Mints's message of "Sat, 11 Jan 2025 06:37:52 -0500")
References: <87ed19mw5d.fsf@HIDDEN>
 <CAN+1HbrpDN66aY07-nZnqn3ukMBQmPfqa72YFnmt8-Hkp4-djg@HIDDEN>
Date: Sat, 11 Jan 2025 12:55:31 +0100
Message-ID: <87a5bx4lak.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Ship Mints <shipmints@HIDDEN> writes:

> package-upgrade, when invoked interactively, does show the list of
> upgradeable packages. When combined with a decent minibuffer completion
> configuration (like Daniel's Vertico), I can cherry-pick or select
> all.

Yes, multi-action works with Vertico+Embark. However in my Emacs
`package-upgrade' shows more than the list of upgradeable archive
packages, such that I am not using this due to the noise. Also
`embark-act-all' cannot be used.

I just took another look, `package-upgrade' shows upgradeable built-in
packages. I really never want to upgrade them. I don't have package.el
configured to upgrade built-ins, so why are they shown? Is this a bug in
`package-upgrade'?

For this reason I use my own `package-upgrade-all' command variant which
shows me a list of packages, instead of the insufficient confirmation
with only the number of upgradeable packages - this is what this minor
issue is about.

> In the security vein, package-upgrade commands could also show both the
> current version(s) and the target version(s) which would be convenient and
> assist people willing to put in the work to actually look at package
> sources before they upgrade.

Agree. Regarding showing the sources, I've mentioned bug#74604. My
preferred upgrade workflow would go via `package-upgrade-all'. Confirm
the list of packages at the beginning and then for each package confirm
the diff.

Daniel

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#75490: 30.0.93; package-upgrade-all - show upgradeable packages
Resent-From: Daniel Mendler <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 12 Jan 2025 21:01:02 +0000
Resent-Message-ID: <handler.75490.B75490.173671563527079 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75490
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: 75490 <at> debbugs.gnu.org
Cc: Philip Kaludercic <philipk@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN>
Received: via spool by 75490-submit <at> debbugs.gnu.org id=B75490.173671563527079
          (code B ref 75490); Sun, 12 Jan 2025 21:01:02 +0000
Received: (at 75490) by debbugs.gnu.org; 12 Jan 2025 21:00:35 +0000
Received: from localhost ([127.0.0.1]:49293 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tX54V-00072g-FP
	for submit <at> debbugs.gnu.org; Sun, 12 Jan 2025 16:00:35 -0500
Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:37849 helo=mail.qxqx.de)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <mail@HIDDEN>)
 id 1tX54S-00072O-Br
 for 75490 <at> debbugs.gnu.org; Sun, 12 Jan 2025 16:00:33 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date:
 References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:
 Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
 Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:
 List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=YMjdkAnxdABmLbJ59YHTERGLDkK6ZZ9V4IKGXTD2eN8=; b=hNaH8TXZJJlvhMX10d+ktc8BOb
 /CX9NYzsJjp5KfBUJXc4MKe2ETcyMKX3LHZeB6+zoNbk5O5y2gpGu4Otv1ueettWH6vKapgA1N6W5
 lFOk3hjQ4oiBpYGJunyXi0i+zrUceB9zhsVjAx0YmWh4pXv4L3RYg3kIeHf5U36O0u3I=;
From: Daniel Mendler <mail@HIDDEN>
In-Reply-To: <87ed19mw5d.fsf@HIDDEN> (Daniel Mendler's message of
 "Sat, 11 Jan 2025 12:23:42 +0100")
References: <87ed19mw5d.fsf@HIDDEN>
Date: Sun, 12 Jan 2025 22:00:23 +0100
Message-ID: <875xmjhhnc.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--=-=-=
Content-Type: text/plain

I've attached a patch to this mail. The yes-or-no-p function handles
longs strings well, such that this works even if there are many
upgradeable packages.

Daniel


--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
 filename=0001-package-upgrade-all-Show-list-of-upgradeable-package.patch

From ac5662962a94f5457d6d9287161a08b6401c5b83 Mon Sep 17 00:00:00 2001
From: Daniel Mendler <mail@HIDDEN>
Date: Sun, 12 Jan 2025 21:54:43 +0100
Subject: [PATCH] package-upgrade-all: Show list of upgradeable packages

Instead of only displaying the number of upgradeable packages,
display the package names for the user to check.

* lisp/emacs-lisp/package.el (package-upgrade-all): Show list of
upgradeable packages.
---
 lisp/emacs-lisp/package.el | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index b62d026f6ff..450e1dcd00e 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -2322,10 +2322,9 @@ package-upgrade-all
         (message "No packages to upgrade")
       (when (and query
                  (not (yes-or-no-p
-                       (if (length= upgradeable 1)
-                           "One package to upgrade.  Do it? "
-                         (format "%s packages to upgrade.  Do it?"
-                                 (length upgradeable))))))
+                       (format
+                        "Upgrade %s?"
+                        (mapconcat #'symbol-name upgradeable ", ")))))
         (user-error "Upgrade aborted"))
       (mapc #'package-upgrade upgradeable))))
 
-- 
2.45.2


--=-=-=--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#75490: 30.0.93; package-upgrade-all - show upgradeable packages
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 13 Jan 2025 12:25:02 +0000
Resent-Message-ID: <handler.75490.B75490.173677106024240 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75490
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Daniel Mendler <mail@HIDDEN>
Cc: 75490 <at> debbugs.gnu.org, philipk@HIDDEN, stefankangas@HIDDEN
Received: via spool by 75490-submit <at> debbugs.gnu.org id=B75490.173677106024240
          (code B ref 75490); Mon, 13 Jan 2025 12:25:02 +0000
Received: (at 75490) by debbugs.gnu.org; 13 Jan 2025 12:24:20 +0000
Received: from localhost ([127.0.0.1]:50576 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tXJUS-0006It-1G
	for submit <at> debbugs.gnu.org; Mon, 13 Jan 2025 07:24:20 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:55936)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tXJUP-0006Ia-2e
 for 75490 <at> debbugs.gnu.org; Mon, 13 Jan 2025 07:24:17 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1tXJUI-0003Pt-N4; Mon, 13 Jan 2025 07:24:10 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=+pnP3HlW4D2ZUeD4+Fkfm3lwjGUO1TgiOg9kIEACHDo=; b=MejdkaDGTrsx
 MNRusDrrk2uJR/9ej0d1gE2Q0KynlbNK154Dty9uLHP4XONzci95hZWYdEeclPGZSbumfxEubKPAY
 ilPIZ7eo4yHtIQrzOGK88JAL/zwsWzX8ONLV6QOAblt33UG/atDBAeZClGjT/M1W8HU8/dPFxywSq
 ivUBmPCgY+cIgvhNMnb+8cenkmFSWH1I2/Q3XErqkfaeQRi41xZG12B77MQcwy6I7hbJXveE0J9Jn
 1JHXeU/Bi5DsHAtOjODvMOg7XXMz6KWtnkJXuHFXQoF2z5k1iKMonQDtHJgHZeFH8fzMOxsGCzrrn
 QADrT/kZUlXclnsT5sxUWw==;
Date: Mon, 13 Jan 2025 14:24:08 +0200
Message-Id: <86cygqx5p3.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <875xmjhhnc.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN)
References: <87ed19mw5d.fsf@HIDDEN>
 <875xmjhhnc.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: Philip Kaludercic <philipk@HIDDEN>,
>  Stefan Kangas <stefankangas@HIDDEN>
> Date: Sun, 12 Jan 2025 22:00:23 +0100
> From:  Daniel Mendler via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> 
> I've attached a patch to this mail. The yes-or-no-p function handles
> longs strings well, such that this works even if there are many
> upgradeable packages.

Do people happen to upgrade dozens of packages in one go?  If that
happens, won't this change in behavior annoy people?  E.g., if the
list is VERY long, we by default show only its last portion that the
mini-window can accommodate after resizing it to the limit, so the
"Upgrade" part might not be visible at all.

Did you consider making this opt-in?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#75490: 30.0.93; package-upgrade-all - show upgradeable packages
Resent-From: Daniel Mendler <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 13 Jan 2025 12:48:01 +0000
Resent-Message-ID: <handler.75490.B75490.17367724337396 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75490
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 75490 <at> debbugs.gnu.org, philipk@HIDDEN, stefankangas@HIDDEN
Received: via spool by 75490-submit <at> debbugs.gnu.org id=B75490.17367724337396
          (code B ref 75490); Mon, 13 Jan 2025 12:48:01 +0000
Received: (at 75490) by debbugs.gnu.org; 13 Jan 2025 12:47:13 +0000
Received: from localhost ([127.0.0.1]:50619 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tXJqb-0001vE-7X
	for submit <at> debbugs.gnu.org; Mon, 13 Jan 2025 07:47:13 -0500
Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:46079 helo=mail.qxqx.de)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <mail@HIDDEN>)
 id 1tXJqY-0001uv-As
 for 75490 <at> debbugs.gnu.org; Mon, 13 Jan 2025 07:47:11 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date:
 References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:
 Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
 Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:
 List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=XGCHqg1fEth5s2XMtS4uGqrQvCJ6inchIdxxJlDnwHw=; b=jyFMegMMjWsYEcbfH2WFYEp1mp
 fzf7OrYXhkWosj3XfVkl2/qp+MZn+FQ83DGZSE2YtAkBsQXHudzUd4FciSZOiEaZ3zAFizGlTTcA0
 NqL6PhqM+OaaDVuwHENER9Om2QpVP40CBHUVIj4PTiOMUezmuME7WzvyfkpnzQCLJXb4=;
From: Daniel Mendler <mail@HIDDEN>
In-Reply-To: <86cygqx5p3.fsf@HIDDEN> (Eli Zaretskii's message of "Mon, 13 Jan
 2025 14:24:08 +0200")
References: <87ed19mw5d.fsf@HIDDEN>
 <875xmjhhnc.fsf@HIDDEN> <86cygqx5p3.fsf@HIDDEN>
Date: Mon, 13 Jan 2025 13:47:02 +0100
Message-ID: <87ldveg9tl.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

>> Cc: Philip Kaludercic <philipk@HIDDEN>,
>>  Stefan Kangas <stefankangas@HIDDEN>
>> Date: Sun, 12 Jan 2025 22:00:23 +0100
>> From:  Daniel Mendler via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>> 
>> I've attached a patch to this mail. The yes-or-no-p function handles
>> longs strings well, such that this works even if there are many
>> upgradeable packages.
>
> Do people happen to upgrade dozens of packages in one go?  If that
> happens, won't this change in behavior annoy people?  E.g., if the
> list is VERY long, we by default show only its last portion that the
> mini-window can accommodate after resizing it to the limit, so the
> "Upgrade" part might not be visible at all.
>
> Did you consider making this opt-in?

We can make this opt-in if this is preferred. Another option would be to
automatically show a longer list in a larger separate window. But in my
tests it worked well with yes-or-no-p alone despite a long list of
package names.

Daniel

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#75490: 30.0.93; package-upgrade-all - show upgradeable packages
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 13 Jan 2025 13:33:01 +0000
Resent-Message-ID: <handler.75490.B75490.173677515415119 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75490
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Daniel Mendler <mail@HIDDEN>
Cc: 75490 <at> debbugs.gnu.org, philipk@HIDDEN, stefankangas@HIDDEN
Received: via spool by 75490-submit <at> debbugs.gnu.org id=B75490.173677515415119
          (code B ref 75490); Mon, 13 Jan 2025 13:33:01 +0000
Received: (at 75490) by debbugs.gnu.org; 13 Jan 2025 13:32:34 +0000
Received: from localhost ([127.0.0.1]:50697 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tXKYS-0003vl-TM
	for submit <at> debbugs.gnu.org; Mon, 13 Jan 2025 08:32:33 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:53614)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tXKYP-0003vX-G7
 for 75490 <at> debbugs.gnu.org; Mon, 13 Jan 2025 08:32:30 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1tXKYJ-0004Q5-Fq; Mon, 13 Jan 2025 08:32:23 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=Ynwk7w9OB2YQDV80QwH3Lm6VowBykI/kQsV4IJZObL8=; b=NE75kf99Vfyo
 F/ncfOZJjppOjyKGr4w/5vRCInbJIHwnlwfK6lS3cDY2w+tJWrkVuMR2G/e3tS/o9odhg57iupg8Y
 xtjCeNjzagadmZ9wzAHt89y78snUJ71YegJYrnRWXvFoJWPKCqi1sb2+wPFUbrJfQIyZDsozOHu50
 TlPmawLHFZgAKUMtnsdVmzpaJAwDkW8HkPAyTQD5Nbmw1fZbSVDl2m/fu1bDjoro8FOdoHmP8XAXm
 4VeRFk5Sv2zmisqr39ICdEknJIvr3YS1YC5Snq4Wvx3imWv2733TpmmODvk4g4MjzidCfx3GNP/9f
 EjMmjKYfXWi+WkoLAO+qUg==;
Date: Mon, 13 Jan 2025 15:32:03 +0200
Message-Id: <86tta2vnzg.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87ldveg9tl.fsf@HIDDEN> (message from Daniel Mendler
 on Mon, 13 Jan 2025 13:47:02 +0100)
References: <87ed19mw5d.fsf@HIDDEN>
 <875xmjhhnc.fsf@HIDDEN> <86cygqx5p3.fsf@HIDDEN>
 <87ldveg9tl.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Daniel Mendler <mail@HIDDEN>
> Cc: 75490 <at> debbugs.gnu.org,  philipk@HIDDEN,  stefankangas@HIDDEN
> Date: Mon, 13 Jan 2025 13:47:02 +0100
> 
> Eli Zaretskii <eliz@HIDDEN> writes:
> 
> >> Cc: Philip Kaludercic <philipk@HIDDEN>,
> >>  Stefan Kangas <stefankangas@HIDDEN>
> >> Date: Sun, 12 Jan 2025 22:00:23 +0100
> >> From:  Daniel Mendler via "Bug reports for GNU Emacs,
> >>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> >> 
> >> I've attached a patch to this mail. The yes-or-no-p function handles
> >> longs strings well, such that this works even if there are many
> >> upgradeable packages.
> >
> > Do people happen to upgrade dozens of packages in one go?  If that
> > happens, won't this change in behavior annoy people?  E.g., if the
> > list is VERY long, we by default show only its last portion that the
> > mini-window can accommodate after resizing it to the limit, so the
> > "Upgrade" part might not be visible at all.
> >
> > Did you consider making this opt-in?
> 
> We can make this opt-in if this is preferred.

I think I'd prefer that, but let's see what others think.

Philip, WDYT?

> Another option would be to automatically show a longer list in a
> larger separate window. But in my tests it worked well with
> yes-or-no-p alone despite a long list of package names.

I think we should indeed pop up a buffer, since the mini-window is
limited in how much it can show conveniently.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#75490: 30.0.93; package-upgrade-all - show upgradeable packages
Resent-From: Philip Kaludercic <philipk@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 13 Jan 2025 13:51:01 +0000
Resent-Message-ID: <handler.75490.B75490.173677625718361 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75490
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 75490 <at> debbugs.gnu.org, Daniel Mendler <mail@HIDDEN>, stefankangas@HIDDEN
Received: via spool by 75490-submit <at> debbugs.gnu.org id=B75490.173677625718361
          (code B ref 75490); Mon, 13 Jan 2025 13:51:01 +0000
Received: (at 75490) by debbugs.gnu.org; 13 Jan 2025 13:50:57 +0000
Received: from localhost ([127.0.0.1]:50729 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tXKqG-0004m5-Ux
	for submit <at> debbugs.gnu.org; Mon, 13 Jan 2025 08:50:57 -0500
Received: from mout01.posteo.de ([185.67.36.65]:51289)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <philipk@HIDDEN>)
 id 1tXKqC-0004ln-Rm
 for 75490 <at> debbugs.gnu.org; Mon, 13 Jan 2025 08:50:54 -0500
Received: from submission (posteo.de [185.67.36.169]) 
 by mout01.posteo.de (Postfix) with ESMTPS id E4496240027
 for <75490 <at> debbugs.gnu.org>; Mon, 13 Jan 2025 14:50:46 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1736776246; bh=+JegosujENHCdnulVjHG0wVFhoMVfXRsSCkqxFsVC74=;
 h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version:
 Content-Type:From;
 b=BirZq3iHpqSYzmjiySe/zGpNRhLrIvs+lugOkiQCCurHoPmp0Rauepj97+GxbLmhJ
 Gqj3dXtop+eu9YC2tWZTz275wH7pSrxYn6kmIDl2xS4zGAoMbLVz6VqWWgbCjuJZvD
 MLT/ElkQnOu7LqNfOH6KdYlTOB6gM4rYIWNcKeq0+qUX2DXHs/oDujqkFlq154h4Hy
 9/lc9Hre1R5sEwej/RoptjqPfac91cGr2v5GARE6RVip1gc+DKiuGgK/rIYJV3wHBL
 b7ZDzjt8v9HlRME93hh7l2YoxlUn1Eqk642pZczd+Kkqwprlzn3Y6vW2N8Cj/+63xU
 TbwNjm8VIAaHQ==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4YWtv84LpXz6tw6;
 Mon, 13 Jan 2025 14:50:44 +0100 (CET)
From: Philip Kaludercic <philipk@HIDDEN>
In-Reply-To: <86tta2vnzg.fsf@HIDDEN> (Eli Zaretskii's message of "Mon, 13 Jan
 2025 15:32:03 +0200")
References: <87ed19mw5d.fsf@HIDDEN>
 <875xmjhhnc.fsf@HIDDEN> <86cygqx5p3.fsf@HIDDEN>
 <87ldveg9tl.fsf@HIDDEN> <86tta2vnzg.fsf@HIDDEN>
Autocrypt: addr=philipk@HIDDEN; keydata=
 mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo
 aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0
 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI
 BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0
 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB
 BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE
 Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK
 NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof
 z4oM
OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66;
 url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66";
 preference=signencrypt
Date: Mon, 13 Jan 2025 13:50:44 +0000
Message-ID: <87zfjuvn4b.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Eli Zaretskii <eliz@HIDDEN> writes:

>> From: Daniel Mendler <mail@HIDDEN>
>> Cc: 75490 <at> debbugs.gnu.org,  philipk@HIDDEN,  stefankangas@HIDDEN
>> Date: Mon, 13 Jan 2025 13:47:02 +0100
>> 
>> Eli Zaretskii <eliz@HIDDEN> writes:
>> 
>> >> Cc: Philip Kaludercic <philipk@HIDDEN>,
>> >>  Stefan Kangas <stefankangas@HIDDEN>
>> >> Date: Sun, 12 Jan 2025 22:00:23 +0100
>> >> From:  Daniel Mendler via "Bug reports for GNU Emacs,
>> >>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>> >> 
>> >> I've attached a patch to this mail. The yes-or-no-p function handles
>> >> longs strings well, such that this works even if there are many
>> >> upgradeable packages.
>> >
>> > Do people happen to upgrade dozens of packages in one go?  If that
>> > happens, won't this change in behavior annoy people?  E.g., if the
>> > list is VERY long, we by default show only its last portion that the
>> > mini-window can accommodate after resizing it to the limit, so the
>> > "Upgrade" part might not be visible at all.
>> >
>> > Did you consider making this opt-in?
>> 
>> We can make this opt-in if this is preferred.
>
> I think I'd prefer that, but let's see what others think.
>
> Philip, WDYT?
>
>> Another option would be to automatically show a longer list in a
>> larger separate window. But in my tests it worked well with
>> yes-or-no-p alone despite a long list of package names.
>
> I think we should indeed pop up a buffer, since the mini-window is
> limited in how much it can show conveniently.

I am a bit short on time to review this right now, but I agree that a
pop-up buffer seems like a better option.  Resizing the minibuffer can
get annoying and difficult to keep an overview, whereas a little table
with an overview of the changes seems more approachable.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#75490: 30.0.93; package-upgrade-all - show upgradeable packages
Resent-From: Daniel Mendler <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 16 Jan 2025 12:49:02 +0000
Resent-Message-ID: <handler.75490.B75490.173703173012422 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75490
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Philip Kaludercic <philipk@HIDDEN>
Cc: 75490 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, stefankangas@HIDDEN
Received: via spool by 75490-submit <at> debbugs.gnu.org id=B75490.173703173012422
          (code B ref 75490); Thu, 16 Jan 2025 12:49:02 +0000
Received: (at 75490) by debbugs.gnu.org; 16 Jan 2025 12:48:50 +0000
Received: from localhost ([127.0.0.1]:60386 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tYPIn-0003EH-Rr
	for submit <at> debbugs.gnu.org; Thu, 16 Jan 2025 07:48:50 -0500
Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:59963 helo=mail.qxqx.de)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <mail@HIDDEN>)
 id 1tYPIk-0003Dy-UU
 for 75490 <at> debbugs.gnu.org; Thu, 16 Jan 2025 07:48:48 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date:
 References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:
 Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
 Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:
 List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=ImXv97XBX49C3VTvay2AnADAlR+Y0QTttYHqEiMLO3o=; b=DjUnNDW5itYzo42C6oTuRvyEz9
 7T522Vt5ZhBphwyHJGB/2zhuwFTW7U8BfeKKxjNMO0xZ811CtPqU9803WvXu+GiJWxmkTzozLpNEu
 gigyrs+XdYjwzb9alKKvCk1xqMGxJTzU54evRqbEysvMNbhCd+j2L3L8hd9J6h54pcEY=;
From: Daniel Mendler <mail@HIDDEN>
In-Reply-To: <87zfjuvn4b.fsf@HIDDEN> (Philip Kaludercic's message of "Mon, 
 13 Jan 2025 13:50:44 +0000")
References: <87ed19mw5d.fsf@HIDDEN>
 <875xmjhhnc.fsf@HIDDEN> <86cygqx5p3.fsf@HIDDEN>
 <87ldveg9tl.fsf@HIDDEN> <86tta2vnzg.fsf@HIDDEN>
 <87zfjuvn4b.fsf@HIDDEN>
Date: Thu, 16 Jan 2025 13:48:39 +0100
Message-ID: <87ed12lyag.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Philip Kaludercic <philipk@HIDDEN> writes:

>>> Another option would be to automatically show a longer list in a
>>> larger separate window. But in my tests it worked well with
>>> yes-or-no-p alone despite a long list of package names.
>>
>> I think we should indeed pop up a buffer, since the mini-window is
>> limited in how much it can show conveniently.
>
> I am a bit short on time to review this right now, but I agree that a
> pop-up buffer seems like a better option.  Resizing the minibuffer can
> get annoying and difficult to keep an overview, whereas a little table
> with an overview of the changes seems more approachable.

Agree. It is a bit unfortunate that there isn't a helper function for
such prompts with a popup window. Such a popup appears at least in
Dired/Ibuffer when deleting/killing multiple files/buffers. Could be
that there are even more instances. Might be good to extract the common
functionality?

Daniel

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#75490: 30.0.93; package-upgrade-all - show upgradeable packages
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 24 Jan 2025 23:59:01 +0000
Resent-Message-ID: <handler.75490.B75490.173776313312838 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75490
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Daniel Mendler <mail@HIDDEN>, Philip Kaludercic <philipk@HIDDEN>
Cc: 75490 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>
Received: via spool by 75490-submit <at> debbugs.gnu.org id=B75490.173776313312838
          (code B ref 75490); Fri, 24 Jan 2025 23:59:01 +0000
Received: (at 75490) by debbugs.gnu.org; 24 Jan 2025 23:58:53 +0000
Received: from localhost ([127.0.0.1]:47671 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tbTZd-0003L0-8Q
	for submit <at> debbugs.gnu.org; Fri, 24 Jan 2025 18:58:53 -0500
Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]:61673)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tbTZa-0003Kh-OY
 for 75490 <at> debbugs.gnu.org; Fri, 24 Jan 2025 18:58:51 -0500
Received: by mail-ej1-x631.google.com with SMTP id
 a640c23a62f3a-aa684b6d9c7so471137866b.2
 for <75490 <at> debbugs.gnu.org>; Fri, 24 Jan 2025 15:58:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1737763125; x=1738367925; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=c3JN0KXToZPJy5mhrenp7VZaqq2+UlgIZwkmP/qc4TI=;
 b=MQmm0/hPpbRxJPHQLovUTJfAYlfK/6wREyw0tAUkpyj72T5RAb7elZHCBNKm1SIm5U
 DhcXx3kSRswAD4xDeHhlQOZKIiL2GB4U01oPYbdrDmLr6Mt+WM507yXk9priYbyUkkmx
 dVvKzv3mnhwGWdR6Y4oR6muGirC6Y9DzP0wA5CQOqQnNlXX+wxYUaxU4IxDuNXTYlWNe
 kF9DTHIVco4mTS7a82AuyopTZgijEi6i+SsX6lKfoLY8p0uvGwbY5mfm2dUz840UuGq9
 /2TkZcf6wxgIkKJ88A8rQ2yuoAdsx8PqIRiTPLF1EMlfhu5GGKOuGSH2QMSLe8pCvBBS
 mdgQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1737763125; x=1738367925;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=c3JN0KXToZPJy5mhrenp7VZaqq2+UlgIZwkmP/qc4TI=;
 b=lR7ds00D8eThF9RMvd/bDX/5oJU+dBmPjf9ONJpjW6lVpCvkyRQpsG5p++LIJNhUb0
 nHgIKRitwBPEv2Q9YeiS/eUhM/d9UNjdKYCx3QrDU92YD7sgQyCzPMfyKJMkfP+ffLzK
 YdLbmMBtcArcCShW5CYSpz1PTq09j9ur0O8+IPYGyyu/e8wkMtChnpuGXDd/0EYJpdSg
 NrAoZ1f9ngLFFmJSafh5j6Jeep4UgIk1R4fzNKlMD2AxtN7EtzZAXMia1mVXQYxl8sab
 BGJUQ8DbPPQzk5koLkP+tUlOwn+hMAb61XsYsyVFO1h9sNWGhbwyfVRy7//HOsL25QUM
 2y5g==
X-Forwarded-Encrypted: i=1;
 AJvYcCX8MdCO1S/Xa4m98AdqI+YViLxrgO1WpcahPikWvF53t/KNmxMULclHo5JoVkM2vGA0+kvoaw==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YzDTRsJCoVakuBcE26x50HGcdDytyHpDEL4UYFYTcn9x2/2QoDl
 UEqAL1jsclHLFqy/7f0jjVK3H5ZOYe5rIvThnQNuIZQzQoSUfPJpQqkepqSClzWoE45Lq16XfrC
 mJnk5V9m+zEy+7owFFngluupz9uM=
X-Gm-Gg: ASbGnctfA8b2lU7QhcXyqtVl/kgYK2MXXARt1IDTKdi+FdYk51SwT6i0MtYH3PYSvl3
 N76WdAa55uq9SWTS++mUcEAEW/8NT4CtDtfpVR0nXm5JGBaNssacIqor5f+giTcM=
X-Google-Smtp-Source: AGHT+IG8TCkejjob1ZHHgxe361DnxXL+V9Xc0UVLKPmSRAFK4QFZD1LRsPX6r/3Ip2lTdlcvlGRj5i4dt2WrZ/6ZRQo=
X-Received: by 2002:a17:907:8691:b0:aa6:7470:8efe with SMTP id
 a640c23a62f3a-ab38b10cf47mr2399945466b.13.1737763124490; Fri, 24 Jan 2025
 15:58:44 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Fri, 24 Jan 2025 17:58:44 -0600
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <87ed12lyag.fsf@HIDDEN>
References: <87ed19mw5d.fsf@HIDDEN>
 <875xmjhhnc.fsf@HIDDEN>
 <86cygqx5p3.fsf@HIDDEN> <87ldveg9tl.fsf@HIDDEN>
 <86tta2vnzg.fsf@HIDDEN> <87zfjuvn4b.fsf@HIDDEN>
 <87ed12lyag.fsf@HIDDEN>
MIME-Version: 1.0
Date: Fri, 24 Jan 2025 17:58:44 -0600
X-Gm-Features: AWEUYZkgQDc40Z3HxMFzKYQUfoyv7z9pClObPqrZnnbngyvVrnia8ei11jO1dXM
Message-ID: <CADwFkmnD+RHmCY=X2jo9vdnGqG=g7a9R6Tx70s-QvW276J-w8A@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Daniel Mendler <mail@HIDDEN> writes:

> Philip Kaludercic <philipk@HIDDEN> writes:
>
>>>> Another option would be to automatically show a longer list in a
>>>> larger separate window. But in my tests it worked well with
>>>> yes-or-no-p alone despite a long list of package names.
>>>
>>> I think we should indeed pop up a buffer, since the mini-window is
>>> limited in how much it can show conveniently.
>>
>> I am a bit short on time to review this right now, but I agree that a
>> pop-up buffer seems like a better option.  Resizing the minibuffer can
>> get annoying and difficult to keep an overview, whereas a little table
>> with an overview of the changes seems more approachable.
>
> Agree. It is a bit unfortunate that there isn't a helper function for
> such prompts with a popup window. Such a popup appears at least in
> Dired/Ibuffer when deleting/killing multiple files/buffers. Could be
> that there are even more instances. Might be good to extract the common
> functionality?

+1 on using a buffer for this (when I upgrade, I do 50+ packages in one
go), and on extracting the common functionality (because I've needed it
myself in the past and had to reimplement).

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 2 Mar 2025 04:07:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 01 23:07:21 2025
Received: from localhost ([127.0.0.1]:49549 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1toabo-00048p-UU
	for submit <at> debbugs.gnu.org; Sat, 01 Mar 2025 23:07:21 -0500
Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]:51607)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1toabm-00048H-QM
 for control <at> debbugs.gnu.org; Sat, 01 Mar 2025 23:07:19 -0500
Received: by mail-ej1-x630.google.com with SMTP id
 a640c23a62f3a-abbd96bef64so541665766b.3
 for <control <at> debbugs.gnu.org>; Sat, 01 Mar 2025 20:07:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1740888433; x=1741493233; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=4YOvRPUtblLFfTVkHfrIN5cOv2lIaWC0TmWERK54YH8=;
 b=g8ucmg3RIv1mj9XtEnWLcTQt4hOH7PyL9KTDRae20h5oS9d5MNCeLqlKBWHOC9pbWE
 1Oe76x7H3iJUC4T4wzURMjCVHnHRcweheqptUljYZS4qwYll113niDowwDLb0kIi1Zz6
 41ngSUGCwbIr1ebfnADLLhus7aNFzvecD3G6BvGnArc5EuTT4GqV1KGgwXjuu6XJkfZk
 NtDvOkL4wKoLnVJXHP3jojOgNQfdpUha9FJQ/eiNavV5V959VdMAdebaBFSkyFkUbIQV
 maoqefcc6gqxauxzSYj6BMo/l0CHHTc31WH0h+KcXUs/Rnv6/KUncJ6OuEWIQZTFk4+o
 374A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1740888433; x=1741493233;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=4YOvRPUtblLFfTVkHfrIN5cOv2lIaWC0TmWERK54YH8=;
 b=bs55aVBXpE27ubw8EhGkpSZLZ82r6Z1E+1XOBHQv4HM9XKvHX/9ufC5lhZRjUoiw89
 fj7Fms890g4eiXy9cv/rUFt1c0oPdoonizfJGA7zg12NfVdtzeESuh2dLPHBbnIOU8Gx
 0s9hcfh7OnSsmtiWg7fAEbhUuykZy47DsSEzXsz8XJf0y/JUomZiYOBGrfPnIY4H1L4c
 oOPIuxPDd9dhIkJyj9Y3RacUBZE69hbtLR28qL+3bABvQ1waFesOaCAwtocZ08usH48R
 /klz+l14jOiujp6RtIleJMENm87t9DTZ9gAg6Tgd+UhsF4o0gbN8s5cewcxjwOQcH9vh
 7Dvg==
X-Gm-Message-State: AOJu0YxXyncT69Ww7ZcaJcRcb687DOUMoedMj0/avI93yrTEmqFgS5EC
 hNVLsXZrdU2sUFl16/L174VS0c5SDbS+moZXqdPAFX3KdpGtOsV+BCb66rx9/ibn5PAC8fbcHvI
 w80HZFWrRMFtEZ7xY9aztltTlZ0CRGsAPaKk=
X-Gm-Gg: ASbGnctzZz3EbaP1lEpBzRkZ4Or3hdyu2sT4mHU2oY1n1t/aoZTB/hqFEGOIqCuOM/a
 RNgXO2lJdTQ/GuD96n9BM58izv87dkZ9jaePd4ujpaRF/iSyVTjbmz1xSvrF/S6GJvq91tpwSQm
 tk1v9e3mGoBO8k9RCZpleJ+GbaAA==
X-Google-Smtp-Source: AGHT+IFj9wDjqAOGQTQuiG4a6bXPLY+C7py5YXwB//N6RzvnQdT1E86gXZGcMkgOqxcK6XKfr4b5j1pH1bAa3bQ08L0=
X-Received: by 2002:a17:907:d26:b0:abf:5266:6542 with SMTP id
 a640c23a62f3a-abf526670b7mr556347366b.55.1740888432665; Sat, 01 Mar 2025
 20:07:12 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sun, 2 Mar 2025 04:07:12 +0000
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Sun, 2 Mar 2025 04:07:12 +0000
X-Gm-Features: AQ5f1JqBFXQLOWYXec6zw8gl_Pa-QayFunFI2M0tJFxgirvUxWZ1sL9NHw8uwy0
Message-ID: <CADwFkmkigO8pydNBJ-dHB5DPVecrPVDaZFMZNZacO5WATPyEsw@HIDDEN>
Subject: control message for bug #75490
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

severity 75490 wishlist
quit

Last modified: Sun, 2 Mar 2025 04:15:03 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.