Received: (at 75490) by debbugs.gnu.org; 13 Jan 2025 12:24:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 13 07:24:20 2025 Received: from localhost ([127.0.0.1]:50576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tXJUS-0006It-1G for submit <at> debbugs.gnu.org; Mon, 13 Jan 2025 07:24:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55936) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tXJUP-0006Ia-2e for 75490 <at> debbugs.gnu.org; Mon, 13 Jan 2025 07:24:17 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tXJUI-0003Pt-N4; Mon, 13 Jan 2025 07:24:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+pnP3HlW4D2ZUeD4+Fkfm3lwjGUO1TgiOg9kIEACHDo=; b=MejdkaDGTrsx MNRusDrrk2uJR/9ej0d1gE2Q0KynlbNK154Dty9uLHP4XONzci95hZWYdEeclPGZSbumfxEubKPAY ilPIZ7eo4yHtIQrzOGK88JAL/zwsWzX8ONLV6QOAblt33UG/atDBAeZClGjT/M1W8HU8/dPFxywSq ivUBmPCgY+cIgvhNMnb+8cenkmFSWH1I2/Q3XErqkfaeQRi41xZG12B77MQcwy6I7hbJXveE0J9Jn 1JHXeU/Bi5DsHAtOjODvMOg7XXMz6KWtnkJXuHFXQoF2z5k1iKMonQDtHJgHZeFH8fzMOxsGCzrrn QADrT/kZUlXclnsT5sxUWw==; Date: Mon, 13 Jan 2025 14:24:08 +0200 Message-Id: <86cygqx5p3.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Daniel Mendler <mail@HIDDEN> In-Reply-To: <875xmjhhnc.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN) Subject: Re: bug#75490: 30.0.93; package-upgrade-all - show upgradeable packages References: <87ed19mw5d.fsf@HIDDEN> <875xmjhhnc.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75490 Cc: 75490 <at> debbugs.gnu.org, philipk@HIDDEN, stefankangas@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: Philip Kaludercic <philipk@HIDDEN>, > Stefan Kangas <stefankangas@HIDDEN> > Date: Sun, 12 Jan 2025 22:00:23 +0100 > From: Daniel Mendler via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > I've attached a patch to this mail. The yes-or-no-p function handles > longs strings well, such that this works even if there are many > upgradeable packages. Do people happen to upgrade dozens of packages in one go? If that happens, won't this change in behavior annoy people? E.g., if the list is VERY long, we by default show only its last portion that the mini-window can accommodate after resizing it to the limit, so the "Upgrade" part might not be visible at all. Did you consider making this opt-in?
bug-gnu-emacs@HIDDEN:bug#75490; Package emacs.
Full text available.
Received: (at 75490) by debbugs.gnu.org; 12 Jan 2025 21:00:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 12 16:00:35 2025
Received: from localhost ([127.0.0.1]:49293 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tX54V-00072g-FP
for submit <at> debbugs.gnu.org; Sun, 12 Jan 2025 16:00:35 -0500
Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:37849 helo=mail.qxqx.de)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <mail@HIDDEN>)
id 1tX54S-00072O-Br
for 75490 <at> debbugs.gnu.org; Sun, 12 Jan 2025 16:00:33 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date:
References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:
Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:
List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
bh=YMjdkAnxdABmLbJ59YHTERGLDkK6ZZ9V4IKGXTD2eN8=; b=hNaH8TXZJJlvhMX10d+ktc8BOb
/CX9NYzsJjp5KfBUJXc4MKe2ETcyMKX3LHZeB6+zoNbk5O5y2gpGu4Otv1ueettWH6vKapgA1N6W5
lFOk3hjQ4oiBpYGJunyXi0i+zrUceB9zhsVjAx0YmWh4pXv4L3RYg3kIeHf5U36O0u3I=;
From: Daniel Mendler <mail@HIDDEN>
To: 75490 <at> debbugs.gnu.org
Subject: Re: bug#75490: 30.0.93; package-upgrade-all - show upgradeable
packages
In-Reply-To: <87ed19mw5d.fsf@HIDDEN> (Daniel Mendler's message of
"Sat, 11 Jan 2025 12:23:42 +0100")
References: <87ed19mw5d.fsf@HIDDEN>
Date: Sun, 12 Jan 2025 22:00:23 +0100
Message-ID: <875xmjhhnc.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 75490
Cc: Philip Kaludercic <philipk@HIDDEN>,
Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-=-=
Content-Type: text/plain
I've attached a patch to this mail. The yes-or-no-p function handles
longs strings well, such that this works even if there are many
upgradeable packages.
Daniel
--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
filename=0001-package-upgrade-all-Show-list-of-upgradeable-package.patch
From ac5662962a94f5457d6d9287161a08b6401c5b83 Mon Sep 17 00:00:00 2001
From: Daniel Mendler <mail@HIDDEN>
Date: Sun, 12 Jan 2025 21:54:43 +0100
Subject: [PATCH] package-upgrade-all: Show list of upgradeable packages
Instead of only displaying the number of upgradeable packages,
display the package names for the user to check.
* lisp/emacs-lisp/package.el (package-upgrade-all): Show list of
upgradeable packages.
---
lisp/emacs-lisp/package.el | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index b62d026f6ff..450e1dcd00e 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -2322,10 +2322,9 @@ package-upgrade-all
(message "No packages to upgrade")
(when (and query
(not (yes-or-no-p
- (if (length= upgradeable 1)
- "One package to upgrade. Do it? "
- (format "%s packages to upgrade. Do it?"
- (length upgradeable))))))
+ (format
+ "Upgrade %s?"
+ (mapconcat #'symbol-name upgradeable ", ")))))
(user-error "Upgrade aborted"))
(mapc #'package-upgrade upgradeable))))
--
2.45.2
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#75490; Package emacs.
Full text available.Received: (at 75490) by debbugs.gnu.org; 11 Jan 2025 11:55:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 11 06:55:43 2025 Received: from localhost ([127.0.0.1]:41605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tWa5f-000871-Go for submit <at> debbugs.gnu.org; Sat, 11 Jan 2025 06:55:43 -0500 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:40863 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1tWa5c-00086k-P7 for 75490 <at> debbugs.gnu.org; Sat, 11 Jan 2025 06:55:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=2xtMcxRPO3HfJP+7q7t6H6wLta7Upi/P8tn40BaYMMk=; b=tT2HAmPunmjFp/ODUzfB8GZmCw sgSwN6YtL05A6HPhrP3+BPDUu/hCYGMjcraht8sE+5jH2fgslWciHIdzJQROGACkDgWesqsdIaX5f 1Apz11Jiqv6/z72jb0DVY7fHrMy3FIjbLwG/Is0RwU0b+D/jLvPc8uJXP2p8D7bxx4Fs=; From: Daniel Mendler <mail@HIDDEN> To: Ship Mints <shipmints@HIDDEN> Subject: Re: bug#75490: 30.0.93; package-upgrade-all - show upgradeable packages In-Reply-To: <CAN+1HbrpDN66aY07-nZnqn3ukMBQmPfqa72YFnmt8-Hkp4-djg@HIDDEN> (Ship Mints's message of "Sat, 11 Jan 2025 06:37:52 -0500") References: <87ed19mw5d.fsf@HIDDEN> <CAN+1HbrpDN66aY07-nZnqn3ukMBQmPfqa72YFnmt8-Hkp4-djg@HIDDEN> Date: Sat, 11 Jan 2025 12:55:31 +0100 Message-ID: <87a5bx4lak.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75490 Cc: 75490 <at> debbugs.gnu.org, Philip Kaludercic <philipk@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Ship Mints <shipmints@HIDDEN> writes: > package-upgrade, when invoked interactively, does show the list of > upgradeable packages. When combined with a decent minibuffer completion > configuration (like Daniel's Vertico), I can cherry-pick or select > all. Yes, multi-action works with Vertico+Embark. However in my Emacs `package-upgrade' shows more than the list of upgradeable archive packages, such that I am not using this due to the noise. Also `embark-act-all' cannot be used. I just took another look, `package-upgrade' shows upgradeable built-in packages. I really never want to upgrade them. I don't have package.el configured to upgrade built-ins, so why are they shown? Is this a bug in `package-upgrade'? For this reason I use my own `package-upgrade-all' command variant which shows me a list of packages, instead of the insufficient confirmation with only the number of upgradeable packages - this is what this minor issue is about. > In the security vein, package-upgrade commands could also show both the > current version(s) and the target version(s) which would be convenient and > assist people willing to put in the work to actually look at package > sources before they upgrade. Agree. Regarding showing the sources, I've mentioned bug#74604. My preferred upgrade workflow would go via `package-upgrade-all'. Confirm the list of packages at the beginning and then for each package confirm the diff. Daniel
bug-gnu-emacs@HIDDEN:bug#75490; Package emacs.
Full text available.Received: (at 75490) by debbugs.gnu.org; 11 Jan 2025 11:39:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 11 06:39:24 2025 Received: from localhost ([127.0.0.1]:41580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tWZps-0007EP-C7 for submit <at> debbugs.gnu.org; Sat, 11 Jan 2025 06:39:24 -0500 Received: from mail-vs1-xe33.google.com ([2607:f8b0:4864:20::e33]:53348) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>) id 1tWZpp-0007EA-VN for 75490 <at> debbugs.gnu.org; Sat, 11 Jan 2025 06:39:22 -0500 Received: by mail-vs1-xe33.google.com with SMTP id ada2fe7eead31-4afdf096fc5so851571137.2 for <75490 <at> debbugs.gnu.org>; Sat, 11 Jan 2025 03:39:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736595556; x=1737200356; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=WLkZfE/dchw+eg/022fgyO7s+4G1Ut6H+8sUAoIblk8=; b=H7QotTZu4uRbYiH1fRVLrHWbMkPPSWdADNyV/McbosN0aENIRLD9B+IBNt58nGEgvn AeHOYfT60cxnbQWOHNxH88eYE7ZkLRQ55pwadYS+ws0NBTH+6pgq4/xz+js4UCRL7659 BlkoTSw11kruH5e12LB1HM7F7TiWqXg/yn1sl0MgmmEvcmpqvFDrGQXJLPrDQahqk/tP UJ0geU9zK4Jn4SHelFN2ec6jB+iujRdYiQElLYSbQsaPEmyk1OlqZYmSSFfNdSlNAuWa iYwM2joWbUSz4LuT/ZnAnI0uiZGdk6OlmpYnjW2Xd9yAeKiGlYM/GIMP7z8PqnGsxMzE 1qSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736595556; x=1737200356; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WLkZfE/dchw+eg/022fgyO7s+4G1Ut6H+8sUAoIblk8=; b=pCu+nEAb1j3G9D0Df6EQV3YYzVwAg5GZrWB/QEl58Oe+X425sjuYSTcfLsmbYigwvQ a7LUSP/iRj+z8qrmtrM80O7iqxeAvnC8to9rXVy+hAIkyhWfxWo5iS5iaoxIVyQd3Elt QGWB95tEE0Jk9GOy3OEF16VIE9/F9wvs40HBHJtTEQ4M5mNBwTc0ehRcnaM3bIKztFEk RTs/XcS3pm+7KpDpdEU07GWNkNI5c9X+xLOHAK+MNtHILBB8c/XCPwKlkm32Ev4LhIVu 3+TFDJD5au/Ytv8Qu3HIRafYLyxjhBakmoOdU832vQmH6vjxJ4FbVFpdO//4hei8g2ig 3W0Q== X-Gm-Message-State: AOJu0YyjXK71K7s27Fu3JR02N95etb/g9iJSq8wMPdv83fJd2hEd6uxE 8X6hSNzeb7gOqmWoGEoCU0gzNIJ+ckFJpxLtiWDSZci0CATE+eS0JmwaR/VH3zHDN/OHNRJoeUJ XVxO8DDgVdsfTt8WWGfjE82LMAqY= X-Gm-Gg: ASbGncvuMJIrp2gML86I9SQ/mNZfofEBDSSAH97pRBgfNcoQX6X2pZopgI9snYxuYDQ b86LWnbWzLBkHC1BRGGPSeI/yo0cd6Ebk69zj6w== X-Google-Smtp-Source: AGHT+IHXL8SLQWDAKmcu7bJ+uHtdEvObhOHe7GshPlo1ARhKEdi2Mma88KlM7pTG6EeTDLF3jTVBW6mjL8nIpanpvbI= X-Received: by 2002:a05:6102:290f:b0:4af:adb2:5133 with SMTP id ada2fe7eead31-4b3d0ec8f8bmr13602814137.23.1736595556148; Sat, 11 Jan 2025 03:39:16 -0800 (PST) MIME-Version: 1.0 References: <87ed19mw5d.fsf@HIDDEN> In-Reply-To: <87ed19mw5d.fsf@HIDDEN> From: Ship Mints <shipmints@HIDDEN> Date: Sat, 11 Jan 2025 06:37:52 -0500 X-Gm-Features: AbW1kva85cIk5MjYpx6BBhz-9PCBDtztIbMWBuPxKyZrKgxyxKwK4o_wibuA178 Message-ID: <CAN+1HbrpDN66aY07-nZnqn3ukMBQmPfqa72YFnmt8-Hkp4-djg@HIDDEN> Subject: Re: bug#75490: 30.0.93; package-upgrade-all - show upgradeable packages To: Daniel Mendler <mail@HIDDEN> Content-Type: multipart/alternative; boundary="0000000000003e2e96062b6ca9a5" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75490 Cc: 75490 <at> debbugs.gnu.org, Philip Kaludercic <philipk@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --0000000000003e2e96062b6ca9a5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable package-upgrade, when invoked interactively, does show the list of upgradeable packages. When combined with a decent minibuffer completion configuration (like Daniel's Vertico), I can cherry-pick or select all. I agree package-update-all has a poor interface and I do not use it. package-upgrade perhaps should also refresh the package list when called interactively and suppress that behavior with a prefix argument. In the security vein, package-upgrade commands could also show both the current version(s) and the target version(s) which would be convenient and assist people willing to put in the work to actually look at package sources before they upgrade. On Sat, Jan 11, 2025 at 6:25=E2=80=AFAM Daniel Mendler via Bug reports for = GNU Emacs, the Swiss army knife of text editors <bug-gnu-emacs@HIDDEN> wrote: > Currently `package-upgrade-all' displays the number of packages to > upgrade. I suggest to instead show a list of the names of the packages > which are about to be upgraded. This way the user has a better chance to > review the packages before they get installed. Of course the user can > have better control by going via the `list-packages' interface. However > I argue that package.el should not offer UIs and confirmations which > omit relevant information in order to improve security. > > The current `package-upgrade-all' confirmation is as follows: > > (when (and query > (not (yes-or-no-p > (if (length=3D upgradeable 1) > "One package to upgrade. Do it? " > (format "%s packages to upgrade. Do it?" > (length upgradeable)))))) > (user-error "Upgrade aborted")) > > I suggest to replace it with this: > > (when (and query > (not (yes-or-no-p > (format > "Upgrade %s?" > (mapconcat #'symbol-name upgradeable ", "))))) > (user-error "Upgrade aborted")) > > If the list gets too long, a popup window could be used. See also the > related bug#74604 regarding diffs on package upgrade. > > Daniel > > > > --0000000000003e2e96062b6ca9a5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:monospac= e">package-upgrade, when invoked interactively, does show the list of upgra= deable packages. When combined with a decent minibuffer completion configur= ation (like Daniel's Vertico), I can cherry-pick or select all. I agree= package-update-all has a poor interface and I do not use=C2=A0it. package-= upgrade perhaps should also refresh the package list when called interactiv= ely and suppress that behavior with a prefix argument.</div><div class=3D"g= mail_default" style=3D"font-family:monospace"><br></div><div class=3D"gmail= _default" style=3D"font-family:monospace">In the security=C2=A0vein, packag= e-upgrade commands could also show both the current version(s) and the targ= et version(s) which would be convenient and assist people willing to put in= the work to actually look at package sources before they upgrade.</div></d= iv><br><div class=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr" cl= ass=3D"gmail_attr">On Sat, Jan 11, 2025 at 6:25=E2=80=AFAM Daniel Mendler v= ia Bug reports for GNU Emacs, the Swiss army knife of text editors <<a h= ref=3D"mailto:bug-gnu-emacs@HIDDEN">bug-gnu-emacs@HIDDEN</a>> wrote:<b= r></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex= ;border-left:1px solid rgb(204,204,204);padding-left:1ex">Currently `packag= e-upgrade-all' displays the number of packages to<br> upgrade. I suggest to instead show a list of the names of the packages<br> which are about to be upgraded. This way the user has a better chance to<br= > review the packages before they get installed. Of course the user can<br> have better control by going via the `list-packages' interface. However= <br> I argue that package.el should not offer UIs and confirmations which<br> omit relevant information in order to improve security.<br> <br> The current `package-upgrade-all' confirmation is as follows:<br> <br> (when (and query<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(not (yes-or-no-p<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(if (length= =3D upgradeable 1)<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0"One package to upgrade.=C2=A0 Do it? "<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(forma= t "%s packages to upgrade.=C2=A0 Do it?"<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0(length upgradeable))))))<br> =C2=A0 (user-error "Upgrade aborted"))<br> <br> I suggest to replace it with this:<br> <br> (when (and query<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(not (yes-or-no-p<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(format<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "Upgrad= e %s?"<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (mapconcat #= 'symbol-name upgradeable ", ")))))<br> =C2=A0 (user-error "Upgrade aborted"))<br> <br> If the list gets too long, a popup window could be used. See also the<br> related bug#74604 regarding diffs on package upgrade.<br> <br> Daniel<br> <br> <br> <br> </blockquote></div> --0000000000003e2e96062b6ca9a5--
bug-gnu-emacs@HIDDEN:bug#75490; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 11 Jan 2025 11:24:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 11 06:24:15 2025
Received: from localhost ([127.0.0.1]:41554 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tWZbD-0006TT-1m
for submit <at> debbugs.gnu.org; Sat, 11 Jan 2025 06:24:15 -0500
Received: from lists.gnu.org ([2001:470:142::17]:40526)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <mail@HIDDEN>)
id 1tWZbA-0006TC-Kl
for submit <at> debbugs.gnu.org; Sat, 11 Jan 2025 06:24:13 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <mail@HIDDEN>)
id 1tWZb5-00064E-4w
for bug-gnu-emacs@HIDDEN; Sat, 11 Jan 2025 06:24:07 -0500
Received: from server.qxqx.de ([2a01:4f8:c012:9177::1] helo=mail.qxqx.de)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <mail@HIDDEN>)
id 1tWZb2-0008QM-1I
for bug-gnu-emacs@HIDDEN; Sat, 11 Jan 2025 06:24:06 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date:
Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=AcJBh0gp9+epRysRdqy3yfowEgLCbif3MJy9cIoHKow=; b=l1Jy1ghaSEffOiVCPpCQKI3E0D
nBNZPzWEAYwliINgGzRISkIxYza99jCOxcMCeEsxGvhNX2eyZ+mJ/eHldPWRJm9OaoAbyWoPwQAYw
s7D4otd4PiDlg7xHkfX9mglbMuxYbpQZJXGFHerZ5Tl3umi/PqUdmLl3sJTerx4cXmSc=;
From: Daniel Mendler <mail@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 30.0.93; package-upgrade-all - show upgradeable packages
X-Debbugs-Cc: Stefan Kangas <stefankangas@HIDDEN>, Philip Kaludercic
<philipk@HIDDEN>
Date: Sat, 11 Jan 2025 12:23:42 +0100
Message-ID: <87ed19mw5d.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2a01:4f8:c012:9177::1;
envelope-from=mail@HIDDEN; helo=mail.qxqx.de
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)
Currently `package-upgrade-all' displays the number of packages to
upgrade. I suggest to instead show a list of the names of the packages
which are about to be upgraded. This way the user has a better chance to
review the packages before they get installed. Of course the user can
have better control by going via the `list-packages' interface. However
I argue that package.el should not offer UIs and confirmations which
omit relevant information in order to improve security.
The current `package-upgrade-all' confirmation is as follows:
(when (and query
(not (yes-or-no-p
(if (length= upgradeable 1)
"One package to upgrade. Do it? "
(format "%s packages to upgrade. Do it?"
(length upgradeable))))))
(user-error "Upgrade aborted"))
I suggest to replace it with this:
(when (and query
(not (yes-or-no-p
(format
"Upgrade %s?"
(mapconcat #'symbol-name upgradeable ", ")))))
(user-error "Upgrade aborted"))
If the list gets too long, a popup window could be used. See also the
related bug#74604 regarding diffs on package upgrade.
Daniel
Daniel Mendler <mail@HIDDEN>:stefankangas@HIDDEN, philipk@HIDDEN, bug-gnu-emacs@HIDDEN.
Full text available.stefankangas@HIDDEN, philipk@HIDDEN, bug-gnu-emacs@HIDDEN:bug#75490; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.