GNU logs - #76664, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#76664: 31.0.50; behavior of widget-put implemented in Lisp changed compared to C
Resent-From: David Ponce <da_vid@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 01 Mar 2025 17:19:02 +0000
Resent-Message-ID: <handler.76664.B.174084953914067 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 76664 <at> debbugs.gnu.org
Message-ID: <80c43471-6d8c-4466-841a-6dde149eeb92@HIDDEN>
Date: Sat, 1 Mar 2025 18:18:35 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: fr, en-US
From: David Ponce <da_vid@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Received-SPF: pass client-ip=80.12.242.70; envelope-from=da_vid@HIDDEN;
 helo=smtp.smtpout.orange.fr
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

Hello,

Since this commit:

       author	Stefan Kangas <stefankangas@HIDDEN>	
       Fri, 28 Feb 2025 18:28:58 +0100 (18:28 +0100)
       commit	8b659313b83c82cfe09af1638289fccdfc9af23d

       Lift widget functions from C to Lisp

I encounter errors in widgets because the behavior of the Lisp
implementation of `widget-put' changed compared to the C version.

Specifically the C version used to return the passed value, which
is no more the case of the Lisp version.

This trivial patch fixed the issue for me:

diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el
index d6fd1156123..ff6550e852f 100644
--- a/lisp/wid-edit.el
+++ b/lisp/wid-edit.el
@@ -625,7 +625,8 @@ widgetp
  (defun widget-put (widget property value)
    "In WIDGET, set PROPERTY to VALUE.
  The value can later be retrieved with `widget-get'."
-  (setcdr widget (plist-put (cdr widget) property value)))
+  (setcdr widget (plist-put (cdr widget) property value))
+  value)
  
  ;;;###autoload
  (defun widget-get (widget property)


Thanks


In GNU Emacs 31.0.50 (build 9, x86_64-pc-linux-gnu, GTK+ Version
  3.24.43, cairo version 1.18.0) of 2025-03-01
Repository revision: 6a2f6056c5a079a7f3db240171680560a3bd9710
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12014000
System Description: Fedora Linux 40 (KDE Plasma)

Configured using:
  'configure --prefix=/home/dponce --with-native-compilation=no
  PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/usr/lib/pkgconfig'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINERAMA XINPUT2 XPM
XRANDR GTK3 ZLIB

Important settings:
   value of $LC_TIME: fr_FR.utf8
   value of $LANG: fr_FR.UTF-8
   locale-coding-system: utf-8-unix

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: David Ponce <da_vid@HIDDEN>
Subject: bug#76664: Acknowledgement (31.0.50; behavior of widget-put
 implemented in Lisp changed compared to C)
Message-ID: <handler.76664.B.174084953914067.ack <at> debbugs.gnu.org>
References: <80c43471-6d8c-4466-841a-6dde149eeb92@HIDDEN>
X-Gnu-PR-Message: ack 76664
X-Gnu-PR-Package: emacs
Reply-To: 76664 <at> debbugs.gnu.org
Date: Sat, 01 Mar 2025 17:19:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 76664 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
76664: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76664
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Last modified: Sat, 1 Mar 2025 17:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.