GNU bug report logs - #76664
31.0.50; behavior of widget-put implemented in Lisp changed compared to C

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 1 Mar 2025 17:18:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 01 12:18:59 2025
Received: from localhost ([127.0.0.1]:42648 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1toQUM-0003en-Dw
	for submit <at> debbugs.gnu.org; Sat, 01 Mar 2025 12:18:58 -0500
Received: from lists.gnu.org ([2001:470:142::17]:56892)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <da_vid@HIDDEN>) id 1toQUJ-0003eD-OC
 for submit <at> debbugs.gnu.org; Sat, 01 Mar 2025 12:18:57 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <da_vid@HIDDEN>) id 1toQUA-0001nh-PM
 for bug-gnu-emacs@HIDDEN; Sat, 01 Mar 2025 12:18:49 -0500
Received: from smtp-70.smtpout.orange.fr ([80.12.242.70]
 helo=smtp.smtpout.orange.fr)
 by eggs.gnu.org with esmtps (TLS1.2:RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <da_vid@HIDDEN>) id 1toQU7-00082r-Gs
 for bug-gnu-emacs@HIDDEN; Sat, 01 Mar 2025 12:18:46 -0500
Received: from [192.168.1.21] ([90.112.40.65]) by smtp.orange.fr with ESMTPA
 id oQTztSgyzmF02oQU2tUai1; Sat, 01 Mar 2025 18:18:39 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr;
 s=t20230301; t=1740849519;
 bh=s/Pf07LEHMJ5dj+SyV+t5kv2lezwPvDVJNrtRKSH0+c=;
 h=Message-ID:Date:MIME-Version:To:From:Subject;
 b=LAAIWVYoT3T2SZdIoGxwDc/tQQHjuUFsS5sfZftxMlZB0xO9T5hsiNBd0NSGIzJF1
 Kbwm86HDX0KTn8SWX1cND0GJmmdcpHG60DoMbUzLdDBeAX0WDj2LAYIwSAYaOuTz9Y
 5LnMXQocszTTt32cJC1OFi2OKmI98/hGfN4tX5khj0zsjGtm4cQApDqaMJF0byZoyN
 dr8JlnLvQKk6YwAyp1convBAT8gHUe5jt5Us9GWZtDnQeDzQ8rCyjKU40hOG1DhbB+
 0hcmVT66axAqDJiLWplI1bCIpj4TL3IQy4306hLtGSm/KuUhTSpwcFx8vj0indrlIv
 zB1N15ye3jg8A==
X-ME-Helo: [192.168.1.21]
X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI=
X-ME-Date: Sat, 01 Mar 2025 18:18:39 +0100
X-ME-IP: 90.112.40.65
Message-ID: <80c43471-6d8c-4466-841a-6dde149eeb92@HIDDEN>
Date: Sat, 1 Mar 2025 18:18:35 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: fr, en-US
To: bug-gnu-emacs@HIDDEN
From: David Ponce <da_vid@HIDDEN>
Subject: 31.0.50; behavior of widget-put implemented in Lisp changed compared
 to C
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Received-SPF: pass client-ip=80.12.242.70; envelope-from=da_vid@HIDDEN;
 helo=smtp.smtpout.orange.fr
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

Hello,

Since this commit:

       author	Stefan Kangas <stefankangas@HIDDEN>	
       Fri, 28 Feb 2025 18:28:58 +0100 (18:28 +0100)
       commit	8b659313b83c82cfe09af1638289fccdfc9af23d

       Lift widget functions from C to Lisp

I encounter errors in widgets because the behavior of the Lisp
implementation of `widget-put' changed compared to the C version.

Specifically the C version used to return the passed value, which
is no more the case of the Lisp version.

This trivial patch fixed the issue for me:

diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el
index d6fd1156123..ff6550e852f 100644
--- a/lisp/wid-edit.el
+++ b/lisp/wid-edit.el
@@ -625,7 +625,8 @@ widgetp
  (defun widget-put (widget property value)
    "In WIDGET, set PROPERTY to VALUE.
  The value can later be retrieved with `widget-get'."
-  (setcdr widget (plist-put (cdr widget) property value)))
+  (setcdr widget (plist-put (cdr widget) property value))
+  value)
  
  ;;;###autoload
  (defun widget-get (widget property)


Thanks


In GNU Emacs 31.0.50 (build 9, x86_64-pc-linux-gnu, GTK+ Version
  3.24.43, cairo version 1.18.0) of 2025-03-01
Repository revision: 6a2f6056c5a079a7f3db240171680560a3bd9710
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12014000
System Description: Fedora Linux 40 (KDE Plasma)

Configured using:
  'configure --prefix=/home/dponce --with-native-compilation=no
  PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/usr/lib/pkgconfig'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINERAMA XINPUT2 XPM
XRANDR GTK3 ZLIB

Important settings:
   value of $LC_TIME: fr_FR.utf8
   value of $LANG: fr_FR.UTF-8
   locale-coding-system: utf-8-unix