GNU logs - #79913, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#79913: 31.0.50; 68e337e: server--process-filter-1 breaks emacsclient even without empty string arguments
Resent-From: "Yue Yi" <include_yy@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 30 Nov 2025 05:59:01 +0000
Resent-Message-ID: <handler.79913.B.17644823023666 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 79913 <at> debbugs.gnu.org
From: "Yue Yi" <include_yy@HIDDEN>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: base64
Date: Sun, 30 Nov 2025 13:57:55 +0800
Message-ID: <tencent_61E77A27F3F71938BB639E95406524B40807@HIDDEN>
Received-SPF: pass client-ip=203.205.221.192; envelope-from=include_yy@HIDDEN;
 helo=out203-205-221-192.mail.qq.com
X-Spam_score_int: 8
X-Spam_score: 0.8
X-Spam_bar: /
X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
 DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 FROM_EXCESS_BASE64=0.001, HELO_DYNAMIC_IPADDR=1.951,
 RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

SGksIEVtYWNzIG1haW50YWluZXJzLAoKSW4gYSByZWNlbnRseSBjb21waWxlZCBFbWFjcywg
SSBub3RpY2VkIHRoYXQgdGhlIG1hZ2l0LWNvbW1pdCBpbiBNYWdpdAppcyBubyBsb25nZXIg
d29ya2luZy4gSW5zdGVhZCwgaXQgb3V0cHV0cyBhbiAiVW5rbm93biBjb21tYW5kIiBtZXNz
YWdlLgpVc2luZyBncmVwLCBJIHRyYWNlZCB0aGlzIGVycm9yIG1lc3NhZ2UgYmFjayB0byBz
ZXJ2ZXIuZWwuIEkgYWxzbyB0ZXN0ZWQKZW1hY3NjbGllbnQgd2l0aCBhIHNpbXBsZSBhcmd1
bWVudCAoZS5nLiwgZW1hY3NjbGllbnQgMS50eHQpIGFuZCBpdApyZXN1bHRzIGluIHRoZSBz
YW1lIGVycm9yLiAoSSBzaG91bGQgY2xhcmlmeSB0aGF0IEkgYW0gb24gV2luZG93cy4pCgot
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0+ODwtLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tCkBAIC0xMjY3LDggKzEyNjcsMTAgQEAgc2VydmVyLS1w
cm9jZXNzLWZpbHRlci0xCiAJCWFyZ3MtbGVmdCkKIAkgICAgOzsgUmVtb3ZlIHRoaXMgbGlu
ZSBmcm9tIFNUUklORy4KIAkgICAgKHNldHEgc3RyaW5nIChzdWJzdHJpbmcgc3RyaW5nICht
YXRjaC1lbmQgMCkpKQotCSAgICAoc2V0cSBhcmdzLWxlZnQKLQkJICAobWFwY2FyICMnc2Vy
dmVyLXVucXVvdGUtYXJnIChzcGxpdC1zdHJpbmcgcmVxdWVzdCAiICIgdCkpKQorCSAgICAo
Y2wtYXNzZXJ0IChlcXVhbCAoc3Vic3RyaW5nIHJlcXVlc3QgLTEpICIgIikKKwkJICAgICAg
IG5pbCAiZW1hY3NjbGllbnQgcmVxdWVzdCBkaWQgbm90IGVuZCBpbiBTUEMiKQorCSAgICAo
c2V0cSBhcmdzLWxlZnQgKG1hcGNhciAjJ3NlcnZlci11bnF1b3RlLWFyZworCQkJCSAgICAo
bmJ1dGxhc3QgKHNwbGl0LXN0cmluZyByZXF1ZXN0ICIgIikpKSkKIAkgICAgKHdoaWxlIGFy
Z3MtbGVmdAogICAgICAgICAgICAgICAocGNhc2UgKHBvcCBhcmdzLWxlZnQpCiAgICAgICAg
ICAgICAgICAgOzsgLXZlcnNpb24gQ0xJRU5ULVZFUlNJT046IG9ic29sZXRlIGF0IGJpcnRo
LgotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0+ODwtLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCgpDb21taXQgNjhlMzM3ZSBjaGFuZ2VkIHRoZSB1
c2FnZSBvZiBzcGxpdC1zdHJpbmcsIGJ1dCB0aGUgcHJvYmxlbSBpcwp0aGF0IHRoZSBgcmVx
dWVzdCcgdmFyaWFibGUgc3RhcnRzIHdpdGggd2hpdGVzcGFjZS4gVGhpcyBsZWFkcyB0byBh
bgplZmZlY3Qgc2ltaWxhciB0byB0aGUgZm9sbG93aW5nOgoKKHNwbGl0LXN0cmluZyAiIGEg
YiBjICIgIiAiKSA9PiAoIiIgImEiICJiIiAiYyIgIiIpCgpIZXJlIGlzIGEgcG9zc2libGUg
Zml4OgoKLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tPjg8LS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpAQCAtMTI3MCw3ICsxMjcwLDcgQEAKIAkg
ICAgKGNsLWFzc2VydCAoZXF1YWwgKHN1YnN0cmluZyByZXF1ZXN0IC0xKSAiICIpCiAJCSAg
ICAgICBuaWwgImVtYWNzY2xpZW50IHJlcXVlc3QgZGlkIG5vdCBlbmQgaW4gU1BDOiAlUyIg
cmVxdWVzdCkKIAkgICAgKHNldHEgYXJncy1sZWZ0IChtYXBjYXIgIydzZXJ2ZXItdW5xdW90
ZS1hcmcKLQkJCQkgICAgKG5idXRsYXN0IChzcGxpdC1zdHJpbmcgcmVxdWVzdCAiICIpKSkp
CisJCQkJICAgIChzcGxpdC1zdHJpbmcgKHN0cmluZy10cmltIHJlcXVlc3QgIiAiKSkpKQog
CSAgICAod2hpbGUgYXJncy1sZWZ0CiAgICAgICAgICAgICAgIChwY2FzZSAocG9wIGFyZ3Mt
bGVmdCkKICAgICAgICAgICAgICAgICA7OyAtdmVyc2lvbiBDTElFTlQtVkVSU0lPTjogb2Jz
b2xldGUgYXQgYmlydGguCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLT44PC0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KCk9mIGNvdXJzZSwgdGhp
cyBvbmx5IHNvbHZlcyB0aGUgaW1tZWRpYXRlIHByb2JsZW0gSSBhbSBmYWNpbmcsIGFuZApw
ZXJoYXBzIHdlIG5lZWQgYSBiZXR0ZXIgYXBwcm9hY2guCgpSZWdhcmRzLgo=

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: "Yue Yi" <include_yy@HIDDEN>
Subject: bug#79913: Acknowledgement (31.0.50; 68e337e: server--process-filter-1
 breaks emacsclient even without empty string arguments)
Message-ID: <handler.79913.B.17644823023666.ack <at> debbugs.gnu.org>
References: <tencent_61E77A27F3F71938BB639E95406524B40807@HIDDEN>
X-Gnu-PR-Message: ack 79913
X-Gnu-PR-Package: emacs
Reply-To: 79913 <at> debbugs.gnu.org
Date: Sun, 30 Nov 2025 05:59:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 79913 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
79913: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D79913
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#79913: 31.0.50; 68e337e: server--process-filter-1 breaks emacsclient even without empty string arguments
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 30 Nov 2025 07:17:02 +0000
Resent-Message-ID: <handler.79913.B79913.176448701425716 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: "Yue Yi" <include_yy@HIDDEN>, Sean Whitton <spwhitton@HIDDEN>
Cc: 79913 <at> debbugs.gnu.org
Date: Sun, 30 Nov 2025 09:16:41 +0200
Message-Id: <86ldjo56sm.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <tencent_61E77A27F3F71938BB639E95406524B40807@HIDDEN>
 (bug-gnu-emacs@HIDDEN)
References: <tencent_61E77A27F3F71938BB639E95406524B40807@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

merge 79913 79889
thanks

> Date: Sun, 30 Nov 2025 13:57:55 +0800
> From:  "Yue Yi" via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> 
> Hi, Emacs maintainers,
> 
> In a recently compiled Emacs, I noticed that the magit-commit in Magit
> is no longer working. Instead, it outputs an "Unknown command" message.
> Using grep, I traced this error message back to server.el. I also tested
> emacsclient with a simple argument (e.g., emacsclient 1.txt) and it
> results in the same error. (I should clarify that I am on Windows.)
> 
> ------------------------------>8<-------------------------------------------
> @@ -1267,8 +1267,10 @@ server--process-filter-1
>  		args-left)
>  	    ;; Remove this line from STRING.
>  	    (setq string (substring string (match-end 0)))
> -	    (setq args-left
> -		  (mapcar #'server-unquote-arg (split-string request " " t)))
> +	    (cl-assert (equal (substring request -1) " ")
> +		       nil "emacsclient request did not end in SPC")
> +	    (setq args-left (mapcar #'server-unquote-arg
> +				    (nbutlast (split-string request " "))))
>  	    (while args-left
>                (pcase (pop args-left)
>                  ;; -version CLIENT-VERSION: obsolete at birth.
> ------------------------------>8<-------------------------------------------
> 
> Commit 68e337e changed the usage of split-string, but the problem is
> that the `request' variable starts with whitespace. This leads to an
> effect similar to the following:
> 
> (split-string " a b c " " ") => ("" "a" "b" "c" "")
> 
> Here is a possible fix:
> 
> ------------------------------>8<-------------------------------------------
> @@ -1270,7 +1270,7 @@
>  	    (cl-assert (equal (substring request -1) " ")
>  		       nil "emacsclient request did not end in SPC: %S" request)
>  	    (setq args-left (mapcar #'server-unquote-arg
> -				    (nbutlast (split-string request " "))))
> +				    (split-string (string-trim request " "))))
>  	    (while args-left
>                (pcase (pop args-left)
>                  ;; -version CLIENT-VERSION: obsolete at birth.
> ------------------------------>8<-------------------------------------------
> 
> Of course, this only solves the immediate problem I am facing, and
> perhaps we need a better approach.

This is a duplicate of an existing bug#79889, so I'm now merging it.

Sean, would you please look into fixing this ASAP?  Several fixes were
already suggested, but I'm not sure what is the best for the new
support of the empty strings, which triggered this.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 30 Nov 2025 07:16:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 30 02:16:55 2025
Received: from localhost ([127.0.0.1]:36075 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1vPbfy-0006gj-QT
	for submit <at> debbugs.gnu.org; Sun, 30 Nov 2025 02:16:55 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:37628)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>)
 id 1vPbfv-0006gL-LW; Sun, 30 Nov 2025 02:16:52 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1vPbfo-0004d4-JH; Sun, 30 Nov 2025 02:16:45 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=M4ZJff3t5s8JLYAQWoqY6oEegmLdoWKTqwYioIw2VN0=; b=TXowgODUXtqo
 pAzy8WNzXwXNcg7yFRVbmEVBcqjKG5srhSK5cEJxpEdxXc1s4HHSSL2vYIa5blCgOnyjCAOyWMZSD
 j4tC+iylgdST3e6p2ILhvEx/EZzaG1rFJIVXxDnzcYEMc5n5PIAqNHDUFyN/+28ta7OIKrbXVrEQ7
 miTGPPF5IjQd/0Bmg8JDowvAPQ/B06DC8WJ4eIptne3def1q2p0bQU6smuLumBWEhdthW/oMU/V5B
 MAk6bok0LACNp0FkKKugOAdEVnTn4uQIgZkeQ5yhKg8vZXSfE9Nd0fWNDdK+XhhKoXpWxZGpgpHpA
 Pf/n4L0dH4yI7serWiSIJQ==;
Date: Sun, 30 Nov 2025 09:16:41 +0200
Message-Id: <86ldjo56sm.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: "Yue Yi" <include_yy@HIDDEN>, Sean Whitton <spwhitton@HIDDEN>
In-Reply-To: <tencent_61E77A27F3F71938BB639E95406524B40807@HIDDEN>
 (bug-gnu-emacs@HIDDEN)
Subject: Re: bug#79913: 31.0.50;
 68e337e: server--process-filter-1 breaks emacsclient even without
 empty string arguments
References: <tencent_61E77A27F3F71938BB639E95406524B40807@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
Cc: 79913 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

merge 79913 79889
thanks

> Date: Sun, 30 Nov 2025 13:57:55 +0800
> From:  "Yue Yi" via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> 
> Hi, Emacs maintainers,
> 
> In a recently compiled Emacs, I noticed that the magit-commit in Magit
> is no longer working. Instead, it outputs an "Unknown command" message.
> Using grep, I traced this error message back to server.el. I also tested
> emacsclient with a simple argument (e.g., emacsclient 1.txt) and it
> results in the same error. (I should clarify that I am on Windows.)
> 
> ------------------------------>8<-------------------------------------------
> @@ -1267,8 +1267,10 @@ server--process-filter-1
>  		args-left)
>  	    ;; Remove this line from STRING.
>  	    (setq string (substring string (match-end 0)))
> -	    (setq args-left
> -		  (mapcar #'server-unquote-arg (split-string request " " t)))
> +	    (cl-assert (equal (substring request -1) " ")
> +		       nil "emacsclient request did not end in SPC")
> +	    (setq args-left (mapcar #'server-unquote-arg
> +				    (nbutlast (split-string request " "))))
>  	    (while args-left
>                (pcase (pop args-left)
>                  ;; -version CLIENT-VERSION: obsolete at birth.
> ------------------------------>8<-------------------------------------------
> 
> Commit 68e337e changed the usage of split-string, but the problem is
> that the `request' variable starts with whitespace. This leads to an
> effect similar to the following:
> 
> (split-string " a b c " " ") => ("" "a" "b" "c" "")
> 
> Here is a possible fix:
> 
> ------------------------------>8<-------------------------------------------
> @@ -1270,7 +1270,7 @@
>  	    (cl-assert (equal (substring request -1) " ")
>  		       nil "emacsclient request did not end in SPC: %S" request)
>  	    (setq args-left (mapcar #'server-unquote-arg
> -				    (nbutlast (split-string request " "))))
> +				    (split-string (string-trim request " "))))
>  	    (while args-left
>                (pcase (pop args-left)
>                  ;; -version CLIENT-VERSION: obsolete at birth.
> ------------------------------>8<-------------------------------------------
> 
> Of course, this only solves the immediate problem I am facing, and
> perhaps we need a better approach.

This is a duplicate of an existing bug#79889, so I'm now merging it.

Sean, would you please look into fixing this ASAP?  Several fixes were
already suggested, but I'm not sure what is the best for the new
support of the empty strings, which triggered this.

Last modified: Sun, 30 Nov 2025 07:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.