Eli Zaretskii <eliz@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 79913) by debbugs.gnu.org; 30 Nov 2025 07:16:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 30 02:16:54 2025
Received: from localhost ([127.0.0.1]:36073 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vPbfy-0006gf-4j
for submit <at> debbugs.gnu.org; Sun, 30 Nov 2025 02:16:54 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:37628)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <eliz@HIDDEN>)
id 1vPbfv-0006gL-LW; Sun, 30 Nov 2025 02:16:52 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1vPbfo-0004d4-JH; Sun, 30 Nov 2025 02:16:45 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=M4ZJff3t5s8JLYAQWoqY6oEegmLdoWKTqwYioIw2VN0=; b=TXowgODUXtqo
pAzy8WNzXwXNcg7yFRVbmEVBcqjKG5srhSK5cEJxpEdxXc1s4HHSSL2vYIa5blCgOnyjCAOyWMZSD
j4tC+iylgdST3e6p2ILhvEx/EZzaG1rFJIVXxDnzcYEMc5n5PIAqNHDUFyN/+28ta7OIKrbXVrEQ7
miTGPPF5IjQd/0Bmg8JDowvAPQ/B06DC8WJ4eIptne3def1q2p0bQU6smuLumBWEhdthW/oMU/V5B
MAk6bok0LACNp0FkKKugOAdEVnTn4uQIgZkeQ5yhKg8vZXSfE9Nd0fWNDdK+XhhKoXpWxZGpgpHpA
Pf/n4L0dH4yI7serWiSIJQ==;
Date: Sun, 30 Nov 2025 09:16:41 +0200
Message-Id: <86ldjo56sm.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: "Yue Yi" <include_yy@HIDDEN>, Sean Whitton <spwhitton@HIDDEN>
In-Reply-To: <tencent_61E77A27F3F71938BB639E95406524B40807@HIDDEN>
(bug-gnu-emacs@HIDDEN)
Subject: Re: bug#79913: 31.0.50;
68e337e: server--process-filter-1 breaks emacsclient even without
empty string arguments
References: <tencent_61E77A27F3F71938BB639E95406524B40807@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 79913
Cc: 79913 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
merge 79913 79889
thanks
> Date: Sun, 30 Nov 2025 13:57:55 +0800
> From: "Yue Yi" via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>
> Hi, Emacs maintainers,
>
> In a recently compiled Emacs, I noticed that the magit-commit in Magit
> is no longer working. Instead, it outputs an "Unknown command" message.
> Using grep, I traced this error message back to server.el. I also tested
> emacsclient with a simple argument (e.g., emacsclient 1.txt) and it
> results in the same error. (I should clarify that I am on Windows.)
>
> ------------------------------>8<-------------------------------------------
> @@ -1267,8 +1267,10 @@ server--process-filter-1
> args-left)
> ;; Remove this line from STRING.
> (setq string (substring string (match-end 0)))
> - (setq args-left
> - (mapcar #'server-unquote-arg (split-string request " " t)))
> + (cl-assert (equal (substring request -1) " ")
> + nil "emacsclient request did not end in SPC")
> + (setq args-left (mapcar #'server-unquote-arg
> + (nbutlast (split-string request " "))))
> (while args-left
> (pcase (pop args-left)
> ;; -version CLIENT-VERSION: obsolete at birth.
> ------------------------------>8<-------------------------------------------
>
> Commit 68e337e changed the usage of split-string, but the problem is
> that the `request' variable starts with whitespace. This leads to an
> effect similar to the following:
>
> (split-string " a b c " " ") => ("" "a" "b" "c" "")
>
> Here is a possible fix:
>
> ------------------------------>8<-------------------------------------------
> @@ -1270,7 +1270,7 @@
> (cl-assert (equal (substring request -1) " ")
> nil "emacsclient request did not end in SPC: %S" request)
> (setq args-left (mapcar #'server-unquote-arg
> - (nbutlast (split-string request " "))))
> + (split-string (string-trim request " "))))
> (while args-left
> (pcase (pop args-left)
> ;; -version CLIENT-VERSION: obsolete at birth.
> ------------------------------>8<-------------------------------------------
>
> Of course, this only solves the immediate problem I am facing, and
> perhaps we need a better approach.
This is a duplicate of an existing bug#79889, so I'm now merging it.
Sean, would you please look into fixing this ASAP? Several fixes were
already suggested, but I'm not sure what is the best for the new
support of the empty strings, which triggered this.
bug-gnu-emacs@HIDDEN:bug#79913; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 30 Nov 2025 05:58:22 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 30 00:58:22 2025 Received: from localhost ([127.0.0.1]:35504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vPaRx-0000x3-Lg for submit <at> debbugs.gnu.org; Sun, 30 Nov 2025 00:58:22 -0500 Received: from lists.gnu.org ([2001:470:142::17]:36928) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <include_yy@HIDDEN>) id 1vPaRs-0000wb-O4 for submit <at> debbugs.gnu.org; Sun, 30 Nov 2025 00:58:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <include_yy@HIDDEN>) id 1vPaRk-0001Zu-Uz for bug-gnu-emacs@HIDDEN; Sun, 30 Nov 2025 00:58:09 -0500 Received: from out203-205-221-192.mail.qq.com ([203.205.221.192]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <include_yy@HIDDEN>) id 1vPaRg-00012f-KC for bug-gnu-emacs@HIDDEN; Sun, 30 Nov 2025 00:58:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1764482275; bh=rLEcX+P4oSqI37TjVN5hh5wI0veoxi7DxCQsEaCb8IU=; h=From:To:Subject:Date; b=d3AUlbmqyVJrADuZLdeqswyO3eMNUJkHZqffzL2lqYttixPeR0ahUrhw8CM0rYH72 9Fu7GM1A/b3+Ca+XXK/wjOK+EV/h60tQkCnn5c1tlYs6ZYE+PXza6A1J+Rwr2gPuBe 4SfucEDYDi01tCmlEQ0oFlr38VnpNluWO1ThIUAg= X-QQ-XMRINFO: OWPUhxQsoeAVDbp3OJHYyFg= X-QQ-XMAILINFO: MGxqgJmnbl23Z9Z/KBYUnDGSAT6qNLrEzE9Y65zbPhuY/QJlx0a74pCmCaLPzw W3gNTNF1tYogGy8fWmXlQ+HN01j8rDxLEtif9rxAStA1horryObArhqMAymqinjWzkmNOcEdXKpNL rlk/YL69zAW7E9Q/1T7r3I6yXKv152DzSvpi78kg9Ja/bw6nt0L7mHv4q+GcGuwABfGOg0T2lVVaT 7xoGbZK6Kbiu+J4p7y6Qb5fFXOBglvFs2p1kUrwJb92sq/Y/GudqDarybBBu9LUneD6/XenDHYSUH DtvoqYW9o0a4N5HOk/+HQMQ7RZfcKvDFtlNdbzSz1Gd4dUfhutgyFt3abrJdIUHtJZZK30pGJlIUh hFG+Wl8/5oZ39xpLUpqYrAe3QvjZjxon2HumWD1XwKOJ5eKc89FnOyUubok+ct7KrFizc1ea0KhR/ zToytPcenfbMwPcqs9PKns+QRYUYRtJVCohtPxaxwdhnK3EfJVxSlmppU0i0xI041ChuXcR4uNcz4 0nKBoPHLWy6lsmMcSe1sV/WK/WHQxrsAYzwtRGkTUtDLlHgspW8jaKtlfn0bN1oI3YVZ0m/9uV04E s0CDNfqUyYVOyL3Ak+ZJzUA2biaHXWU8oEXnQ1QuHftCF4NaRkI8ooZgQuiBMK6nJ67X2keUN3Qfa 1+JblF7sLQabwze29AUpsknpjzjtTVYlg5BxgpufaT4EeS3a37cTmZZD35PH6qC+YJoaOm4bmCR7Y r+q5SLmaAS4rrbkrHpaMmfu+7Q0AqrbIEFJySIQeNLHYKLLCYgBPT4mejYbnpZFER7oiOTVUCKDp4 OKZ4QPq2YRc0vgsjXoFWEtVsIUvprrMibn7S5TlbNTn9u0VFaj4MxMHBgzPL1eF4YtdBa7mrL59om Aq+6fiT1nE0AtVzM5uIhsYj5gLoDlHxCbNezXLrGuCqFq07bjrBcx9qR+qTe0Vcc+wKK+pWpNgKLB 0njCb5BweBlk4dQ8khjq3ciE5zb5j7Nx9UjzX7iYjIUJSuzNlEIOdzQjw7l2UU7MCKXQbtKkwdW07 GK9IzHUvrBiVqbL+RDHtkoeRS1A5DtxtfqUva From: "=?utf-8?B?WXVlIFlp?=" <include_yy@HIDDEN> To: "=?utf-8?B?WXVlIFlpIHZpYSBCdWcgcmVwb3J0cyBmb3IgR05VIEVtYWNzLHRoZSBTd2lzcyBhcm15IGtuaWZlIG9mIHRleHQgZWRpdG9ycw==?=" <bug-gnu-emacs@HIDDEN> Subject: 31.0.50; 68e337e: server--process-filter-1 breaks emacsclient even without empty string arguments Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Date: Sun, 30 Nov 2025 13:57:55 +0800 X-Priority: 3 Message-ID: <tencent_61E77A27F3F71938BB639E95406524B40807@HIDDEN> X-QQ-MIME: TCMime 1.0 by Tencent X-Mailer: QQMail 2.x X-QQ-Mailer: QQMail 2.x X-QQ-mid: xmseza62-0t1764482275t61i4gw57 Received-SPF: pass client-ip=203.205.221.192; envelope-from=include_yy@HIDDEN; helo=out203-205-221-192.mail.qq.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_EXCESS_BASE64=0.001, HELO_DYNAMIC_IPADDR=1.951, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.1 (/) SGksIEVtYWNzIG1haW50YWluZXJzLAoKSW4gYSByZWNlbnRseSBjb21waWxlZCBFbWFjcywg SSBub3RpY2VkIHRoYXQgdGhlIG1hZ2l0LWNvbW1pdCBpbiBNYWdpdAppcyBubyBsb25nZXIg d29ya2luZy4gSW5zdGVhZCwgaXQgb3V0cHV0cyBhbiAiVW5rbm93biBjb21tYW5kIiBtZXNz YWdlLgpVc2luZyBncmVwLCBJIHRyYWNlZCB0aGlzIGVycm9yIG1lc3NhZ2UgYmFjayB0byBz ZXJ2ZXIuZWwuIEkgYWxzbyB0ZXN0ZWQKZW1hY3NjbGllbnQgd2l0aCBhIHNpbXBsZSBhcmd1 bWVudCAoZS5nLiwgZW1hY3NjbGllbnQgMS50eHQpIGFuZCBpdApyZXN1bHRzIGluIHRoZSBz YW1lIGVycm9yLiAoSSBzaG91bGQgY2xhcmlmeSB0aGF0IEkgYW0gb24gV2luZG93cy4pCgot LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0+ODwtLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tCkBAIC0xMjY3LDggKzEyNjcsMTAgQEAgc2VydmVyLS1w cm9jZXNzLWZpbHRlci0xCiAJCWFyZ3MtbGVmdCkKIAkgICAgOzsgUmVtb3ZlIHRoaXMgbGlu ZSBmcm9tIFNUUklORy4KIAkgICAgKHNldHEgc3RyaW5nIChzdWJzdHJpbmcgc3RyaW5nICht YXRjaC1lbmQgMCkpKQotCSAgICAoc2V0cSBhcmdzLWxlZnQKLQkJICAobWFwY2FyICMnc2Vy dmVyLXVucXVvdGUtYXJnIChzcGxpdC1zdHJpbmcgcmVxdWVzdCAiICIgdCkpKQorCSAgICAo Y2wtYXNzZXJ0IChlcXVhbCAoc3Vic3RyaW5nIHJlcXVlc3QgLTEpICIgIikKKwkJICAgICAg IG5pbCAiZW1hY3NjbGllbnQgcmVxdWVzdCBkaWQgbm90IGVuZCBpbiBTUEMiKQorCSAgICAo c2V0cSBhcmdzLWxlZnQgKG1hcGNhciAjJ3NlcnZlci11bnF1b3RlLWFyZworCQkJCSAgICAo bmJ1dGxhc3QgKHNwbGl0LXN0cmluZyByZXF1ZXN0ICIgIikpKSkKIAkgICAgKHdoaWxlIGFy Z3MtbGVmdAogICAgICAgICAgICAgICAocGNhc2UgKHBvcCBhcmdzLWxlZnQpCiAgICAgICAg ICAgICAgICAgOzsgLXZlcnNpb24gQ0xJRU5ULVZFUlNJT046IG9ic29sZXRlIGF0IGJpcnRo LgotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0+ODwtLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCgpDb21taXQgNjhlMzM3ZSBjaGFuZ2VkIHRoZSB1 c2FnZSBvZiBzcGxpdC1zdHJpbmcsIGJ1dCB0aGUgcHJvYmxlbSBpcwp0aGF0IHRoZSBgcmVx dWVzdCcgdmFyaWFibGUgc3RhcnRzIHdpdGggd2hpdGVzcGFjZS4gVGhpcyBsZWFkcyB0byBh bgplZmZlY3Qgc2ltaWxhciB0byB0aGUgZm9sbG93aW5nOgoKKHNwbGl0LXN0cmluZyAiIGEg YiBjICIgIiAiKSA9PiAoIiIgImEiICJiIiAiYyIgIiIpCgpIZXJlIGlzIGEgcG9zc2libGUg Zml4OgoKLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tPjg8LS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpAQCAtMTI3MCw3ICsxMjcwLDcgQEAKIAkg ICAgKGNsLWFzc2VydCAoZXF1YWwgKHN1YnN0cmluZyByZXF1ZXN0IC0xKSAiICIpCiAJCSAg ICAgICBuaWwgImVtYWNzY2xpZW50IHJlcXVlc3QgZGlkIG5vdCBlbmQgaW4gU1BDOiAlUyIg cmVxdWVzdCkKIAkgICAgKHNldHEgYXJncy1sZWZ0IChtYXBjYXIgIydzZXJ2ZXItdW5xdW90 ZS1hcmcKLQkJCQkgICAgKG5idXRsYXN0IChzcGxpdC1zdHJpbmcgcmVxdWVzdCAiICIpKSkp CisJCQkJICAgIChzcGxpdC1zdHJpbmcgKHN0cmluZy10cmltIHJlcXVlc3QgIiAiKSkpKQog CSAgICAod2hpbGUgYXJncy1sZWZ0CiAgICAgICAgICAgICAgIChwY2FzZSAocG9wIGFyZ3Mt bGVmdCkKICAgICAgICAgICAgICAgICA7OyAtdmVyc2lvbiBDTElFTlQtVkVSU0lPTjogb2Jz b2xldGUgYXQgYmlydGguCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLT44PC0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KCk9mIGNvdXJzZSwgdGhp cyBvbmx5IHNvbHZlcyB0aGUgaW1tZWRpYXRlIHByb2JsZW0gSSBhbSBmYWNpbmcsIGFuZApw ZXJoYXBzIHdlIG5lZWQgYSBiZXR0ZXIgYXBwcm9hY2guCgpSZWdhcmRzLgo=
"Yue Yi" <include_yy@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#79913; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.