GNU logs - #79937, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#79937: 30.2; rust-ts-mode: incorrect fontification for token_tree,  index_expression, and lowercase imports
Resent-From: Kanishk <kanishk0422@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 02 Dec 2025 13:59:02 +0000
Resent-Message-ID: <handler.79937.B.17646839142419 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 79937 <at> debbugs.gnu.org
From: Kanishk <kanishk0422@HIDDEN>
Content-Type: multipart/alternative;
 boundary="Apple-Mail=_30492904-7FE3-4C1C-B449-5251D65CF507"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.100.1.1.5\))
Message-Id: <4AA6D8C1-02AD-49EE-B1D8-C1A658ADBD11@HIDDEN>
Date: Tue, 2 Dec 2025 14:39:04 +0530
Received-SPF: pass client-ip=2607:f8b0:4864:20::62c;
 envelope-from=kanishk0422@HIDDEN; helo=mail-pl1-x62c.google.com
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  Hello Emacs maintainers, This patch fixes three fontification
 issues in rust-ts-mode.el. Missing variable face inside token_tree:
 Identifiers
 appearing inside macro token trees were not highlighted. For example:
 macro_rules!
 m { ($x:ident) => { $x } } The $x identifier did not receive var [...] 
 Content analysis details:   (1.2 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org]
 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends
 in digit (kanishk0422[at]gmail.com)
 1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (kanishk0422[at]gmail.com)
 0.0 HTML_MESSAGE           BODY: HTML included in message
X-Mailman-Approved-At: Tue, 02 Dec 2025 08:58:33 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)


--Apple-Mail=_30492904-7FE3-4C1C-B449-5251D65CF507
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

Hello Emacs maintainers,

This patch fixes three fontification issues in rust-ts-mode.el.

Missing variable face inside token_tree:
Identifiers appearing inside macro token trees were not highlighted. For =
example:
macro_rules! m { ($x:ident) =3D> { $x } }
The $x identifier did not receive variable-name highlighting.

Missing variable-use face inside index_expression:
Expressions such as:
arr[i]
did not highlight i as a variable-use, even though it should be treated =
the same way as other identifier occurrences in expressions.

Lowercase imports in use_list not correctly highlighted:
Rust module and crate names are always lowercase, but rust-ts-mode did =
not assign an appropriate face to them in:
use foo::Bar;
The uppercase item Bar is a type and should use font-lock-type-face. The =
lowercase module foo should use font-lock-constant-face, consistent with =
rust-mode and common Rust editor behavior.

This patch adds:

(token_tree (identifier) @font-lock-variable-name-face)

(index_expression (identifier) @font-lock-variable-use-face)

A new rule in the type feature to fontify lowercase identifiers in =
use_list using font-lock-constant-face.

These changes are safe, isolated, and improve correctness of Rust =
fontification without altering any unrelated behavior. They also bring =
rust-ts-mode in line with rust-mode and with Rust naming conventions.

Thank you.=

--Apple-Mail=_30492904-7FE3-4C1C-B449-5251D65CF507
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=us-ascii

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; =
charset=3Dus-ascii"></head><body style=3D"overflow-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: after-white-space;">
<p data-start=3D"79" data-end=3D"103" style=3D"caret-color: rgb(0, 0, =
0); color: rgb(0, 0, 0);">Hello Emacs maintainers,</p><p =
data-start=3D"105" data-end=3D"168" style=3D"caret-color: rgb(0, 0, 0); =
color: rgb(0, 0, 0);">This patch fixes three fontification issues in =
rust-ts-mode.el.</p><ol data-start=3D"170" data-end=3D"1011" =
style=3D"caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);"><li =
data-start=3D"170" data-end=3D"403"><p data-start=3D"173" =
data-end=3D"403">Missing variable face inside token_tree:<br>Identifiers =
appearing inside macro token trees were not highlighted. For =
example:<br>macro_rules! m { ($x:ident) =3D&gt; { $x } =
}<br>The&nbsp;<code data-start=3D"344" =
data-end=3D"348">$x</code>&nbsp;identifier did not receive variable-name =
highlighting.</p></li><li data-start=3D"405" data-end=3D"625"><p =
data-start=3D"408" data-end=3D"625">Missing variable-use face inside =
index_expression:<br>Expressions such as:<br>arr[i]<br>did not =
highlight&nbsp;<code data-start=3D"509" data-end=3D"512">i</code>&nbsp;as =
a variable-use, even though it should be treated the same way as other =
identifier occurrences in expressions.</p></li><li data-start=3D"627" =
data-end=3D"1011"><p data-start=3D"630" data-end=3D"1011">Lowercase =
imports in use_list not correctly highlighted:<br>Rust module and crate =
names are always lowercase, but rust-ts-mode did not assign an =
appropriate face to them in:<br>use foo::Bar;<br>The uppercase =
item&nbsp;<code data-start=3D"838" data-end=3D"843">Bar</code>&nbsp;is a =
type and should use font-lock-type-face. The lowercase module&nbsp;<code =
data-start=3D"911" data-end=3D"916">foo</code>&nbsp;should use =
font-lock-constant-face, consistent with rust-mode and common Rust =
editor behavior.</p></li></ol><p data-start=3D"1013" data-end=3D"1029" =
style=3D"caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);">This patch =
adds:</p><ul data-start=3D"1030" data-end=3D"1263" style=3D"caret-color: =
rgb(0, 0, 0); color: rgb(0, 0, 0);"><li data-start=3D"1030" =
data-end=3D"1089"><p data-start=3D"1032" data-end=3D"1089"><code =
data-start=3D"1032" data-end=3D"1089">(token_tree (identifier) =
@font-lock-variable-name-face)</code></p></li><li data-start=3D"1090" =
data-end=3D"1154"><p data-start=3D"1092" data-end=3D"1154"><code =
data-start=3D"1092" data-end=3D"1154">(index_expression (identifier) =
@font-lock-variable-use-face)</code></p></li><li data-start=3D"1155" =
data-end=3D"1263"><p data-start=3D"1157" data-end=3D"1263">A new rule in =
the type feature to fontify lowercase identifiers in use_list using =
font-lock-constant-face.</p></li></ul><p data-start=3D"1265" =
data-end=3D"1471" style=3D"caret-color: rgb(0, 0, 0); color: rgb(0, 0, =
0);">These changes are safe, isolated, and improve correctness of Rust =
fontification without altering any unrelated behavior. They also bring =
rust-ts-mode in line with rust-mode and with Rust naming =
conventions.</p><p data-start=3D"1473" data-end=3D"1483" =
style=3D"caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);">Thank you.</p>

</body></html>=

--Apple-Mail=_30492904-7FE3-4C1C-B449-5251D65CF507--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Kanishk <kanishk0422@HIDDEN>
Subject: bug#79937: Acknowledgement (30.2; rust-ts-mode: incorrect
 fontification for token_tree,  index_expression, and lowercase imports)
Message-ID: <handler.79937.B.17646839142419.ack <at> debbugs.gnu.org>
References: <4AA6D8C1-02AD-49EE-B1D8-C1A658ADBD11@HIDDEN>
X-Gnu-PR-Message: ack 79937
X-Gnu-PR-Package: emacs
Reply-To: 79937 <at> debbugs.gnu.org
Date: Tue, 02 Dec 2025 13:59:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 79937 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
79937: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D79937
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#79937: rust-ts-mode: Fix fontification of token_tree, index_expression, and lowercase imports
References: <4AA6D8C1-02AD-49EE-B1D8-C1A658ADBD11@HIDDEN>
In-Reply-To: <4AA6D8C1-02AD-49EE-B1D8-C1A658ADBD11@HIDDEN>
Resent-From: Kanishk <kanishk0422@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 02 Dec 2025 18:15:02 +0000
Resent-Message-ID: <handler.79937.B79937.17646993005553 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 79937 <at> debbugs.gnu.org
From: Kanishk <kanishk0422@HIDDEN>
Content-Type: multipart/mixed;
 boundary="Apple-Mail=_AB671180-86A5-4D83-ADF8-B78F35731A36"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.100.1.1.5\))
Message-Id: <BAF12781-88C4-4CBA-899E-65EA608560D8@HIDDEN>
Date: Tue, 2 Dec 2025 23:44:35 +0530
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>


--Apple-Mail=_AB671180-86A5-4D83-ADF8-B78F35731A36
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

This patch fixes three issues in rust-ts-mode.el:

1. Identifiers inside token_tree were not fontified as variables.
2. Identifiers inside index_expression were not fontified as =
variable-use.
3. Lowercase module/crate names inside use_list were not given the =
correct face.

The patch adds:
- (token_tree (identifier) @font-lock-variable-name-face)
- (index_expression (identifier) @font-lock-variable-use-face)
- A new rule to highlight lowercase imports using =
font-lock-constant-face.

These changes are consistent with Rust naming conventions, rust-mode, =
and other Rust editor integrations, and improve correctness without =
affecting unrelated behavior.

In GNU Emacs 30.2 (build 2, aarch64-apple-darwin25.0.0, NS
 appkit-2685.10 Version 26.0.1 (Build 25A362)) of 2025-11-24 built on
 tesseract-6.local
Windowing system distributor 'Apple', version 10.3.2685
System Description:  macOS 26.0.1

Configured using:
 'configure --disable-dependency-tracking --disable-silent-rules
 --enable-locallisppath=3D/opt/homebrew/share/emacs/site-lisp
 --infodir=3D/opt/homebrew/Cellar/emacs-plus@30/30.2/share/info/emacs
 --prefix=3D/opt/homebrew/Cellar/emacs-plus@30/30.2
 --with-native-compilation=3Daot --with-xml2 --with-gnutls
 --without-compress-install --without-dbus --without-imagemagick
 --with-modules --with-rsvg --with-webp =E2=80=94with-tree-sitter =
--with-ns
 --disable-ns-self-contained 'CFLAGS=3D-O2 -DFD_SETSIZE=3D10000
 -DDARWIN_UNLIMITED_SELECT -I/opt/homebrew/opt/sqlite/include
 -I/opt/homebrew/opt/gcc/include -I/opt/homebrew/opt/libgccjit/include'
 'LDFLAGS=3D-L/opt/homebrew/opt/sqlite/lib -L/opt/homebrew/lib/gcc/15
 -Wl,-rpath,/opt/homebrew/lib/gcc/15''=

--Apple-Mail=_AB671180-86A5-4D83-ADF8-B78F35731A36
Content-Disposition: attachment;
	filename=0001-lisp-vc-vc.el-vc-push-Delay-clearing-incoming-revisi.patch
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="0001-lisp-vc-vc.el-vc-push-Delay-clearing-incoming-revisi.patch"
Content-Transfer-Encoding: quoted-printable

=46rom=20df4d8c147524c3cea5cf77a0b73d3f64e58aa4f9=20Mon=20Sep=2017=20=
00:00:00=202001=0AFrom:=20Sean=20Whitton=20<spwhitton@HIDDEN>=0A=
Date:=20Tue,=202=20Dec=202025=2011:55:14=20+0000=0ASubject:=20[PATCH]=20=
*=20lisp/vc/vc.el=20(vc-push):=20Delay=20clearing=20incoming=20revisions=0A=
=20cache.=0A=0A---=0A=20lisp/vc/vc.el=20|=203=20++-=0A=201=20file=20=
changed,=202=20insertions(+),=201=20deletion(-)=0A=0Adiff=20--git=20=
a/lisp/vc/vc.el=20b/lisp/vc/vc.el=0Aindex=208771603a4ad..15982067829=20=
100644=0A---=20a/lisp/vc/vc.el=0A+++=20b/lisp/vc/vc.el=0A@@=20-4277,7=20=
+4277,8=20@@=20vc-push=0A=20=20=20=20=20=20=20=20=20(progn=20=
(vc-call-backend=20backend=20'push=20arg)=0A=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20;;=20FIXME:=20Ideally=20we=20would=20only=20clear=20=
out=20the=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20=
REMOTE-LOCATION=20to=20which=20we=20are=20pushing.=0A-=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20(vc--repo-setprop=20'vc-incoming-revision=20=
nil))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(vc-run-delayed=0A=
+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(vc--repo-setprop=20=
'vc-incoming-revision=20nil)))=0A=20=20=20=20=20=20=20(user-error=20"VC=20=
push=20is=20unsupported=20for=20`%s'"=20backend))))=0A=20=0A=20=
;;;###autoload=0A--=20=0A2.52.0=0A=0A=

--Apple-Mail=_AB671180-86A5-4D83-ADF8-B78F35731A36--

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#79937: rust-ts-mode: Fix fontification of token_tree, index_expression, and lowercase imports
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 03 Dec 2025 12:16:07 +0000
Resent-Message-ID: <handler.79937.B79937.17647641656509 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Kanishk <kanishk0422@HIDDEN>, Randy Taylor <dev@HIDDEN>
Cc: 79937 <at> debbugs.gnu.org
Date: Wed, 03 Dec 2025 14:15:44 +0200
Message-Id: <86bjkf3gnj.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <BAF12781-88C4-4CBA-899E-65EA608560D8@HIDDEN> (message from
 Kanishk on Tue, 2 Dec 2025 23:44:35 +0530)
References: <4AA6D8C1-02AD-49EE-B1D8-C1A658ADBD11@HIDDEN>
 <BAF12781-88C4-4CBA-899E-65EA608560D8@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> From: Kanishk <kanishk0422@HIDDEN>
> Date: Tue, 2 Dec 2025 23:44:35 +0530
> 
> This patch fixes three issues in rust-ts-mode.el:
> 
> 1. Identifiers inside token_tree were not fontified as variables.
> 2. Identifiers inside index_expression were not fontified as variable-use.
> 3. Lowercase module/crate names inside use_list were not given the correct face.
> 
> The patch adds:
> - (token_tree (identifier) @font-lock-variable-name-face)
> - (index_expression (identifier) @font-lock-variable-use-face)
> - A new rule to highlight lowercase imports using font-lock-constant-face.
> 
> These changes are consistent with Rust naming conventions, rust-mode, and other Rust editor integrations, and improve correctness without affecting unrelated behavior.

Thanks, but did you send the correct patch?  It is by Sean, and
patches vc.el, not rust-ts-mode:

> From df4d8c147524c3cea5cf77a0b73d3f64e58aa4f9 Mon Sep 17 00:00:00 2001
> From: Sean Whitton <spwhitton@HIDDEN>
> Date: Tue, 2 Dec 2025 11:55:14 +0000
> Subject: [PATCH] * lisp/vc/vc.el (vc-push): Delay clearing incoming revisions
>  cache.
> 
> ---
>  lisp/vc/vc.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
> index 8771603a4ad..15982067829 100644
> --- a/lisp/vc/vc.el
> +++ b/lisp/vc/vc.el
> @@ -4277,7 +4277,8 @@ vc-push
>          (progn (vc-call-backend backend 'push arg)
>                 ;; FIXME: Ideally we would only clear out the
>                 ;; REMOTE-LOCATION to which we are pushing.
> -               (vc--repo-setprop 'vc-incoming-revision nil))
> +               (vc-run-delayed
> +                 (vc--repo-setprop 'vc-incoming-revision nil)))
>        (user-error "VC push is unsupported for `%s'" backend))))
>  
>  ;;;###autoload
> -- 
> 2.52.0

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#79937: 30.2; rust-ts-mode: incorrect fontification for token_tree, index_expression, and lowercase imports
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 03 Dec 2025 12:18:03 +0000
Resent-Message-ID: <handler.79937.B79937.17647642327244 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 79937
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Kanishk <kanishk0422@HIDDEN>, Randy Taylor <dev@HIDDEN>
Cc: 79937 <at> debbugs.gnu.org
Received: via spool by 79937-submit <at> debbugs.gnu.org id=B79937.17647642327244
          (code B ref 79937); Wed, 03 Dec 2025 12:18:03 +0000
Received: (at 79937) by debbugs.gnu.org; 3 Dec 2025 12:17:12 +0000
Received: from localhost ([127.0.0.1]:39925 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1vQln9-0001s6-VM
	for submit <at> debbugs.gnu.org; Wed, 03 Dec 2025 07:17:11 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:48800)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vQln4-0001pn-CF
 for 79937 <at> debbugs.gnu.org; Wed, 03 Dec 2025 07:17:05 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1vQlmx-0007Ho-Ko; Wed, 03 Dec 2025 07:16:55 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=l7Slz36BNMvNq4SC+OfT87HDXdt+brOoUfEFmAfjn7w=; b=HXoyGHQE0yrj
 +0gkUGn7LYauEJ0PkoFIWngLRMTAiiAgH2+HlzyoY6A0uMaDwSfHwypCjaz4URZ/0buW51DLuRXOE
 j4CMpj7kAJrr94lkGYZTRr8nyzp+S1mi37Wh38JVErfalWBfH7gHMWZtgG0auV8cTbpA5RN2yyUmQ
 iMfK4Q5rbYviWtYK9UMI3Q/MrgzqaSwRUQ4z8Jl+V72rIibDcJwWaB7Yo7wsZyz2xvedaImCnQUgi
 AIB2WEzzRXN/ozRR/S/UWWtH7tyLcB2rmRRW94OwrQTn7H0VqZaXpPGd7OYdTHOPsiXspzBZdHS0w
 gdjS29uWKWYYpJyFetDv8g==;
Date: Wed, 03 Dec 2025 14:16:52 +0200
Message-Id: <86a4zz3gln.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <4AA6D8C1-02AD-49EE-B1D8-C1A658ADBD11@HIDDEN> (message from
 Kanishk on Tue, 2 Dec 2025 14:39:04 +0530)
References: <4AA6D8C1-02AD-49EE-B1D8-C1A658ADBD11@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Kanishk <kanishk0422@HIDDEN>
> Date: Tue, 2 Dec 2025 14:39:04 +0530
> 
> Hello Emacs maintainers,
> 
> This patch fixes three fontification issues in rust-ts-mode.el.
> 
> Missing variable face inside token_tree:
> Identifiers appearing inside macro token trees were not highlighted. For example:
> macro_rules! m { ($x:ident) => { $x } }
> The $x identifier did not receive variable-name highlighting.
> 
> Missing variable-use face inside index_expression:
> Expressions such as:
> arr[i]
> did not highlight i as a variable-use, even though it should be treated the same way as other identifier occurrences in expressions.
> 
> Lowercase imports in use_list not correctly highlighted:
> Rust module and crate names are always lowercase, but rust-ts-mode did not assign an appropriate face to them in:
> use foo::Bar;
> The uppercase item Bar is a type and should use font-lock-type-face. The lowercase module foo should use font-lock-constant-face, consistent with rust-mode and common Rust editor behavior.
> 
> This patch adds:
> 
> (token_tree (identifier) @font-lock-variable-name-face)
> 
> (index_expression (identifier) @font-lock-variable-use-face)
> 
> A new rule in the type feature to fontify lowercase identifiers in use_list using font-lock-constant-face.
> 
> These changes are safe, isolated, and improve correctness of Rust fontification without altering any unrelated behavior. They also bring rust-ts-mode in line with rust-mode and with Rust naming conventions.

Hmm... I see no patch here.  Did you send a patch?

Last modified: Wed, 3 Dec 2025 12:30:03 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.