Received: (at 79937) by debbugs.gnu.org; 3 Dec 2025 12:17:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 03 07:17:11 2025
Received: from localhost ([127.0.0.1]:39925 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vQln9-0001s6-VM
for submit <at> debbugs.gnu.org; Wed, 03 Dec 2025 07:17:11 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:48800)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vQln4-0001pn-CF
for 79937 <at> debbugs.gnu.org; Wed, 03 Dec 2025 07:17:05 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1vQlmx-0007Ho-Ko; Wed, 03 Dec 2025 07:16:55 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=l7Slz36BNMvNq4SC+OfT87HDXdt+brOoUfEFmAfjn7w=; b=HXoyGHQE0yrj
+0gkUGn7LYauEJ0PkoFIWngLRMTAiiAgH2+HlzyoY6A0uMaDwSfHwypCjaz4URZ/0buW51DLuRXOE
j4CMpj7kAJrr94lkGYZTRr8nyzp+S1mi37Wh38JVErfalWBfH7gHMWZtgG0auV8cTbpA5RN2yyUmQ
iMfK4Q5rbYviWtYK9UMI3Q/MrgzqaSwRUQ4z8Jl+V72rIibDcJwWaB7Yo7wsZyz2xvedaImCnQUgi
AIB2WEzzRXN/ozRR/S/UWWtH7tyLcB2rmRRW94OwrQTn7H0VqZaXpPGd7OYdTHOPsiXspzBZdHS0w
gdjS29uWKWYYpJyFetDv8g==;
Date: Wed, 03 Dec 2025 14:16:52 +0200
Message-Id: <86a4zz3gln.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Kanishk <kanishk0422@HIDDEN>, Randy Taylor <dev@HIDDEN>
In-Reply-To: <4AA6D8C1-02AD-49EE-B1D8-C1A658ADBD11@HIDDEN> (message from
Kanishk on Tue, 2 Dec 2025 14:39:04 +0530)
Subject: Re: bug#79937: 30.2;
rust-ts-mode: incorrect fontification for token_tree,
index_expression, and lowercase imports
References: <4AA6D8C1-02AD-49EE-B1D8-C1A658ADBD11@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 79937
Cc: 79937 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Kanishk <kanishk0422@HIDDEN>
> Date: Tue, 2 Dec 2025 14:39:04 +0530
>
> Hello Emacs maintainers,
>
> This patch fixes three fontification issues in rust-ts-mode.el.
>
> Missing variable face inside token_tree:
> Identifiers appearing inside macro token trees were not highlighted. For example:
> macro_rules! m { ($x:ident) => { $x } }
> The $x identifier did not receive variable-name highlighting.
>
> Missing variable-use face inside index_expression:
> Expressions such as:
> arr[i]
> did not highlight i as a variable-use, even though it should be treated the same way as other identifier occurrences in expressions.
>
> Lowercase imports in use_list not correctly highlighted:
> Rust module and crate names are always lowercase, but rust-ts-mode did not assign an appropriate face to them in:
> use foo::Bar;
> The uppercase item Bar is a type and should use font-lock-type-face. The lowercase module foo should use font-lock-constant-face, consistent with rust-mode and common Rust editor behavior.
>
> This patch adds:
>
> (token_tree (identifier) @font-lock-variable-name-face)
>
> (index_expression (identifier) @font-lock-variable-use-face)
>
> A new rule in the type feature to fontify lowercase identifiers in use_list using font-lock-constant-face.
>
> These changes are safe, isolated, and improve correctness of Rust fontification without altering any unrelated behavior. They also bring rust-ts-mode in line with rust-mode and with Rust naming conventions.
Hmm... I see no patch here. Did you send a patch?
bug-gnu-emacs@HIDDEN:bug#79937; Package emacs.
Full text available.Received: (at 79937) by debbugs.gnu.org; 3 Dec 2025 12:16:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 03 07:16:04 2025 Received: from localhost ([127.0.0.1]:39916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vQlm5-0001g9-Bh for submit <at> debbugs.gnu.org; Wed, 03 Dec 2025 07:16:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45546) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vQllz-0001dv-QA for 79937 <at> debbugs.gnu.org; Wed, 03 Dec 2025 07:15:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1vQllt-0007AD-EP; Wed, 03 Dec 2025 07:15:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5igSiB3m/bQtniIhMokvfcVH06K7L8V043A8HHD3Dcw=; b=H8I8RZgnp7+d EhY7WQ16NWTLY1T7RQfHp6cRTdQDVRFMlc0vMGiL17ctxIM6wEL2jlwUXfLIcv2PLYlxhDleOYVuT 5XR/UkQpgXPUvGfyDFGYk6fxeVHTiBDr2Uf9tNU/JVIEylNUPhB4tNq7LKJsBtasYgmGgXumRTJgi +A5a8bIEjW4cEF/Qm2ii21BQulBSaxvS6ygBIr/0YUvlULIlSJ0KuVEzWjpu2/I8sGeDPlIlJrHSW 7wBxDR9TA0B+4sFymBLzX3t+mEPgrJ1AM3UzWi9hL/9Ou9mr1DNDnAfg8dq5ZDEGnxdQowtmREvIt Pgsto/ipIbxHI354GGEYIQ==; Date: Wed, 03 Dec 2025 14:15:44 +0200 Message-Id: <86bjkf3gnj.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Kanishk <kanishk0422@HIDDEN>, Randy Taylor <dev@HIDDEN> In-Reply-To: <BAF12781-88C4-4CBA-899E-65EA608560D8@HIDDEN> (message from Kanishk on Tue, 2 Dec 2025 23:44:35 +0530) Subject: Re: bug#79937: rust-ts-mode: Fix fontification of token_tree, index_expression, and lowercase imports References: <4AA6D8C1-02AD-49EE-B1D8-C1A658ADBD11@HIDDEN> <BAF12781-88C4-4CBA-899E-65EA608560D8@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79937 Cc: 79937 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Kanishk <kanishk0422@HIDDEN> > Date: Tue, 2 Dec 2025 23:44:35 +0530 > > This patch fixes three issues in rust-ts-mode.el: > > 1. Identifiers inside token_tree were not fontified as variables. > 2. Identifiers inside index_expression were not fontified as variable-use. > 3. Lowercase module/crate names inside use_list were not given the correct face. > > The patch adds: > - (token_tree (identifier) @font-lock-variable-name-face) > - (index_expression (identifier) @font-lock-variable-use-face) > - A new rule to highlight lowercase imports using font-lock-constant-face. > > These changes are consistent with Rust naming conventions, rust-mode, and other Rust editor integrations, and improve correctness without affecting unrelated behavior. Thanks, but did you send the correct patch? It is by Sean, and patches vc.el, not rust-ts-mode: > From df4d8c147524c3cea5cf77a0b73d3f64e58aa4f9 Mon Sep 17 00:00:00 2001 > From: Sean Whitton <spwhitton@HIDDEN> > Date: Tue, 2 Dec 2025 11:55:14 +0000 > Subject: [PATCH] * lisp/vc/vc.el (vc-push): Delay clearing incoming revisions > cache. > > --- > lisp/vc/vc.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el > index 8771603a4ad..15982067829 100644 > --- a/lisp/vc/vc.el > +++ b/lisp/vc/vc.el > @@ -4277,7 +4277,8 @@ vc-push > (progn (vc-call-backend backend 'push arg) > ;; FIXME: Ideally we would only clear out the > ;; REMOTE-LOCATION to which we are pushing. > - (vc--repo-setprop 'vc-incoming-revision nil)) > + (vc-run-delayed > + (vc--repo-setprop 'vc-incoming-revision nil))) > (user-error "VC push is unsupported for `%s'" backend)))) > > ;;;###autoload > -- > 2.52.0
bug-gnu-emacs@HIDDEN:bug#79937; Package emacs.
Full text available.Received: (at 79937) by debbugs.gnu.org; 2 Dec 2025 18:15:00 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Dec 02 13:15:00 2025 Received: from localhost ([127.0.0.1]:32951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vQUtv-0001RU-Vu for submit <at> debbugs.gnu.org; Tue, 02 Dec 2025 13:15:00 -0500 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:42040) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <kanishk0422@HIDDEN>) id 1vQUtt-0001R8-8y for 79937 <at> debbugs.gnu.org; Tue, 02 Dec 2025 13:14:58 -0500 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-2957850c63bso750395ad.0 for <79937 <at> debbugs.gnu.org>; Tue, 02 Dec 2025 10:14:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764699290; x=1765304090; darn=debbugs.gnu.org; h=to:date:message-id:subject:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=BT9S3NaAGziT/sFtPUnI17cswKBKNYV+iBH8PeMqzPE=; b=jA4KvAbbu+by21j81NMetKzcQq2lWGqlj1XHLz87fh1NeP32Y/+mJio0yJajf2YrTB g42dOGqqAprt/pJ4JNbIMYJRthfCQQTBhwwpPNLSnVsQH5HivDVMKIJ3iSoy6L0u/xj0 o70Z020pPrO4mkFBjtbfkV5ba9NbNHue1cGdhVLbBErCHW7Ja2YHMZFgKxg8RxIbQUzq +WwmakmNEnoP+6u770zrT0In5Vd+GDtlqluUXYCAAw4MdNReqhnaA+eJiVn1p5o65XCO f+nzXzSrp7xChL3evVwohaGVoqYT4XJ7v/HSgjLd3+frMXuWcirKJfXidxJdHF8BoiNl 2PpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764699290; x=1765304090; h=to:date:message-id:subject:mime-version:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BT9S3NaAGziT/sFtPUnI17cswKBKNYV+iBH8PeMqzPE=; b=mWwgvGcHbH8EEXnUC0U5sx4Iz5DGL7rW3RtgA+XZ2oxbSpzazmKcwnx8CKHF7ctKCB LZzfZQKUpSHimQSFq5r3KGS2UMCB+QS3nXojilaFibDDO7Nxozgp22u7kBGkxs+aa5iD e/LEe1aAYGR4sIYew+ez839mNapous1Y86UnJ6iL9IJ/WnqLtgb7HekOdbj0FQWvdLlW 0GaZNSPOk/GS5ucPLyuYNlccj2tngUAPFQ2kAQO4oNExZKH6sRTxeM8brz0P8ydBe+Lw Cmb+up51RRdAuN5cxwfQeK9QBFvMtKlkbXbek3LfK9lur0we4BU5LoUi6K1l3dbP36qr REWw== X-Gm-Message-State: AOJu0YxMTy8Au9R05B/UY+qoM798SHYkB4jG+e+H8cX34YsERF0sf/ey ml1Upvahp1L5bawLAP1J4PWa6hObqsUyrcjJ2jVMfRSjCe+HoHC5Qcpm+MYSVw== X-Gm-Gg: ASbGncsg/B2NUxW8aZyELkAaq18mEju1IAgKMqhFSOKEQJZOsT69s9C55IMYPbVdB0B ppI544jjYnZzdgYqxAv29Me4XzEamIV1etO0EEAxSWJ0pE2bC3hjKsmb6teVvhdeiDl87hhll/x uXUnB5ZxbJPn7xCqZInTfFqgbgggkWwSBiQDCw6i9MXjIiP0ofRM1zSverP2MFN+Tjdcc5m//VF QTSteJzX5VyYAQs/3hHqeRuEqsPsPQ6c3tFEwmVtG0QgGQGrvTqcm7t9f358vDNBoYNpJtWGds2 DDVHW9sz8NcizwYYlM1ZPheDhfPwD7+wc9Y3kvnq+wW+HGvqfQ+ZjdHuVTpxd6aF/La0T+55r5s jvjoG81Nqpsmo0xLZLywXMZtfmmLehKQfANntAWMDup+kCHqCDet5Hzpu1oKKxgzgozlsFNFt3b kU+6dceZiNQb/u78zoiUelz+C7zYitwpnc X-Google-Smtp-Source: AGHT+IH0URJoEBuQgq9aYuHjHi9Rz70ByBC+oRG4zhV6OphSKExDv8i2EIE/XbnzwXF4Z1UdK6xhKA== X-Received: by 2002:a17:903:1967:b0:29a:69d:acdc with SMTP id d9443c01a7336-29d5a5b9e5dmr41613145ad.25.1764699290101; Tue, 02 Dec 2025 10:14:50 -0800 (PST) Received: from smtpclient.apple ([45.251.50.24]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29bd96307ebsm136033185ad.36.2025.12.02.10.14.48 for <79937 <at> debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Dec 2025 10:14:49 -0800 (PST) From: Kanishk <kanishk0422@HIDDEN> Content-Type: multipart/mixed; boundary="Apple-Mail=_AB671180-86A5-4D83-ADF8-B78F35731A36" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.100.1.1.5\)) Subject: rust-ts-mode: Fix fontification of token_tree, index_expression, and lowercase imports Message-Id: <BAF12781-88C4-4CBA-899E-65EA608560D8@HIDDEN> Date: Tue, 2 Dec 2025 23:44:35 +0530 To: 79937 <at> debbugs.gnu.org X-Mailer: Apple Mail (2.3864.100.1.1.5) X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 79937 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) --Apple-Mail=_AB671180-86A5-4D83-ADF8-B78F35731A36 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 This patch fixes three issues in rust-ts-mode.el: 1. Identifiers inside token_tree were not fontified as variables. 2. Identifiers inside index_expression were not fontified as = variable-use. 3. Lowercase module/crate names inside use_list were not given the = correct face. The patch adds: - (token_tree (identifier) @font-lock-variable-name-face) - (index_expression (identifier) @font-lock-variable-use-face) - A new rule to highlight lowercase imports using = font-lock-constant-face. These changes are consistent with Rust naming conventions, rust-mode, = and other Rust editor integrations, and improve correctness without = affecting unrelated behavior. In GNU Emacs 30.2 (build 2, aarch64-apple-darwin25.0.0, NS appkit-2685.10 Version 26.0.1 (Build 25A362)) of 2025-11-24 built on tesseract-6.local Windowing system distributor 'Apple', version 10.3.2685 System Description: macOS 26.0.1 Configured using: 'configure --disable-dependency-tracking --disable-silent-rules --enable-locallisppath=3D/opt/homebrew/share/emacs/site-lisp --infodir=3D/opt/homebrew/Cellar/emacs-plus@30/30.2/share/info/emacs --prefix=3D/opt/homebrew/Cellar/emacs-plus@30/30.2 --with-native-compilation=3Daot --with-xml2 --with-gnutls --without-compress-install --without-dbus --without-imagemagick --with-modules --with-rsvg --with-webp =E2=80=94with-tree-sitter = --with-ns --disable-ns-self-contained 'CFLAGS=3D-O2 -DFD_SETSIZE=3D10000 -DDARWIN_UNLIMITED_SELECT -I/opt/homebrew/opt/sqlite/include -I/opt/homebrew/opt/gcc/include -I/opt/homebrew/opt/libgccjit/include' 'LDFLAGS=3D-L/opt/homebrew/opt/sqlite/lib -L/opt/homebrew/lib/gcc/15 -Wl,-rpath,/opt/homebrew/lib/gcc/15''= --Apple-Mail=_AB671180-86A5-4D83-ADF8-B78F35731A36 Content-Disposition: attachment; filename=0001-lisp-vc-vc.el-vc-push-Delay-clearing-incoming-revisi.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-lisp-vc-vc.el-vc-push-Delay-clearing-incoming-revisi.patch" Content-Transfer-Encoding: quoted-printable =46rom=20df4d8c147524c3cea5cf77a0b73d3f64e58aa4f9=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Sean=20Whitton=20<spwhitton@HIDDEN>=0A= Date:=20Tue,=202=20Dec=202025=2011:55:14=20+0000=0ASubject:=20[PATCH]=20= *=20lisp/vc/vc.el=20(vc-push):=20Delay=20clearing=20incoming=20revisions=0A= =20cache.=0A=0A---=0A=20lisp/vc/vc.el=20|=203=20++-=0A=201=20file=20= changed,=202=20insertions(+),=201=20deletion(-)=0A=0Adiff=20--git=20= a/lisp/vc/vc.el=20b/lisp/vc/vc.el=0Aindex=208771603a4ad..15982067829=20= 100644=0A---=20a/lisp/vc/vc.el=0A+++=20b/lisp/vc/vc.el=0A@@=20-4277,7=20= +4277,8=20@@=20vc-push=0A=20=20=20=20=20=20=20=20=20(progn=20= (vc-call-backend=20backend=20'push=20arg)=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20;;=20FIXME:=20Ideally=20we=20would=20only=20clear=20= out=20the=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20= REMOTE-LOCATION=20to=20which=20we=20are=20pushing.=0A-=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20(vc--repo-setprop=20'vc-incoming-revision=20= nil))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(vc-run-delayed=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(vc--repo-setprop=20= 'vc-incoming-revision=20nil)))=0A=20=20=20=20=20=20=20(user-error=20"VC=20= push=20is=20unsupported=20for=20`%s'"=20backend))))=0A=20=0A=20= ;;;###autoload=0A--=20=0A2.52.0=0A=0A= --Apple-Mail=_AB671180-86A5-4D83-ADF8-B78F35731A36--
bug-gnu-emacs@HIDDEN:bug#79937; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 2 Dec 2025 13:58:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Dec 02 08:58:34 2025
Received: from localhost ([127.0.0.1]:58975 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vQQtl-0000cw-Eo
for submit <at> debbugs.gnu.org; Tue, 02 Dec 2025 08:58:34 -0500
Received: from lists.gnu.org ([2001:470:142::17]:39590)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <kanishk0422@HIDDEN>)
id 1vQMO4-0004JJ-R7
for submit <at> debbugs.gnu.org; Tue, 02 Dec 2025 04:09:33 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <kanishk0422@HIDDEN>)
id 1vQMNu-0002sB-Nt
for bug-gnu-emacs@HIDDEN; Tue, 02 Dec 2025 04:09:24 -0500
Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <kanishk0422@HIDDEN>)
id 1vQMNt-0004rQ-58
for bug-gnu-emacs@HIDDEN; Tue, 02 Dec 2025 04:09:22 -0500
Received: by mail-pl1-x62c.google.com with SMTP id
d9443c01a7336-29555b384acso58592295ad.1
for <bug-gnu-emacs@HIDDEN>; Tue, 02 Dec 2025 01:09:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1764666558; x=1765271358; darn=gnu.org;
h=to:date:message-id:subject:mime-version:from:from:to:cc:subject
:date:message-id:reply-to;
bh=APgk7A8dnTpjxWmuxSR0/ghzp3vJnfHDwCxlnqRkFp4=;
b=MdsL/EEJiZ7Nzkc7KIuV7kDPPgh3DKzUHVpYZHwBap0heb4tuzGSB8lnJq8rCVFS16
gthAX9xt1hKgWObDRFUJT99co8Vxpj1L3IGh3ANxUrpnEIWZHYAr9mYKLCrnVem3+zZg
2bT8Aq71tp1IwAqCW8hk6IRgFYfZsvHSXpw6DHU+cMN2Px5E3PWcIIopCO8AIT01endC
kuGSLikYxUv3WzjrgekP3bTfpBYq1q374CE2E/WGuJbf9EM/MkK+GmV47KlHju3xxFwR
awSOW5r7KlHE8qGuVLp9VrwGj1RUrFr4uzng+D4uyNi9HAY0CzdDJ2HgIcNktvYqPX97
6kuQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1764666558; x=1765271358;
h=to:date:message-id:subject:mime-version:from:x-gm-gg
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=APgk7A8dnTpjxWmuxSR0/ghzp3vJnfHDwCxlnqRkFp4=;
b=mvJR36rmV9oBxAs0BG2Y33sEzNzG/JkwWAMkVGk9ksQ2lFlFpDwXwcNDzKaX+Mf2F4
VPePwwyB9SBA7p/2J3U3MaTXi9j8i+yZoMO5OFgrnbosGyx1UaMz4k2IHuiiSalK5rxb
qi+7YbYvVivvp62wz6KfR3oLbpXrNHIfY6dj22aaVUmVsg2eOga8HQcXmDoV0Ci6FQLu
kVuGovPyJ9pEb792pz4l1yhnTOZRuZeYQqXi+WLvfrExdwTeWSrGhih6gZL3T/JAhwet
Knp+34qfvl9VU/qSp8T++A/5zbqjZzKq2aml2iBd0KBIUNamR3qNlVZSG6eLtZ6iMZh+
rMNQ==
X-Gm-Message-State: AOJu0YwV+Q59/LwA+AeOobCZ9kmU2UhvskB7Zm8B1T2Auc45lMpE9wVu
v9eD1qqQxmWhTOQqzTkim4te+LKnGHC/8qLn861k2zYYyy86PNkwh/koNemXSg==
X-Gm-Gg: ASbGnctVQZbbkEKFSVEsozh0aw91+yyr2ss42mIdc5gvhmjz95NuJxF8kCgtUxOK9Kg
nq7YzT4cRuVhPavPFbhHzw9iszLxxELo3wCVm/a8prrjlmYrsh1kTZWEb5vq0QmPaLgRPb4rjrU
5/+qy62r12uWFOLJ1Pyi3GfC8uKJQbzM17gK5IU694iUAyeiYdb0FdRsOD1CVSa8HVBMFsjJstW
yjJrLkYmUnjd7QSorm+r2w1kBGxh7kdaQfZJ8jSX2hBtspejlP2P31Jq5DAHRP6K6Oz+WQ8hR84
MD5Jf1w+kao7s4SXx0gpiXoilXtO66GybF9j2B7PRj+PfIo3wZS4n0wGEvTYgXFYz1CG6HnbeAX
82IZ+tqLubediuQh6mUzBXp2/sp51qoapXc8gMZ2OPh1rc2NEWEYAHuvS4RXvy1yAX9SqlfQXkt
HA2IorvXrRP3kPUS4Qaj6ruT6Wcrz6NP/Z
X-Google-Smtp-Source: AGHT+IFbr7uGhKz1nQHO4UJmWYNHR0KOteFl81zo9S4D8nQ1W1h8/NevtAr2PfRYFXKVjGHfFykpFw==
X-Received: by 2002:a17:903:fa6:b0:295:5668:2f27 with SMTP id
d9443c01a7336-29b6c3c29bcmr351436285ad.9.1764666557415;
Tue, 02 Dec 2025 01:09:17 -0800 (PST)
Received: from smtpclient.apple ([45.251.50.24])
by smtp.gmail.com with ESMTPSA id
d9443c01a7336-29bce40b993sm150633205ad.14.2025.12.02.01.09.16
for <bug-gnu-emacs@HIDDEN>
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Tue, 02 Dec 2025 01:09:17 -0800 (PST)
From: Kanishk <kanishk0422@HIDDEN>
Content-Type: multipart/alternative;
boundary="Apple-Mail=_30492904-7FE3-4C1C-B449-5251D65CF507"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.100.1.1.5\))
Subject: 30.2; rust-ts-mode: incorrect fontification for token_tree,
index_expression, and lowercase imports
Message-Id: <4AA6D8C1-02AD-49EE-B1D8-C1A658ADBD11@HIDDEN>
Date: Tue, 2 Dec 2025 14:39:04 +0530
To: bug-gnu-emacs@HIDDEN
X-Mailer: Apple Mail (2.3864.100.1.1.5)
Received-SPF: pass client-ip=2607:f8b0:4864:20::62c;
envelope-from=kanishk0422@HIDDEN; helo=mail-pl1-x62c.google.com
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hello Emacs maintainers, This patch fixes three fontification
issues in rust-ts-mode.el. Missing variable face inside token_tree:
Identifiers
appearing inside macro token trees were not highlighted. For example:
macro_rules!
m { ($x:ident) => { $x } } The $x identifier did not receive var [...]
Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org]
0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends
in digit (kanishk0422[at]gmail.com)
1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (kanishk0422[at]gmail.com)
0.0 HTML_MESSAGE BODY: HTML included in message
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Tue, 02 Dec 2025 08:58:33 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
--Apple-Mail=_30492904-7FE3-4C1C-B449-5251D65CF507
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=us-ascii
Hello Emacs maintainers,
This patch fixes three fontification issues in rust-ts-mode.el.
Missing variable face inside token_tree:
Identifiers appearing inside macro token trees were not highlighted. For =
example:
macro_rules! m { ($x:ident) =3D> { $x } }
The $x identifier did not receive variable-name highlighting.
Missing variable-use face inside index_expression:
Expressions such as:
arr[i]
did not highlight i as a variable-use, even though it should be treated =
the same way as other identifier occurrences in expressions.
Lowercase imports in use_list not correctly highlighted:
Rust module and crate names are always lowercase, but rust-ts-mode did =
not assign an appropriate face to them in:
use foo::Bar;
The uppercase item Bar is a type and should use font-lock-type-face. The =
lowercase module foo should use font-lock-constant-face, consistent with =
rust-mode and common Rust editor behavior.
This patch adds:
(token_tree (identifier) @font-lock-variable-name-face)
(index_expression (identifier) @font-lock-variable-use-face)
A new rule in the type feature to fontify lowercase identifiers in =
use_list using font-lock-constant-face.
These changes are safe, isolated, and improve correctness of Rust =
fontification without altering any unrelated behavior. They also bring =
rust-ts-mode in line with rust-mode and with Rust naming conventions.
Thank you.=
--Apple-Mail=_30492904-7FE3-4C1C-B449-5251D65CF507
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
charset=us-ascii
<html><head><meta http-equiv=3D"content-type" content=3D"text/html; =
charset=3Dus-ascii"></head><body style=3D"overflow-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: after-white-space;">
<p data-start=3D"79" data-end=3D"103" style=3D"caret-color: rgb(0, 0, =
0); color: rgb(0, 0, 0);">Hello Emacs maintainers,</p><p =
data-start=3D"105" data-end=3D"168" style=3D"caret-color: rgb(0, 0, 0); =
color: rgb(0, 0, 0);">This patch fixes three fontification issues in =
rust-ts-mode.el.</p><ol data-start=3D"170" data-end=3D"1011" =
style=3D"caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);"><li =
data-start=3D"170" data-end=3D"403"><p data-start=3D"173" =
data-end=3D"403">Missing variable face inside token_tree:<br>Identifiers =
appearing inside macro token trees were not highlighted. For =
example:<br>macro_rules! m { ($x:ident) =3D> { $x } =
}<br>The <code data-start=3D"344" =
data-end=3D"348">$x</code> identifier did not receive variable-name =
highlighting.</p></li><li data-start=3D"405" data-end=3D"625"><p =
data-start=3D"408" data-end=3D"625">Missing variable-use face inside =
index_expression:<br>Expressions such as:<br>arr[i]<br>did not =
highlight <code data-start=3D"509" data-end=3D"512">i</code> as =
a variable-use, even though it should be treated the same way as other =
identifier occurrences in expressions.</p></li><li data-start=3D"627" =
data-end=3D"1011"><p data-start=3D"630" data-end=3D"1011">Lowercase =
imports in use_list not correctly highlighted:<br>Rust module and crate =
names are always lowercase, but rust-ts-mode did not assign an =
appropriate face to them in:<br>use foo::Bar;<br>The uppercase =
item <code data-start=3D"838" data-end=3D"843">Bar</code> is a =
type and should use font-lock-type-face. The lowercase module <code =
data-start=3D"911" data-end=3D"916">foo</code> should use =
font-lock-constant-face, consistent with rust-mode and common Rust =
editor behavior.</p></li></ol><p data-start=3D"1013" data-end=3D"1029" =
style=3D"caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);">This patch =
adds:</p><ul data-start=3D"1030" data-end=3D"1263" style=3D"caret-color: =
rgb(0, 0, 0); color: rgb(0, 0, 0);"><li data-start=3D"1030" =
data-end=3D"1089"><p data-start=3D"1032" data-end=3D"1089"><code =
data-start=3D"1032" data-end=3D"1089">(token_tree (identifier) =
@font-lock-variable-name-face)</code></p></li><li data-start=3D"1090" =
data-end=3D"1154"><p data-start=3D"1092" data-end=3D"1154"><code =
data-start=3D"1092" data-end=3D"1154">(index_expression (identifier) =
@font-lock-variable-use-face)</code></p></li><li data-start=3D"1155" =
data-end=3D"1263"><p data-start=3D"1157" data-end=3D"1263">A new rule in =
the type feature to fontify lowercase identifiers in use_list using =
font-lock-constant-face.</p></li></ul><p data-start=3D"1265" =
data-end=3D"1471" style=3D"caret-color: rgb(0, 0, 0); color: rgb(0, 0, =
0);">These changes are safe, isolated, and improve correctness of Rust =
fontification without altering any unrelated behavior. They also bring =
rust-ts-mode in line with rust-mode and with Rust naming =
conventions.</p><p data-start=3D"1473" data-end=3D"1483" =
style=3D"caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);">Thank you.</p>
</body></html>=
--Apple-Mail=_30492904-7FE3-4C1C-B449-5251D65CF507--
Kanishk <kanishk0422@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#79937; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.