GNU logs - #9625, boring messages

Message sent to bug-automake@HIDDEN:

Subject: bug#9625: Overriding `check:' target
Resent-From: Stefano Lattarini <stefano.lattarini@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-CC: bug-automake@HIDDEN
Resent-Date: Wed, 28 Sep 2011 09:09:02 +0000
Resent-Message-ID: <handler.9625.B.131720088315203 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: automake@HIDDEN
Cc: jordigh@HIDDEN, 9625 <at> debbugs.gnu.org
From: Stefano Lattarini <stefano.lattarini@HIDDEN>
Date: Wed, 28 Sep 2011 11:06:29 +0200
User-Agent: KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; )
References: <CAPHS2gwUFyLx6VE=Mr4XfCvpV9OZ0UYtcdpxwEG1Ucy-nuKj5Q@HIDDEN>
In-Reply-To: <CAPHS2gwUFyLx6VE=Mr4XfCvpV9OZ0UYtcdpxwEG1Ucy-nuKj5Q@HIDDEN>
MIME-Version: 1.0
Message-Id: <201109281106.30120.stefano.lattarini@HIDDEN>
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Precedence: list
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org

[Adding bug-automake]

Reference:
 <http://lists.gnu.org/archive/html/automake/2011-09/msg00028.html>

Hi Jordi, thanks for the report.

On Tuesday 27 September 2011, Jordi Guti=C3=A9rrez wrote:
> (Please cc: me as I'm not subscribed to the list)
>=20
> This may be a little frivolous, but in GNU Octave's top-level
> Makefile.am, we override the check: target:
>
Ah yes, you've hitten a known bug/limitation that I had already
encoutered, but the lamentably forgotten about (sorry!).

>     http://hg.savannah.gnu.org/hgweb/octave/file/1bfca2bbea8b/Makefile.am=
#l106
>=20
> However, in the generated Makefile, this produces a warning:
>=20
>     Makefile:2354: warning: overriding commands for target `check'
>     Makefile:1948: warning: ignoring old commands for target `check'
>=20
> because the generated Makefile contains these lines:
>=20
>     ## Standard target
>     check: $(BUILT_SOURCES)
>        $(MAKE) $(AM_MAKEFLAGS) check-recursive
>
JFTR, If I understand things correctly, this hackish recipe is really
required to ensure that $(BUILT_SOURCES) are effectively built not
only before the `check' target, but also before all its "built-in"
dependencies (`check-local', `check-am' and `check-recusrsive', mostly).

>     ## Overriden target
>     check: all
>        $(MAKE) -C test check
>=20
Just a question: why this overriding?   If the `test' directory is
listed in SUBDIRS, the automake-generated `check' target will take
care of automatically recursing into `test' anyway.  Or am I missing
something about Octave's source tree setup?

> I would like to silence that warning.
>
If you can, I suggest you to just drop the `check:' overriding, and let
Automake handle the recusrions automatically.  If you can't do so, I'll
take a better look to see if we can work out another solution.

> It clutters my compilation
> buffer when I'm in Emacs and want to quickly jump to the first error
> or warning with C-x `. It would suffice if I could make the check:
> target empty. Can you please explain under what conditions the check:
> target actually has a script involved?
>
You mean a "recipe involved" here, right?  If yes, that happens iff the
BUILT_SOURCES variable is defined.

> I tried making a minimal
> example of my own with Automake, and it produced something like this:
>=20
>     ...
>     check: check-recursive
>     all-am: Makefile config.h
>     ...
>=20
> i.e. an empty target. So I can override check: without getting a
> warning.
>
In truth, automake is *not* letting you override it; you are "just"
adding additional dependencies and a recipe to it -- but make finds
this legitimate of course, so it won't complain.

> When does this happen? When is the check: target empty
> and when does it actually have a command in there?
>=20
Automake should provide a recipe to the `check' target iff the
`BUILT_SOURCES' variable is defined.

HTH,
  Stefano

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Stefano Lattarini <stefano.lattarini@HIDDEN>
Subject: bug#9625: Acknowledgement (Overriding `check:' target)
Message-ID: <handler.9625.B.131720088315203.ack <at> debbugs.gnu.org>
References: <201109281106.30120.stefano.lattarini@HIDDEN>
X-Gnu-PR-Message: ack 9625
X-Gnu-PR-Package: automake
Reply-To: 9625 <at> debbugs.gnu.org
Date: Wed, 28 Sep 2011 09:09:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-automake@HIDDEN

If you wish to submit further information on this problem, please
send it to 9625 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
9625: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D9625
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-automake@HIDDEN:

Subject: bug#9625: Overriding `check:' target
Resent-From: Jordi =?UTF-8?Q?Guti=C3=A9rrez?= Hermoso <jordigh@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-CC: bug-automake@HIDDEN
Resent-Date: Wed, 28 Sep 2011 16:35:01 +0000
Resent-Message-ID: <handler.9625.B.131722768831455 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Stefano Lattarini <stefano.lattarini@HIDDEN>
Cc: 9625 <at> debbugs.gnu.org, automake@HIDDEN
MIME-Version: 1.0
In-Reply-To: <201109281106.30120.stefano.lattarini@HIDDEN>
References: <CAPHS2gwUFyLx6VE=Mr4XfCvpV9OZ0UYtcdpxwEG1Ucy-nuKj5Q@HIDDEN>
	<201109281106.30120.stefano.lattarini@HIDDEN>
Date: Wed, 28 Sep 2011 09:09:57 -0500
Message-ID: <CAPHS2gyW2Lw=X7Khi9+h14Dhee2Tr_K8P1HSjuNK1swcmCPtug@HIDDEN>
From: Jordi =?UTF-8?Q?Guti=C3=A9rrez?= Hermoso <jordigh@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org

(Please cc: me as I'm not subscribed to the list)

On 28 September 2011 04:06, Stefano Lattarini
<stefano.lattarini@HIDDEN> wrote:
> [Adding bug-automake]
>
> Reference:
> =C2=A0<http://lists.gnu.org/archive/html/automake/2011-09/msg00028.html>
>
> Hi Jordi, thanks for the report.
>
> On Tuesday 27 September 2011, Jordi Guti=C3=A9rrez wrote:
>
>>
>> This may be a little frivolous, but in GNU Octave's top-level
>> Makefile.am, we override the check: target:
>>
>> http://hg.savannah.gnu.org/hgweb/octave/file/1bfca2bbea8b/Makefile.am#l1=
06
>
> Ah yes, you've hitten a known bug/limitation that I had already
> encoutered, but the lamentably forgotten about (sorry!).

Huh, so this is an automake bug?

>>
>> However, in the generated Makefile, this produces a warning:
>>
>> =C2=A0 =C2=A0 Makefile:2354: warning: overriding commands for target `ch=
eck'
>> =C2=A0 =C2=A0 Makefile:1948: warning: ignoring old commands for target `=
check'
>>
>> because the generated Makefile contains these lines:
>>
>> =C2=A0 =C2=A0 ## Standard target
>> =C2=A0 =C2=A0 check: $(BUILT_SOURCES)
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0$(MAKE) $(AM_MAKEFLAGS) check-recursive
>>
> JFTR, If I understand things correctly, this hackish recipe is
> really required to ensure that $(BUILT_SOURCES) are effectively
> built not only before the `check' target, but also before all its
> "built-in" dependencies (`check-local', `check-am' and
> `check-recusrsive', mostly).
>
>> =C2=A0 =C2=A0 ## Overriden target
>> =C2=A0 =C2=A0 check: all
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0$(MAKE) -C test check
>>
> Just a question: why this overriding?

It's simply so that "make check" will contain the test output as the
last bit of output. Without this, the tests are run, but the output is
cluttered with "make[2]: Leaving directory..." output and similar.

>> When does this happen? When is the check: target empty
>> and when does it actually have a command in there?
>>
> Automake should provide a recipe to the `check' target iff the
> `BUILT_SOURCES' variable is defined.

I see. Yes, we do define that variable, as you can see above in the
Makefile.am in our VCS.

- Jordi G. H.

Message sent to bug-automake@HIDDEN:

Subject: bug#9625: Overriding `check:' target
Resent-From: Stefano Lattarini <stefano.lattarini@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-CC: bug-automake@HIDDEN
Resent-Date: Wed, 28 Sep 2011 19:16:02 +0000
Resent-Message-ID: <handler.9625.B.131723733419155 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Jordi =?UTF-8?Q?Guti=C3=A9rrez?= Hermoso <jordigh@HIDDEN>
Cc: 9625 <at> debbugs.gnu.org, automake@HIDDEN
From: Stefano Lattarini <stefano.lattarini@HIDDEN>
Date: Wed, 28 Sep 2011 21:14:07 +0200
User-Agent: KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; )
References: <CAPHS2gwUFyLx6VE=Mr4XfCvpV9OZ0UYtcdpxwEG1Ucy-nuKj5Q@HIDDEN>
	<201109281106.30120.stefano.lattarini@HIDDEN>
	<CAPHS2gyW2Lw=X7Khi9+h14Dhee2Tr_K8P1HSjuNK1swcmCPtug@HIDDEN>
In-Reply-To: <CAPHS2gyW2Lw=X7Khi9+h14Dhee2Tr_K8P1HSjuNK1swcmCPtug@HIDDEN>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Message-Id: <201109282114.08378.stefano.lattarini@HIDDEN>
Precedence: list
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org

On Wednesday 28 September 2011, Jordi Guti=C3=A9rrez wrote:
> (Please cc: me as I'm not subscribed to the list)
>=20
> On 28 September 2011 04:06, Stefano Lattarini
> <stefano.lattarini@HIDDEN> wrote:
> > [Adding bug-automake]
> >
> > Reference:
> >  <http://lists.gnu.org/archive/html/automake/2011-09/msg00028.html>
> >
> > Hi Jordi, thanks for the report.
> >
> > On Tuesday 27 September 2011, Jordi Guti=C3=A9rrez wrote:
> >
> >>
> >> This may be a little frivolous, but in GNU Octave's top-level
> >> Makefile.am, we override the check: target:
> >>
> >> http://hg.savannah.gnu.org/hgweb/octave/file/1bfca2bbea8b/Makefile.am#=
l106
> >
> > Ah yes, you've hitten a known bug/limitation that I had already
> > encoutered, but the lamentably forgotten about (sorry!).
>=20
> Huh, so this is an automake bug?
>
This is fuzzy: it can be seen either as a bug or as a limitation.  In
theory, every automake-provided target should be overridable, which
suggests the behaviour you are observing is a bug.  But apparently the
`all' and `check' targets are special enough to deserve a special
treatment, especially when BUILT_SOURCES is involved; so the fact they
cannot be overridden can be seen as an unfortunate, but not gratuitous,
limitation.

Anyway, changing the current behaviour might be tricky and break other
usages "in the wild", so it's not something I want to do lighlty (even
if documenting it might be worthwhile).  So, IMHO the best fix for your
problem is to change the Octave's Makefile.am, if possible.

> >>
> >> However, in the generated Makefile, this produces a warning:
> >>
> >>     Makefile:2354: warning: overriding commands for target `check'
> >>     Makefile:1948: warning: ignoring old commands for target `check'
> >>
> >> because the generated Makefile contains these lines:
> >>
> >>     ## Standard target
> >>     check: $(BUILT_SOURCES)
> >>        $(MAKE) $(AM_MAKEFLAGS) check-recursive
> >>
> > JFTR, If I understand things correctly, this hackish recipe is
> > really required to ensure that $(BUILT_SOURCES) are effectively
> > built not only before the `check' target, but also before all its
> > "built-in" dependencies (`check-local', `check-am' and
> > `check-recusrsive', mostly).
> >
> >>     ## Overriden target
> >>     check: all
> >>        $(MAKE) -C test check
> >>
> > Just a question: why this overriding?
>=20
> It's simply so that "make check" will contain the test output as the
> last bit of output. Without this, the tests are run, but the output is
> cluttered with "make[2]: Leaving directory..." output and similar.
>
Is this really much a problem?  Can't you just ignore these extra lines,
or call make with the `--no-print-directory' option?

BTW, if the Octave testsuite uses the Automake-provided harness, you could
enable colorized tests output, which makes pretty easy to ignore noise
when visually scanning the testsuite output.

> >> When does this happen? When is the check: target empty
> >> and when does it actually have a command in there?
> >>
> > Automake should provide a recipe to the `check' target iff the
> > `BUILT_SOURCES' variable is defined.
>=20
> I see. Yes, we do define that variable, as you can see above in the
> Makefile.am in our VCS.
>
Yes, I've noticed that :-)

HTH,
  Stefano

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 7 Dec 2011 22:53:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 07 17:53:18 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1RYQMY-0000up-Hl
	for submit <at> debbugs.gnu.org; Wed, 07 Dec 2011 17:53:18 -0500
Received: from mail-ee0-f44.google.com ([74.125.83.44])
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1RYQMX-0000uj-Nq
	for control <at> debbugs.gnu.org; Wed, 07 Dec 2011 17:53:18 -0500
Received: by eekd4 with SMTP id d4so879494eek.3
	for <control <at> debbugs.gnu.org>; Wed, 07 Dec 2011 14:52:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=from:to:subject:date:user-agent:mime-version:content-type
	:content-transfer-encoding:message-id;
	bh=DaYSB2CghJTJRd8j8sp8BQobRc+ppUI3xYnkrfmyc9A=;
	b=DHJ34Gzpu7yTV5I3rfCnnHUHjQJzxayMR/fR9ijAp7iDh37vfWUBNyx7lqLdOgocic
	9mYuw3sFZjsXR4Y+cBkhYp9yGDs1csWaEfCDPQ8PlUqAmamnlTGXrv5cCmWsaE72YAxF
	TeFc2OR6CEAmqAYaXVMlf78GMrzbkUH0fZPCk=
Received: by 10.14.16.79 with SMTP id g55mr37772eeg.175.1323298351178;
	Wed, 07 Dec 2011 14:52:31 -0800 (PST)
Received: from bigio.localnet
	(host167-102-dynamic.2-87-r.retail.telecomitalia.it. [87.2.102.167])
	by mx.google.com with ESMTPS id 58sm11270765eet.11.2011.12.07.14.52.30
	(version=TLSv1/SSLv3 cipher=OTHER);
	Wed, 07 Dec 2011 14:52:30 -0800 (PST)
From: Stefano Lattarini <stefano.lattarini@HIDDEN>
To: control <at> debbugs.gnu.org
Subject: am
Date: Wed, 7 Dec 2011 23:52:21 +0100
User-Agent: KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; )
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201112072352.21490.stefano.lattarini@HIDDEN>
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -4.0 (----)

severity 7610 minor
severity 7766 minor
severity 9625 minor
severity 10248 serious
severity 7884 important
severity 9768 important
thanks

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.