GNU bug report logs - #9625
Overriding `check:' target

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: automake; Severity: minor; Reported by: Stefano Lattarini <stefano.lattarini@HIDDEN>; dated Wed, 28 Sep 2011 09:09:02 UTC; Maintainer for automake is bug-automake@HIDDEN.
Severity set to 'minor' from 'normal' Request was from Stefano Lattarini <stefano.lattarini@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 28 Sep 2011 19:15:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 28 15:15:34 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1R8zbR-0004yu-TN
	for submit <at> debbugs.gnu.org; Wed, 28 Sep 2011 15:15:34 -0400
Received: from eggs.gnu.org ([140.186.70.92])
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1R8zbP-0004ym-Cf
	for submit <at> debbugs.gnu.org; Wed, 28 Sep 2011 15:15:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1R8zaT-0001Md-7j
	for submit <at> debbugs.gnu.org; Wed, 28 Sep 2011 15:14:34 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	RCVD_IN_DNSWL_LOW,T_DKIM_INVALID autolearn=unavailable version=3.3.1
Received: from lists.gnu.org ([140.186.70.17]:42349)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1R8zaT-0001MZ-6D
	for submit <at> debbugs.gnu.org; Wed, 28 Sep 2011 15:14:33 -0400
Received: from eggs.gnu.org ([140.186.70.92]:56406)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1R8zaM-0002r9-Kr
	for bug-automake@HIDDEN; Wed, 28 Sep 2011 15:14:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1R8zaL-0001KY-0s
	for bug-automake@HIDDEN; Wed, 28 Sep 2011 15:14:26 -0400
Received: from mail-wy0-f169.google.com ([74.125.82.169]:57230)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefano.lattarini@HIDDEN>)
	id 1R8zaH-0001Jf-I3; Wed, 28 Sep 2011 15:14:21 -0400
Received: by wyf22 with SMTP id 22so305436wyf.0
	for <multiple recipients>; Wed, 28 Sep 2011 12:14:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=from:to:subject:date:user-agent:cc:references:in-reply-to
	:mime-version:content-type:content-transfer-encoding:message-id;
	bh=LFt0cXkn+ziMtazW44g3Ya7d1GxLZ6oK8OkYFRgVzWI=;
	b=r0X6lbD/VhdH0pA6xxtsTdthSBHgO/zM10JTxpuUfpeGiRrecJGW5jHSdupVxiNLvn
	/4qJxkfPcTcJH2YZMG8x6Dz1sHwS/5boj0VAIoBKpbjaCWCcflSeXYsxrEv5E3DxVzLJ
	JR3yULGVfX4yMG2SaHnOyU4dUDNiUB65dsnm4=
Received: by 10.216.6.211 with SMTP id 61mr10383693wen.94.1317237260753;
	Wed, 28 Sep 2011 12:14:20 -0700 (PDT)
Received: from bigio.localnet
	(host150-95-dynamic.2-87-r.retail.telecomitalia.it. [87.2.95.150])
	by mx.google.com with ESMTPS id fr18sm41820568wbb.9.2011.09.28.12.14.19
	(version=TLSv1/SSLv3 cipher=OTHER);
	Wed, 28 Sep 2011 12:14:19 -0700 (PDT)
From: Stefano Lattarini <stefano.lattarini@HIDDEN>
To: Jordi =?utf-8?q?Guti=C3=A9rrez_Hermoso?= <jordigh@HIDDEN>
Subject: Re: Overriding `check:' target
Date: Wed, 28 Sep 2011 21:14:07 +0200
User-Agent: KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; )
References: <CAPHS2gwUFyLx6VE=Mr4XfCvpV9OZ0UYtcdpxwEG1Ucy-nuKj5Q@HIDDEN>
	<201109281106.30120.stefano.lattarini@HIDDEN>
	<CAPHS2gyW2Lw=X7Khi9+h14Dhee2Tr_K8P1HSjuNK1swcmCPtug@HIDDEN>
In-Reply-To: <CAPHS2gyW2Lw=X7Khi9+h14Dhee2Tr_K8P1HSjuNK1swcmCPtug@HIDDEN>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Message-Id: <201109282114.08378.stefano.lattarini@HIDDEN>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 140.186.70.17
X-Spam-Score: -5.1 (-----)
X-Debbugs-Envelope-To: submit
Cc: bug-automake@HIDDEN, automake@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -5.1 (-----)

On Wednesday 28 September 2011, Jordi Guti=C3=A9rrez wrote:
> (Please cc: me as I'm not subscribed to the list)
>=20
> On 28 September 2011 04:06, Stefano Lattarini
> <stefano.lattarini@HIDDEN> wrote:
> > [Adding bug-automake]
> >
> > Reference:
> >  <http://lists.gnu.org/archive/html/automake/2011-09/msg00028.html>
> >
> > Hi Jordi, thanks for the report.
> >
> > On Tuesday 27 September 2011, Jordi Guti=C3=A9rrez wrote:
> >
> >>
> >> This may be a little frivolous, but in GNU Octave's top-level
> >> Makefile.am, we override the check: target:
> >>
> >> http://hg.savannah.gnu.org/hgweb/octave/file/1bfca2bbea8b/Makefile.am#=
l106
> >
> > Ah yes, you've hitten a known bug/limitation that I had already
> > encoutered, but the lamentably forgotten about (sorry!).
>=20
> Huh, so this is an automake bug?
>
This is fuzzy: it can be seen either as a bug or as a limitation.  In
theory, every automake-provided target should be overridable, which
suggests the behaviour you are observing is a bug.  But apparently the
`all' and `check' targets are special enough to deserve a special
treatment, especially when BUILT_SOURCES is involved; so the fact they
cannot be overridden can be seen as an unfortunate, but not gratuitous,
limitation.

Anyway, changing the current behaviour might be tricky and break other
usages "in the wild", so it's not something I want to do lighlty (even
if documenting it might be worthwhile).  So, IMHO the best fix for your
problem is to change the Octave's Makefile.am, if possible.

> >>
> >> However, in the generated Makefile, this produces a warning:
> >>
> >>     Makefile:2354: warning: overriding commands for target `check'
> >>     Makefile:1948: warning: ignoring old commands for target `check'
> >>
> >> because the generated Makefile contains these lines:
> >>
> >>     ## Standard target
> >>     check: $(BUILT_SOURCES)
> >>        $(MAKE) $(AM_MAKEFLAGS) check-recursive
> >>
> > JFTR, If I understand things correctly, this hackish recipe is
> > really required to ensure that $(BUILT_SOURCES) are effectively
> > built not only before the `check' target, but also before all its
> > "built-in" dependencies (`check-local', `check-am' and
> > `check-recusrsive', mostly).
> >
> >>     ## Overriden target
> >>     check: all
> >>        $(MAKE) -C test check
> >>
> > Just a question: why this overriding?
>=20
> It's simply so that "make check" will contain the test output as the
> last bit of output. Without this, the tests are run, but the output is
> cluttered with "make[2]: Leaving directory..." output and similar.
>
Is this really much a problem?  Can't you just ignore these extra lines,
or call make with the `--no-print-directory' option?

BTW, if the Octave testsuite uses the Automake-provided harness, you could
enable colorized tests output, which makes pretty easy to ignore noise
when visually scanning the testsuite output.

> >> When does this happen? When is the check: target empty
> >> and when does it actually have a command in there?
> >>
> > Automake should provide a recipe to the `check' target iff the
> > `BUILT_SOURCES' variable is defined.
>=20
> I see. Yes, we do define that variable, as you can see above in the
> Makefile.am in our VCS.
>
Yes, I've noticed that :-)

HTH,
  Stefano




Information forwarded to bug-automake@HIDDEN:
bug#9625; Package automake. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 28 Sep 2011 16:34:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 28 12:34:48 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1R8x5q-0008BG-MC
	for submit <at> debbugs.gnu.org; Wed, 28 Sep 2011 12:34:47 -0400
Received: from eggs.gnu.org ([140.186.70.92])
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jordigh@HIDDEN>) id 1R8vK7-0005bO-H3
	for submit <at> debbugs.gnu.org; Wed, 28 Sep 2011 10:41:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jordigh@HIDDEN>) id 1R8vJD-0003mn-Ab
	for submit <at> debbugs.gnu.org; Wed, 28 Sep 2011 10:40:28 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	RCVD_IN_DNSWL_LOW,T_DKIM_INVALID autolearn=unavailable version=3.3.1
Received: from lists.gnu.org ([140.186.70.17]:56034)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jordigh@HIDDEN>) id 1R8vJD-0003mf-8X
	for submit <at> debbugs.gnu.org; Wed, 28 Sep 2011 10:40:27 -0400
Received: from eggs.gnu.org ([140.186.70.92]:58551)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jordigh@HIDDEN>) id 1R8vJ9-0001GZ-1K
	for bug-automake@HIDDEN; Wed, 28 Sep 2011 10:40:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jordigh@HIDDEN>) id 1R8vJ4-0003jx-Hc
	for bug-automake@HIDDEN; Wed, 28 Sep 2011 10:40:22 -0400
Received: from mail-yi0-f41.google.com ([209.85.218.41]:56837)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jordigh@HIDDEN>)
	id 1R8vJ4-0003jn-De; Wed, 28 Sep 2011 10:40:18 -0400
Received: by yia25 with SMTP id 25so7618597yia.0
	for <multiple recipients>; Wed, 28 Sep 2011 07:40:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type
	:content-transfer-encoding;
	bh=XmaWXUaGTcCdAGYs6TBCThxvM1VBcIefEAZEMexGph0=;
	b=uQ20uCKwznolSSAI5GVJ6a+QUFqbKCDI1I0jr/gcvma1esFaQr5RW8KO6hWfSf7R6Z
	W4ysAq27vwZEmsWCueXbC4cTyECwY/GfKdq0+EQNTvWhNlnTHKfguviV4Rw/SnuoRUMt
	bpMeupeEuvq81CUhASPZC0/oq7pMFJKmA1I30=
MIME-Version: 1.0
Received: by 10.231.50.201 with SMTP id a9mr3966918ibg.1.1317218997528; Wed,
	28 Sep 2011 07:09:57 -0700 (PDT)
Received: by 10.231.170.65 with HTTP; Wed, 28 Sep 2011 07:09:57 -0700 (PDT)
In-Reply-To: <201109281106.30120.stefano.lattarini@HIDDEN>
References: <CAPHS2gwUFyLx6VE=Mr4XfCvpV9OZ0UYtcdpxwEG1Ucy-nuKj5Q@HIDDEN>
	<201109281106.30120.stefano.lattarini@HIDDEN>
Date: Wed, 28 Sep 2011 09:09:57 -0500
X-Google-Sender-Auth: H4LL2tkKys7sCD2XQHqW0RQp_-4
Message-ID: <CAPHS2gyW2Lw=X7Khi9+h14Dhee2Tr_K8P1HSjuNK1swcmCPtug@HIDDEN>
Subject: Re: Overriding `check:' target
From: =?UTF-8?Q?Jordi_Guti=C3=A9rrez_Hermoso?= <jordigh@HIDDEN>
To: Stefano Lattarini <stefano.lattarini@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 140.186.70.17
X-Spam-Score: -5.9 (-----)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Wed, 28 Sep 2011 12:34:45 -0400
Cc: bug-automake@HIDDEN, automake@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -5.9 (-----)

(Please cc: me as I'm not subscribed to the list)

On 28 September 2011 04:06, Stefano Lattarini
<stefano.lattarini@HIDDEN> wrote:
> [Adding bug-automake]
>
> Reference:
> =C2=A0<http://lists.gnu.org/archive/html/automake/2011-09/msg00028.html>
>
> Hi Jordi, thanks for the report.
>
> On Tuesday 27 September 2011, Jordi Guti=C3=A9rrez wrote:
>
>>
>> This may be a little frivolous, but in GNU Octave's top-level
>> Makefile.am, we override the check: target:
>>
>> http://hg.savannah.gnu.org/hgweb/octave/file/1bfca2bbea8b/Makefile.am#l1=
06
>
> Ah yes, you've hitten a known bug/limitation that I had already
> encoutered, but the lamentably forgotten about (sorry!).

Huh, so this is an automake bug?

>>
>> However, in the generated Makefile, this produces a warning:
>>
>> =C2=A0 =C2=A0 Makefile:2354: warning: overriding commands for target `ch=
eck'
>> =C2=A0 =C2=A0 Makefile:1948: warning: ignoring old commands for target `=
check'
>>
>> because the generated Makefile contains these lines:
>>
>> =C2=A0 =C2=A0 ## Standard target
>> =C2=A0 =C2=A0 check: $(BUILT_SOURCES)
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0$(MAKE) $(AM_MAKEFLAGS) check-recursive
>>
> JFTR, If I understand things correctly, this hackish recipe is
> really required to ensure that $(BUILT_SOURCES) are effectively
> built not only before the `check' target, but also before all its
> "built-in" dependencies (`check-local', `check-am' and
> `check-recusrsive', mostly).
>
>> =C2=A0 =C2=A0 ## Overriden target
>> =C2=A0 =C2=A0 check: all
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0$(MAKE) -C test check
>>
> Just a question: why this overriding?

It's simply so that "make check" will contain the test output as the
last bit of output. Without this, the tests are run, but the output is
cluttered with "make[2]: Leaving directory..." output and similar.

>> When does this happen? When is the check: target empty
>> and when does it actually have a command in there?
>>
> Automake should provide a recipe to the `check' target iff the
> `BUILT_SOURCES' variable is defined.

I see. Yes, we do define that variable, as you can see above in the
Makefile.am in our VCS.

- Jordi G. H.




Information forwarded to bug-automake@HIDDEN:
bug#9625; Package automake. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 28 Sep 2011 09:08:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 28 05:08:03 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1R8q7W-0003wz-Cx
	for submit <at> debbugs.gnu.org; Wed, 28 Sep 2011 05:08:03 -0400
Received: from eggs.gnu.org ([140.186.70.92])
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1R8q7T-0003wl-IB
	for submit <at> debbugs.gnu.org; Wed, 28 Sep 2011 05:08:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1R8q6X-0006YQ-EQ
	for submit <at> debbugs.gnu.org; Wed, 28 Sep 2011 05:07:05 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	RCVD_IN_DNSWL_LOW, T_DKIM_INVALID,
	T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1
Received: from lists.gnu.org ([140.186.70.17]:55833)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1R8q6X-0006YM-Ct
	for submit <at> debbugs.gnu.org; Wed, 28 Sep 2011 05:07:01 -0400
Received: from eggs.gnu.org ([140.186.70.92]:39708)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1R8q6T-0000fc-7A
	for bug-automake@HIDDEN; Wed, 28 Sep 2011 05:07:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1R8q6O-0006Ug-Ec
	for bug-automake@HIDDEN; Wed, 28 Sep 2011 05:06:57 -0400
Received: from mail-wy0-f169.google.com ([74.125.82.169]:49920)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefano.lattarini@HIDDEN>)
	id 1R8q6K-0006RS-7e; Wed, 28 Sep 2011 05:06:48 -0400
Received: by wyf22 with SMTP id 22so8616410wyf.0
	for <multiple recipients>; Wed, 28 Sep 2011 02:06:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=from:to:subject:date:user-agent:cc:references:in-reply-to
	:mime-version:message-id:content-type:content-transfer-encoding;
	bh=cQZ4BLssV6MbegxL2aVNdWxmirSZ6OBm0+NfZKGL7yY=;
	b=ZfwBVzko76yr1GKSK0KJehAkTnSLecMLVHJJTnQdgsyRimNdRHILfEBy3i+HalIlLe
	WNeDkLGyDN62OMYVGlPZoCgUqzg/zj5S5GY8r02p9A0rUR/NnplznhiCTTaW8GFlLXbC
	70NzLPKm5Nfeecrr8fc9n3LW5gLjB8J+MdLD0=
Received: by 10.216.135.220 with SMTP id u70mr399798wei.13.1317200807340;
	Wed, 28 Sep 2011 02:06:47 -0700 (PDT)
Received: from bigio.localnet
	(host203-50-dynamic.58-82-r.retail.telecomitalia.it. [82.58.50.203])
	by mx.google.com with ESMTPS id l40sm25181332wbm.10.2011.09.28.02.06.45
	(version=TLSv1/SSLv3 cipher=OTHER);
	Wed, 28 Sep 2011 02:06:46 -0700 (PDT)
From: Stefano Lattarini <stefano.lattarini@HIDDEN>
To: automake@HIDDEN
Subject: Overriding `check:' target
Date: Wed, 28 Sep 2011 11:06:29 +0200
User-Agent: KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; )
References: <CAPHS2gwUFyLx6VE=Mr4XfCvpV9OZ0UYtcdpxwEG1Ucy-nuKj5Q@HIDDEN>
In-Reply-To: <CAPHS2gwUFyLx6VE=Mr4XfCvpV9OZ0UYtcdpxwEG1Ucy-nuKj5Q@HIDDEN>
MIME-Version: 1.0
Message-Id: <201109281106.30120.stefano.lattarini@HIDDEN>
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 140.186.70.17
X-Spam-Score: -5.1 (-----)
X-Debbugs-Envelope-To: submit
Cc: Jordi =?utf-8?q?Guti=C3=A9rrez_Hermoso?= <jordigh@HIDDEN>,
	bug-automake@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -5.1 (-----)

[Adding bug-automake]

Reference:
 <http://lists.gnu.org/archive/html/automake/2011-09/msg00028.html>

Hi Jordi, thanks for the report.

On Tuesday 27 September 2011, Jordi Guti=C3=A9rrez wrote:
> (Please cc: me as I'm not subscribed to the list)
>=20
> This may be a little frivolous, but in GNU Octave's top-level
> Makefile.am, we override the check: target:
>
Ah yes, you've hitten a known bug/limitation that I had already
encoutered, but the lamentably forgotten about (sorry!).

>     http://hg.savannah.gnu.org/hgweb/octave/file/1bfca2bbea8b/Makefile.am=
#l106
>=20
> However, in the generated Makefile, this produces a warning:
>=20
>     Makefile:2354: warning: overriding commands for target `check'
>     Makefile:1948: warning: ignoring old commands for target `check'
>=20
> because the generated Makefile contains these lines:
>=20
>     ## Standard target
>     check: $(BUILT_SOURCES)
>        $(MAKE) $(AM_MAKEFLAGS) check-recursive
>
JFTR, If I understand things correctly, this hackish recipe is really
required to ensure that $(BUILT_SOURCES) are effectively built not
only before the `check' target, but also before all its "built-in"
dependencies (`check-local', `check-am' and `check-recusrsive', mostly).

>     ## Overriden target
>     check: all
>        $(MAKE) -C test check
>=20
Just a question: why this overriding?   If the `test' directory is
listed in SUBDIRS, the automake-generated `check' target will take
care of automatically recursing into `test' anyway.  Or am I missing
something about Octave's source tree setup?

> I would like to silence that warning.
>
If you can, I suggest you to just drop the `check:' overriding, and let
Automake handle the recusrions automatically.  If you can't do so, I'll
take a better look to see if we can work out another solution.

> It clutters my compilation
> buffer when I'm in Emacs and want to quickly jump to the first error
> or warning with C-x `. It would suffice if I could make the check:
> target empty. Can you please explain under what conditions the check:
> target actually has a script involved?
>
You mean a "recipe involved" here, right?  If yes, that happens iff the
BUILT_SOURCES variable is defined.

> I tried making a minimal
> example of my own with Automake, and it produced something like this:
>=20
>     ...
>     check: check-recursive
>     all-am: Makefile config.h
>     ...
>=20
> i.e. an empty target. So I can override check: without getting a
> warning.
>
In truth, automake is *not* letting you override it; you are "just"
adding additional dependencies and a recipe to it -- but make finds
this legitimate of course, so it won't complain.

> When does this happen? When is the check: target empty
> and when does it actually have a command in there?
>=20
Automake should provide a recipe to the `check' target iff the
`BUILT_SOURCES' variable is defined.

HTH,
  Stefano




Acknowledgement sent to Stefano Lattarini <stefano.lattarini@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-automake@HIDDEN. Full text available.
Report forwarded to bug-automake@HIDDEN:
bug#9625; Package automake. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Fri, 31 Oct 2014 17:00:04 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.